Changes in nsdeps

62aa6f2e - scripts/nsdeps: get 'make nsdeps' working again

Tue, 03 Dec 2024 10:21:05 +0000

scripts/nsdeps: get 'make nsdeps' working againSince commit cdd30ebb1b9f ("module: Convert symbol namespace to stringliteral"), when MODULE_IMPORT_NS() is missing, 'make nsdeps' insertspointless code: MODULE_IMPORT_NS("ns");Here, "ns" is not a namespace, but the variable in the semantic patch.It must not be quoted. Instead, a string literal must be passed toCoccinelle.Fixes: cdd30ebb1b9f ("module: Convert symbol namespace to string literal")Signed-off-by: Masahiro Yamada Signed-off-by: Linus Torvalds List of files: /linux-6.15/scripts/nsdeps

bad6beb2 - kbuild: remove extmod_prefix, MODORDER, MODULES_NSDEPS variables

Sun, 10 Nov 2024 01:34:34 +0000

kbuild: remove extmod_prefix, MODORDER, MODULES_NSDEPS variablesWith the previous changes, $(extmod_prefix), $(MODORDER), and$(MODULES_NSDEPS) are constant. (empty, modules.order, andmodules.nsdeps, respectively).Remove these variables and hard-code their values.Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/scripts/nsdeps

13b25489 - kbuild: change working directory to external module directory with M=

Sun, 10 Nov 2024 01:34:33 +0000

kbuild: change working directory to external module directory with M=Currently, Kbuild always operates in the output directory of the kernel,even when building external modules. This increases the risk of externalmodule Makefiles attempting to write to the kernel directory.This commit switches the working directory to the external moduledirectory, allowing the removal of the $(KBUILD_EXTMOD)/ prefix fromsome build artifacts.The command for building external modules maintains backwardcompatibility, but Makefiles that rely on working in the kerneldirectory may break. In such cases, $(objtree) and $(srctree) shouldbe used to refer to the output and source directories of the kernel.The appearance of the build log will change as follows:[Before] $ make -C /path/to/my/linux M=/path/to/my/externel/module make: Entering directory '/path/to/my/linux' CC [M] /path/to/my/externel/module/helloworld.o MODPOST /path/to/my/externel/module/Module.symvers CC [M] /path/to/my/externel/module/helloworld.mod.o CC [M] /path/to/my/externel/module/.module-common.o LD [M] /path/to/my/externel/module/helloworld.ko make: Leaving directory '/path/to/my/linux'[After] $ make -C /path/to/my/linux M=/path/to/my/externel/module make: Entering directory '/path/to/my/linux' make[1]: Entering directory '/path/to/my/externel/module' CC [M] helloworld.o MODPOST Module.symvers CC [M] helloworld.mod.o CC [M] .module-common.o LD [M] helloworld.ko make[1]: Leaving directory '/path/to/my/externel/module' make: Leaving directory '/path/to/my/linux'Printing "Entering directory" twice is cumbersome. This will beaddressed later.Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/scripts/nsdeps

49c3ca34 - scripts/nsdeps: adjust to the format change of *.mod files

Tue, 07 Jun 2022 15:18:40 +0000

scripts/nsdeps: adjust to the format change of *.mod filesCommit 22f26f21774f ("kbuild: get rid of duplication in *.mod files")changed the format of *.mod files to put one object per line, but missedto adjust scripts/nsdeps.Fixes: 22f26f21774f ("kbuild: get rid of duplication in *.mod files")Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/nsdeps

77a88274 - kbuild: replace LANG=C with LC_ALL=C

Fri, 30 Apr 2021 01:56:27 +0000

kbuild: replace LANG=C with LC_ALL=CLANG gives a weak default to each LC_* in case it is not explicitlydefined. LC_ALL, if set, overrides all other LC_* variables. LANG < LC_CTYPE, LC_COLLATE, LC_MONETARY, LC_NUMERIC, ... < LC_ALLThis is why documentation such as [1] suggests to set LC_ALL in buildscripts to get the deterministic result.LANG=C is not strong enough to override LC_* that may be set by endusers.[1]: https://reproducible-builds.org/docs/locales/Signed-off-by: Masahiro Yamada Acked-by: Michael Ellerman (powerpc)Reviewed-by: Matthias Maennich Acked-by: Matthieu Baerts (mptcp)Reviewed-by: Greg Kroah-Hartman List of files: /linux-6.15/scripts/nsdeps

33114c43 - kbuild: do not use scripts/ld-version.sh for checking spatch version

Sat, 12 Dec 2020 16:54:29 +0000

kbuild: do not use scripts/ld-version.sh for checking spatch versionscripts/ld-version.sh was, as its file name implies, originally intendedfor the GNU ld version, but is (ab)used for the spatch version too.Use 'sort -CV' for the version comparison, then coccicheck does not needto use scripts/ld-version.sh. Fix nsdeps as well.Signed-off-by: Masahiro Yamada Signed-off-by: Julia Lawall List of files: /linux-6.15/scripts/nsdeps

55c75498 - scripts: add dummy report mode to add_namespace.cocci

Thu, 04 Jun 2020 16:41:45 +0000

scripts: add dummy report mode to add_namespace.cocciWhen running `make coccicheck` in report mode using theadd_namespace.cocci file, it will fail for files that containMODULE_LICENSE. Those match the replacement precondition, but spatcherrors out as virtual.ns is not set.In order to fix that, add the virtual rule nsdeps and only do search andreplace if that rule has been explicitly requested.In order to make spatch happy in report mode, we also need a dummy rule,as otherwise it errors out with "No rules apply". Using a script:pythonrule appears unrelated and odd, but this is the shortest I could come upwith.Adjust scripts/nsdeps accordingly to set the nsdeps rule when run trough`make nsdeps`.Suggested-by: Julia Lawall Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck failed")Cc: YueHaibing Cc: jeyu@kernel.orgCc: cocci@systeme.lip6.frCc: stable@vger.kernel.orgSigned-off-by: Matthias Maennich Reported-by: Shuah Khan Acked-by: Julia Lawall Link: https://lore.kernel.org/r/20200604164145.173925-1-maennich@google.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/scripts/nsdeps

bc35d4bd - scripts/nsdeps: support nsdeps for external module builds

Tue, 29 Oct 2019 12:38:08 +0000

scripts/nsdeps: support nsdeps for external module buildsscripts/nsdeps is written to take care of only in-tree modules.Perhaps, this is not a bug, but just a design. At least,Documentation/core-api/symbol-namespaces.rst focuses on in-tree modules.Having said that, some people already tried nsdeps for external modules.So, it would be nice to support it.Reported-by: Steve French Reported-by: Jessica Yu Signed-off-by: Masahiro Yamada Tested-by: Jessica Yu Acked-by: Jessica Yu Reviewed-by: Matthias Maennich Tested-by: Matthias Maennich List of files: /linux-6.15/scripts/nsdeps

bbc55bde - modpost: dump missing namespaces into a single modules.nsdeps file

Tue, 29 Oct 2019 12:38:07 +0000

modpost: dump missing namespaces into a single modules.nsdeps fileThe modpost, with the -d option given, generates per-module .ns_depsfiles.Kbuild generates per-module .mod files to carry module information.This is convenient because Make handles multiple jobs in parallelwhen the -j option is given.On the other hand, the modpost always runs as a single thread.I do not see a strong reason to produce separate .ns_deps files.This commit changes the modpost to generate just one file,modules.nsdeps, each line of which has the following format: : Please note it contains *missing* namespaces instead of required ones.So, modules.nsdeps is empty if the namespace dependency is all good.This will work more efficiently because spatch will no longer processalready imported namespaces. I removed the '(if needed)' from thensdeps log since spatch is invoked only when needed.This also solves the stale .ns_deps problem reported by Jessica Yu: https://lkml.org/lkml/2019/10/28/467Signed-off-by: Masahiro Yamada Tested-by: Jessica Yu Acked-by: Jessica Yu Reviewed-by: Matthias Maennich Tested-by: Matthias Maennich List of files: /linux-6.15/scripts/nsdeps

57baec7b - scripts/nsdeps: make sure to pass all module source files to spatch

Tue, 05 Nov 2019 10:10:23 +0000

scripts/nsdeps: make sure to pass all module source files to spatchThe nsdeps script passes a list of the module source files togenerate_deps_for_ns() as a space delimited string named $mod_source_files,which then passes it to spatch. But since $mod_source_files is not encasedin quotes, each source file in that string is treated as a separate shellfunction argument (as $2, $3, $4, etc.). However, the spatch invocationonly refers to $2, so only the first file out of $mod_source_files isprocessed by spatch.This causes problems (namely, the MODULE_IMPORT_NS() statement doesn'tget inserted) when a module is composed of many source files and the"main" module file containing the MODULE_LICENSE() statement is not thefirst file listed in $mod_source_files. Fix this by encasing$mod_source_files in quotes so that the entirety of the string istreated as a single argument and can be referred to as $2.In addition, put quotes in the variable assignment of mod_source_filesto prevent any shell interpretation and field splitting.Reviewed-by: Masahiro Yamada Acked-by: Matthias Maennich Signed-off-by: Jessica Yu List of files: /linux-6.15/scripts/nsdeps

09684950 - scripts/nsdeps: use alternative sed delimiter

Mon, 21 Oct 2019 13:34:26 +0000

scripts/nsdeps: use alternative sed delimiterWhen doing an out of tree build with O=, the nsdeps script constructsthe absolute pathname of the module source file so that it can insertMODULE_IMPORT_NS statements in the right place. However, ${srctree}contains an unescaped path to the source tree, which, when used in a sedsubstitution, makes sed complain:++ sed 's/[^ ]* *//home/jeyu/jeyu-linux\/&/g'sed: -e expression #1, char 12: unknown option to `s'The sed substitution command 's' ends prematurely with the forwardslashes in the pathname, and sed errors out when it encounters the 'h',which is an invalid sed substitution option. To avoid escaping forwardslashes ${srctree}, we can use '|' as an alternative delimiter forsed instead to avoid this error.Reviewed-by: Masahiro Yamada Reviewed-by: Matthias Maennich Tested-by: Matthias Maennich Signed-off-by: Jessica Yu List of files: /linux-6.15/scripts/nsdeps

df6f0987 - nsdeps: make generated patches independent of locale

Thu, 03 Oct 2019 07:58:26 +0000

nsdeps: make generated patches independent of localescripts/nsdeps automatically generates a patch to add MODULE_IMPORT_NStags, and what is nicer, it sorts the lines alphabetically with the'sort' command. However, the output from the 'sort' command depends onlocale.For example, I got this:$ { echo usbstorage; echo usb_storage; } | LANG=en_US.UTF-8 sortusbstorageusb_storage$ { echo usbstorage; echo usb_storage; } | LANG=C sortusb_storageusbstorageSo, this means people might potentially send different patches.This kind of issue was reported in the past, for example,commit f55f2328bb28 ("kbuild: make sorting initramfs contentsindependent of locale").Adding 'LANG=C' is a conventional way of fixing when a deterministicresult is desirable.I added 'LANG=C' very close to the 'sort' command since changinglocale affects the language of error messages etc. We should respectusers' choice as much as possible.Reviewed-by: Matthias Maennich Signed-off-by: Masahiro Yamada Signed-off-by: Jessica Yu List of files: /linux-6.15/scripts/nsdeps

40997fb8 - nsdeps: fix hashbang of scripts/nsdeps

Thu, 03 Oct 2019 07:58:25 +0000

nsdeps: fix hashbang of scripts/nsdepsThis script does not use bash-extension. I am guessing this hashbangwas copied from scripts/coccicheck, which really uses bash-extension./bin/sh is enough for this script.Reviewed-by: Matthias Maennich Signed-off-by: Masahiro Yamada Signed-off-by: Jessica Yu List of files: /linux-6.15/scripts/nsdeps

eb8305ae - scripts: Coccinelle script for namespace dependencies.

Fri, 06 Sep 2019 10:32:32 +0000

scripts: Coccinelle script for namespace dependencies.A script that uses the '.ns_deps' files generated by modpost toautomatically add the required symbol namespace dependencies to eachmodule.Usage:1) Move some symbols to a namespace with EXPORT_SYMBOL_NS() or define DEFAULT_SYMBOL_NAMESPACE2) Run 'make' (or 'make modules') and get warnings about modules not importing that namespace.3) Run 'make nsdeps' to automatically add required import statements to said modules.This makes it easer for subsystem maintainers to introduce and maintainsymbol namespaces into their codebase.Co-developed-by: Martijn Coenen Signed-off-by: Martijn Coenen Acked-by: Julia Lawall Reviewed-by: Greg Kroah-Hartman Signed-off-by: Matthias Maennich Signed-off-by: Jessica Yu List of files: /linux-6.15/scripts/nsdeps