Changes in expected_stderr

9d0d2660 - kconfig: recursive checks drop file/lineno

Wed, 17 Jul 2024 01:50:41 +0000

kconfig: recursive checks drop file/linenoThis prevents segfault when getting filename and lineno in recursivechecks.If the following snippet is found in Kconfig:[Test code 1]config FOO bool depends on BAR select BAR... without BAR defined; then there is a segfault. Kconfig:34:error: recursive dependency detected! Kconfig:34: symbol FOO depends on BAR make[4]: *** [scripts/kconfig/Makefile:85: allnoconfig] Segmentation faultThis is because of the following. BAR is a fake entry created bysym_lookup() with prop being NULL. In the recursive check, there is aNULL check for prop to fall back to stack->sym->prop if stack->prop isNULL. However, in this case, stack->sym points to the fake BAR entrycreated by sym_lookup(), so prop is still NULL. prop was then referencedwithout additional NULL checks, causing segfault.As the previous email thread suggests, the file and lineno for select isalso wrong:[Test code 2]config FOO boolconfig BAR boolconfig FOO bool "FOO" depends on BAR select BAR $ make defconfig *** Default configuration is based on 'x86_64_defconfig' Kconfig:1:error: recursive dependency detected! Kconfig:1: symbol FOO depends on BAR Kconfig:4: symbol BAR is selected by FOO [...]Kconfig:4 should be Kconfig:10.This patch deletes the wrong and segfault-prone filename/linenoinference completely. With this patch, Test code 1 yields:error: recursive dependency detected! symbol FOO depends on BAR symbol BAR is selected by FOOSigned-off-by: HONG Yifan Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/tests/err_recursive_dep/expected_stderr

cc25cfc5 - kconfig: print recursive dependency errors in the parsed order

Sun, 11 Feb 2024 12:41:04 +0000

kconfig: print recursive dependency errors in the parsed orderfor_all_symbols() iterates in the symbol hash table. The order ofiteration depends on the hash table implementation.If you use it for printing errors, they are shown in random order.For example, the order of following test input and the correspondingerror do not match: - scripts/kconfig/tests/err_recursive_dep/Kconfig - scripts/kconfig/tests/err_recursive_dep/expected_stderrSigned-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/tests/err_recursive_dep/expected_stderr

cd238eff - docs: kbuild: convert docs to ReST and rename to *.rst

Wed, 12 Jun 2019 17:52:48 +0000

docs: kbuild: convert docs to ReST and rename to *.rstThe kbuild documentation clearly shows that the documentsthere are written at different times: some use markdown,some use their own peculiar logic to split sections.Convert everything to ReST without affecting too muchthe author's style and avoiding adding uneeded markups.The conversion is actually: - add blank lines and identation in order to identify paragraphs; - fix tables markups; - add some lists markups; - mark literal blocks; - adjust title markups.At its new index.rst, let's add a :orphan: while this is not linked tothe main index.rst file, in order to avoid build warnings.Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Jonathan Corbet List of files: /linux-6.15/scripts/kconfig/tests/err_recursive_dep/expected_stderr

f498926c - kconfig: improve the recursive dependency report

Wed, 15 Aug 2018 05:59:45 +0000

kconfig: improve the recursive dependency reportThis commit improves the messages of the recursive dependency.Currently, sym->dir_dep.expr is not checked. Hence, any dependencyin property visibility is regarded as the dependency of the symbol.[Test Code 1] config A bool "a" depends on B config B bool "b" depends on A[Test Code 2] config A bool "a" if B config B bool "b" depends on AFor both cases above, the same message is displayed: symbol B depends on A symbol A depends on BThis commit changes the message for the latter, like this: symbol B depends on A symbol A prompt is visible depending on BAlso, 'select' and 'imply' are distinguished.Signed-off-by: Masahiro Yamada Tested-by: Dirk Gouders List of files: /linux-6.15/scripts/kconfig/tests/err_recursive_dep/expected_stderr

5e8c5299 - kconfig: report recursive dependency involving 'imply'

Wed, 15 Aug 2018 05:59:44 +0000

kconfig: report recursive dependency involving 'imply'Currently, Kconfig does not complain about the recursive dependencywhere 'imply' keywords are involved.[Test Code] config A bool "a" config B bool "b" imply A depends on AIn the code above, Kconfig cannot calculate the symbol values correctlydue to the circular dependency. For example, allyesconfig followed bysyncconfig results in an odd behavior because CONFIG_B becomes visiblein syncconfig. $ make allyesconfig scripts/kconfig/conf --allyesconfig Kconfig # # configuration written to .config # $ cat .config # # Automatically generated file; DO NOT EDIT. # Main menu # CONFIG_A=y $ make syncconfig scripts/kconfig/conf --syncconfig Kconfig * * Restart config... * * * Main menu * a (A) [Y/n/?] y b (B) [N/y/?] (NEW)To detect this correctly, sym_check_expr_deps() should recurse tonot only sym->rev_dep.expr but also sym->implied.expr .At this moment, sym_check_print_recursive() cannot distinguish'select' and 'imply' since it does not know the precise contextwhere the recursive dependency has been hit. This will be solvedby the next commit.In fact, even the document and the unit-test are confused. Using'imply' does not solve recursive dependency since 'imply' addressesthe unmet direct dependency, which 'select' could cause.Signed-off-by: Masahiro Yamada Tested-by: Dirk Gouders List of files: /linux-6.15/scripts/kconfig/tests/err_recursive_dep/expected_stderr

f1575595 - kconfig: error out when seeing recursive dependency

Wed, 15 Aug 2018 05:59:43 +0000

kconfig: error out when seeing recursive dependencyOriginally, recursive dependency was a fatal error for Kconfigbecause Kconfig cannot compute symbol values in such a situation.Commit d595cea62403 ("kconfig: print more info when we see a recursivedependency") changed it to a warning, which I guess was not intentional.Get it back to an error again.Also, rename the unit test directory "warn_recursive_dep" to"err_recursive_dep" so that it matches to the behavior.Signed-off-by: Masahiro Yamada Tested-by: Dirk Gouders List of files: /linux-6.15/scripts/kconfig/tests/err_recursive_dep/expected_stderr