5e8c5299 - kconfig: report recursive dependency involving 'imply'

Wed, 15 Aug 2018 05:59:44 +0000

kconfig: report recursive dependency involving 'imply'Currently, Kconfig does not complain about the recursive dependencywhere 'imply' keywords are involved.[Test Code] config A bool "a" config B bool "b" imply A depends on AIn the code above, Kconfig cannot calculate the symbol values correctlydue to the circular dependency. For example, allyesconfig followed bysyncconfig results in an odd behavior because CONFIG_B becomes visiblein syncconfig. $ make allyesconfig scripts/kconfig/conf --allyesconfig Kconfig # # configuration written to .config # $ cat .config # # Automatically generated file; DO NOT EDIT. # Main menu # CONFIG_A=y $ make syncconfig scripts/kconfig/conf --syncconfig Kconfig * * Restart config... * * * Main menu * a (A) [Y/n/?] y b (B) [N/y/?] (NEW)To detect this correctly, sym_check_expr_deps() should recurse tonot only sym->rev_dep.expr but also sym->implied.expr .At this moment, sym_check_print_recursive() cannot distinguish'select' and 'imply' since it does not know the precise contextwhere the recursive dependency has been hit. This will be solvedby the next commit.In fact, even the document and the unit-test are confused. Using'imply' does not solve recursive dependency since 'imply' addressesthe unmet direct dependency, which 'select' could cause.Signed-off-by: Masahiro Yamada Tested-by: Dirk Gouders List of files: /linux-6.15/scripts/kconfig/tests/err_recursive_dep/Kconfig

f1575595 - kconfig: error out when seeing recursive dependency

Wed, 15 Aug 2018 05:59:43 +0000

kconfig: error out when seeing recursive dependencyOriginally, recursive dependency was a fatal error for Kconfigbecause Kconfig cannot compute symbol values in such a situation.Commit d595cea62403 ("kconfig: print more info when we see a recursivedependency") changed it to a warning, which I guess was not intentional.Get it back to an error again.Also, rename the unit test directory "warn_recursive_dep" to"err_recursive_dep" so that it matches to the behavior.Signed-off-by: Masahiro Yamada Tested-by: Dirk Gouders List of files: /linux-6.15/scripts/kconfig/tests/err_recursive_dep/Kconfig

Changes in Kconfig

5e8c5299 - kconfig: report recursive dependency involving 'imply'

f1575595 - kconfig: error out when seeing recursive dependency