en Copyright 2015 Java http://172.16.0.5:8080/history/linux-6.15/scripts/kconfig/tests/choice/alldef_expected_config#fde19251 kconfig: remove tristate choice supportI previously submitted a fix for a bug in the choice feature [1], whereI mentioned, "Another (much cleaner) approach would be to remove thetristate choice support entirely".There are more issues in the tristate choice feature. For example, youcan observe a couple of bugs in the following test code.[Test Code] config MODULES def_bool y modules choice prompt "tristate choice" default A config A tristate "A" config B tristate "B" endchoiceBug 1: the 'default' property is not correctly processed'make alldefconfig' produces: CONFIG_MODULES=y # CONFIG_A is not set # CONFIG_B is not setHowever, the correct output should be: CONFIG_MODULES=y CONFIG_A=y # CONFIG_B is not setThe unit test file, scripts/kconfig/tests/choice/alldef_expected_config,is wrong as well.Bug 2: choice members never get 'y' with randconfigFor the test code above, the following combinations are possible: A B (1) y n (2) n y (3) m m (4) m n (5) n m (6) n n'make randconfig' never produces (1) or (2).These bugs are fixable, but a more critical problem is the lack of asensible syntax to specify the default for the tristate choice.The default for the choice must be one of the choice members, whichcannot specify any of the patterns (3) through (6) above.In addition, I have never seen it being used in a useful way.The following commits removed unnecessary use of tristate choices: - df8df5e4bc37 ("usb: get rid of 'choice' for legacy gadget drivers") - bfb57ef0544a ("rapidio: remove choice for enumeration")This commit removes the tristate choice support entirely, which allowsme to delete a lot of code, making further refactoring easier.Note:This includes the revert of commit fa64e5f6a35e ("kconfig/symbol.c:handle choice_values that depend on 'm' symbols"). It was suspiciousbecause it did not address the root cause but introduced inconsistencyin visibility between choice members and other symbols.[1]: https://lore.kernel.org/linux-kbuild/20240427104231.2728905-1-masahiroy@kernel.org/T/#m0a1bb6992581462ceca861b409bb33cb8fd7dbaeSigned-off-by: Masahiro Yamada <masahiroy@kernel.org>Reviewed-by: Nicolas Schier <nicolas@fjasle.eu> List of files: /linux-6.15/scripts/kconfig/tests/choice/alldef_expected_config Sun, 02 Jun 2024 12:54:14 +0000 Masahiro Yamada <masahiroy@kernel.org> http://172.16.0.5:8080/history/linux-6.15/scripts/kconfig/tests/choice/alldef_expected_config#1903c511 kconfig: tests: add basic choice testsThe calculation of 'choice' is a bit complicated part in Kconfig.The behavior of 'y' choice is intuitive. If choice values are tristate,the choice can be 'm' where each value can be enabled independently.Also, if a choice is marked as 'optional', the whole choice can beinvisible.Test basic functionality of choice.Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>Reviewed-by: Ulf Magnusson <ulfalizer@gmail.com> List of files: /linux-6.15/scripts/kconfig/tests/choice/alldef_expected_config Tue, 13 Mar 2018 09:12:04 +0000 Masahiro Yamada <yamada.masahiro@socionext.com>