Changes in lkc.h

a16219bd - scripts: move hash function from scripts/kconfig/ to scripts/include/

Sun, 08 Sep 2024 12:43:16 +0000

scripts: move hash function from scripts/kconfig/ to scripts/include/This function was originally added by commit 8af27e1dc4e4 ("fixdep: usehash table instead of a single array").Move it to scripts/include/ so that other host programs can use it.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/lkc.h

a9d83d74 - kbuild: split x*alloc() functions in kconfig to scripts/include/xalloc.h

Mon, 12 Aug 2024 12:48:50 +0000

kbuild: split x*alloc() functions in kconfig to scripts/include/xalloc.hThese functions will be useful for other host programs.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/lkc.h

94a4b0a4 - kconfig: remove SYMBOL_CHOICEVAL flag

Sun, 07 Jul 2024 15:38:06 +0000

kconfig: remove SYMBOL_CHOICEVAL flagThis flag is unneeded because a choice member can be detected byother means.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/lkc.h

6425e3b2 - kconfig: add const qualifiers to several function arguments

Sun, 07 Jul 2024 15:38:05 +0000

kconfig: add const qualifiers to several function argumentsClarify that the given structures are not modified.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/lkc.h

e8fcd915 - kconfig: change sym_choice_default() to take the choice menu

Tue, 18 Jun 2024 10:35:24 +0000

kconfig: change sym_choice_default() to take the choice menuChange the argument of sym_choice_default() to ease further cleanups.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/lkc.h

bd0db4b6 - kconfig: remove sym_get_choice_value()

Tue, 18 Jun 2024 10:35:22 +0000

kconfig: remove sym_get_choice_value()sym_get_choice_value(menu->sym) is equivalent to sym_calc_choice(menu).Convert all call sites of sym_get_choice_value() and then remove it.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/lkc.h

f79dc03f - kconfig: refactor choice value calculation

Tue, 18 Jun 2024 10:35:21 +0000

kconfig: refactor choice value calculationHandling choices has always been in a PITA in Kconfig.For example, fixes and reverts were repeated for randconfig withKCONFIG_ALLCONFIG: - 422c809f03f0 ("kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG") - 23a5dfdad22a ("Revert "kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG"") - 8357b48549e1 ("kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG") - 490f16171119 ("Revert "kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG"")As these commits pointed out, randconfig does not randomize choices whenKCONFIG_ALLCONFIG is used. This issue still remains.[Test Case] choice prompt "choose" config A bool "A" config B bool "B" endchoice $ echo > all.config $ make KCONFIG_ALLCONFIG=1 randconfigThe output is always as follows: CONFIG_A=y # CONFIG_B is not setNot only randconfig, but other all*config variants are also broken withKCONFIG_ALLCONFIG.With the same Kconfig, $ echo '# CONFIG_A is not set' > all.config $ make KCONFIG_ALLCONFIG=1 allyesconfigYou will get this: CONFIG_A=y # CONFIG_B is not setThis is incorrect because it does not respect all.config.The correct output should be: # CONFIG_A is not set CONFIG_B=yTo handle user inputs more accurately, this commit refactors the codebased on the following principles: - When a user value is given, Kconfig must set it immediately. Do not defer it by setting SYMBOL_NEED_SET_CHOICE_VALUES. - The SYMBOL_DEF_USER flag must not be cleared, unless a new config file is loaded. Kconfig must not forget user inputs.In addition, user values for choices must be managed with priority.If user inputs conflict within a choice block, the newest value wins.The values given by randconfig have lower priority than explicit userinputs.This commit implements it by using a linked list. Every time a choiceblock gets a new input, it is moved to the top of the list.Let me explain how it works.Let's say, we have a choice block that consists of five symbols:A, B, C, D, and E.Initially, the linked list looks like this: A(=?) --> B(=?) --> C(=?) --> D(=?) --> E(=?)Suppose randconfig is executed with the following KCONFIG_ALLCONFIG: CONFIG_C=y # CONFIG_A is not set CONFIG_D=yFirst, CONFIG_C=y is read. C is set to 'y' and moved to the top. C(=y) --> A(=?) --> B(=?) --> D(=?) --> E(=?)Next, '# CONFIG_A is not set' is read. A is set to 'n' and moved tothe top. A(=n) --> C(=y) --> B(=?) --> D(=?) --> E(=?)Then, 'CONFIG_D=y' is read. D is set to 'y' and moved to the top. D(=y) --> A(=n) --> C(=y) --> B(=?) --> E(=?)Lastly, randconfig shuffles the order of the remaining symbols,resulting in: D(=y) --> A(=n) --> C(=y) --> B(=y) --> E(=y)or D(=y) --> A(=n) --> C(=y) --> E(=y) --> B(=y)When calculating the output, the linked list is traversed and the firstvisible symbol with 'y' is taken. In this case, it is D if visible.If D is hidden by 'depends on', the next node, A, is examined. Sinceit is already specified as 'n', it is skipped. Next, C is checked, andselected if it is visible.If C is also invisible, either B or E is chosen as a result of therandomization.If B and E are also invisible, the linked list is traversed in thereverse order, and the least prioritized 'n' symbol is chosen. It isA in this case.Now, Kconfig remembers all user values. This is a big difference fromthe previous implementation, where Kconfig would forget CONFIG_C=y whenCONFIG_D=y appeared in the same input file.The new appaorch respects user-specified values as much as possible.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/lkc.h

6a121588 - kconfig: remove 'optional' property support

Mon, 22 Apr 2024 16:41:04 +0000

kconfig: remove 'optional' property supportThe 'choice' statement is primarily used to exclusively select oneoption, but the 'optional' property allows all entries to be disabled.In the following example, both A and B can be disabled simultaneously: choice prompt "choose A, B, or nothing" optional config A bool "A" config B bool "B" endchoiceYou can achieve the equivalent outcome by other means.A common solution is to add another option to guard the choice block.In the following example, you can set ENABLE_A_B_CHOICE=n to disablethe entire choice block: choice prompt "choose A or B" depends on ENABLE_A_B_CHOICE config A bool "A" config B bool "B" endchoiceAnother approach is to insert one more entry: choice prompt "choose A, B, or disable both" config A bool "A" config B bool "B" config DISABLE_A_AND_B bool "choose this to disable both A and B" endchoiceSome real examples are DEBUG_INFO_NONE, INITRAMFS_COMPRESSION_NONE,LTO_NONE, etc.The 'optional' property is even more unnecessary for a tristate choice.Without the 'optional' property, you can disable A and B; you can set'm' in the choice prompt, and disable A and B individually: choice prompt "choose one built-in or make them modular" config A tristate "A" config B tristate "B" endchoiceIn conclusion, the 'optional' property was unneeded.Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/scripts/kconfig/lkc.h

1da251c6 - kconfig: remove SYMBOL_CHOICE flag

Mon, 22 Apr 2024 16:10:54 +0000

kconfig: remove SYMBOL_CHOICE flagAll symbols except choices have a name.Previously, choices were allowed to have a name, but commit c83f020973bc("kconfig: remove named choice support") eliminated that possibility.Now, it is easy to distinguish choices from normal symbols; if the nameis NULL, it is a choice.Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/scripts/kconfig/lkc.h

7284b4fb - kconfig: add menu_next() function and menu_for_each(_sub)_entry macros

Sun, 21 Apr 2024 09:02:51 +0000

kconfig: add menu_next() function and menu_for_each(_sub)_entry macrosSeveral functions require traversing menu entries sequentially. Thiscommit introduces some helpers to simplify such operations.The menu_next() function facilitates depth-first traversal: 1. Descend to the child level if the current menu has one 2. Move to the next sibling at the same level if available 3. Ascend to the parent level if there is no more child or siblingThe menu_for_each_sub_entry() macro iterates over all submenu entriesusing depth-first traverse.The menu_for_each_entry() macro is the same, but over all menu entries.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/lkc.h

7e3465f6 - kconfig: do not reparent the menu inside a choice block

Sat, 23 Mar 2024 08:51:01 +0000

kconfig: do not reparent the menu inside a choice blockThe boolean 'choice' is used to list exclusively selected configoptions.You must not add a dependency between choice members, because such adependency would create an invisible entry.In the following test case, it is impossible to choose 'C'.[Test Case 1] choice prompt "Choose one, but how to choose C?" config A bool "A" config B bool "B" config C bool "C" depends on A endchoiceHence, Kconfig shows the following error message: Kconfig:1:error: recursive dependency detected! Kconfig:1: choice contains symbol C Kconfig:10: symbol C is part of choice A Kconfig:4: symbol A is part of choice For a resolution refer to Documentation/kbuild/kconfig-language.rst subsection "Kconfig recursive dependency limitations"However, Kconfig does not report anything for the following similar code:[Test Case 2] choice prompt "Choose one, but how to choose B?" config A bool "A" config B bool "B" depends on A config C bool "C" endchoiceThis is because menu_finalize() reparents the menu tree when an entrydepends on the preceding one.With reparenting, the menu tree: choice |- A |- B \- C... will be transformed into the following structure: choice |- A | \- B \- CConsequently, Kconfig considers only 'A' and 'C' as choice members.This behavior is awkward. The second test case should be an error too.This commit stops reparenting inside a choice.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/lkc.h

7c4aa901 - kconfig: move strhash() to util.c as a global function

Fri, 02 Feb 2024 15:58:22 +0000

kconfig: move strhash() to util.c as a global functionRemove the 'static' qualifier from strhash() so that it can be accessedfrom other files. Move it to util.c, which is a more appropriate location.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/lkc.h

5b058034 - kconfig: change file_lookup() to return the file name

Fri, 02 Feb 2024 15:58:16 +0000

kconfig: change file_lookup() to return the file nameCurrently, file_lookup() returns a pointer to (struct file), but thecallers use only file->name.Make it return the ->name member directly.This adjustment encapsulates struct file and file_list as internalimplementation.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/lkc.h

1d7c4f10 - kconfig: remove zconf_curname() and zconf_lineno()

Fri, 02 Feb 2024 15:58:08 +0000

kconfig: remove zconf_curname() and zconf_lineno()Now zconf_curname() and zconf_lineno() are so simple that they justreturn cur_filename, cur_lineno, respectively.Remove these functions, and then use cur_filename and cur_linenodirectly.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/lkc.h

526396b7 - kconfig: write Kconfig files to autoconf.cmd in order

Fri, 02 Feb 2024 15:58:04 +0000

kconfig: write Kconfig files to autoconf.cmd in orderCurrently, include/config/autoconf.cmd saves included Kconfig files inreverse order. While this is not a big deal, it is inconsistent withother *.cmd files generated by fixdep.Output the included Kconfig files in the included order.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/lkc.h

092e39d1 - kconfig: squash menu_has_help() and menu_get_help()

Sun, 03 Dec 2023 10:25:25 +0000

kconfig: squash menu_has_help() and menu_get_help()menu_has_help() and menu_get_help() functions are only used withinmenu_get_ext_help().Squash them into menu_get_ext_help(). It revealed the if-conditionalin menu_get_help() was unneeded, as menu_has_help() has already checkedthat menu->help is not NULL.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/lkc.h

e14f1242 - kconfig: menuconfig: simplify global jump key assignment

Sun, 16 Jul 2023 04:55:07 +0000

kconfig: menuconfig: simplify global jump key assignmentCommit 95ac9b3b585d ("menuconfig: Assign jump keys per-page insteadof globally") injected a lot of hacks to the bottom of the textboxinfrastructure.I reverted many of them without changing the behavior. (almost)Now, the key markers are inserted when constructing the search resultinstead of updating the text buffer on-the-fly.The buffer passed to the textbox got back to a constant string.The ugly casts from (const char *) to (char *) went away.A disadvantage is that the same key numbers might be displayed multipletimes in the dialog if you use a huge window (but I believe it isunlikely to happen).Signed-off-by: Masahiro Yamada Reviewed-by: Jesse Taube List of files: /linux-6.15/scripts/kconfig/lkc.h

4d980fd1 - kconfig: remove const qualifier from str_get()

Sun, 13 Nov 2022 10:59:42 +0000

kconfig: remove const qualifier from str_get()update_text() apparently edits the buffer returned by str_get().(and there is no reason why it shouldn't)Remove 'const' quailifier and casting.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/lkc.h

efc8338e - Kconfig: remove sym_set_choice_value

Wed, 14 Sep 2022 01:59:06 +0000

Kconfig: remove sym_set_choice_valuesym_set_choice_value could be removed and directly callsym_set_tristate_value instead.Signed-off-by: Zeng Heng Suggested-by: Masahiro Yamada Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/lkc.h

03764b30 - Kconfig: remove unused function 'menu_get_root_menu'

Mon, 12 Sep 2022 09:48:38 +0000

Kconfig: remove unused function 'menu_get_root_menu'There is nowhere calling `menu_get_root_menu` function,so remove it.Signed-off-by: Zeng Heng Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/kconfig/lkc.h