Changes in Makefile

a11aaf6d - kbuild: scripts/gdb: bring the "abspath" back

Wed, 26 Jun 2024 12:06:16 +0000

kbuild: scripts/gdb: bring the "abspath" backUse the "abspath" call when symlinking the gdb python scripts inscripts/gdb/linux. This call is needed to avoid broken links whenrunning the scripts_gdb target on a build directory located directlyunder the source tree (e.g., O=builddir).Fixes: 659bbf7e1b08 ("kbuild: scripts/gdb: Replace missed $(srctree)/$(src) w/ $(src)")Signed-off-by: Joel Granados Reviewed-by: Douglas Anderson Tested-by: Douglas Anderson Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/gdb/linux/Makefile

659bbf7e - kbuild: scripts/gdb: Replace missed $(srctree)/$(src) w/ $(src)

Mon, 20 May 2024 19:56:52 +0000

kbuild: scripts/gdb: Replace missed $(srctree)/$(src) w/ $(src)Recently we went through the source tree and replaced$(srctree)/$(src) w/ $(src). However, the gdb scripts Makefile had ahidden $(srctree)/$(src) that looked like this: $(abspath $(srctree))/$(src)Because we missed that then my installed kernel had symlinks thatlooked like this: __init__.py -> ${INSTALL_DIR}/$(INSTALL_DIR}/scripts/gdb/linux/__init__.pyLet's also replace the midden $(abspath $(srctree))/$(src) with$(src). Now: __init__.py -> $(INSTALL_DIR}/scripts/gdb/linux/__init__.pyFixes: b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src) for source directory")Signed-off-by: Douglas Anderson Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/gdb/linux/Makefile

b1992c37 - kbuild: use $(src) instead of $(srctree)/$(src) for source directory

Sat, 27 Apr 2024 14:55:02 +0000

kbuild: use $(src) instead of $(srctree)/$(src) for source directoryKbuild conventionally uses $(obj)/ for generated files, and $(src)/ forchecked-in source files. It is merely a convention without any functionaldifference. In fact, $(obj) and $(src) are exactly the same, as definedin scripts/Makefile.build: src := $(obj)When the kernel is built in a separate output directory, $(src) doesnot accurately reflect the source directory location. While Kbuildresolves this discrepancy by specifying VPATH=$(srctree) to search forsource files, it does not cover all cases. For example, when adding aheader search path for local headers, -I$(srctree)/$(src) is typicallypassed to the compiler.This introduces inconsistency between upstream and downstream Makefilesbecause $(src) is used instead of $(srctree)/$(src) for the latter.To address this inconsistency, this commit changes the semantics of$(src) so that it always points to the directory in the source tree.Going forward, the variables used in Makefiles will have the followingmeanings: $(obj) - directory in the object tree $(src) - directory in the source tree (changed by this commit) $(objtree) - the top of the kernel object tree $(srctree) - the top of the kernel source treeConsequently, $(srctree)/$(src) in upstream Makefiles need to be replacedwith $(src).Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/scripts/gdb/linux/Makefile

2047ace9 - kbuild: use always-y instead of extra-y

Wed, 20 Jan 2021 06:23:51 +0000

kbuild: use always-y instead of extra-yAs commit d0e628cd817f ("kbuild: doc: clarify the difference betweenextra-y and always-y") explained, extra-y should be used for listingthe prerequisites of vmlinux.These targets are not related to vmlinux. always-y is a better fix.Signed-off-by: Masahiro Yamada Reviewed-by: Rob Herring List of files: /linux-6.15/scripts/gdb/linux/Makefile

051f278e - kbuild: replace KBUILD_SRCTREE with boolean building_out_of_srctree

Sat, 06 Jul 2019 03:07:12 +0000

kbuild: replace KBUILD_SRCTREE with boolean building_out_of_srctreeCommit 25b146c5b8ce ("kbuild: allow Kbuild to start from any directory")deprecated KBUILD_SRCTREE.It is only used in tools/testing/selftest/ to distinguish out-of-treebuild. Replace it with a new boolean flag, building_out_of_srctree.I also replaced the conditional ($(srctree),.) because the next commitwill allow an absolute path to be used for $(srctree) even when buildingin the source tree.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/gdb/linux/Makefile

a9a49c2a - kbuild: use $(srctree) instead of KBUILD_SRC to check out-of-tree build

Sat, 30 Mar 2019 12:04:17 +0000

kbuild: use $(srctree) instead of KBUILD_SRC to check out-of-tree buildKBUILD_SRC was conventionally used for some different purposes: [1] To remember the source tree path [2] As a flag to check if sub-make is already done [3] As a flag to check if Kbuild runs out of treeFor [1], we do not need to remember it because the top Makefilecan compute it by $(realpath $(dir $(lastword $(MAKEFILE_LIST))))[2] has been replaced with self-commenting 'sub_make_done'.For [3], we can distinguish in-tree/out-of-tree by comparing$(srctree) and '.'This commit converts [3] to prepare for the KBUILD_SRC removal.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/gdb/linux/Makefile

b513adf4 - scripts/gdb: refactor rules for symlink creation

Tue, 19 Feb 2019 09:33:06 +0000

scripts/gdb: refactor rules for symlink creationgdb-scripts is not a real object, but (ab)used like a phony target.Rewrite the code in a more Kbuild-ish way. Add symlinks to extra-yand use if_changed.Signed-off-by: Masahiro Yamada Reviewed-by: Kieran Bingham List of files: /linux-6.15/scripts/gdb/linux/Makefile

1e5ff84f - scripts/gdb: do not descend into scripts/gdb from scripts

Tue, 19 Feb 2019 09:33:04 +0000

scripts/gdb: do not descend into scripts/gdb from scriptsCurrently, Kbuild descends from scripts/Makefile to scripts/gdb/Makefilejust for creating symbolic links, but it does not need to do it so early.Merge the two descending paths to simplify the code.Signed-off-by: Masahiro Yamada Reviewed-by: Kieran Bingham List of files: /linux-6.15/scripts/gdb/linux/Makefile

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/scripts/gdb/linux/Makefile

8e9b4667 - kbuild: use $(abspath ...) instead of $(shell cd ... && /bin/pwd)

Sun, 20 Aug 2017 06:04:11 +0000

kbuild: use $(abspath ...) instead of $(shell cd ... && /bin/pwd)Kbuild conventionally uses $(shell cd ... && /bin/pwd) idiom to getthe absolute path of the directory because GNU Make 3.80, the minimalsupported version at that time, did not support $(abspath ...) or$(realpath ...).Commit 37d69ee30808 ("docs: bump minimal GNU Make version to 3.81")dropped the GNU Make 3.80 support, so we are now allowed to use thosemake-builtin helpers.This conversion will provide better portability without relying onthe pwd command or its location /bin/pwd.I am intentionally using $(realpath ...) instead $(abspath ...) insome places. The difference between the two is $(realpath ...)returns an empty string if the given path does not exist. It isconvenient in places where we need to error-out if the makefile failsto create an output directory.Signed-off-by: Masahiro Yamada Acked-by: Thierry Reding List of files: /linux-6.15/scripts/gdb/linux/Makefile

834a3529 - scripts/gdb: rebuild constants.py on dependancy change

Thu, 14 Jul 2016 19:06:58 +0000

scripts/gdb: rebuild constants.py on dependancy changeThe autogenerated constants.py file was only being built on the initialcall, and if the constants.py.in file changed. As we are utilising theCPP hooks, we can successfully use the call if_changed_dep rules todetermine when to rebuild the file based on it's inclusions.Link: http://lkml.kernel.org/r/1467127337-11135-3-git-send-email-kieran@bingham.xyzSigned-off-by: Kieran Bingham Reported-by: Jan Kiszka Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/scripts/gdb/linux/Makefile

abb035b4 - scripts/gdb: silence 'nothing to do' message

Thu, 14 Jul 2016 19:06:55 +0000

scripts/gdb: silence 'nothing to do' messageThe constants.py generation, involves a rule to link into the mainmakefile. This rule has no command and generates a spurious warningmessage in the build logs when CONFIG_SCRIPTS_GDB is enabled.Fix simply by giving a no-op actionLink: http://lkml.kernel.org/r/1467127337-11135-2-git-send-email-kieran@bingham.xyzSigned-off-by: Kieran Bingham Reported-by: Jan Kiszka Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/scripts/gdb/linux/Makefile

f197d75f - scripts/gdb: provide linux constants

Mon, 23 May 2016 23:24:40 +0000

scripts/gdb: provide linux constantsSome macro's and defines are needed when parsing memory, and withoutcompiling the kernel as -g3 they are not available in the debug-symbols.We use the pre-processor here to extract constants to a dedicated modulefor the linux debugger extensionsTop level Kbuild is used to call in and generate the constants file,while maintaining dependencies on autogenerated files ininclude/generatedLink: http://lkml.kernel.org/r/bc3df9c25f57ea72177c066a51a446fc19e2c27f.1462865983.git.jan.kiszka@siemens.comSigned-off-by: Kieran Bingham Signed-off-by: Jan Kiszka Cc: Michal Marek Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/scripts/gdb/linux/Makefile

3ee7b3fa - scripts/gdb: add infrastructure

Tue, 17 Feb 2015 21:46:36 +0000

scripts/gdb: add infrastructureThis provides the basic infrastructure to load kernel-specific pythonhelper scripts when debugging the kernel in gdb.The loading mechanism is based on gdb loading for -gdb.py whenopening . Therefore, this places a corresponding link to themain helper script into the output directory that contains vmlinux.The main scripts will pull in submodules containing Linux specific gdbcommands and functions. To avoid polluting the source directory withcompiled python modules, we link to them from the object directory.Due to gdb.parse_and_eval and string redirection for gdb.execute, wedepend on gdb >= 7.2.This feature is enabled via CONFIG_GDB_SCRIPTS.Signed-off-by: Jan Kiszka Acked-by: Michal Marek [kbuild stuff]Cc: Thomas Gleixner Cc: Jason Wessel Cc: Andi Kleen Cc: Ben Widawsky Cc: Borislav Petkov Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/scripts/gdb/linux/Makefile