Changes in Makefile.headersinst

3204a7fb - kbuild: prefix $(srctree)/ to some included Makefiles

Sun, 28 Feb 2021 06:10:26 +0000

kbuild: prefix $(srctree)/ to some included MakefilesVPATH is used in Kbuild to make pattern rules search for prerequisitesin both $(objtree) and $(srctree). Some of *.c, *.S files are not realsources, but generated by tools such as flex, bison, perl.In contrast, I doubt the benefit of --include-dir=$(abs_srctree) becauseit is always clear which Makefiles are real sources, and which are not.So, my hope is to add $(srctree)/ prefix to all check-in Makefiles,then remove --include-dir=$(abs_srctree) flag in the future.I am touching only some Kbuild core parts for now. Treewide fixes willbe needed to achieve this goal.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.headersinst

7ecaf069 - kbuild: move headers_check rule to usr/include/Makefile

Thu, 07 Nov 2019 07:14:41 +0000

kbuild: move headers_check rule to usr/include/MakefileCurrently, some sanity checks for uapi headers are done byscripts/headers_check.pl, which is wired up to the 'headers_check'target in the top Makefile.It is true compiling headers has better test coverage, but thereare still several headers excluded from the compile test. I liketo keep headers_check.pl for a while, but we can delete a lot ofcode by moving the build rule to usr/include/Makefile.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.headersinst

7ff4f080 - kbuild: fix 'No such file or directory' warning for headers_install

Sat, 22 Jun 2019 06:55:20 +0000

kbuild: fix 'No such file or directory' warning for headers_installSince commit d5470d14431e ("kbuild: re-implement Makefile.headersinstwithout recursion"), headers_install emits an ugly warning.$ make headers_install [ snip ] UPD include/generated/uapi/linux/version.hfind: ‘./include/uapi/Kbuild’: No such file or directory HDRINST usr/include/video/uvesafb.h ...This happens for GNU Make <= 4.2.1When I wrote that commit, I missed this warning because I was using thestate-of-the-art Make version compiled from the git tree.$(wildcard $(src)/*/) is intended to match to only existing directoriessince it has a trailing slash, but actually matches to regular files too.(include/uapi/Kbuild in this case)This is a bug of GNU Make, and was fixed by:| commit b7acb10e86dc8f5fdf2a2bbd87e1059c315e31d6| Author: spagoveanu@gmail.com | Date: Wed Jun 20 02:03:48 2018 +0300|| * src/dir.c: Preserve glob d_type fieldWe need to cater to old Make versions. Add '$(filter %/,...) to filterout the regular files.Fixes: d5470d14431e ("kbuild: re-implement Makefile.headersinst without recursion")Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.headersinst

555187a8 - kbuild: simplify scripts/headers_install.sh

Tue, 04 Jun 2019 10:14:05 +0000

kbuild: simplify scripts/headers_install.shNow that headers_install.sh is invoked per file, remove the for-loopin the shell script.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.headersinst

d5470d14 - kbuild: re-implement Makefile.headersinst without recursion

Tue, 04 Jun 2019 10:14:03 +0000

kbuild: re-implement Makefile.headersinst without recursionSince commit fcc8487d477a ("uapi: export all headers under uapidirectories"), the headers in uapi directories are all exported bydefault although exceptional cases are still allowed by the syntax'no-export-headers'.The traditional directory descending has been kept (in a somewhathacky way), but it is actually unneeded.Get rid of it to simplify the code.Also, handle files one by one instead of the previous per-directoryprocessing. This will emit much more log, but I like it.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.headersinst

59b2bd05 - kbuild: add 'headers' target to build up uapi headers in usr/include

Tue, 04 Jun 2019 10:14:02 +0000

kbuild: add 'headers' target to build up uapi headers in usr/includeIn Linux build system, build targets and installation targets areseparated.Examples are: - 'make vmlinux' -> 'make install' - 'make modules' -> 'make modules_install' - 'make dtbs' -> 'make dtbs_install' - 'make vdso' -> 'make vdso_install'The intention is to run the build targets under the normal privilege,then the installation targets under the root privilege since we needthe write permission to the system directories.We have 'make headers_install' but the corresponding 'make headers'stage does not exist. The purpose of headers_install is to providethe kernel interface to C library. So, nobody would try to installheaders to /usr/include directly.If 'sudo make INSTALL_HDR_PATH=/usr/include headers_install' were run,some build artifacts in the kernel tree would be owned by root becausesome of uapi headers are generated by 'uapi-asm-generic', 'archheaders'targets.Anyway, I believe it makes sense to split the header installation intotwo stages. [1] 'make headers' Process headers in uapi directories by scripts/headers_install.sh and copy them to usr/include [2] 'make headers_install' Copy '*.h' verbatim from usr/include to $(INSTALL_HDR_PATH)/includeFor the backward compatibility, 'headers_install' depends on 'headers'.Some samples expect uapi headers in usr/include. So, the 'headers'target is useful to build up them in the fixed location usr/includeirrespective of INSTALL_HDR_PATH.Another benefit is to stop polluting the final destination with thetime-stamp files '.install' and '.check'. Maybe you can see them inyour toolchains.Lastly, my main motivation is to prepare for compile-testing uapiheaders. To build something, we have to save an object and .*.cmdsomewhere. The usr/include/ will be the work directory for that.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.headersinst

91998731 - kbuild: generate asm-generic wrappers if mandatory headers are missing

Thu, 03 Jan 2019 01:10:38 +0000

kbuild: generate asm-generic wrappers if mandatory headers are missingSome time ago, Sam pointed out a certain degree of overwrap betweengeneric-y and mandatory-y. (https://lkml.org/lkml/2017/7/10/121)I tweaked the meaning of mandatory-y a little bit; now it defines theminimum set of ASM headers that all architectures must have.If arch does not have specific implementation of a mandatory header,Kbuild will let it fallback to the asm-generic one by automaticallygenerating a wrapper. This will allow to drop lots of redundantgeneric-y defines.Previously, "mandatory" was used in the context of UAPI, but I guessthis can be extended to kernel space ASM headers.Suggested-by: Sam Ravnborg Signed-off-by: Masahiro Yamada Acked-by: Sam Ravnborg List of files: /linux-6.15/scripts/Makefile.headersinst

5e34bd1d - kbuild: remove a special handling for *.agh in Makefile.headersinst

Wed, 05 Dec 2018 07:37:53 +0000

kbuild: remove a special handling for *.agh in Makefile.headersinstscripts/Makefile.headersinst takes care of *.agh just for arch/cris/include/uapi/arch-v10/arch/sv_addr.aghbecause renaming exported headers is difficult (or impossible).This code is no longer necessary thanks to commit c690eddc2f3b ("CRIS:Drop support for the CRIS port").Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.headersinst

e474ed45 - kbuild: specify FORCE in Makefile.headersinst as .PHONY target

Mon, 13 Nov 2017 10:33:19 +0000

kbuild: specify FORCE in Makefile.headersinst as .PHONY targetSwap the order of ".PHONY: $(PHONY)" and "PHONY += FORCE"so that FORCE is correctly specified as a .PHONY target.Use a preferred way for specifying $(subdirs) as .PHONY targets.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.headersinst

2982c953 - kbuild: remove redundant $(wildcard ...) for cmd_files calculation

Mon, 13 Nov 2017 10:29:35 +0000

kbuild: remove redundant $(wildcard ...) for cmd_files calculationI do not see any reason why $(wildcard ...) needs to be called twicefor computing cmd_files. Remove the first one.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.headersinst

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/scripts/Makefile.headersinst

9d022c54 - kbuild: replace $(hdr-arch) with $(SRCARCH)

Wed, 04 Oct 2017 03:56:04 +0000

kbuild: replace $(hdr-arch) with $(SRCARCH)Since commit 5e53879008b9 ("sparc,sparc64: unify Makefile"), hdr-archand SRCARCH always match.Signed-off-by: Masahiro Yamada Reviewed-by: Douglas Anderson List of files: /linux-6.15/scripts/Makefile.headersinst

09c3776c - kbuild: remove wrapper files handling from Makefile.headersinst

Sun, 09 Jul 2017 18:33:00 +0000

kbuild: remove wrapper files handling from Makefile.headersinstscripts/Makefike.headersinst creates asm-generic wrappers by itselfbecause scripts/Makefile.asm-generic created some of exported wrappersoutside uapi directories.Now this distortion has been fixed. scripts/Makefile.headersinst cansimply copy wrappers created by scripts/Makefile.asm-generic.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.headersinst

d1b32bac - kbuild: do not include old-kbuild-file from Makefile.headersinst

Sun, 09 Jul 2017 18:32:58 +0000

kbuild: do not include old-kbuild-file from Makefile.headersinstNow asm-generic wrappers to be exported are all listed inarch/*/include/uapi/asm/Kbuild. "make headers_install" no longerdepends on any Kbuild files outside uapi directories.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.headersinst

a8ff49a1 - kbuild: pass dst= to Makefile.headersinst from top Makefile

Sun, 09 Jul 2017 18:32:35 +0000

kbuild: pass dst= to Makefile.headersinst from top MakefileWe can always pass dst= from the top Makefile. This will simplifythe logic in Makefile.headersinst.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.headersinst

87ebb94e - kbuild: remove useless $(gen) variable in Makefile.headersinst

Sun, 09 Jul 2017 18:32:33 +0000

kbuild: remove useless $(gen) variable in Makefile.headersinstWe have no true case for the $(if $(gen), ...) conditional. Drop itto simplify the gendir calculation.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.headersinst

2f263d14 - kbuild: fix header installation under fakechroot environment

Thu, 15 Jun 2017 08:36:22 +0000

kbuild: fix header installation under fakechroot environmentSince commit fcc8487d477a ("uapi: export all headers under uapidirectories") fakechroot make bindeb-pkg fails, mismatching files fordirectories:touch: cannot touch 'usr/include/video/uvesafb.h/.install': Not adirectoryThis due to a bug in fakechroot:when using the function $(wildcard $(srcdir)/*/.) in a makefile, under afakechroot environment, not only directories but also files arereturned.To circumvent that, we are using the functions:$(sort $(dir $(wildcard $(srcdir)/*/))))Fixes: fcc8487d477a ("uapi: export all headers under uapi directories")Signed-off-by: Richard Genoud Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.headersinst

05d8cba4 - kbuild: skip install/check of headers right under uapi directories

Tue, 16 May 2017 05:15:03 +0000

kbuild: skip install/check of headers right under uapi directoriesSince commit 61562f981e92 ("uapi: export all arch specificsdirectories"), "make INSTALL_HDR_PATH=$root/usr headers_install"deletes standard glibc headers and others in $(root)/usr/include.The cause of the issue is that headers_install now starts descendingfrom arch/$(hdr-arch)/include/uapi with $(root)/usr/include for itsdestination when installing asm headers. So, headers already thereare assumed to be unwanted.When headers_install starts descending from include/uapi with$(root)/usr/include for its destination, it works around the problemby creating an dummy destination $(root)/usr/include/uapi, but thisis tricky.To fix the problem in a clean way is to skip headers install/checkin include/uapi and arch/$(hdr-arch)/include/uapi because we knowthere are only sub-directories in uapi directories. A good sideeffect is the empty destination $(root)/usr/include/uapi will goaway.I am also removing the trailing slash in the headers_check target toskip checking in arch/$(hdr-arch)/include/uapi.Fixes: 61562f981e92 ("uapi: export all arch specifics directories")Reported-by: Dan Williams Signed-off-by: Masahiro Yamada Tested-by: Dan Williams Acked-by: Nicolas Dichtel List of files: /linux-6.15/scripts/Makefile.headersinst

61562f98 - uapi: export all arch specifics directories

Mon, 27 Mar 2017 12:20:16 +0000

uapi: export all arch specifics directoriesThis patch removes the need of subdir-y. Now all files/directories underarch//include/uapi/ are exported.The only change for userland is the layout of the command 'makeheaders_install_all': directories asm- are replaced by arch-/.Those new directories contains all files/directories of the specified arch.Note that only cris and tile have more directories than only asm: - arch-v[10|32] for cris; - arch for tile.Signed-off-by: Nicolas Dichtel Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.headersinst

fcc8487d - uapi: export all headers under uapi directories

Mon, 27 Mar 2017 12:20:15 +0000

uapi: export all headers under uapi directoriesRegularly, when a new header is created in include/uapi/, the developerforgets to add it in the corresponding Kbuild file. This error is usuallydetected after the release is out.In fact, all headers under uapi directories should be exported, thus it'suseless to have an exhaustive list.After this patch, the following files, which were not exported, are nowexported (with make headers_install_all):asm-arc/kvm_para.hasm-arc/ucontext.hasm-blackfin/shmparam.hasm-blackfin/ucontext.hasm-c6x/shmparam.hasm-c6x/ucontext.hasm-cris/kvm_para.hasm-h8300/shmparam.hasm-h8300/ucontext.hasm-hexagon/shmparam.hasm-m32r/kvm_para.hasm-m68k/kvm_para.hasm-m68k/shmparam.hasm-metag/kvm_para.hasm-metag/shmparam.hasm-metag/ucontext.hasm-mips/hwcap.hasm-mips/reg.hasm-mips/ucontext.hasm-nios2/kvm_para.hasm-nios2/ucontext.hasm-openrisc/shmparam.hasm-parisc/kvm_para.hasm-powerpc/perf_regs.hasm-sh/kvm_para.hasm-sh/ucontext.hasm-tile/shmparam.hasm-unicore32/shmparam.hasm-unicore32/ucontext.hasm-x86/hwcap2.hasm-xtensa/kvm_para.hdrm/armada_drm.hdrm/etnaviv_drm.hdrm/vgem_drm.hlinux/aspeed-lpc-ctrl.hlinux/auto_dev-ioctl.hlinux/bcache.hlinux/btrfs_tree.hlinux/can/vxcan.hlinux/cifs/cifs_mount.hlinux/coresight-stm.hlinux/cryptouser.hlinux/fsmap.hlinux/genwqe/genwqe_card.hlinux/hash_info.hlinux/kcm.hlinux/kcov.hlinux/kfd_ioctl.hlinux/lightnvm.hlinux/module.hlinux/nbd-netlink.hlinux/nilfs2_api.hlinux/nilfs2_ondisk.hlinux/nsfs.hlinux/pr.hlinux/qrtr.hlinux/rpmsg.hlinux/sched/types.hlinux/sed-opal.hlinux/smc.hlinux/smc_diag.hlinux/stm.hlinux/switchtec_ioctl.hlinux/vfio_ccw.hlinux/wil6210_uapi.hrdma/bnxt_re-abi.hNote that I have removed from this list the files which are generated in everyexported directories (like .install or .install.cmd).Thanks to Julien Floret for the tip to get allsubdirs with a pure makefile command.For the record, note that exported files for asm directories are a mix offiles listed by: - include/uapi/asm-generic/Kbuild.asm; - arch//include/uapi/asm/Kbuild; - arch//include/asm/Kbuild.Signed-off-by: Nicolas Dichtel Acked-by: Daniel Vetter Acked-by: Russell King Acked-by: Mark Salter Acked-by: Michael Ellerman (powerpc)Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.headersinst