Changes in Makefile.gcc-plugins

012e8d20 - gcc-plugins: Undefine LATENT_ENTROPY_PLUGIN when plugin disabled for a file

Tue, 16 Aug 2022 05:17:20 +0000

gcc-plugins: Undefine LATENT_ENTROPY_PLUGIN when plugin disabled for a fileCommit 36d4b36b6959 ("lib/nodemask: inline next_node_in() andnode_random()") refactored some code by moving node_random() fromlib/nodemask.c to include/linux/nodemask.h, thus requiring nodemask.h toinclude random.h, which conditionally defines add_latent_entropy()depending on whether the macro LATENT_ENTROPY_PLUGIN is defined.This broke the build on powerpc, where nodemask.h is indirectly includedin arch/powerpc/kernel/prom_init.c, part of the early boot machinery thatis excluded from the latent entropy plugin usingDISABLE_LATENT_ENTROPY_PLUGIN. It turns out that while we add a gcc flagto disable the actual plugin, we don't undefine LATENT_ENTROPY_PLUGIN.This leads to the following: CC arch/powerpc/kernel/prom_init.o In file included from ./include/linux/nodemask.h:97, from ./include/linux/mmzone.h:17, from ./include/linux/gfp.h:7, from ./include/linux/xarray.h:15, from ./include/linux/radix-tree.h:21, from ./include/linux/idr.h:15, from ./include/linux/kernfs.h:12, from ./include/linux/sysfs.h:16, from ./include/linux/kobject.h:20, from ./include/linux/pci.h:35, from arch/powerpc/kernel/prom_init.c:24: ./include/linux/random.h: In function 'add_latent_entropy': ./include/linux/random.h:25:46: error: 'latent_entropy' undeclared (first use in this function); did you mean 'add_latent_entropy'? 25 | add_device_randomness((const void *)&latent_entropy, sizeof(latent_entropy)); | ^~~~~~~~~~~~~~ | add_latent_entropy ./include/linux/random.h:25:46: note: each undeclared identifier is reported only once for each function it appears in make[2]: *** [scripts/Makefile.build:249: arch/powerpc/kernel/prom_init.o] Fehler 1 make[1]: *** [scripts/Makefile.build:465: arch/powerpc/kernel] Fehler 2 make: *** [Makefile:1855: arch/powerpc] Error 2Change the DISABLE_LATENT_ENTROPY_PLUGIN flags to undefineLATENT_ENTROPY_PLUGIN for files where the plugin is disabled.Cc: Yury Norov Fixes: 38addce8b600 ("gcc-plugins: Add latent_entropy plugin")Link: https://bugzilla.kernel.org/show_bug.cgi?id=216367Link: https://lore.kernel.org/linuxppc-dev/alpine.DEB.2.22.394.2208152006320.289321@ramsan.of.borg/Reported-by: Erhard Furtner Signed-off-by: Andrew Donnellan Reviewed-by: Yury Norov Signed-off-by: Kees Cook Link: https://lore.kernel.org/r/20220816051720.44108-1-ajd@linux.ibm.com List of files: /linux-6.15/scripts/Makefile.gcc-plugins

613f4b3e - randstruct: Split randstruct Makefile and CFLAGS

Tue, 03 May 2022 20:55:01 +0000

randstruct: Split randstruct Makefile and CFLAGSTo enable the new Clang randstruct implementation[1], moverandstruct into its own Makefile and split the CFLAGS fromGCC_PLUGINS_CFLAGS into RANDSTRUCT_CFLAGS.[1] https://reviews.llvm.org/D121556Cc: linux-hardening@vger.kernel.orgSigned-off-by: Kees Cook Link: https://lore.kernel.org/r/20220503205503.3054173-5-keescook@chromium.org List of files: /linux-6.15/scripts/Makefile.gcc-plugins

595b893e - randstruct: Reorganize Kconfigs and attribute macros

Tue, 03 May 2022 20:55:00 +0000

randstruct: Reorganize Kconfigs and attribute macrosIn preparation for Clang supporting randstruct, reorganize the Kconfigs,move the attribute macros, and generalize the feature to be namedCONFIG_RANDSTRUCT for on/off, CONFIG_RANDSTRUCT_FULL for the fullrandomization mode, and CONFIG_RANDSTRUCT_PERFORMANCE for the cache-linesized mode.Cc: linux-hardening@vger.kernel.orgSigned-off-by: Kees Cook Link: https://lore.kernel.org/r/20220503205503.3054173-4-keescook@chromium.org List of files: /linux-6.15/scripts/Makefile.gcc-plugins

d3646589 - sancov: Split plugin build from plugin CFLAGS

Tue, 03 May 2022 20:54:59 +0000

sancov: Split plugin build from plugin CFLAGSWhen the sancov_plugin is enabled, it gets added to gcc-plugin-y whichis used to populate both GCC_PLUGIN (for building the plugin) andGCC_PLUGINS_CFLAGS (for enabling and options). Instead of adding sancovto both and then removing it from GCC_PLUGINS_CFLAGS, create a separatelist, gcc-plugin-external-y, which is only added to GCC_PLUGIN.This will also be used by the coming randstruct build changes.Cc: Masahiro Yamada Cc: linux-kbuild@vger.kernel.orgCc: linux-hardening@vger.kernel.orgSigned-off-by: Kees Cook Link: https://lore.kernel.org/r/20220503205503.3054173-3-keescook@chromium.org List of files: /linux-6.15/scripts/Makefile.gcc-plugins

f154066b - gcc-plugins/stackleak: Provide verbose mode

Sun, 06 Feb 2022 17:20:08 +0000

gcc-plugins/stackleak: Provide verbose modeIn order to compare instrumentation between builds, make the verbosemode of the plugin available during the build. This is rarely needed(behind EXPERT) and very noisy (disabled for COMPILE_TEST).Cc: Alexander Popov Signed-off-by: Kees Cook List of files: /linux-6.15/scripts/Makefile.gcc-plugins

b4d89579 - gcc-plugins: Remove cyc_complexity

Wed, 20 Oct 2021 17:35:54 +0000

gcc-plugins: Remove cyc_complexityThis plugin has no impact on the resulting binary, is disabledunder COMPILE_TEST, and is not enabled on any builds I'm aware of.Additionally, given the clarified purpose of GCC plugins in the kernel,remove cyc_complexity.Cc: Masahiro Yamada Cc: Michal Marek Cc: Nick Desaulniers Cc: Jonathan Corbet Cc: linux-hardening@vger.kernel.orgCc: linux-kbuild@vger.kernel.orgCc: linux-doc@vger.kernel.orgSigned-off-by: Kees Cook Reviewed-by: Miguel Ojeda Reviewed-by: Nathan Chancellor Acked-by: Nick Desaulniers Acked-by: Ard Biesheuvel Link: https://lore.kernel.org/r/20211020173554.38122-3-keescook@chromium.org List of files: /linux-6.15/scripts/Makefile.gcc-plugins

554afc3b - gcc-plugins/structleak: add makefile var for disabling structleak

Wed, 29 Sep 2021 21:27:09 +0000

gcc-plugins/structleak: add makefile var for disabling structleakKUnit and structleak don't play nice, so add a makefile variable forenabling structleak when it complains.Co-developed-by: Kees Cook Signed-off-by: Kees Cook Signed-off-by: Brendan Higgins Reviewed-by: David Gow Signed-off-by: Shuah Khan List of files: /linux-6.15/scripts/Makefile.gcc-plugins

feee1b8c - gcc-plugins/stackleak: Use asm instrumentation to avoid useless register saving

Wed, 24 Jun 2020 12:33:29 +0000

gcc-plugins/stackleak: Use asm instrumentation to avoid useless register savingThe kernel code instrumentation in stackleak gcc plugin works in two stages.At first, stack tracking is added to GIMPLE representation of every function(except some special cases). And later, when stack frame size info isavailable, stack tracking is removed from the RTL representation of thefunctions with small stack frame. There is an unwanted side-effect for thesefunctions: some of them do useless work with caller-saved registers.As an example of such case, proc_sys_write without() instrumentation: 55 push %rbp 41 b8 01 00 00 00 mov $0x1,%r8d 48 89 e5 mov %rsp,%rbp e8 11 ff ff ff callq ffffffff81284610 5d pop %rbp c3 retq 0f 1f 44 00 00 nopl 0x0(%rax,%rax,1) 66 2e 0f 1f 84 00 00 nopw %cs:0x0(%rax,%rax,1) 00 00 00proc_sys_write() with instrumentation: 55 push %rbp 48 89 e5 mov %rsp,%rbp 41 56 push %r14 41 55 push %r13 41 54 push %r12 53 push %rbx 49 89 f4 mov %rsi,%r12 48 89 fb mov %rdi,%rbx 49 89 d5 mov %rdx,%r13 49 89 ce mov %rcx,%r14 4c 89 f1 mov %r14,%rcx 4c 89 ea mov %r13,%rdx 4c 89 e6 mov %r12,%rsi 48 89 df mov %rbx,%rdi 41 b8 01 00 00 00 mov $0x1,%r8d e8 f2 fe ff ff callq ffffffff81298e80 5b pop %rbx 41 5c pop %r12 41 5d pop %r13 41 5e pop %r14 5d pop %rbp c3 retq 66 0f 1f 84 00 00 00 nopw 0x0(%rax,%rax,1) 00 00Let's improve the instrumentation to avoid this:1. Make stackleak_track_stack() save all register that it works with.Use no_caller_saved_registers attribute for that function. This attributeis available for x86_64 and i386 starting from gcc-7.2. Insert calling stackleak_track_stack() in asm: asm volatile("call stackleak_track_stack" :: "r" (current_stack_pointer))Here we use ASM_CALL_CONSTRAINT trick from arch/x86/include/asm/asm.h.The input constraint is taken into account during gcc shrink-wrappingoptimization. It is needed to be sure that stackleak_track_stack() call isinserted after the prologue of the containing function, when the stackframe is prepared.This work is a deep reengineering of the idea described on grsecurity blog https://grsecurity.net/resolving_an_unfortunate_stackleak_interactionSigned-off-by: Alexander Popov Acked-by: Miguel Ojeda Link: https://lore.kernel.org/r/20200624123330.83226-5-alex.popov@linux.comSigned-off-by: Kees Cook List of files: /linux-6.15/scripts/Makefile.gcc-plugins

81a56f6d - gcc-plugins: structleak: Generalize to all variable types

Wed, 23 Jan 2019 23:19:29 +0000

gcc-plugins: structleak: Generalize to all variable typesThis adjusts structleak to also work with non-struct types when theyare passed by reference, since those variables may leak just likeanything else. This is exposed via an improved set of Kconfig options.(This does mean structleak is slightly misnamed now.)Building with CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL should give thekernel complete initialization coverage of all stack variables passedby reference, including padding (see lib/test_stackinit.c).Using CONFIG_GCC_PLUGIN_STRUCTLEAK_VERBOSE to count added initializationsunder defconfig: ..._BYREF: 5945 added initializations ..._BYREF_ALL: 16606 added initializationsThere is virtually no change to text+data size (both have less than 0.05%growth): text data bss dec hex filename19502103 5051456 1917000 26470559 193e89f vmlinux.stock19513412 5051456 1908808 26473676 193f4cc vmlinux.byref19516974 5047360 1900616 26464950 193d2b6 vmlinux.byref_allThe measured performance difference is in the noise for hackbench andkernel build benchmarks:Stock: 5x hackbench -g 20 -l 1000 Mean: 10.649s Std Dev: 0.339 5x kernel build (4-way parallel) Mean: 261.98s Std Dev: 1.53CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF: 5x hackbench -g 20 -l 1000 Mean: 10.540s Std Dev: 0.233 5x kernel build (4-way parallel) Mean: 260.52s Std Dev: 1.31CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL: 5x hackbench -g 20 -l 1000 Mean: 10.320 Std Dev: 0.413 5x kernel build (4-way parallel) Mean: 260.10 Std Dev: 0.86This does not yet solve missing padding initialization for structureson the stack that are never passed by reference (which should be a tinyminority). Hopefully this will be more easily addressed by upstreamcompiler fixes after clarifying the C11 padding initializationspecification.Signed-off-by: Kees Cook Reviewed-by: Ard Biesheuvel List of files: /linux-6.15/scripts/Makefile.gcc-plugins

189af465 - ARM: smp: add support for per-task stack canaries

Thu, 06 Dec 2018 08:32:57 +0000

ARM: smp: add support for per-task stack canariesOn ARM, we currently only change the value of the stack canary whenswitching tasks if the kernel was built for UP. On SMP kernels, thisis impossible since the stack canary value is obtained via a globalsymbol reference, which meansa) all running tasks on all CPUs must use the same valueb) we can only modify the value when no kernel stack frames are live on any CPU, which is effectively never.So instead, use a GCC plugin to add a RTL pass that replaces eachreference to the address of the __stack_chk_guard symbol with anexpression that produces the address of the 'stack_canary' fieldthat is added to struct thread_info. This way, each task will useits own randomized value.Cc: Russell King Cc: Kees Cook Cc: Emese Revfy Cc: Arnd Bergmann Cc: Laura Abbott Cc: kernel-hardening@lists.openwall.comAcked-by: Nicolas Pitre Signed-off-by: Ard Biesheuvel Signed-off-by: Kees Cook List of files: /linux-6.15/scripts/Makefile.gcc-plugins

ce2fd53a - kbuild: descend into scripts/gcc-plugins/ via scripts/Makefile

Thu, 29 Nov 2018 03:56:31 +0000

kbuild: descend into scripts/gcc-plugins/ via scripts/MakefileNow that 'archprepare' depends on 'scripts', Kbuild can descend intoscripts/gcc-plugins in a more standard way.Signed-off-by: Masahiro Yamada Reviewed-by: Kees Cook List of files: /linux-6.15/scripts/Makefile.gcc-plugins

10e9ae9f - gcc-plugins: Add STACKLEAK plugin for tracking the kernel stack

Thu, 16 Aug 2018 22:16:59 +0000

gcc-plugins: Add STACKLEAK plugin for tracking the kernel stackThe STACKLEAK feature erases the kernel stack before returning fromsyscalls. That reduces the information which kernel stack leak bugs canreveal and blocks some uninitialized stack variable attacks.This commit introduces the STACKLEAK gcc plugin. It is needed fortracking the lowest border of the kernel stack, which is importantfor the code erasing the used part of the kernel stack at the endof syscalls (comes in a separate commit).The STACKLEAK feature is ported from grsecurity/PaX. More information at: https://grsecurity.net/ https://pax.grsecurity.net/This code is modified from Brad Spengler/PaX Team's code in the lastpublic patch of grsecurity/PaX based on our understanding of the code.Changes or omissions from the original code are ours and don't reflectthe original grsecurity/PaX code.Signed-off-by: Alexander Popov Tested-by: Laura Abbott Signed-off-by: Kees Cook List of files: /linux-6.15/scripts/Makefile.gcc-plugins

7ccb95e8 - gcc-plugins: Regularize Makefile.gcc-plugins

Thu, 12 Jul 2018 00:38:52 +0000

gcc-plugins: Regularize Makefile.gcc-pluginsThe layout of Makefile.gcc-plugins had uneven tabs, and the long namesof things made this file a bit hard to quickly visually parse. Thisbreaks lines and moves options to the same tab depth. While we're atit, this also adds some comments about the various sections.Signed-off-by: Kees Cook List of files: /linux-6.15/scripts/Makefile.gcc-plugins

c17d6179 - gcc-plugins: remove unused GCC_PLUGIN_SUBDIR

Tue, 03 Jul 2018 00:39:12 +0000

gcc-plugins: remove unused GCC_PLUGIN_SUBDIRGCC_PLUGIN_SUBDIR has never been used. If you really need this inthe future, please re-add it then.For now, the code is unused. Remove.'export HOSTLIBS' is not necessary either.Signed-off-by: Masahiro Yamada Signed-off-by: Kees Cook List of files: /linux-6.15/scripts/Makefile.gcc-plugins

59f53855 - gcc-plugins: test plugin support in Kconfig and clean up Makefile

Mon, 28 May 2018 09:22:06 +0000

gcc-plugins: test plugin support in Kconfig and clean up MakefileRun scripts/gcc-plugin.sh from Kconfig so that users can enableGCC_PLUGINS only when the compiler supports building plugins.Kconfig defines a new symbol, PLUGIN_HOSTCC. This will containthe compiler (g++ or gcc) used for building plugins, or emptyif the plugin can not be supported at all.This allows us to remove all ugly testing in Makefile.gcc-plugins.Signed-off-by: Masahiro Yamada Acked-by: Kees Cook List of files: /linux-6.15/scripts/Makefile.gcc-plugins

8034c2fb - gcc-plugins: move GCC version check for PowerPC to Kconfig

Mon, 28 May 2018 09:22:05 +0000

gcc-plugins: move GCC version check for PowerPC to KconfigFor PowerPC, GCC 5.2 is the requirement for GCC plugins. Move theversion check to Kconfig so that the GCC plugin menus will be hiddenif an older compiler is in use.Signed-off-by: Masahiro Yamada Acked-by: Andrew Donnellan Reviewed-by: Kees Cook List of files: /linux-6.15/scripts/Makefile.gcc-plugins

5aadfdeb - kcov: test compiler capability in Kconfig and correct dependency

Mon, 28 May 2018 09:22:04 +0000

kcov: test compiler capability in Kconfig and correct dependencyAs Documentation/kbuild/kconfig-language.txt notes, 'select' should bebe used with care - it forces a lower limit of another symbol, ignoringthe dependency. Currently, KCOV can select GCC_PLUGINS even if archdoes not select HAVE_GCC_PLUGINS. This could cause the unmet directdependency.Now that Kconfig can test compiler capability, let's handle this in amore sophisticated way.There are two ways to enable KCOV; use the compiler that nativelysupports -fsanitize-coverage=trace-pc, or build the SANCOV plugin ifthe compiler has ability to build GCC plugins. Hence, the correctdependency for KCOV is: depends on CC_HAS_SANCOV_TRACE_PC || GCC_PLUGINSYou do not need to build the SANCOV plugin if the compiler alreadysupports -fsanitize-coverage=trace-pc. Hence, the select should be: select GCC_PLUGIN_SANCOV if !CC_HAS_SANCOV_TRACE_PCWith this, GCC_PLUGIN_SANCOV is selected only when necessary, soscripts/Makefile.gcc-plugins can be cleaner.I also cleaned up Kconfig and scripts/Makefile.kcov as well.Signed-off-by: Masahiro Yamada Reviewed-by: Kees Cook List of files: /linux-6.15/scripts/Makefile.gcc-plugins

642ef99b - gcc-plugins: fix build condition of SANCOV plugin

Fri, 13 Apr 2018 05:06:10 +0000

gcc-plugins: fix build condition of SANCOV pluginSince commit d677a4d60193 ("Makefile: support flag-fsanitizer-coverage=trace-cmp"), you miss to build the SANCOVplugin under some circumstances. CONFIG_KCOV=y CONFIG_KCOV_ENABLE_COMPARISONS=y Your compiler does not support -fsanitize-coverage=trace-pc Your compiler does not support -fsanitize-coverage=trace-cmpUnder this condition, $(CFLAGS_KCOV) is not empty but contains aspace, so the following ifeq-conditional is false. ifeq ($(CFLAGS_KCOV),)Then, scripts/Makefile.gcc-plugins misses to add sancov_plugin.so togcc-plugin-y while the SANCOV plugin is necessary as an alternativemeans.Fixes: d677a4d60193 ("Makefile: support flag -fsanitizer-coverage=trace-cmp")Signed-off-by: Masahiro Yamada Acked-by: Kees Cook List of files: /linux-6.15/scripts/Makefile.gcc-plugins

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/scripts/Makefile.gcc-plugins

f7dd2507 - gcc-plugins: structleak: add option to init all vars used as byref args

Sun, 06 Aug 2017 11:06:27 +0000

gcc-plugins: structleak: add option to init all vars used as byref argsIn the Linux kernel, struct type variables are rarely passed by-value,and so functions that initialize such variables typically take an inputreference to the variable rather than returning a value that cansubsequently be used in an assignment.If the initalization function is not part of the same compilation unit,the lack of an assignment operation defeats any analysis the compilercan perform as to whether the variable may be used before having beeninitialized. This means we may end up passing on such variablesuninitialized, resulting in potential information leaks.So extend the existing structleak GCC plugin so it will [optionally]apply to all struct type variables that have their address taken at anypoint, rather than only to variables of struct types that have a __userannotation.Signed-off-by: Ard Biesheuvel Signed-off-by: Kees Cook List of files: /linux-6.15/scripts/Makefile.gcc-plugins