Changes in Makefile.dtbinst

9cc5f3bf - kbuild: Install dtb files as 0644 in Makefile.dtbinst

Mon, 10 Jun 2024 05:21:12 +0000

kbuild: Install dtb files as 0644 in Makefile.dtbinstThe compiled dtb files aren't executable, so install them with 0644 as theirpermission mode, instead of defaulting to 0755 for the permission mode andinstalling them with the executable bits set.Some Linux distributions, including Debian, [1][2][3] already include fixesin their kernel package build recipes to change the dtb file permissions to0644 in their kernel packages. These changes, when additionally propagatedinto the long-term kernel versions, will allow such distributions to removetheir downstream fixes.[1] https://salsa.debian.org/kernel-team/linux/-/merge_requests/642[2] https://salsa.debian.org/kernel-team/linux/-/merge_requests/749[3] https://salsa.debian.org/kernel-team/linux/-/blob/debian/6.8.12-1/debian/rules.real#L193Cc: Diederik de Haas Cc: Fixes: aefd80307a05 ("kbuild: refactor Makefile.dtbinst more")Signed-off-by: Dragan Simic Reviewed-by: Nicolas Schier Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.dtbinst

8f66864c - kbuild: simplify dtbs_install by reading the list of compiled DTBs

Tue, 09 Jan 2024 12:07:35 +0000

kbuild: simplify dtbs_install by reading the list of compiled DTBsRetrieve the list of *.dtb(o) files from arch/*/boot/dts/dtbs-listinstead of traversing the directory tree again.Please note that 'make dtbs_install' installs *.dtb(o) files directlyadded to dtb-y because scripts/Makefile.dtbinst installs $(dtb-y)without expanding the -dtbs suffix.This commit preserves this behavior.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.dtbinst

6a1d798f - kbuild: Support flat DTBs install

Thu, 06 Dec 2018 16:29:51 +0000

kbuild: Support flat DTBs installIn preparation to move Arm .dts files into sub-directories groupedby vendor/family, the current flat tree of DTBs generated bydtbs_install needs to be maintained. Moving the installed DTBs tosub-directories would break various consumers using 'make dtbs_install'.This is a NOP until sub-directories are introduced.Signed-off-by: Rob Herring List of files: /linux-6.15/scripts/Makefile.dtbinst

a2430b25 - kbuild: add kbuild-file macro

Fri, 18 Nov 2022 19:15:50 +0000

kbuild: add kbuild-file macroWhile building, installing, cleaning, Kbuild visits sub-directoriesand includes 'Kbuild' or 'Makefile' that exists there.Add 'kbuild-file' macro, and reuse it from scripts/Makefie.*Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier Reviewed-by: Alexander Lobakin Tested-by: Alexander Lobakin List of files: /linux-6.15/scripts/Makefile.dtbinst

3204a7fb - kbuild: prefix $(srctree)/ to some included Makefiles

Sun, 28 Feb 2021 06:10:26 +0000

kbuild: prefix $(srctree)/ to some included MakefilesVPATH is used in Kbuild to make pattern rules search for prerequisitesin both $(objtree) and $(srctree). Some of *.c, *.S files are not realsources, but generated by tools such as flex, bison, perl.In contrast, I doubt the benefit of --include-dir=$(abs_srctree) becauseit is always clear which Makefiles are real sources, and which are not.So, my hope is to add $(srctree)/ prefix to all check-in Makefiles,then remove --include-dir=$(abs_srctree) flag in the future.I am touching only some Kbuild core parts for now. Treewide fixes willbe needed to achieve this goal.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.dtbinst

ce88c9c7 - kbuild: Add support to build overlays (%.dtbo)

Fri, 29 Jan 2021 07:24:08 +0000

kbuild: Add support to build overlays (%.dtbo)Add support for building DT overlays (%.dtbo). The overlay's source filewill have the usual extension, i.e. .dts, though the blob will have.dtbo extension to distinguish it from normal blobs.Acked-by: Masahiro Yamada Signed-off-by: Viresh Kumar Signed-off-by: Rob Herring Link: https://lore.kernel.org/r/434ba2467dd0cd011565625aeb3450650afe0aae.1611904394.git.viresh.kumar@linaro.org List of files: /linux-6.15/scripts/Makefile.dtbinst

aefd8030 - kbuild: refactor Makefile.dtbinst more

Fri, 06 Mar 2020 17:08:52 +0000

kbuild: refactor Makefile.dtbinst moreRefactor Makefile.dtbinst so it looks similar to other Makefiles.*.dtb should not be a phony target. Copy files based on the timestamps.Print installed dtb paths instead of in-kernel dtb paths.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.dtbinst

2431f22a - kbuild: compute the dtbs_install destination more simply

Fri, 06 Mar 2020 17:08:51 +0000

kbuild: compute the dtbs_install destination more simplyThe 'dtbinst_root' is used to remember the root of the in-kernel dtsdirectory (i.e. arch/*/boot/dts), but it looks clumsy.I prefer using two variables 'obj' and 'dst' to track the in-kerneldirectory and the install destination, respectively.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.dtbinst

7e7962dd - kbuild: handle dtb-y and CONFIG_OF_ALL_DTBS natively in Makefile.lib

Sun, 05 Nov 2017 05:30:53 +0000

kbuild: handle dtb-y and CONFIG_OF_ALL_DTBS natively in Makefile.libIf CONFIG_OF_ALL_DTBS is enabled, "make ARCH=arm64 dtbs" compiles eachDTB twice; one from arch/arm64/boot/dts/*/Makefile and the other fromthe dtb-$(CONFIG_OF_ALL_DTBS) line in arch/arm64/boot/dts/Makefile.It could be a race problem when building DTBS in parallel.Another minor issue is CONFIG_OF_ALL_DTBS covers only *.dts in vendorsub-directories, so this broke when Broadcom added one more hierarchyin arch/arm64/boot/dts/broadcom//.One idea to fix the issues in a clean way is to move DTB handlingto Kbuild core scripts. Makefile.dtbinst already recognizes dtb-ynatively, so it should not hurt to do so.Add $(dtb-y) to extra-y, and $(dtb-) as well if CONFIG_OF_ALL_DTBS isenabled. All clutter things in Makefiles go away.As a bonus clean-up, I also removed dts-dirs. Just use subdir-ydirectly to traverse sub-directories.Signed-off-by: Masahiro Yamada Acked-by: Arnd Bergmann [robh: corrected BUILTIN_DTB to CONFIG_BUILTIN_DTB]Signed-off-by: Rob Herring List of files: /linux-6.15/scripts/Makefile.dtbinst

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/scripts/Makefile.dtbinst

2bfbe788 - kbuild: Do not use hyphen in exported variable name

Sat, 19 Aug 2017 21:30:02 +0000

kbuild: Do not use hyphen in exported variable nameThis definition in Makefile.dtbinst: export dtbinst-root ?= $(obj)should define and export dtbinst-root when handling the root dtsdirectory, and do nothing in the subdirectories. However some shells,including dash, will not pass through environment variables whose nameincludes a hyphen. Usually GNU make does not use a shell to recurse,but if e.g. $(srctree) contains '~' it will use a shell here.Rename the variable to dtbinst_root.References: https://bugs.debian.org/833561Fixes: 323a028d39cdi ("dts, kbuild: Implement support for dtb vendor subdirs")Signed-off-by: Ben Hutchings Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.dtbinst

f55813b4 - kbuild: dtbinst: remove unnecessary __dtbs_install_prep target

Thu, 04 May 2017 01:14:57 +0000

kbuild: dtbinst: remove unnecessary __dtbs_install_prep targetSince commit 5399eb9b3908 ("dtbsinstall: don't move target directoryout of the way"), the target __dtbs_install_prep is invoked just forcreating the install directory, but all the necessary directoriesare automatically created by: cmd_dtb_install = mkdir -p $(2); cp $< $(2)Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/Makefile.dtbinst

5399eb9b - dtbsinstall: don't move target directory out of the way

Tue, 20 Oct 2015 13:01:32 +0000

dtbsinstall: don't move target directory out of the wayNo other kernel installation target moves the target directory out ofthe way, even deleting an old version of it. These are destructiveoperations, ones which the kernel build system should not be making.This behaviour prevents being able to do: make install INSTALL_PATH=/some/path/boot make dtbs_install INSTALL_DTBS_PATH=/some/path/bootAs it causes the boot directory containing the kernel installed instep 1 to be moved to /some/path/boot.old. Things get even more funif you do: make install dtbs_install INSTALL_PATH=/some/path/boot INSTALL_DTBS_PATH=/some/path/bootThe kernel gets installed into /some/path/boot, then the directory getsrenamed to /some/path/boot.old, and a new directory created to hold thedtbs. Even more fun if you supply -j2 when we end up with races inmake.Remove this behaviour.If this behaviour is required at installation time, this should bedone by the installation external to the kernel makefiles, just likeit would be done for 'make modules_install'.Signed-off-by: Russell King Acked-by: Jason Cooper Acked-by: Rob Herring Signed-off-by: Michal Marek List of files: /linux-6.15/scripts/Makefile.dtbinst

5f655c7a - kbuild: include $(src)/Makefile rather than $(obj)/Makefile

Fri, 27 Mar 2015 11:43:37 +0000

kbuild: include $(src)/Makefile rather than $(obj)/MakefileThis commit actually has no impact because $(src) and $(obj) pointto the same path, but $(src)/Makefile looks better when we includesource files.Signed-off-by: Masahiro Yamada Signed-off-by: Michal Marek List of files: /linux-6.15/scripts/Makefile.dtbinst

7aacad53 - kbuild: use relative path to include Makefile

Fri, 27 Mar 2015 11:43:35 +0000

kbuild: use relative path to include MakefileThe "MAKEFLAGS += --include-dir=$(srctree)" line in the top Makefileallows us to do this.Signed-off-by: Masahiro Yamada Signed-off-by: Michal Marek List of files: /linux-6.15/scripts/Makefile.dtbinst

323a028d - dts, kbuild: Implement support for dtb vendor subdirs

Wed, 03 Sep 2014 14:17:02 +0000

dts, kbuild: Implement support for dtb vendor subdirsThis patch adds support of vendor sub directories for dtb files.Subdirectories can be specified in $(dts-dirs). Kbuild traverses overall directories while building and installing dtb files. The directorytree is also reflected in the install path.Tested-by: Andrew Bresticker Signed-off-by: Robert Richter List of files: /linux-6.15/scripts/Makefile.dtbinst

9fb5e537 - dts, kbuild: Factor out dtbs install rules to Makefile.dtbinst

Wed, 03 Sep 2014 13:29:24 +0000

dts, kbuild: Factor out dtbs install rules to Makefile.dtbinstMove dtbs install rules to Makefile.dtbinst. This change is needed toimplement support for dts vendor subdirs. The change makes Makefileseasier and smaller as no longer the dtbs_install rule needs to bedefined. Another advantage is that install goals are not encoded intargets anymore (%.dtb_dtbinst_).Signed-off-by: Robert Richter List of files: /linux-6.15/scripts/Makefile.dtbinst