en Copyright 2015 Java http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#f73ca66f rust: lockdep: Use Pin for all LockClassKey usagesReintroduce dynamically-allocated LockClassKeys such that they areautomatically (de)registered. Require that all usages of LockClassKeysensure that they are Pin'd.Currently, only `'static` LockClassKeys are supported, so Pin isredundant. However, it is intended that dynamically-allocatedLockClassKeys will eventually be supported, so using Pin from the outsetwill make that change simpler.Closes: https://github.com/Rust-for-Linux/linux/issues/1102Suggested-by: Benno Lossin <benno.lossin@proton.me>Suggested-by: Boqun Feng <boqun.feng@gmail.com>Signed-off-by: Mitchell Levy <levymitchell0@gmail.com>Signed-off-by: Boqun Feng <boqun.feng@gmail.com>Signed-off-by: Ingo Molnar <mingo@kernel.org>Reviewed-by: Benno Lossin <benno.lossin@proton.me>Link: https://lore.kernel.org/r/20250307232717.1759087-12-boqun.feng@gmail.com List of files: /linux-6.15/rust/kernel/workqueue.rs Fri, 07 Mar 2025 23:00:00 +0000 Mitchell Levy <levymitchell0@gmail.com> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#374b60a0 rust: hrtimer: implement `HrTimerPointer` for `Pin<Box<T>>`Allow `Pin<Box<T>>` to be the target of a timer callback.Acked-by: Frederic Weisbecker <frederic@kernel.org>Acked-by: Thomas Gleixner <tglx@linutronix.de>Reviewed-by: Lyude Paul <lyude@redhat.com>Reviewed-by: Benno Lossin <benno.lossin@proton.me>Link: https://lore.kernel.org/r/20250309-hrtimer-v3-v6-12-rc2-v12-10-73586e2bd5f1@kernel.orgSigned-off-by: Andreas Hindborg <a.hindborg@kernel.org> List of files: /linux-6.15/rust/kernel/time/hrtimer/tbox.rs Sun, 09 Mar 2025 15:00:00 +0000 Andreas Hindborg <a.hindborg@kernel.org> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#042b0c79 rust: hrtimer: implement `UnsafeHrTimerPointer` for `Pin<&mut T>`Allow pinned mutable references to structs that contain a `HrTimer` node tobe scheduled with the `hrtimer` subsystem.Acked-by: Frederic Weisbecker <frederic@kernel.org>Acked-by: Thomas Gleixner <tglx@linutronix.de>Reviewed-by: Lyude Paul <lyude@redhat.com>Reviewed-by: Benno Lossin <benno.lossin@proton.me>Link: https://lore.kernel.org/r/20250309-hrtimer-v3-v6-12-rc2-v12-8-73586e2bd5f1@kernel.orgSigned-off-by: Andreas Hindborg <a.hindborg@kernel.org> List of files: /linux-6.15/rust/kernel/time/hrtimer/pin_mut.rs Sun, 09 Mar 2025 15:00:00 +0000 Andreas Hindborg <a.hindborg@kernel.org> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#94e05a66 rust: hrtimer: allow timer restart from timer handlerAllow timer handlers to report that they want a timer to be restarted afterthe timer handler has finished executing.Acked-by: Frederic Weisbecker <frederic@kernel.org>Acked-by: Thomas Gleixner <tglx@linutronix.de>Reviewed-by: Benno Lossin <benno.lossin@proton.me>Reviewed-by: Tamir Duberstein <tamird@gmail.com>Reviewed-by: Lyude Paul <lyude@redhat.com>Link: https://lore.kernel.org/r/20250309-hrtimer-v3-v6-12-rc2-v12-4-73586e2bd5f1@kernel.orgSigned-off-by: Andreas Hindborg <a.hindborg@kernel.org> List of files: /linux-6.15/rust/kernel/time/hrtimer/arc.rs Sun, 09 Mar 2025 15:00:00 +0000 Andreas Hindborg <a.hindborg@kernel.org> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#aa33de03 rust: hrtimer: add clocksource selection through `ClockId`Allow selecting a clock source for timers by passing a `ClockId`variant to `HrTimer::new`.Acked-by: Frederic Weisbecker <frederic@kernel.org>Acked-by: Thomas Gleixner <tglx@linutronix.de>Reviewed-by: Lyude Paul <lyude@redhat.com>Reviewed-by: Benno Lossin <benno.lossin@proton.me>Link: https://lore.kernel.org/r/20250309-hrtimer-v3-v6-12-rc2-v12-12-73586e2bd5f1@kernel.orgSigned-off-by: Andreas Hindborg <a.hindborg@kernel.org> List of files: /linux-6.15/rust/kernel/time.rs/linux-6.15/rust/kernel/time/hrtimer.rs Sun, 09 Mar 2025 15:00:00 +0000 Andreas Hindborg <a.hindborg@kernel.org> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#582523d9 rust: hrtimer: implement `UnsafeHrTimerPointer` for `Pin<&T>`Allow pinned references to structs that contain a `HrTimer` node to bescheduled with the `hrtimer` subsystem.Acked-by: Frederic Weisbecker <frederic@kernel.org>Acked-by: Thomas Gleixner <tglx@linutronix.de>Reviewed-by: Lyude Paul <lyude@redhat.com>Reviewed-by: Benno Lossin <benno.lossin@proton.me>Link: https://lore.kernel.org/r/20250309-hrtimer-v3-v6-12-rc2-v12-7-73586e2bd5f1@kernel.orgSigned-off-by: Andreas Hindborg <a.hindborg@kernel.org> List of files: /linux-6.15/rust/kernel/time/hrtimer/pin.rs Sun, 09 Mar 2025 15:00:00 +0000 Andreas Hindborg <a.hindborg@kernel.org> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#dbd5058b rust: make pin-init its own crateRename relative paths inside of the crate to still refer to the sameitems, also rename paths inside of the kernel crate and adjust the buildsystem to build the crate.[ Remove the `expect` (and thus the `lint_reasons` feature) since the tree now uses `quote!` from `rust/macros/export.rs`. Remove the `TokenStream` import removal, since it is now used as well. In addition, temporarily (i.e. just for this commit) use an `--extern force:alloc` to prevent an unknown `new_uninit` error in the `rustdoc` target. For context, please see a similar case in: https://lore.kernel.org/lkml/20240422090644.525520-1-ojeda@kernel.org/ And adjusted the message above. - Miguel ]Signed-off-by: Benno Lossin <benno.lossin@proton.me>Reviewed-by: Fiona Behrens <me@kloenk.dev>Tested-by: Andreas Hindborg <a.hindborg@kernel.org>Link: https://lore.kernel.org/r/20250308110339.2997091-16-benno.lossin@proton.meSigned-off-by: Miguel Ojeda <ojeda@kernel.org> List of files: /linux-6.15/rust/kernel/prelude.rs/linux-6.15/rust/kernel/sync/arc.rs/linux-6.15/rust/kernel/types.rs Sat, 08 Mar 2025 11:00:00 +0000 Benno Lossin <benno.lossin@proton.me> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#4e72a62e rust: uaccess: name the correct functionCorrectly refer to `reserve` rather than `try_reserve` in a comment. Thiscomment has been incorrect since inception in commit 1b580e7b9ba2 ("rust:uaccess: add userspace pointers").Fixes: 1b580e7b9ba2 ("rust: uaccess: add userspace pointers")Signed-off-by: Tamir Duberstein <tamird@gmail.com>Reviewed-by: Alice Ryhl <aliceryhl@google.com>Reviewed-by: Benno Lossin <benno.lossin@proton.me>Reviewed-by: Charalampos Mitrodimas <charmitro@posteo.net>Link: https://lore.kernel.org/r/20250317-uaccess-typo-reserve-v1-1-bbfcb45121f3@gmail.comSigned-off-by: Miguel Ojeda <ojeda@kernel.org> List of files: /linux-6.15/rust/kernel/uaccess.rs Mon, 17 Mar 2025 11:00:00 +0000 Tamir Duberstein <tamird@gmail.com> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#6fbafe1c rust: task: fix `SAFETY` comment in `Task::wake_up`The `SAFETY` comment inside the `wake_up` method referenceserroneously the `signal_pending` C function instead of the`wake_up_process` which is actually called.Fix the comment to reference the correct C function.Fixes: fe95f58320e6 ("rust: task: adjust safety comments in Task methods")Signed-off-by: Panagiotis Foliadis <pfoliadis@posteo.net>Reviewed-by: Charalampos Mitrodimas <charmitro@posteo.net>Reviewed-by: Alice Ryhl <aliceryhl@google.com>Link: https://lore.kernel.org/r/20250308-comment-fix-v1-1-4bba709fd36d@posteo.net[ Slightly reworded. - Miguel ]Signed-off-by: Miguel Ojeda <ojeda@kernel.org> List of files: /linux-6.15/rust/kernel/task.rs Sat, 08 Mar 2025 16:00:00 +0000 Panagiotis Foliadis <pfoliadis@posteo.net> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#51158207 rust: add rcu abstractionAdd a simple abstraction to guard critical code sections with an rcuread lock.Reviewed-by: Boqun Feng <boqun.feng@gmail.com>Signed-off-by: Wedson Almeida Filho <wedsonaf@gmail.com>Co-developed-by: Danilo Krummrich <dakr@kernel.org>Signed-off-by: Danilo Krummrich <dakr@kernel.org>Tested-by: Dirk Behme <dirk.behme@de.bosch.com>Tested-by: Fabien Parent <fabien.parent@linaro.org>Link: https://lore.kernel.org/r/20241219170425.12036-5-dakr@kernel.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> List of files: /linux-6.15/rust/kernel/sync/rcu.rs Thu, 19 Dec 2024 17:00:00 +0000 Wedson Almeida Filho <wedsonaf@gmail.com> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#0494d9c8 rust: add `Revocable` typeRevocable allows access to objects to be safely revoked at run time.This is useful, for example, for resources allocated during device probe;when the device is removed, the driver should stop accessing the deviceresources even if another state is kept in memory due to existingreferences (i.e., device context data is ref-counted and has a non-zerorefcount after removal of the device).Signed-off-by: Wedson Almeida Filho <wedsonaf@gmail.com>Co-developed-by: Danilo Krummrich <dakr@kernel.org>Signed-off-by: Danilo Krummrich <dakr@kernel.org>Tested-by: Dirk Behme <dirk.behme@de.bosch.com>Link: https://lore.kernel.org/r/20241219170425.12036-7-dakr@kernel.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> List of files: /linux-6.15/rust/kernel/revocable.rs Thu, 19 Dec 2024 17:00:00 +0000 Wedson Almeida Filho <wedsonaf@gmail.com> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#3566362d rust: std_vendor: update dbg macro from Rust upstream`dbg!` contains adapted code from Rust upstream. Compare the kernelcode with the Rust upstream one and update missing column numbers in`dbg!` outputs.Column numbers are not copied but adjusted for the kernel's examples.Suggested-by: Miguel Ojeda <ojeda@kernel.org>Link: https://github.com/Rust-for-Linux/linux/issues/1124Signed-off-by: Deepak Thukral <iapain@gmail.com>Link: https://lore.kernel.org/r/20241004125616.49886-1-iapain@gmail.com[ Fixed typo and slightly reworded. - Miguel ]Signed-off-by: Miguel Ojeda <ojeda@kernel.org> List of files: /linux-6.15/rust/kernel/std_vendor.rs Fri, 04 Oct 2024 12:00:00 +0000 Deepak Thukral <iapain@gmail.com> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#211dcf77 rust: clean Rust 1.88.0's `clippy::uninlined_format_args` lintStarting with Rust 1.88.0 (expected 2025-06-26) [1], `rustc` may moveback the `uninlined_format_args` to `style` from `pedantic` (it wasthere waiting for rust-analyzer suppotr), and thus we will start to seelints like: warning: variables can be used directly in the `format!` string --> rust/macros/kunit.rs:105:37 | 105 | let kunit_wrapper_fn_name = format!("kunit_rust_wrapper_{}", test); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 105 - let kunit_wrapper_fn_name = format!("kunit_rust_wrapper_{}", test); 105 + let kunit_wrapper_fn_name = format!("kunit_rust_wrapper_{test}");There is even a case that is a pure removal: warning: variables can be used directly in the `format!` string --> rust/macros/module.rs:51:13 | 51 | format!("{field}={content}\0", field = field, content = content) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 51 - format!("{field}={content}\0", field = field, content = content) 51 + format!("{field}={content}\0")The lints all seem like nice cleanups, thus just apply them.We may want to disable `allow-mixed-uninlined-format-args` in the future.Cc: stable@vger.kernel.org # Needed in 6.12.y and later (Rust is pinned in older LTSs).Link: https://github.com/rust-lang/rust-clippy/pull/14160 [1]Acked-by: Benno Lossin <lossin@kernel.org>Reviewed-by: Tamir Duberstein <tamird@gmail.com>Reviewed-by: Alice Ryhl <aliceryhl@google.com>Link: https://lore.kernel.org/r/20250502140237.1659624-6-ojeda@kernel.orgSigned-off-by: Miguel Ojeda <ojeda@kernel.org> List of files: /linux-6.15/rust/kernel/str.rs Fri, 02 May 2025 14:00:00 +0000 Miguel Ojeda <ojeda@kernel.org> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#ef9e3797 rust: static_assert: add `static_assert!` macroAdd the `static_assert!` macro, which is a compile-time assert, similarto the C11 `_Static_assert` and C++11 `static_assert` declarations [1,2].Do so in a new module, called `static_assert`.For instance: static_assert!(42 > 24); static_assert!(core::mem::size_of::<u8>() == 1); const X: &[u8] = b"bar"; static_assert!(X[1] == b'a'); const fn f(x: i32) -> i32 { x + 2 } static_assert!(f(40) == 42);Link: https://en.cppreference.com/w/c/language/_Static_assert [1]Link: https://en.cppreference.com/w/cpp/language/static_assert [2]Co-developed-by: Alex Gaynor <alex.gaynor@gmail.com>Signed-off-by: Alex Gaynor <alex.gaynor@gmail.com>Signed-off-by: Miguel Ojeda <ojeda@kernel.org> List of files: /linux-6.15/rust/kernel/static_assert.rs Thu, 10 Nov 2022 16:00:00 +0000 Miguel Ojeda <ojeda@kernel.org> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#935e1d90 rust: pci: require Send for Driver trait implementersThe instance of Self, returned and created by Driver::probe() isdropped in the bus' remove() callback.Request implementers of the Driver trait to implement Send, since theremove() callback is not guaranteed to run from the same thread asprobe().Fixes: 1bd8b6b2c5d3 ("rust: pci: add basic PCI device / driver abstractions")Cc: stable <stable@kernel.org>Reported-by: Alice Ryhl <aliceryhl@google.com>Closes: https://lore.kernel.org/lkml/Z9rDxOJ2V2bPjj5i@google.com/Signed-off-by: Danilo Krummrich <dakr@kernel.org>Reviewed-by: Benno Lossin <benno.lossin@proton.me>Link: https://lore.kernel.org/r/20250319145350.69543-1-dakr@kernel.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> List of files: /linux-6.15/rust/kernel/pci.rs Wed, 19 Mar 2025 14:00:00 +0000 Danilo Krummrich <dakr@kernel.org> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#51d0de75 rust: platform: require Send for Driver trait implementersThe instance of Self, returned and created by Driver::probe() isdropped in the bus' remove() callback.Request implementers of the Driver trait to implement Send, since theremove() callback is not guaranteed to run from the same thread asprobe().Fixes: 683a63befc73 ("rust: platform: add basic platform device / driver abstractions")Cc: stable <stable@kernel.org>Reported-by: Alice Ryhl <aliceryhl@google.com>Closes: https://lore.kernel.org/lkml/Z9rDxOJ2V2bPjj5i@google.com/Signed-off-by: Danilo Krummrich <dakr@kernel.org>Reviewed-by: Benno Lossin <benno.lossin@proton.me>Link: https://lore.kernel.org/r/20250319145350.69543-2-dakr@kernel.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> List of files: /linux-6.15/rust/kernel/platform.rs Wed, 19 Mar 2025 14:00:00 +0000 Danilo Krummrich <dakr@kernel.org> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#92d2873b print: use new #[export] macro for rust_fmt_argumentThis moves the rust_fmt_argument function over to use the new #[export]macro, which will verify at compile-time that the function signaturematches what is in the header file.Reviewed-by: Andreas Hindborg <a.hindborg@kernel.org>Reviewed-by: Tamir Duberstein <tamird@gmail.com>Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>Signed-off-by: Alice Ryhl <aliceryhl@google.com>Acked-by: Petr Mladek <pmladek@suse.com>Link: https://lore.kernel.org/r/20250303-export-macro-v3-4-41fbad85a27f@google.com[ Removed period as requested by Andy. - Miguel ]Signed-off-by: Miguel Ojeda <ojeda@kernel.org> List of files: /linux-6.15/rust/kernel/print.rs Mon, 03 Mar 2025 08:00:00 +0000 Alice Ryhl <aliceryhl@google.com> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#f6be7af4 rust: rbtree: fix comments referring to Box instead of KBoxSeveral safety comments in the RBTree implementation still refer to"Box::from_raw" and "Box::into_raw", but the code actually uses KBox.These comments were not updated when the implementation transitionedfrom using Box to KBox.Fixes: 8373147ce496 ("rust: treewide: switch to our kernel `Box` type")Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net>Reviewed-by: Benno Lossin <benno.lossin@proton.me>Reviewed-by: Alice Ryhl <aliceryhl@google.com>Link: https://lore.kernel.org/r/20250315-rbtree-comment-fixes-v1-1-51f72c420ff0@posteo.netSigned-off-by: Miguel Ojeda <ojeda@kernel.org> List of files: /linux-6.15/rust/kernel/rbtree.rs Sat, 15 Mar 2025 21:00:00 +0000 Charalampos Mitrodimas <charmitro@posteo.net> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#74fc3493 rust: miscdevice: change how f_ops vtable is constructedI was helping someone with writing a new Rust abstraction, and we wereusing the miscdevice abstraction as an example. While doing this, itbecame clear to me that the way I implemented the f_ops vtable isconfusing to new Rust users, and that the approach used by the blockabstractions is less confusing.Thus, update the miscdevice abstractions to use the same approach asrust/kernel/block/mq/operations.rs.Sorry about the large diff. This changes the indentation of a largeamount of code.Reviewed-by: Christian Schrefl <chrisi.schrefl@gmail.com>Signed-off-by: Alice Ryhl <aliceryhl@google.com>Link: https://lore.kernel.org/r/20250227-miscdevice-fops-change-v1-1-c9e9b75d67eb@google.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> List of files: /linux-6.15/rust/kernel/miscdevice.rs Thu, 27 Feb 2025 13:00:00 +0000 Alice Ryhl <aliceryhl@google.com> http://172.16.0.5:8080/history/linux-6.15/rust/kernel/#47cb6bf7 rust: use derive(CoercePointee) on rustc >= 1.84.0The `kernel` crate relies on both `coerce_unsized` and `dispatch_from_dyn`unstable features.Alice Ryhl has proposed [1] the introduction of the unstable macro`SmartPointer` to reduce such dependence, along with a RFC patch [2].Since Rust 1.81.0 this macro, later renamed to `CoercePointee` inRust 1.84.0 [3], has been fully implemented with the naming discussionresolved.This feature is now on track to stabilization in the language.In order to do so, we shall start using this macro in the `kernel` crateto prove the functionality and utility of the macro as the justificationof its stabilization.This patch makes this switch in such a way that the crate remainsbackward compatible with older Rust compiler versions,via the new Kconfig option `RUSTC_HAS_COERCE_POINTEE`.A minimal demonstration example is added to the`samples/rust/rust_print_main.rs` module.Link: https://rust-lang.github.io/rfcs/3621-derive-smart-pointer.html [1]Link: https://lore.kernel.org/all/20240823-derive-smart-pointer-v1-1-53769cd37239@google.com/ [2]Link: https://github.com/rust-lang/rust/pull/131284 [3]Signed-off-by: Xiangfei Ding <dingxiangfei2009@gmail.com>Reviewed-by: Fiona Behrens <me@kloenk.dev>Reviewed-by: Alice Ryhl <aliceryhl@google.com>Link: https://lore.kernel.org/r/20241203205050.679106-2-dingxiangfei2009@gmail.com[ Fixed version to 1.84. Renamed option to `RUSTC_HAS_COERCE_POINTEE` to match `CC_HAS_*` ones. Moved up new config option, closer to the `CC_HAS_*` ones. Simplified Kconfig line. Fixed typos and slightly reworded example and commit. Added Link to PR. - Miguel ]Signed-off-by: Miguel Ojeda <ojeda@kernel.org> List of files: /linux-6.15/rust/kernel/list/arc.rs Tue, 03 Dec 2024 20:00:00 +0000 Xiangfei Ding <dingxiangfei2009@gmail.com>