Changes in Kconfig

b261d222 - lib/crc: remove CONFIG_LIBCRC32C

Tue, 01 Apr 2025 22:16:00 +0000

lib/crc: remove CONFIG_LIBCRC32CNow that LIBCRC32C does nothing besides select CRC32, make every optionthat selects LIBCRC32C instead select CRC32 directly. Then removeLIBCRC32C.Reviewed-by: Christoph Hellwig Reviewed-by: "Martin K. Petersen" Acked-by: Ard Biesheuvel Link: https://lore.kernel.org/r/20250401221600.24878-8-ebiggers@kernel.orgSigned-off-by: Eric Biggers List of files: /linux-6.15/net/sched/Kconfig

86fe596b - net: sched: Remove NET_ACT_IPT from Kconfig

Fri, 09 Feb 2024 18:06:56 +0000

net: sched: Remove NET_ACT_IPT from KconfigAfter this commit ba24ea129126 ("net/sched: Retire ipt action")NET_ACT_IPT is not needed anymore as the action is retired and the codeis removed.Clean the Kconfig part as well.Signed-off-by: Harshit Mogalapalli Acked-by: Jamal Hadi Salim Link: https://lore.kernel.org/r/20240209180656.867546-1-harshit.m.mogalapalli@oracle.comSigned-off-by: Paolo Abeni List of files: /linux-6.15/net/sched/Kconfig

e420bed0 - bpf: Add fd-based tcx multi-prog infra with link support

Wed, 19 Jul 2023 14:08:52 +0000

bpf: Add fd-based tcx multi-prog infra with link supportThis work refactors and adds a lightweight extension ("tcx") to the tc BPFingress and egress data path side for allowing BPF program management basedon fds via bpf() syscall through the newly added generic multi-prog API.The main goal behind this work which we also presented at LPC [0] last yearand a recent update at LSF/MM/BPF this year [3] is to support long-awaitedBPF link functionality for tc BPF programs, which allows for a model of safeownership and program detachment.Given the rise in tc BPF users in cloud native environments, this becomesnecessary to avoid hard to debug incidents either through stale leftoverprograms or 3rd party applications accidentally stepping on each others toes.As a recap, a BPF link represents the attachment of a BPF program to a BPFhook point. The BPF link holds a single reference to keep BPF program alive.Moreover, hook points do not reference a BPF link, only the application'sfd or pinning does. A BPF link holds meta-data specific to attachment andimplements operations for link creation, (atomic) BPF program update,detachment and introspection. The motivation for BPF links for tc BPF programsis multi-fold, for example: - From Meta: "It's especially important for applications that are deployed fleet-wide and that don't "control" hosts they are deployed to. If such application crashes and no one notices and does anything about that, BPF program will keep running draining resources or even just, say, dropping packets. We at FB had outages due to such permanent BPF attachment semantics. With fd-based BPF link we are getting a framework, which allows safe, auto-detachable behavior by default, unless application explicitly opts in by pinning the BPF link." [1] - From Cilium-side the tc BPF programs we attach to host-facing veth devices and phys devices build the core datapath for Kubernetes Pods, and they implement forwarding, load-balancing, policy, EDT-management, etc, within BPF. Currently there is no concept of 'safe' ownership, e.g. we've recently experienced hard-to-debug issues in a user's staging environment where another Kubernetes application using tc BPF attached to the same prio/handle of cls_bpf, accidentally wiping all Cilium-based BPF programs from underneath it. The goal is to establish a clear/safe ownership model via links which cannot accidentally be overridden. [0,2]BPF links for tc can co-exist with non-link attachments, and the semantics arein line also with XDP links: BPF links cannot replace other BPF links, BPFlinks cannot replace non-BPF links, non-BPF links cannot replace BPF links andlastly only non-BPF links can replace non-BPF links. In case of Cilium, thiswould solve mentioned issue of safe ownership model as 3rd party applicationswould not be able to accidentally wipe Cilium programs, even if they are notBPF link aware.Earlier attempts [4] have tried to integrate BPF links into core tc machineryto solve cls_bpf, which has been intrusive to the generic tc kernel API withextensions only specific to cls_bpf and suboptimal/complex since cls_bpf couldbe wiped from the qdisc also. Locking a tc BPF program in place this way, isgetting into layering hacks given the two object models are vastly different.We instead implemented the tcx (tc 'express') layer which is an fd-based tc BPFattach API, so that the BPF link implementation blends in naturally similar toother link types which are fd-based and without the need for changing core tcinternal APIs. BPF programs for tc can then be successively migrated from classiccls_bpf to the new tc BPF link without needing to change the program's sourcecode, just the BPF loader mechanics for attaching is sufficient.For the current tc framework, there is no change in behavior with this changeand neither does this change touch on tc core kernel APIs. The gist of thispatch is that the ingress and egress hook have a lightweight, qdisc-lessextension for BPF to attach its tc BPF programs, in other words, a minimalentry point for tc BPF. The name tcx has been suggested from discussion ofearlier revisions of this work as a good fit, and to more easily differ betweenthe classic cls_bpf attachment and the fd-based one.For the ingress and egress tcx points, the device holds a cache-friendly arraywith program pointers which is separated from control plane (slow-path) data.Earlier versions of this work used priority to determine ordering and expressionof dependencies similar as with classic tc, but it was challenged that forsomething more future-proof a better user experience is required. Hence thisresulted in the design and development of the generic attach/detach/query APIfor multi-progs. See prior patch with its discussion on the API design. tcx isthe first user and later we plan to integrate also others, for example, onecandidate is multi-prog support for XDP which would benefit and have the same'look and feel' from API perspective.The goal with tcx is to have maximum compatibility to existing tc BPF programs,so they don't need to be rewritten specifically. Compatibility to call intoclassic tcf_classify() is also provided in order to allow successive migrationor both to cleanly co-exist where needed given its all one logical tc layer andthe tcx plus classic tc cls/act build one logical overall processing pipeline.tcx supports the simplified return codes TCX_NEXT which is non-terminating (goto next program) and terminating ones with TCX_PASS, TCX_DROP, TCX_REDIRECT.The fd-based API is behind a static key, so that when unused the code is alsonot entered. The struct tcx_entry's program array is currently static, butcould be made dynamic if necessary at a point in future. The a/b pair swapdesign has been chosen so that for detachment there are no allocations whichotherwise could fail.The work has been tested with tc-testing selftest suite which all passes, aswell as the tc BPF tests from the BPF CI, and also with Cilium's L4LB.Thanks also to Nikolay Aleksandrov and Martin Lau for in-depth early reviewsof this work. [0] https://lpc.events/event/16/contributions/1353/ [1] https://lore.kernel.org/bpf/CAEf4BzbokCJN33Nw_kg82sO=xppXnKWEncGTWCTB9vGCmLB6pw@mail.gmail.com [2] https://colocatedeventseu2023.sched.com/event/1Jo6O/tales-from-an-ebpf-programs-murder-mystery-hemanth-malla-guillaume-fournier-datadog [3] http://vger.kernel.org/bpfconf2023_material/tcx_meta_netdev_borkmann.pdf [4] https://lore.kernel.org/bpf/20210604063116.234316-1-memxor@gmail.comSigned-off-by: Daniel Borkmann Acked-by: Jakub Kicinski Link: https://lore.kernel.org/r/20230719140858.13224-3-daniel@iogearbox.netSigned-off-by: Alexei Starovoitov List of files: /linux-6.15/net/sched/Kconfig

265b4da8 - net/sched: Retire rsvp classifier

Tue, 14 Feb 2023 13:49:15 +0000

net/sched: Retire rsvp classifierThe rsvp classifier has served us well for about a quarter of a century but hashas not been getting much maintenance attention due to lack of known users.Signed-off-by: Jamal Hadi Salim Acked-by: Jiri Pirko Signed-off-by: Paolo Abeni List of files: /linux-6.15/net/sched/Kconfig

8c710f75 - net/sched: Retire tcindex classifier

Tue, 14 Feb 2023 13:49:14 +0000

net/sched: Retire tcindex classifierThe tcindex classifier has served us well for about a quarter of a centurybut has not been getting much TLC due to lack of known users. Most recentlyit has become easy prey to syzkaller. For this reason, we are retiring it.Signed-off-by: Jamal Hadi Salim Acked-by: Jiri Pirko Signed-off-by: Paolo Abeni List of files: /linux-6.15/net/sched/Kconfig

bbe77c14 - net/sched: Retire dsmark qdisc

Tue, 14 Feb 2023 13:49:13 +0000

net/sched: Retire dsmark qdiscThe dsmark qdisc has served us well over the years for diffserv but has notbeen getting much attention due to other more popular approaches to do diffservservices. Most recently it has become a shooting target for syzkaller. For thisreason, we are retiring it.Signed-off-by: Jamal Hadi Salim Acked-by: Jiri Pirko Signed-off-by: Paolo Abeni List of files: /linux-6.15/net/sched/Kconfig

fb38306c - net/sched: Retire ATM qdisc

Tue, 14 Feb 2023 13:49:12 +0000

net/sched: Retire ATM qdiscThe ATM qdisc has served us well over the years but has not been getting muchTLC due to lack of known users. Most recently it has become a shooting targetfor syzkaller. For this reason, we are retiring it.Signed-off-by: Jamal Hadi Salim Acked-by: Jiri Pirko Signed-off-by: Paolo Abeni List of files: /linux-6.15/net/sched/Kconfig

051d4420 - net/sched: Retire CBQ qdisc

Tue, 14 Feb 2023 13:49:11 +0000

net/sched: Retire CBQ qdiscWhile this amazing qdisc has served us well over the years it has not beengetting any tender love and care and has bitrotted over time.It has become mostly a shooting target for syzkaller lately.For this reason, we are retiring it. Goodbye CBQ - we loved you.Signed-off-by: Jamal Hadi Salim Acked-by: Jiri Pirko Signed-off-by: Paolo Abeni List of files: /linux-6.15/net/sched/Kconfig

c0c3ab63 - net: create nf_conntrack_ovs for ovs and tc use

Tue, 07 Feb 2023 22:52:06 +0000

net: create nf_conntrack_ovs for ovs and tc useSimilar to nf_nat_ovs created by Commit ebddb1404900 ("net: move thenat function to nf_nat_ovs for ovs and tc"), this patch is to createnf_conntrack_ovs to get these functions shared by OVS and TC only.There are nf_ct_helper() and nf_ct_add_helper() from nf_conntrak_helperin this patch, and will be more in the following patches.Signed-off-by: Xin Long Reviewed-by: Simon Horman Reviewed-by: Aaron Conole Acked-by: Florian Westphal Signed-off-by: Jakub Kicinski List of files: /linux-6.15/net/sched/Kconfig

1dfe086d - net/sched: taprio: centralize mqprio qopt validation

Sat, 04 Feb 2023 13:53:01 +0000

net/sched: taprio: centralize mqprio qopt validationThere is a lot of code in taprio which is "borrowed" from mqprio.It makes sense to put a stop to the "borrowing" and start actuallyreusing code.Because taprio and mqprio are built as part of different kernel modules,code reuse can only take place either by writing it as static inline(limiting), putting it in sch_generic.o (not generic enough), orcreating a third auto-selectable kernel module which only holds librarycode. I opted for the third variant.In a previous change, mqprio gained support for reverse TC:TXQ mappings,something which taprio still denies. Make taprio use the same validationlogic so that it supports this configuration as well.The taprio code didn't enforce TXQ overlaps in txtime-assist mode andthat looks intentional, even if I've no idea why that might be. Preservethat, but add a comment.There isn't any dedicated MAINTAINERS entry for mqprio, so nothing toupdate there.Signed-off-by: Vladimir Oltean Reviewed-by: Simon Horman Reviewed-by: Gerhard Engleder Signed-off-by: David S. Miller List of files: /linux-6.15/net/sched/Kconfig

6a7a2c18 - net: Kconfig: fix spellos

Tue, 24 Jan 2023 18:17:24 +0000

net: Kconfig: fix spellosFix spelling in net/ Kconfig files.(reported by codespell)Signed-off-by: Randy Dunlap Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc: Florian Westphal Cc: coreteam@netfilter.orgCc: Jamal Hadi Salim Cc: Cong Wang Cc: Jiri Pirko Link: https://lore.kernel.org/r/20230124181724.18166-1-rdunlap@infradead.orgSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/sched/Kconfig

ebddb140 - net: move the nat function to nf_nat_ovs for ovs and tc

Thu, 08 Dec 2022 16:56:12 +0000

net: move the nat function to nf_nat_ovs for ovs and tcThere are two nat functions are nearly the same in both OVS andTC code, (ovs_)ct_nat_execute() and ovs_ct_nat/tcf_ct_act_nat().This patch creates nf_nat_ovs.c under netfilter and moves themthere then exports nf_ct_nat() so that it can be shared by bothOVS and TC, and keeps the nat (type) check and nat flag updatein OVS and TC's own place, as these parts are different betweenOVS and TC.Note that in OVS nat function it was using skb->protocol to getthe proto as it already skips vlans in key_extract(), while itdoesn't in TC, and TC has to call skb_protocol() to get proto.So in nf_ct_nat_execute(), we keep using skb_protocol() whichworks for both OVS and TC contrack.Signed-off-by: Xin Long Acked-by: Aaron Conole Acked-by: Pablo Neira Ayuso Signed-off-by: David S. Miller List of files: /linux-6.15/net/sched/Kconfig

8427fd10 - net: sched: allow act_ct to be built without NF_NAT

Fri, 18 Nov 2022 21:33:03 +0000

net: sched: allow act_ct to be built without NF_NATIn commit f11fe1dae1c4 ("net/sched: Make NET_ACT_CT depends on NF_NAT"),it fixed the build failure when NF_NAT is m and NET_ACT_CT is y byadding depends on NF_NAT for NET_ACT_CT. However, it would also causeNET_ACT_CT cannot be built without NF_NAT, which is not expected. Thispatch fixes it by changing to use "(!NF_NAT || NF_NAT)" as the depend.Fixes: f11fe1dae1c4 ("net/sched: Make NET_ACT_CT depends on NF_NAT")Signed-off-by: Xin Long Link: https://lore.kernel.org/r/b6386f28d1ba34721795fb776a91cbdabb203447.1668807183.git.lucien.xin@gmail.comSigned-off-by: Paolo Abeni List of files: /linux-6.15/net/sched/Kconfig

102e2c07 - net: sched: incorrect Kconfig dependencies on Netfilter modules

Tue, 08 Dec 2020 20:47:07 +0000

net: sched: incorrect Kconfig dependencies on Netfilter modules- NET_ACT_CONNMARK and NET_ACT_CTINFO only require conntrack support.- NET_ACT_IPT only requires NETFILTER_XTABLES symbols, not IP_NF_IPTABLES. After this patch, NET_ACT_IPT becomes consistent with NET_EMATCH_IPT. NET_ACT_IPT dependency on IP_NF_IPTABLES predates Linux-2.6.12-rc2 (initial git repository build).Fixes: 22a5dc0e5e3e ("net: sched: Introduce connmark action")Fixes: 24ec483cec98 ("net: sched: Introduce act_ctinfo action")Signed-off-by: Pablo Neira Ayuso Link: https://lore.kernel.org/r/20201208204707.11268-1-pablo@netfilter.orgSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/sched/Kconfig

8354bcbe - net: sched: fix spelling mistake in Kconfig "trys" -> "tries"

Mon, 07 Dec 2020 16:12:31 +0000

net: sched: fix spelling mistake in Kconfig "trys" -> "tries"There is a spelling mistake in the Kconfig help text. Fix it.Signed-off-by: Colin Ian King Signed-off-by: David S. Miller List of files: /linux-6.15/net/sched/Kconfig

b97e9d9d - net: sched: Allow changing default qdisc to FQ-PIE

Wed, 01 Jul 2020 23:01:52 +0000

net: sched: Allow changing default qdisc to FQ-PIESimilar to fq_codel and the other qdiscs that can set as default,fq_pie is also suitable for general use without explicit configuration,which makes it a valid choice for this.This is useful in situations where a painless out-of-the-box solutionfor reducing bufferbloat is desired but fq_codel is not necessarily thebest choice. For example, fq_pie can be better for DASH streaming, butthere could be more cases where it's the better choice of the two simpleAQMs available in the kernel.Signed-off-by: Danny Lin Signed-off-by: David S. Miller List of files: /linux-6.15/net/sched/Kconfig

a7f7f624 - treewide: replace '---help---' in Kconfig files with 'help'

Sat, 13 Jun 2020 16:50:22 +0000

treewide: replace '---help---' in Kconfig files with 'help'Since commit 84af7a6194e4 ("checkpatch: kconfig: prefer 'help' over'---help---'"), the number of '---help---' has been graduallydecreasing, but there are still more than 2400 instances.This commit finishes the conversion. While I touched the lines,I also fixed the indentation.There are a variety of indentation styles found. a) 4 spaces + '---help---' b) 7 spaces + '---help---' c) 8 spaces + '---help---' d) 1 space + 1 tab + '---help---' e) 1 tab + '---help---' (correct indentation) f) 1 tab + 1 space + '---help---' g) 1 tab + 2 spaces + '---help---'In order to convert all of them to 1 tab + 'help', I ran thefollowing commend: $ find . -name 'Kconfig*' | xargs sed -i 's/^[[:space:]]*---help---/\thelp/'Signed-off-by: Masahiro Yamada List of files: /linux-6.15/net/sched/Kconfig

a51c328d - net: qos: introduce a gate control flow action

Fri, 01 May 2020 00:53:15 +0000

net: qos: introduce a gate control flow actionIntroduce a ingress frame gate control flow action.Tc gate action does the work like this:Assume there is a gate allow specified ingress frames can be passed atspecific time slot, and be dropped at specific time slot. Tc filterchooses the ingress frames, and tc gate action would specify what slotdoes these frames can be passed to device and what time slot would bedropped.Tc gate action would provide an entry list to tell how much time gatekeep open and how much time gate keep state close. Gate action alsoassign a start time to tell when the entry list start. Then driver wouldrepeat the gate entry list cyclically.For the software simulation, gate action requires the user assign a timeclock type.Below is the setting example in user space. Tc filter a stream source ipaddress is 192.168.0.20 and gate action own two time slots. One is last200ms gate open let frame pass another is last 100ms gate close letframes dropped. When the ingress frames have reach total frames over8000000 bytes, the excessive frames will be dropped in that 200000000nstime slot.> tc qdisc add dev eth0 ingress> tc filter add dev eth0 parent ffff: protocol ip \ flower src_ip 192.168.0.20 \ action gate index 2 clockid CLOCK_TAI \ sched-entry open 200000000 -1 8000000 \ sched-entry close 100000000 -1 -1> tc chain del dev eth0 ingress chain 0"sched-entry" follow the name taprio style. Gate state is"open"/"close". Follow with period nanosecond. Then next item is internalpriority value means which ingress queue should put. "-1" meanswildcard. The last value optional specifies the maximum number ofMSDU octets that are permitted to pass the gate during the specifiedtime interval.Base-time is not set will be 0 as default, as result start time wouldbe ((N + 1) * cycletime) which is the minimal of future time.Below example shows filtering a stream with destination mac address is10:00:80:00:00:00 and ip type is ICMP, follow the action gate. The gateaction would run with one close time slot which means always keep close.The time cycle is total 200000000ns. The base-time would calculate by: 1357000000000 + (N + 1) * cycletimeWhen the total value is the future time, it will be the start time.The cycletime here would be 200000000ns for this case.> tc filter add dev eth0 parent ffff: protocol ip \ flower skip_hw ip_proto icmp dst_mac 10:00:80:00:00:00 \ action gate index 12 base-time 1357000000000 \ sched-entry close 200000000 -1 -1 \ clockid CLOCK_TAISigned-off-by: Po Liu Signed-off-by: David S. Miller List of files: /linux-6.15/net/sched/Kconfig

c34b961a - net/sched: act_ct: Create nf flow table per zone

Tue, 03 Mar 2020 13:07:49 +0000

net/sched: act_ct: Create nf flow table per zoneUse the NF flow tables infrastructure for CT offload.Create a nf flow table per zone.Next patches will add FT entries to this table, and dothe software offload.Signed-off-by: Paul Blakey Reviewed-by: Jiri Pirko Signed-off-by: David S. Miller List of files: /linux-6.15/net/sched/Kconfig

ec97ecf1 - net: sched: add Flow Queue PIE packet scheduler

Wed, 22 Jan 2020 18:22:33 +0000

net: sched: add Flow Queue PIE packet schedulerPrinciples: - Packets are classified on flows. - This is a Stochastic model (as we use a hash, several flows might be hashed to the same slot) - Each flow has a PIE managed queue. - Flows are linked onto two (Round Robin) lists, so that new flows have priority on old ones. - For a given flow, packets are not reordered. - Drops during enqueue only. - ECN capability is off by default. - ECN threshold (if ECN is enabled) is at 10% by default. - Uses timestamps to calculate queue delay by default.Usage:tc qdisc ... fq_pie [ limit PACKETS ] [ flows NUMBER ] [ target TIME ] [ tupdate TIME ] [ alpha NUMBER ] [ beta NUMBER ] [ quantum BYTES ] [ memory_limit BYTES ] [ ecnprob PERCENTAGE ] [ [no]ecn ] [ [no]bytemode ] [ [no_]dq_rate_estimator ]defaults: limit: 10240 packets, flows: 1024 target: 15 ms, tupdate: 15 ms (in jiffies) alpha: 1/8, beta : 5/4 quantum: device MTU, memory_limit: 32 Mb ecnprob: 10%, ecn: off bytemode: off, dq_rate_estimator: offSigned-off-by: Mohit P. Tahiliani Signed-off-by: Sachin D. Patil Signed-off-by: V. Saicharan Signed-off-by: Mohit Bhasi Signed-off-by: Leslie Monis Signed-off-by: Gautam Ramakrishnan Signed-off-by: David S. Miller List of files: /linux-6.15/net/sched/Kconfig