Changes in Makefile

7c482665 - rxrpc: Implement RACK/TLP to deal with transmission stalls [RFC8985]

Wed, 04 Dec 2024 07:47:07 +0000

rxrpc: Implement RACK/TLP to deal with transmission stalls [RFC8985]When an rxrpc call is in its transmission phase and is sending a lot ofpackets, stalls occasionally occur that cause severe performancedegradation (eg. increasing the transmission time for a 256MiB payload from0.7s to 2.5s over a 10G link).rxrpc already implements TCP-style congestion control [RFC5681] and thishelps mitigate the effects, but occasionally we're missing a time eventthat deals with a missing ACK, leading to a stall until the RTO expires.Fix this by implementing RACK/TLP in rxrpc.Signed-off-by: David Howells cc: Marc Dionne cc: linux-afs@lists.infradead.orgSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/rxrpc/Makefile

0b9bb322 - rxrpc: Split out the call state changing functions into their own file

Wed, 26 Oct 2022 23:16:55 +0000

rxrpc: Split out the call state changing functions into their own fileSplit out the functions that change the state of an rxrpc call into theirown file. The idea being to remove anything to do with changing the stateof a call directly from the rxrpc sendmsg() and recvmsg() paths and haveall that done in the I/O thread only, with the ultimate aim of removing thestate lock entirely. Moving the code out of sendmsg.c and recvmsg.c makesthat easier to manage.Signed-off-by: David Howells cc: Marc Dionne cc: linux-afs@lists.infradead.org List of files: /linux-6.15/net/rxrpc/Makefile

96b2d69b - rxrpc: Split the receive code

Thu, 23 Jan 2020 13:01:33 +0000

rxrpc: Split the receive codeSplit the code that handles packet reception in softirq mode as a preludeto moving all the packet processing beyond routing to the appropriate calland setting up of a new call out into process context.Signed-off-by: David Howells cc: Marc Dionne cc: linux-afs@lists.infradead.org List of files: /linux-6.15/net/rxrpc/Makefile

75bfdbf2 - rxrpc: Implement an in-kernel rxperf server for testing purposes

Thu, 03 Nov 2022 22:27:52 +0000

rxrpc: Implement an in-kernel rxperf server for testing purposesImplement an in-kernel rxperf server to allow kernel-based rxrpc servicesto be tested directly, unlike with AFS where they're accessed by thefileserver when the latter decides it wants to.This is implemented as a module that, if loaded, opens UDP port 7009(afs3-rmtsys) and listens on it for incoming calls. Calls can be generatedusing the rxperf command shipped with OpenAFS, for example.Changes=======ver #2) - Use min_t() instead of min().Signed-off-by: David Howells cc: Marc Dionne cc: linux-afs@lists.infradead.orgcc: Jakub Kicinski List of files: /linux-6.15/net/rxrpc/Makefile

02a19356 - rxrpc: Define rxrpc_txbuf struct to carry data to be transmitted

Tue, 05 Apr 2022 20:16:32 +0000

rxrpc: Define rxrpc_txbuf struct to carry data to be transmittedDefine a struct, rxrpc_txbuf, to carry data to be transmitted instead of asocket buffer so that it can be placed onto multiple queues at once. Thisalso allows the data buffer to be in the same allocation as the internaldata.Signed-off-by: David Howells cc: Marc Dionne cc: linux-afs@lists.infradead.org List of files: /linux-6.15/net/rxrpc/Makefile

ca7fb100 - rxrpc: Split the server key type (rxrpc_s) into its own file

Wed, 16 Sep 2020 07:25:08 +0000

rxrpc: Split the server key type (rxrpc_s) into its own fileSplit the server private key type (rxrpc_s) out into its own file ratherthan mingling it with the authentication/client key type (rxrpc) since theydon't really bear any relation.Signed-off-by: David Howells List of files: /linux-6.15/net/rxrpc/Makefile

c410bf01 - rxrpc: Fix the excessive initial retransmission timeout

Mon, 11 May 2020 13:54:34 +0000

rxrpc: Fix the excessive initial retransmission timeoutrxrpc currently uses a fixed 4s retransmission timeout until the RTT issufficiently sampled. This can cause problems with some fileservers withcalls to the cache manager in the afs filesystem being dropped from thefileserver because a packet goes missing and the retransmission timeout isgreater than the call expiry timeout.Fix this by: (1) Copying the RTT/RTO calculation code from Linux's TCP implementation and altering it to fit rxrpc. (2) Altering the various users of the RTT to make use of the new SRTT value. (3) Replacing the use of rxrpc_resend_timeout to use the calculated RTO value instead (which is needed in jiffies), along with a backoff.Notes: (1) rxrpc provides RTT samples by matching the serial numbers on outgoing DATA packets that have the RXRPC_REQUEST_ACK set and PING ACK packets against the reference serial number in incoming REQUESTED ACK and PING-RESPONSE ACK packets. (2) Each packet that is transmitted on an rxrpc connection gets a new per-connection serial number, even for retransmissions, so an ACK can be cross-referenced to a specific trigger packet. This allows RTT information to be drawn from retransmitted DATA packets also. (3) rxrpc maintains the RTT/RTO state on the rxrpc_peer record rather than on an rxrpc_call because many RPC calls won't live long enough to generate more than one sample. (4) The calculated SRTT value is in units of 8ths of a microsecond rather than nanoseconds.The (S)RTT and RTO values are displayed in /proc/net/rxrpc/peers.Fixes: 17926a79320a ([AF_RXRPC]: Provide secure RxRPC sockets for use by userspace and kernel both"")Signed-off-by: David Howells List of files: /linux-6.15/net/rxrpc/Makefile

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/net/rxrpc/Makefile

2baec2c3 - rxrpc: Support network namespacing

Wed, 24 May 2017 16:02:32 +0000

rxrpc: Support network namespacingSupport network namespacing in AF_RXRPC with the following changes: (1) All the local endpoint, peer and call lists, locks, counters, etc. are moved into the per-namespace record. (2) All the connection tracking is moved into the per-namespace record with the exception of the client connection ID tree, which is kept global so that connection IDs are kept unique per-machine. (3) Each namespace gets its own epoch. This allows each network namespace to pretend to be a separate client machine. (4) The /proc/net/rxrpc_xxx files are now called /proc/net/rxrpc/xxx and the contents reflect the namespace.fs/afs/ should be okay with this patch as it explicitly requires the currentnet namespace to be init_net to permit a mount to proceed at the moment. Itwill, however, need updating so that cells, IP addresses and DNS records areper-namespace also.Signed-off-by: David Howells Signed-off-by: David S. Miller List of files: /linux-6.15/net/rxrpc/Makefile

88c4845d - rxrpc: Change module filename to rxrpc.ko

Fri, 17 Feb 2017 18:16:21 +0000

rxrpc: Change module filename to rxrpc.koChange module filename from af-rxrpc.ko to rxrpc.ko so as to be consistentwith the other protocol drivers.Also adjust the documentation to reflect this.Further, there is no longer a standalone rxkad module, as it has beenmerged into the rxrpc core, so get rid of references to that.Reported-by: Marc Dionne Signed-off-by: David Howells Signed-off-by: David S. Miller List of files: /linux-6.15/net/rxrpc/Makefile

0b58b8a1 - rxrpc: Split sendmsg from packet transmission code

Fri, 02 Sep 2016 21:39:45 +0000

rxrpc: Split sendmsg from packet transmission codeSplit the sendmsg code from the packet transmission code (mostly to befound in output.c).Signed-off-by: David Howells List of files: /linux-6.15/net/rxrpc/Makefile

7877a4a4 - rxrpc: Split service connection code out into its own file

Mon, 04 Apr 2016 13:00:40 +0000

rxrpc: Split service connection code out into its own fileSplit the service-specific connection code out into into its own file. Theclient-specific code has already been split out. This will leave just thecommon code in the original file.Signed-off-by: David Howells List of files: /linux-6.15/net/rxrpc/Makefile

aa390bbe - rxrpc: Kill off the rxrpc_transport struct

Fri, 17 Jun 2016 09:06:56 +0000

rxrpc: Kill off the rxrpc_transport structThe rxrpc_transport struct is now redundant, given that the rxrpc_peerstruct is now per peer port rather than per peer host, so get rid of it.Service connection lists are transferred to the rxrpc_peer struct, as isthe conn_lock. Previous patches moved the client connection handling outof the rxrpc_transport struct and discarded the connection bundling code.Signed-off-by: David Howells List of files: /linux-6.15/net/rxrpc/Makefile

4a3388c8 - rxrpc: Use IDR to allocate client conn IDs on a machine-wide basis

Mon, 04 Apr 2016 13:00:37 +0000

rxrpc: Use IDR to allocate client conn IDs on a machine-wide basisUse the IDR facility to allocate client connection IDs on a machine-widebasis so that each client connection has a unique identifier. When theconnection ID space wraps, we advance the epoch by 1, thereby effectivelyhaving a 62-bit ID space. The IDR facility is then used to look up clientconnections during incoming packet routing instead of using an rbtreerooted on the transport.This change allows for the removal of the transport in the future and alsomeans that client connections can be looked up directly in the data-readyhandler by connection ID.The ID management code is placed in a new file, conn-client.c, to which allthe client connection-specific code will eventually move.Note that the IDR tree gets very expensive on memory if the connection IDsare widely scattered throughout the number space, so we shall need toretire connections that have, say, an ID more than four times the maximumnumber of client conns away from the current allocation point to try andkeep the IDs concentrated. We will also need to retire connections from anold epoch.Also note that, for the moment, a pointer to the transport has to be passedthrough into the ID allocation function so that we can take a BH lock toprevent a locking issue against in-BH lookup of client connections. Thiswill go away later when RCU is used for server connections also.Signed-off-by: David Howells List of files: /linux-6.15/net/rxrpc/Makefile

87563616 - rxrpc: Separate local endpoint event handling out into its own file

Mon, 04 Apr 2016 13:00:34 +0000

rxrpc: Separate local endpoint event handling out into its own fileSeparate local endpoint event handling out into its own file preparatory tooverhauling the object management aspect (which remains in the originalfile).Signed-off-by: David Howells List of files: /linux-6.15/net/rxrpc/Makefile

be6e6707 - rxrpc: Rework peer object handling to use hash table and RCU

Mon, 04 Apr 2016 13:00:32 +0000

rxrpc: Rework peer object handling to use hash table and RCURework peer object handling to use a hash table instead of a flat list andto use RCU. Peer objects are no longer destroyed by passing them to aworkqueue to process, but rather are just passed to the RCU garbagecollector as kfree'able objects.The hash function uses the local endpoint plus all the components of theremote address, except for the RxRPC service ID. Peers thus represent aUDP port on the remote machine as contacted by a UDP port on this machine.The RCU read lock is used to handle non-creating lookups so that they canbe called from bottom half context in the sk_error_report handler withouthaving to lock the hash table against modification.rxrpc_lookup_peer_rcu() *does* take a reference on the peer object as inthe future, this will be passed to a work item for error distribution inthe error_report path and this function will cease being used in thedata_ready path.Creating lookups are done under spinlock rather than mutex as they might beset up due to an external stimulus if the local endpoint is a server.Captured network error messages (ICMP) are handled with respect to thisstruct and MTU size and RTT are cached here.Signed-off-by: David Howells List of files: /linux-6.15/net/rxrpc/Makefile

8c3e34a4 - rxrpc: Rename files matching ar-*.c to git rid of the "ar-" prefix

Mon, 13 Jun 2016 11:16:05 +0000

rxrpc: Rename files matching ar-*.c to git rid of the "ar-" prefixRename files matching net/rxrpc/ar-*.c to get rid of the "ar-" prefix.This will aid splitting those files by making easier to come up with newnames.Note that the not all files are simply renamed from ar-X.c to X.c. Thefollowing exceptions are made: (*) ar-call.c -> call_object.c ar-ack.c -> call_event.c call_object.c is going to contain the core of the call object handling. Call event handling is all going to be in call_event.c. (*) ar-accept.c -> call_accept.c Incoming call handling is going to be here. (*) ar-connection.c -> conn_object.c ar-connevent.c -> conn_event.c The former file is going to have the basic connection object handling, but there will likely be some differentiation between client connections and service connections in additional files later. The latter file will have all the connection-level event handling. (*) ar-local.c -> local_object.c This will have the local endpoint object handling code. The local endpoint event handling code will later be split out into local_event.c. (*) ar-peer.c -> peer_object.c This will have the peer endpoint object handling code. Peer event handling code will be placed in peer_event.c (for the moment, there is none). (*) ar-error.c -> peer_event.c This will become the peer event handling code, though for the moment it's actually driven from the local endpoint's perspective.Note that I haven't renamed ar-transport.c to transport_object.c as theintention is to delete it when the rxrpc_transport struct is excised.The only file that actually has its contents changed is net/rxrpc/Makefile.net/rxrpc/ar-internal.h will need its section marker comments updating, butI'll do that in a separate patch to make it easier for git to follow thehistory across the rename. I may also want to rename ar-internal.h at somepoint - but that would mean updating all the #includes and I'd rather dothat in a separate step.Signed-off-by: David Howells

e0e4d82f - rxrpc: Create a null security type and get rid of conditional calls

Thu, 07 Apr 2016 16:23:58 +0000

rxrpc: Create a null security type and get rid of conditional callsCreate a null security type for security index 0 and get rid of allconditional calls to the security operations. We expect normally to beusing security, so this should be of little negative impact.Signed-off-by: David Howells Signed-off-by: David S. Miller List of files: /linux-6.15/net/rxrpc/Makefile

648af7fc - rxrpc: Absorb the rxkad security module

Thu, 07 Apr 2016 16:23:51 +0000

rxrpc: Absorb the rxkad security moduleAbsorb the rxkad security module into the af_rxrpc module so that there'sonly one module file. This avoids a circular dependency whereby rxkad pinsaf_rxrpc and cached connections pin rxkad but can't be manually evicted(they will expire eventually and cease pinning).With this change, af_rxrpc can just be unloaded, despite having cachedconnections.Signed-off-by: David Howells Signed-off-by: David S. Miller List of files: /linux-6.15/net/rxrpc/Makefile

8e688d9c - rxrpc: Move some miscellaneous bits out into their own file

Thu, 07 Apr 2016 16:23:16 +0000

rxrpc: Move some miscellaneous bits out into their own fileMove some miscellaneous bits out into their own file to make it easier tosplit the call handling.Signed-off-by: David Howells Signed-off-by: David S. Miller List of files: /linux-6.15/net/rxrpc/Makefile