Changes in Kconfig

a7f7f624 - treewide: replace '---help---' in Kconfig files with 'help'

Sat, 13 Jun 2020 16:50:22 +0000

treewide: replace '---help---' in Kconfig files with 'help'Since commit 84af7a6194e4 ("checkpatch: kconfig: prefer 'help' over'---help---'"), the number of '---help---' has been graduallydecreasing, but there are still more than 2400 instances.This commit finishes the conversion. While I touched the lines,I also fixed the indentation.There are a variety of indentation styles found. a) 4 spaces + '---help---' b) 7 spaces + '---help---' c) 8 spaces + '---help---' d) 1 space + 1 tab + '---help---' e) 1 tab + '---help---' (correct indentation) f) 1 tab + 1 space + '---help---' g) 1 tab + 2 spaces + '---help---'In order to convert all of them to 1 tab + 'help', I ran thefollowing commend: $ find . -name 'Kconfig*' | xargs sed -i 's/^[[:space:]]*---help---/\thelp/'Signed-off-by: Masahiro Yamada List of files: /linux-6.15/net/netlink/Kconfig

ec8f24b7 - treewide: Add SPDX license identifier - Makefile/Kconfig

Sun, 19 May 2019 12:07:45 +0000

treewide: Add SPDX license identifier - Makefile/KconfigAdd SPDX license identifiers to all Make/Kconfig files which: - Have no license information of any formThese files fall under the project license, GPL v2 only. The resulting SPDXlicense identifier is: GPL-2.0-onlySigned-off-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/net/netlink/Kconfig

d1b4c689 - netlink: remove mmapped netlink support

Thu, 18 Feb 2016 14:03:24 +0000

netlink: remove mmapped netlink supportmmapped netlink has a number of unresolved issues:- TX zerocopy support had to be disabled more than a year ago via commit 4682a0358639b29cf ("netlink: Always copy on mmap TX.") because the content of the mmapped area can change after netlink attribute validation but before message processing.- RX support was implemented mainly to speed up nfqueue dumping packet payload to userspace. However, since commit ae08ce0021087a5d812d2 ("netfilter: nfnetlink_queue: zero copy support") we avoid one copy with the socket-based interface too (via the skb_zerocopy helper).The other problem is that skbs attached to mmaped netlink socketbehave different from normal skbs:- they don't have a shinfo area, so all functions that use skb_shinfo()(e.g. skb_clone) cannot be used.- reserving headroom prevents userspace from seeing the content asit expects message to start at skb->head.See for instancecommit aa3a022094fa ("netlink: not trim skb for mmaped socket when dump").- skbs handed e.g. to netlink_ack must have non-NULL skb->sk, else wecrash because it needs the sk to check if a tx ring is attached.Also not obvious, leads to non-intuitive bug fixes such as 7c7bdf359("netfilter: nfnetlink: use original skbuff when acking batches").mmaped netlink also didn't play nicely with the skb_zerocopy helperused by nfqueue and openvswitch. Daniel Borkmann fixed this viacommit 6bb0fef489f6 ("netlink, mmap: fix edge-case leakages in nf queuezero-copy")' but at the cost of also needing to provide remaininglength to the allocation function.nfqueue also has problems when used with mmaped rx netlink:- mmaped netlink doesn't allow use of nfqueue batch verdict messages. Problem is that in the mmap case, the allocation time also determines the ordering in which the frame will be seen by userspace (A allocating before B means that A is located in earlier ring slot, but this also means that B might get a lower sequence number then A since seqno is decided later. To fix this we would need to extend the spinlocked region to also cover the allocation and message setup which isn't desirable.- nfqueue can now be configured to queue large (GSO) skbs to userspace. Queing GSO packets is faster than having to force a software segmentation in the kernel, so this is a desirable option. However, with a mmap based ring one has to use 64kb per ring slot element, else mmap has to fall back to the socket path (NL_MMAP_STATUS_COPY) for all large packets.To use the mmap interface, userspace not only has to probe for mmap netlinksupport, it also has to implement a recv/socket receive path in order tohandle messages that exceed the size of an rx ring element.Cc: Daniel Borkmann Cc: Ken-ichirou MATSUZAWA Cc: Pablo Neira Ayuso Cc: Patrick McHardy Cc: Thomas Graf Signed-off-by: Florian Westphal Signed-off-by: David S. Miller List of files: /linux-6.15/net/netlink/Kconfig

ee1bec9b - netlink: kconfig: move mmap i/o into netlink kconfig

Wed, 01 May 2013 01:37:20 +0000

netlink: kconfig: move mmap i/o into netlink kconfigCurrently, in menuconfig, Netlink's new mmaped IO is the very firstentry under the ``Networking support'' item and comes even before``Networking options'': [ ] Netlink: mmaped IO Networking options ---> ...Lets move this into ``Networking options'' under netlink's Kconfig,since this might be more appropriate. Introduced by commit ccdfcc398(``netlink: mmaped netlink: ring setup'').Signed-off-by: Daniel Borkmann Signed-off-by: David S. Miller List of files: /linux-6.15/net/netlink/Kconfig

eaaa3139 - netlink: Diag core and basic socket info dumping (v2)

Thu, 21 Mar 2013 16:33:48 +0000

netlink: Diag core and basic socket info dumping (v2)The netlink_diag can be built as a module, just like it's done inunix sockets.The core dumping message carries the basic info about netlink sockets:family, type and protocol, portis, dst_group, dst_portid, state.Groups can be received as an optional parameter NETLINK_DIAG_GROUPS.Netlink sockets cab be filtered by protocols.The socket inode number and cookie is reserved for future per-socket inforetrieving. The per-protocol filtering is also reserved for future byrequiring the sdiag_protocol to be zero.The file /proc/net/netlink doesn't provide enough information fordumping netlink sockets. It doesn't provide dst_group, dst_portid,groups above 32.v2: fix NETLINK_DIAG_MAX. Now it's equal to the last constant.Acked-by: Pavel Emelyanov Cc: "David S. Miller" Cc: Eric Dumazet Cc: Pablo Neira Ayuso Cc: "Eric W. Biederman" Cc: Gao feng Cc: Thomas Graf Signed-off-by: Andrey Vagin Signed-off-by: David S. Miller List of files: /linux-6.15/net/netlink/Kconfig