Changes in udp_impl.h

dc97391e - sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)

Fri, 23 Jun 2023 22:55:12 +0000

sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)Remove ->sendpage() and ->sendpage_locked(). sendmsg() withMSG_SPLICE_PAGES should be used instead. This allows multiple pages andmultipage folios to be passed through.Signed-off-by: David Howells Acked-by: Marc Kleine-Budde # for net/cancc: Jens Axboe cc: Matthew Wilcox cc: linux-afs@lists.infradead.orgcc: mptcp@lists.linux.devcc: rds-devel@oss.oracle.comcc: tipc-discussion@lists.sourceforge.netcc: virtualization@lists.linux-foundation.orgLink: https://lore.kernel.org/r/20230623225513.2732256-16-dhowells@redhat.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/ipv4/udp_impl.h

ec095263 - net: remove noblock parameter from recvmsg() entities

Mon, 11 Apr 2022 12:49:55 +0000

net: remove noblock parameter from recvmsg() entitiesThe internal recvmsg() functions have two parameters 'flags' and 'noblock'that were merged inside skb_recv_datagram(). As a follow up patch to commitf4b41f062c42 ("net: remove noblock parameter from skb_recv_datagram()")this patch removes the separate 'noblock' parameter for recvmsg().Analogue to the referenced patch for skb_recv_datagram() the 'flags' and'noblock' parameters are unnecessarily split up with e.g.err = sk->sk_prot->recvmsg(sk, msg, size, flags & MSG_DONTWAIT, flags & ~MSG_DONTWAIT, &addr_len);or inerr = INDIRECT_CALL_2(sk->sk_prot->recvmsg, tcp_recvmsg, udp_recvmsg, sk, msg, size, flags & MSG_DONTWAIT, flags & ~MSG_DONTWAIT, &addr_len);instead of simply using only flags all the time and check for MSG_DONTWAITwhere needed (to preserve for the formerly separated no(n)block condition).Signed-off-by: Oliver Hartkopp Link: https://lore.kernel.org/r/20220411124955.154876-1-socketcan@hartkopp.netSigned-off-by: Paolo Abeni List of files: /linux-6.15/net/ipv4/udp_impl.h

a7b75c5a - net: pass a sockptr_t into ->setsockopt

Thu, 23 Jul 2020 06:09:07 +0000

net: pass a sockptr_t into ->setsockoptRework the remaining setsockopt code to pass a sockptr_t instead of aplain user pointer. This removes the last remaining set_fs(KERNEL_DS)outside of architecture specific code.Signed-off-by: Christoph Hellwig Acked-by: Stefan Schmidt [ieee802154]Acked-by: Matthieu Baerts Signed-off-by: David S. Miller List of files: /linux-6.15/net/ipv4/udp_impl.h

b6238c04 - net/ipv4: remove compat_ip_{get,set}sockopt

Fri, 17 Jul 2020 06:23:26 +0000

net/ipv4: remove compat_ip_{get,set}sockoptHandle the few cases that need special treatment in-line usingin_compat_syscall().Signed-off-by: Christoph Hellwig Signed-off-by: David S. Miller List of files: /linux-6.15/net/ipv4/udp_impl.h

8f6b5392 - udp: add missing rehash callback to udplite

Wed, 16 Jan 2019 16:17:44 +0000

udp: add missing rehash callback to udpliteAfter commit 4cdeeee9252a ("net: udp: prefer listeners bound to anaddress"), UDP-Lite only works when specifying a local address forthe sockets.This is related to the problem addressed in the commit 719f835853a9("udp: add rehash on connect()"). Moreover, __udp4_lib_lookup() nowlooks for a socket immediately in the secondary hash table.The issue was found with LTP/network tests (UDP-Lite test-cases).Fixes: 4cdeeee9252a ("net: udp: prefer listeners bound to an address")Signed-off-by: Alexey Kodanev Reviewed-by: Eric Dumazet Signed-off-by: David S. Miller List of files: /linux-6.15/net/ipv4/udp_impl.h

32bbd879 - net: Convert protocol error handlers from void to int

Thu, 08 Nov 2018 11:19:21 +0000

net: Convert protocol error handlers from void to intWe'll need this to handle ICMP errors for tunnels without a sending socket(i.e. FoU and GUE). There, we might have to look up different types of IPtunnels, registered as network protocols, before we get a match, so wewant this for the error handlers of IPPROTO_IPIP and IPPROTO_IPV6 in bothinet_protos and inet6_protos. These error codes will be used in the nextpatch.For consistency, return sensible error codes in protocol error handlerswhenever handlers can't handle errors because, even if valid, they don'tmatch a protocol or any of its states.This has no effect on existing error handling paths.Signed-off-by: Stefano Brivio Reviewed-by: Sabrina Dubroca Signed-off-by: David S. Miller List of files: /linux-6.15/net/ipv4/udp_impl.h

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/net/ipv4/udp_impl.h

a3f96c47 - udp: make udp_queue_rcv_skb() functions static

Wed, 17 May 2017 12:52:16 +0000

udp: make *udp*_queue_rcv_skb() functions staticSince the udp memory accounting refactor, we don't need any moreto export the *udp*_queue_rcv_skb(). Make them static and fixa couple of sparse warnings:net/ipv4/udp.c:1615:5: warning: symbol 'udp_queue_rcv_skb' was notdeclared. Should it be static?net/ipv6/udp.c:572:5: warning: symbol 'udpv6_queue_rcv_skb' was notdeclared. Should it be static?Fixes: 850cbaddb52d ("udp: use it's own memory accounting schema")Fixes: c915fe13cbaa ("udplite: fix NULL pointer dereference")Signed-off-by: Paolo Abeni Signed-off-by: David S. Miller List of files: /linux-6.15/net/ipv4/udp_impl.h

30c7be26 - udplite: call proper backlog handlers

Tue, 22 Nov 2016 17:06:45 +0000

udplite: call proper backlog handlersIn commits 93821778def10 ("udp: Fix rcv socket locking") andf7ad74fef3af ("net/ipv6/udp: UDP encapsulation: break backlog_rcv into__udpv6_queue_rcv_skb") UDP backlog handlers were renamed, but UDPlitewas forgotten.This leads to crashes if UDPlite header is pulled twice, which happensstarting from commit e6afc8ace6dd ("udp: remove headers from UDP packetsbefore queueing")Bug found by syzkaller team, thanks a lot guys !Note that backlog use in UDP/UDPlite is scheduled to be removed startingfrom linux-4.10, so this patch is only needed up to linux-4.9Fixes: 93821778def1 ("udp: Fix rcv socket locking")Fixes: f7ad74fef3af ("net/ipv6/udp: UDP encapsulation: break backlog_rcv into __udpv6_queue_rcv_skb")Fixes: e6afc8ace6dd ("udp: remove headers from UDP packets before queueing")Signed-off-by: Eric Dumazet Reported-by: Andrey Konovalov Cc: Benjamin LaHaise Cc: Herbert Xu Signed-off-by: David S. Miller List of files: /linux-6.15/net/ipv4/udp_impl.h

1b784140 - net: Remove iocb argument from sendmsg and recvmsg

Mon, 02 Mar 2015 07:37:48 +0000

net: Remove iocb argument from sendmsg and recvmsgAfter TIPC doesn't depend on iocb argument in its internalimplementations of sendmsg() and recvmsg() hooks defined in protostructure, no any user is using iocb argument in them at all now.Then we can drop the redundant iocb argument completely from kinds ofimplementations of both sendmsg() and recvmsg() in the entirenetworking stack.Cc: Christoph Hellwig Suggested-by: Al Viro Signed-off-by: Ying Xue Signed-off-by: David S. Miller List of files: /linux-6.15/net/ipv4/udp_impl.h

7e58487b - net: ipv4/ipv6: Remove extern from function prototypes

Fri, 18 Oct 2013 20:48:24 +0000

net: ipv4/ipv6: Remove extern from function prototypesThere are a mix of function prototypes with and without externin the kernel sources. Standardize on not using extern forfunction prototypes.Function prototypes don't need to be written with extern.extern is assumed by the compiler. Its use is as unnecessary asusing auto to declare automatic/local variables in a block.Signed-off-by: Joe Perches Signed-off-by: David S. Miller List of files: /linux-6.15/net/ipv4/udp_impl.h

5e73ea1a - ipv4: fix checkpatch errors

Sun, 15 Apr 2012 01:34:41 +0000

ipv4: fix checkpatch errorsFix checkpatch errors of the following type: * ERROR: "foo * bar" should be "foo *bar" * ERROR: "(foo*)" should be "(foo *)"Signed-off-by: Daniel Baluta Signed-off-by: David S. Miller List of files: /linux-6.15/net/ipv4/udp_impl.h

b7058842 - net: Make setsockopt() optlen be unsigned.

Wed, 30 Sep 2009 23:12:20 +0000

net: Make setsockopt() optlen be unsigned.This provides safety against negative optlen at the typelevel instead of depending upon (sometimes non-trivial)checks against this sprinkled all over the the place, ineach and every implementation.Based upon work done by Arjan van de Ven and feedbackfrom Linus Torvalds.Signed-off-by: David S. Miller List of files: /linux-6.15/net/ipv4/udp_impl.h

645ca708 - udp: introduce struct udp_table and multiple spinlocks

Wed, 29 Oct 2008 08:41:45 +0000

udp: introduce struct udp_table and multiple spinlocksUDP sockets are hashed in a 128 slots hash table.This hash table is protected by *one* rwlock.This rwlock is readlocked each time an incoming UDP message is handled.This rwlock is writelocked each time a socket must be inserted inhash table (bind time), or deleted from this table (close time)This is not scalable on SMP machines :1) Even in read mode, lock() and unlock() are atomic operations and must dirty a contended cache line, shared by all cpus.2) A writer might be starved if many readers are 'in flight'. This can happen on a machine with some NIC receiving many UDP messages. User process can be delayed a long time at socket creation/dismantle time.This patch prepares RCU migration, by introducing 'struct udp_tableand struct udp_hslot', and using one spinlock per chain, to reducecontention on central rwlock.Introducing one spinlock per chain reduces latencies, for portrandomization on heavily loaded UDP servers. This also speedupbindings to specific ports.udp_lib_unhash() was uninlined, becoming to big.Some cleanups were done to ease review of following patch(RCUification of UDP Unicast lookups)Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller List of files: /linux-6.15/net/ipv4/udp_impl.h

7d06b2e0 - net: change proto destroy method to return void

Sun, 15 Jun 2008 00:04:49 +0000

net: change proto destroy method to return voidChange struct proto destroy function pointer to return void. Noticedby Al Viro.Signed-off-by: Brian Haley Signed-off-by: David S. Miller List of files: /linux-6.15/net/ipv4/udp_impl.h

6ba5a3c5 - [UDP]: Make full use of proto.h.udp_hash innovation.

Sat, 22 Mar 2008 23:51:21 +0000

[UDP]: Make full use of proto.h.udp_hash innovation.After this we have only udp_lib_get_port to get the port and two stubs for ipv4 and ipv6. No difference in udp and udplite exceptfor initialized h.udp_hash member.I tried to find a graceful way to drop the only difference betweenudp_v4_get_port and udp_v6_get_port (i.e. the rcv_saddr comparison routine), but adding one more callback on the struct proto didn't appear such :( Maybe later.Signed-off-by: Pavel Emelyanov Signed-off-by: David S. Miller List of files: /linux-6.15/net/ipv4/udp_impl.h

32c1da70 - [UDP]: Randomize port selection.

Sat, 25 Aug 2007 06:09:41 +0000

[UDP]: Randomize port selection.This patch causes UDP port allocation to be randomized like TCP.The earlier code would always choose same port (ie first empty list).Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller List of files: /linux-6.15/net/ipv4/udp_impl.h

df2bc459 - [UDP]: Revert 2-pass hashing changes.

Tue, 05 Jun 2007 22:18:43 +0000

[UDP]: Revert 2-pass hashing changes.This reverts changesets:6aaf47fa48d3c44280810b1b470261d340e4ed87b7b5f487ab39bc10ed0694af35651a03d9cb97ffde34ed91c4ffa4727964a832c46e624dd1495cf5fc038410b4b1643766f8033f4940bcdb1dace633There are still some correctness issues recentlydiscovered which do not have a known fix that doesn'tinvolve doing a full hash table scan on port bind.So revert for now.Signed-off-by: David S. Miller List of files: /linux-6.15/net/ipv4/udp_impl.h

fc038410 - [UDP]: Fix AF-specific references in AF-agnostic code.

Wed, 09 May 2007 23:42:20 +0000

[UDP]: Fix AF-specific references in AF-agnostic code.__udp_lib_port_inuse() cannot make direct references toinet_sk(sk)->rcv_saddr as that is ipv4 specific state andthis code is used by ipv6 too.Use an operations vector to solve this, and this also pavesthe way for ipv6 support for non-wild saddr hashing in UDP.Signed-off-by: David S. Miller List of files: /linux-6.15/net/ipv4/udp_impl.h

e905a9ed - [NET] IPV4: Fix whitespace errors.

Fri, 09 Feb 2007 14:24:47 +0000

[NET] IPV4: Fix whitespace errors.Signed-off-by: YOSHIFUJI Hideaki Signed-off-by: David S. Miller List of files: /linux-6.15/net/ipv4/udp_impl.h