Changes in user.c

2deaf7f4 - bpf: Add BPF_SOCK_OPS_TSTAMP_SND_HW_CB callback

Thu, 20 Feb 2025 07:29:36 +0000

bpf: Add BPF_SOCK_OPS_TSTAMP_SND_HW_CB callbackSupport hw SCM_TSTAMP_SND case for bpf timestamping.Add a new sock_ops callback, BPF_SOCK_OPS_TSTAMP_SND_HW_CB. Thiscallback will occur at the same timestamping point as the userspace's hardware SCM_TSTAMP_SND. The BPF program can use it toget the same SCM_TSTAMP_SND timestamp without modifying theuser-space application.To avoid increasing the code complexity, replace SKBTX_HW_TSTAMPwith SKBTX_HW_TSTAMP_NOBPF instead of changing numerous callersfrom driver side using SKBTX_HW_TSTAMP. The new definition ofSKBTX_HW_TSTAMP means the combination tests of socket timestampingand bpf timestamping. After this patch, drivers can work under thebpf timestamping.Considering some drivers don't assign the skb with hardwaretimestamp, this patch does the assignment and then BPF programcan acquire the hwstamp from skb directly.Signed-off-by: Jason Xing Signed-off-by: Martin KaFai Lau Reviewed-by: Willem de Bruijn Link: https://patch.msgid.link/20250220072940.99994-9-kerneljasonxing@gmail.com List of files: /linux-6.15/net/dsa/user.c

b8927bd4 - net: dsa: allow use of phylink managed EEE support

Mon, 10 Feb 2025 10:36:49 +0000

net: dsa: allow use of phylink managed EEE supportIn order to allow DSA drivers to use phylink managed EEE, we need tochange the behaviour of the DSA's .set_eee() ethtool method.Implementation of the DSA .set_mac_eee() method becomes optional withphylink managed EEE as it is only used to validate the EEE parameterssupplied from userspace. The rest of the EEE state management shouldbe left to phylink.Signed-off-by: Russell King (Oracle) Link: https://patch.msgid.link/E1thR9l-003vXC-9F@rmk-PC.armlinux.org.ukSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/user.c

4b0a3ffa - net: dsa: implement get_ts_stats ethtool operation for user ports

Thu, 16 Jan 2025 10:46:26 +0000

net: dsa: implement get_ts_stats ethtool operation for user portsIntegrate with the standard infrastructure for reporting hardware packettimestamping statistics.Signed-off-by: Vladimir Oltean Reviewed-by: Jakub Kicinski Link: https://patch.msgid.link/20250116104628.123555-3-vladimir.oltean@nxp.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/user.c

60c6e3a5 - net: dsa: no longer call ds->ops->get_mac_eee()

Mon, 06 Jan 2025 11:58:53 +0000

net: dsa: no longer call ds->ops->get_mac_eee()All implementations of get_mac_eee() now just return zero without doinganything useful. Remove the call to this method in preparation toremoving the method from each DSA driver.Signed-off-by: Russell King (Oracle) Link: https://patch.msgid.link/E1tUlkz-007Uyl-UA@rmk-PC.armlinux.org.ukSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/user.c

88325a29 - net: dsa: require .support_eee() method to be implemented

Tue, 10 Dec 2024 14:18:52 +0000

net: dsa: require .support_eee() method to be implementedNow that we have updated all drivers, switch DSA to require animplementation of the .support_eee() method for EEE to be usable,rather than defaulting to being permissive when not implemented.Signed-off-by: Russell King (Oracle) Reviewed-by: Florian Fainelli Reviewed-by: Vladimir Oltean Link: https://patch.msgid.link/E1tL14e-006cZy-AT@rmk-PC.armlinux.org.ukSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/user.c

9723a773 - net: dsa: add hook to determine whether EEE is supported

Tue, 10 Dec 2024 14:18:16 +0000

net: dsa: add hook to determine whether EEE is supportedAdd a hook to determine whether the switch supports EEE. This willreturn false if the switch does not, or true if it does. If themethod is not implemented, we assume (currently) that the switchsupports EEE.Signed-off-by: Russell King (Oracle) Reviewed-by: Florian Fainelli Reviewed-by: Vladimir Oltean Link: https://patch.msgid.link/E1tL144-006cZD-El@rmk-PC.armlinux.org.ukSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/user.c

66c36639 - net: dsa: remove check for dp->pl in EEE methods

Tue, 10 Dec 2024 14:18:11 +0000

net: dsa: remove check for dp->pl in EEE methodsWhen user ports are initialised, a phylink instance is always created,and so dp->pl will always be non-NULL. The EEE methods are only usedfor user ports, so checking for dp->pl to be NULL makes no sense. Noother phylink-calling method implements similar checks in DSA. Removethis unnecessary check.Signed-off-by: Russell King (Oracle) Reviewed-by: Florian Fainelli Reviewed-by: Vladimir Oltean Link: https://patch.msgid.link/E1tL13z-006cZ7-BZ@rmk-PC.armlinux.org.ukSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/user.c

be325f08 - rtnetlink: add ndo_fdb_dump_context

Mon, 09 Dec 2024 10:07:45 +0000

rtnetlink: add ndo_fdb_dump_contextrtnl_fdb_dump() and various ndo_fdb_dump() helpers sharea hidden layout of cb->ctx.Before switching rtnl_fdb_dump() to for_each_netdev_dump()in the following patch, make this more explicit.Signed-off-by: Eric Dumazet Reviewed-by: Ido Schimmel Reviewed-by: Kuniyuki Iwashima Link: https://patch.msgid.link/20241209100747.2269613-2-edumazet@google.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/user.c

f12b3638 - net: dsa: use ethtool string helpers

Mon, 28 Oct 2024 04:48:28 +0000

net: dsa: use ethtool string helpersThese are the preferred way to copy ethtool strings.Avoids incrementing pointers all over the place.Signed-off-by: Rosen Penev (for hellcreek driver)Reviewed-by: Kurt Kanzenbach Link: https://patch.msgid.link/20241028044828.1639668-1-rosenp@gmail.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/user.c

3535d70d - net: dsa: allow matchall mirroring rules towards the CPU

Wed, 23 Oct 2024 13:52:50 +0000

net: dsa: allow matchall mirroring rules towards the CPUIf the CPU bandwidth capacity permits, it may be useful to mirror theentire ingress of a user port to software.This is in fact possible to express even if there is no net_devicerepresentation for the CPU port. In fact, that approach was alreadyexhausted and that representation wouldn't have even helped [1].The idea behind implementing this is that currently, we refuse tooffload any mirroring towards a non-DSA target net_device. But if weacknowledge the fact that to reach any foreign net_device, the switchmust send the packet to the CPU anyway, then we can simply offload justthat part, and let the software do the rest. There is only one conditionwe need to uphold: the filter needs to be present in the software datapath as well (no skip_sw).There are 2 actions to consider: FLOW_ACTION_MIRRED (redirect to egressof target interface) and FLOW_ACTION_MIRRED_INGRESS (redirect to ingressof target interface). We don't have the ability/API to offloadFLOW_ACTION_MIRRED_INGRESS when the target port is also a DSA user port,but we could also permit that through mirred to the CPU + software.Example:$ ip link add dummy0 type dummy; ip link set dummy0 up$ tc qdisc add dev swp0 clsact$ tc filter add dev swp0 ingress matchall action mirred ingress mirror dev dummy0Any DSA driver with a ds->ops->port_mirror_add() implementation can nowmake use of this with no additional change.[1] https://lore.kernel.org/netdev/20191002233750.13566-1-olteanv@gmail.com/Signed-off-by: Vladimir Oltean Link: https://patch.msgid.link/20241023135251.1752488-6-vladimir.oltean@nxp.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/user.c

4cc4394a - net: dsa: add more extack messages in dsa_user_add_cls_matchall_mirred()

Wed, 23 Oct 2024 13:52:49 +0000

net: dsa: add more extack messages in dsa_user_add_cls_matchall_mirred()Do not leave -EOPNOTSUPP errors without an explanation. It is confusingfor the user to figure out what is wrong otherwise.Signed-off-by: Vladimir Oltean Link: https://patch.msgid.link/20241023135251.1752488-5-vladimir.oltean@nxp.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/user.c

c11ace14 - net: dsa: use "extack" as argument to flow_action_basic_hw_stats_check()

Wed, 23 Oct 2024 13:52:48 +0000

net: dsa: use "extack" as argument to flow_action_basic_hw_stats_check()We already have an "extack" stack variable indsa_user_add_cls_matchall_police() anddsa_user_add_cls_matchall_mirred(), there is no need to retrieveit again from cls->common.extack.Signed-off-by: Vladimir Oltean Link: https://patch.msgid.link/20241023135251.1752488-4-vladimir.oltean@nxp.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/user.c

a0af7162 - net: dsa: clean up dsa_user_add_cls_matchall()

Wed, 23 Oct 2024 13:52:47 +0000

net: dsa: clean up dsa_user_add_cls_matchall()The body is a bit hard to read, hard to extend, and has duplicatedconditions.Clean up the "if (many conditions) else if (many conditions, someof them repeated)" pattern by:- Moving the repeated conditions out- Replacing the repeated tests for the same variable with a switch/case- Moving the protocol check inside the dsa_user_add_cls_matchall_mirred() function call.This is pure refactoring, no logic has been changed, though some testswere reordered. The order does not matter - they are independent thingsto be tested for.Signed-off-by: Vladimir Oltean Link: https://patch.msgid.link/20241023135251.1752488-3-vladimir.oltean@nxp.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/user.c

e44ef3f6 - netpoll: remove ndo_netpoll_setup() second argument

Fri, 18 Oct 2024 05:21:08 +0000

netpoll: remove ndo_netpoll_setup() second argumentnpinfo is not used in any of the ndo_netpoll_setup() methods.Signed-off-by: Eric Dumazet Reviewed-by: Simon Horman Link: https://patch.msgid.link/20241018052108.2610827-1-edumazet@google.comSigned-off-by: Paolo Abeni List of files: /linux-6.15/net/dsa/user.c

8c924369 - net: dsa: refuse cross-chip mirroring operations

Tue, 08 Oct 2024 09:43:20 +0000

net: dsa: refuse cross-chip mirroring operationsIn case of a tc mirred action from one switch to another, the behavioris not correct. We simply tell the source switch driver to program amirroring entry towards mirror->to_local_port = to_dp->index, but it isnot even guaranteed that the to_dp belongs to the same switch as dp.For proper cross-chip support, we would need to go through thecross-chip notifier layer in switch.c, program the entry on cascadeports, and introduce new, explicit API for cross-chip mirroring, giventhat intermediary switches should have introspection into the DSA tagspassed through the cascade port (and not just program a port mirror onthe entire cascade port). None of that exists today.Reject what is not implemented so that user space is not misled intothinking it works.Fixes: f50f212749e8 ("net: dsa: Add plumbing for port mirroring")Signed-off-by: Vladimir Oltean Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/20241008094320.3340980-1-vladimir.oltean@nxp.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/user.c

00d066a4 - netdev_features: convert NETIF_F_LLTX to dev->lltx

Thu, 29 Aug 2024 12:33:37 +0000

netdev_features: convert NETIF_F_LLTX to dev->lltxNETIF_F_LLTX can't be changed via Ethtool and is not a feature,rather an attribute, very similar to IFF_NO_QUEUE (and hot).Free one netdev_features_t bit and make it a "hot" private flag.Signed-off-by: Alexander Lobakin Signed-off-by: Paolo Abeni List of files: /linux-6.15/net/dsa/user.c

2111375b - net: Add struct kernel_ethtool_ts_info

Tue, 09 Jul 2024 13:53:38 +0000

net: Add struct kernel_ethtool_ts_infoIn prevision to add new UAPI for hwtstamp we will be limited to the structethtool_ts_info that is currently passed in fixed binary format through theETHTOOL_GET_TS_INFO ethtool ioctl. It would be good if new kernel codealready started operating on an extensible kernel variant of thatstructure, similar in concept to struct kernel_hwtstamp_config vs structhwtstamp_config.Since struct ethtool_ts_info is in include/uapi/linux/ethtool.h, herewe introduce the kernel-only structure in include/linux/ethtool.h.The manual copy is then made in the function called by ETHTOOL_GET_TS_INFO.Acked-by: Shannon Nelson Acked-by: Alexandra Winter Signed-off-by: Kory Maincent Link: https://patch.msgid.link/20240709-feature_ptp_netnext-v17-6-b5317f50df2a@bootlin.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/user.c

eef8e906 - net: dsa: update the unicast MAC address when changing conduit

Wed, 05 Jun 2024 13:33:29 +0000

net: dsa: update the unicast MAC address when changing conduitWhen changing DSA user interface conduit while the user interface is up,DSA exhibits different behavior in comparison to when the interface isdown. This different behavior concerns the primary unicast MAC addressstored in the port standalone FDB and in the conduit device UC database.If we put a switch port down while changing the conduit with ip link set sw0p0 down ip link set sw0p0 type dsa conduit conduit1 ip link set sw0p0 upwe delete the address in dsa_user_close() and install the (possiblydifferent) address in dsa_user_open().But when changing the conduit on the fly, the old address is notdeleted and the new one is not installed.Since we explicitly want to support live-changing the conduit, uninstallthe old address before calling dsa_port_assign_conduit() and install the(possibly different) new address after the call.Because conduit change might also trigger address change (the userinterface is supposed to inherit the conduit interface MAC address if noaddress is defined in hardware (dp->mac is a zero address)), move theeth_hw_addr_inherit() call from dsa_user_change_conduit() todsa_port_change_conduit(), just before installing the new address.Although this is in theory a flaw in DSA core, it needs not bebackported, since there is currently no DSA driver that can be affectedby this. The only DSA driver that supports changing conduit is felix,and, as explained by Vladimir Oltean [1]: There are 2 reasons why with felix the bug does not manifest itself. First is because both the 'ocelot' and the alternate 'ocelot-8021q' tagging protocols have the 'promisc_on_conduit = true' flag. So the unicast address doesn't have to be in the conduit's RX filter - neither the old or the new conduit. Second, dsa_user_host_uc_install() theoretically leaves behind host FDB entries installed towards the wrong (old) CPU port. But in felix_fdb_add(), we treat any FDB entry requested towards any CPU port as if it was a multicast FDB entry programmed towards _all_ CPU ports. For that reason, it is installed towards the port mask of the PGID_CPU port group ID: if (dsa_port_is_cpu(dp)) port = PGID_CPU;Therefore no Fixes tag for this change.[1] https://lore.kernel.org/netdev/20240507201827.47suw4fwcjrbungy@skbuf/Signed-off-by: Marek Behún Reviewed-by: Vladimir Oltean Tested-by: Vladimir Oltean Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/user.c

77f75412 - net: dsa: deduplicate code adding / deleting the port address to fdb

Wed, 05 Jun 2024 13:33:28 +0000

net: dsa: deduplicate code adding / deleting the port address to fdbThe sequence if (dsa_switch_supports_uc_filtering(ds)) dsa_port_standalone_host_fdb_add(dp, addr, 0); if (!ether_addr_equal(addr, conduit->dev_addr)) dev_uc_add(conduit, addr);is executed both in dsa_user_open() and dsa_user_set_mac_addr().Its reverse is executed both in dsa_user_close() anddsa_user_set_mac_addr().Refactor these sequences into new functions dsa_user_host_uc_install()and dsa_user_host_uc_uninstall().Signed-off-by: Marek Behún Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/user.c

5f5109af - net: dsa: add support switches global DSCP priority mapping

Fri, 03 May 2024 13:13:49 +0000

net: dsa: add support switches global DSCP priority mappingSome switches like Microchip KSZ variants do not support per port DSCPpriority configuration. Instead there is a global DSCP mapping table.To handle it, we will accept set/del request to any of user ports tomake global configuration and update dcb app entries for all otherports.Signed-off-by: Oleksij Rempel Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/user.c