Changes in Makefile

6c87e1a4 - net: dsa: vsc73xx: introduce tag 8021q for vsc73xx

Sat, 13 Jul 2024 21:16:13 +0000

net: dsa: vsc73xx: introduce tag 8021q for vsc73xxThis commit introduces a new tagger based on 802.1q tagging.It's designed for the vsc73xx driver. The VSC73xx family doesn't haveany tag support for the RGMII port, but it could be based on VLANs.Reviewed-by: Florian Fainelli Reviewed-by: Vladimir Oltean Signed-off-by: Pawel Dembicki Reviewed-by: Linus Walleij Link: https://patch.msgid.link/20240713211620.1125910-8-paweldembicki@gmail.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Makefile

6ca80638 - net: dsa: Use conduit and user terms

Mon, 23 Oct 2023 18:17:28 +0000

net: dsa: Use conduit and user termsUse more inclusive terms throughout the DSA subsystem by moving awayfrom "master" which is replaced by "conduit" and "slave" which isreplaced by "user". No functional changes.Acked-by: Rob Herring Acked-by: Stephen Hemminger Reviewed-by: Vladimir Oltean Signed-off-by: Florian Fainelli Link: https://lore.kernel.org/r/20231023181729.1191071-2-florian.fainelli@broadcom.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Makefile

9538ebce - net: dsa: add trace points for FDB/MDB operations

Fri, 07 Apr 2023 14:14:50 +0000

net: dsa: add trace points for FDB/MDB operationsDSA performs non-trivial housekeeping of unicast and multicast addresseson shared (CPU and DSA) ports, and puts a bit of pressure on higherlayers, requiring them to behave correctly (remove these addressesexactly as many times as they were added). Otherwise, either addresseslinger around forever, or DSA returns -ENOENT complaining that entriesthat were already deleted must be deleted again.To aid debugging, introduce some trace points specifically for FDB andMDB - that's where some of the bugs still are right now.Some bugs I have seen were also due to race conditions, see:- 630fd4822af2 ("net: dsa: flush switchdev workqueue on bridge join error path")- a2614140dc0f ("net: dsa: mv88e6xxx: flush switchdev FDB workqueue before removing VLAN")so it would be good to not disturb the timing too much, hence the choiceto use trace points vs regular dev_dbg().I've had these for some time on my computer in a less polished form, andthey've proven useful. What I found most useful was to enableCONFIG_BOOTTIME_TRACING, add "trace_event=dsa" to the kernel cmdline,and run "cat /sys/kernel/debug/tracing/trace". This is to debug morecomplex environments with network managers started by the init system,things like that.Signed-off-by: Vladimir Oltean Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Makefile

5a178186 - net: dsa: replace NETDEV_PRE_CHANGE_HWTSTAMP notifier with a stub

Thu, 06 Apr 2023 11:42:46 +0000

net: dsa: replace NETDEV_PRE_CHANGE_HWTSTAMP notifier with a stubThere was a sort of rush surrounding commit 88c0a6b503b7 ("net: create anetdev notifier for DSA to reject PTP on DSA master"), due to a desireto convert DSA's attempt to deny TX timestamping on a DSA master tosomething that doesn't block the kernel-wide API conversion fromndo_eth_ioctl() to ndo_hwtstamp_set().What was required was a mechanism that did not depend on ndo_eth_ioctl(),and what was provided was a mechanism that did not depend onndo_eth_ioctl(), while at the same time introducing something thatwasn't absolutely necessary - a new netdev notifier.There have been objections from Jakub Kicinski that using notifiers ingeneral when they are not absolutely necessary creates complications tothe control flow and difficulties to maintainers who look at the code.So there is a desire to not use notifiers.In addition to that, the notifier chain gets called even if there is noDSA in the system and no one is interested in applying any restriction.Take the model of udp_tunnel_nic_ops and introduce a stub mechanism,through which net/core/dev_ioctl.c can call into DSA even whenCONFIG_NET_DSA=m.Compared to the code that existed prior to the notifier conversion, akawhat was added in commits:- 4cfab3566710 ("net: dsa: Add wrappers for overloaded ndo_ops")- 3369afba1e46 ("net: Call into DSA netdevice_ops wrappers")this is different because we are not overloading any structnet_device_ops of the DSA master anymore, but rather, we are exposing arather specific functionality which is orthogonal to which API is usedto enable it - ndo_eth_ioctl() or ndo_hwtstamp_set().Also, what is similar is that both approaches use function pointers toget from built-in code to DSA.There is no point in replicating the function pointers towards__dsa_master_hwtstamp_validate() once for every CPU port (dev->dsa_ptr).Instead, it is sufficient to introduce a singleton struct dsa_stubs,built into the kernel, which contains a single function pointer to__dsa_master_hwtstamp_validate().I find this approach preferable to what we had originally, becausedev->dsa_ptr->netdev_ops->ndo_do_ioctl() used to require going throughstruct dsa_port (dev->dsa_ptr), and so, this was incompatible with anyattempts to add any data encapsulation and hide DSA data structures fromthe outside world.Link: https://lore.kernel.org/netdev/20230403083019.120b72fd@kernel.org/Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Makefile

47d2ce03 - net: dsa: rename dsa2.c back into dsa.c and create its header

Mon, 21 Nov 2022 13:55:52 +0000

net: dsa: rename dsa2.c back into dsa.c and create its headerThe previous change moved the code into the larger file (dsa2.c) tominimize the delta. Rename that now to dsa.c, and create dsa.h, whereall related definitions from dsa_priv.h go.Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Signed-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Makefile

165c2fb9 - net: dsa: merge dsa.c into dsa2.c

Mon, 21 Nov 2022 13:55:51 +0000

net: dsa: merge dsa.c into dsa2.cThere is no longer a meaningful distinction between what goes intodsa2.c and what goes into dsa.c. Merge the 2 into a single file.Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Signed-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Makefile

bd954b82 - net: dsa: move tagging protocol code to tag.{c,h}

Mon, 21 Nov 2022 13:55:47 +0000

net: dsa: move tagging protocol code to tag.{c,h}It would be nice if tagging protocol drivers could include just theheader they need, since they are (mostly) data path and isolated frommost of the other DSA core code does.Create a tag.c and a tag.h file which are meant to support taggingprotocol drivers.Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Signed-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Makefile

5cf2c75b - net: dsa: move bulk of devlink code to devlink.{c,h}

Mon, 21 Nov 2022 13:55:41 +0000

net: dsa: move bulk of devlink code to devlink.{c,h}dsa.c and dsa2.c are bloated with too much off-topic code. Identify allcode related to devlink and move it to a new devlink.c file.Steer clear of the dsa_priv.h dumping ground antipattern and create adedicated devlink.h for it, which will be included only by the C fileswhich need it. Usage of dsa_priv.h will be minimized in later patches.Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Signed-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Makefile

d2be3204 - net: dsa: modularize DSA_TAG_PROTO_NONE

Mon, 21 Nov 2022 13:55:40 +0000

net: dsa: modularize DSA_TAG_PROTO_NONEThere is no reason that I can see why the no-op tagging protocol shouldbe registered manually, so make it a module and make all drivers whichhave any sort of reference to DSA_TAG_PROTO_NONE select it.Note that I don't know if ksz_get_tag_protocol() really needs this,or if it's just the logic which is poorly written. All switches seem tohave their own tagging protocol, and DSA_TAG_PROTO_NONE is just afallback that never gets used.Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Signed-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Makefile

95f510d0 - net: dsa: allow the DSA master to be seen and changed through rtnetlink

Sun, 11 Sep 2022 01:06:59 +0000

net: dsa: allow the DSA master to be seen and changed through rtnetlinkSome DSA switches have multiple CPU ports, which can be used to improveCPU termination throughput, but DSA, through dsa_tree_setup_cpu_ports(),sets up only the first one, leading to suboptimal use of hardware.The desire is to not change the default configuration but to permit theuser to create a dynamic mapping between individual user ports and theCPU port that they are served by, configurable through rtnetlink. It isalso intended to permit load balancing between CPU ports, and in thatcase, the foreseen model is for the DSA master to be a bonding interfacewhose lowers are the physical DSA masters.To that end, we create a struct rtnl_link_ops for DSA user ports withthe "dsa" kind. We expose the IFLA_DSA_MASTER link attribute thatcontains the ifindex of the newly desired DSA master.Signed-off-by: Vladimir Oltean Signed-off-by: Paolo Abeni List of files: /linux-6.15/net/dsa/Makefile

a08d6a6d - net: dsa: add Renesas RZ/N1 switch tag driver

Fri, 24 Jun 2022 14:39:48 +0000

net: dsa: add Renesas RZ/N1 switch tag driverThe switch that is present on the Renesas RZ/N1 SoC uses a specificVLAN value followed by 6 bytes which contains forwarding configuration.Signed-off-by: Clément Léger Reviewed-by: Vladimir Oltean Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Makefile

1521d5ad - net: dsa: tag_rtl8_4: add realtek 8 byte protocol 4 tag

Mon, 18 Oct 2021 09:38:00 +0000

net: dsa: tag_rtl8_4: add realtek 8 byte protocol 4 tagThis commit implements a basic version of the 8 byte tag protocol usedin the Realtek RTL8365MB-VC unmanaged switch, which carries with it aprotocol version of 0x04.The implementation itself only handles the parsing of the EtherTypevalue and Realtek protocol version, together with the source ordestination port fields. The rest is left unimplemented for now.The tag format is described in a confidential document provided to mycompany by Realtek Semiconductor Corp. Permission has been granted bythe vendor to publish this driver based on that material, together withan extract from the document describing the tag format and its fields.It is hoped that this will help future implementors who do not haveaccess to the material but who wish to extend the functionality ofdrivers for chips which use this protocol.In addition, two possible values of the REASON field are specified,based on experiments on my end. Realtek does not specify what value thisfield can take.Signed-off-by: Alvin Šipraga Reviewed-by: Vladimir Oltean Reviewed-by: Linus Walleij Reviewed-by: Florian Fainelli Tested-by: Arınç ÜNAL Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Makefile

9cb8edda - net: dsa: move NET_DSA_TAG_RTL4_A to right place in Kconfig/Makefile

Mon, 18 Oct 2021 09:37:58 +0000

net: dsa: move NET_DSA_TAG_RTL4_A to right place in Kconfig/MakefileMove things around a little so that this tag driver is alphabeticallyordered. The Kconfig file is sorted based on the tristate text.Suggested-by: Andrew Lunn Signed-off-by: Alvin Šipraga Reviewed-by: Vladimir Oltean Reviewed-by: Linus Walleij Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Makefile

8b6e638b - net: dsa: build tag_8021q.c as part of DSA core

Mon, 19 Jul 2021 17:14:47 +0000

net: dsa: build tag_8021q.c as part of DSA coreUpcoming patches will add tag_8021q related logic to switch.c andport.c, in order to allow it to make use of cross-chip notifiers.In addition, a struct dsa_8021q_context *ctx pointer will be added tostruct dsa_switch.It seems fairly low-reward to #ifdef the *ctx from struct dsa_switch andto provide shim implementations of the entire tag_8021q.c callingsurface (not even clear what to do about the tag_8021q cross-chipnotifiers to avoid compiling them). The runtime overhead for switcheswhich don't use tag_8021q is fairly small because all helpers will checkfor ds->tag_8021q_ctx being a NULL pointer and stop there.So let's make it part of dsa_core.o.Signed-off-by: Vladimir Oltean Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Makefile

7c83a7c5 - net: dsa: add a second tagger for Ocelot switches based on tag_8021q

Fri, 29 Jan 2021 01:00:08 +0000

net: dsa: add a second tagger for Ocelot switches based on tag_8021qThere are use cases for which the existing tagger, based on the NPI(Node Processor Interface) functionality, is insufficient.Namely:- Frames injected through the NPI port bypass the frame analyzer, so no source address learning is performed, no TSN stream classification, etc.- Flow control is not functional over an NPI port (PAUSE frames are encapsulated in the same Extraction Frame Header as all other frames)- There can be at most one NPI port configured for an Ocelot switch. But in NXP LS1028A and T1040 there are two Ethernet CPU ports. The non-NPI port is currently either disabled, or operated as a plain user port (albeit an internally-facing one). Having the ability to configure the two CPU ports symmetrically could pave the way for e.g. creating a LAG between them, to increase bandwidth seamlessly for the system.So there is a desire to have an alternative to the NPI mode. This changekeeps the default tagger for the Seville and Felix switches as "ocelot",but it can be changed via the following device attribute:echo ocelot-8021q > /sys/class//dsa/taggingSigned-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Signed-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Makefile

54a52823 - dsa: add support for Arrow XRS700x tag trailer

Thu, 14 Jan 2021 19:57:32 +0000

dsa: add support for Arrow XRS700x tag trailerAdd support for Arrow SpeedChips XRS700x single byte tag trailer. Thisis modeled on tag_trailer.c which works in a similar way.Signed-off-by: George McCollister Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli Reviewed-by: Vladimir Oltean Signed-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Makefile

469ee5fe - net: dsa: tag_dsa: Unify regular and ethertype DSA taggers

Sat, 14 Nov 2020 23:45:57 +0000

net: dsa: tag_dsa: Unify regular and ethertype DSA taggersEthertype DSA encodes exactly the same information in the DSA tag asthe non-ethertype variety. So refactor out the common parts and reusethem for both protocols.This is ensures tag parsing and generation is always consistent acrossall mv88e6xxx chips.While we are at it, explicitly deal with all possible CPU codes onreceive, making sure to set offload_fwd_mark as appropriate.Signed-off-by: Tobias Waldekranz Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli Signed-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Makefile

01ef09ca - net: dsa: Add tag handling for Hirschmann Hellcreek switches

Tue, 03 Nov 2020 07:10:54 +0000

net: dsa: Add tag handling for Hirschmann Hellcreek switchesThe Hirschmann Hellcreek TSN switches have a special tagging protocol for framesexchanged between the CPU port and the master interface. The format is a onebyte trailer indicating the destination or origin port.It's quite similar to the Micrel KSZ tagging. That's why the implementation isbased on that code.Signed-off-by: Kurt Kanzenbach Reviewed-by: Vladimir Oltean Signed-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Makefile

efd7fe68 - net: dsa: tag_rtl4_a: Implement Realtek 4 byte A tag

Wed, 08 Jul 2020 12:25:36 +0000

net: dsa: tag_rtl4_a: Implement Realtek 4 byte A tagThis implements the known parts of the Realtek 4 bytetag protocol version 0xA, as found in the RTL8366RBDSA switch.It is designated as protocol version 0xA as adifferent Realtek 4 byte tag format with protocolversion 0x9 is known to exist in the Realtek RTL8306chips.The tag and switch chip lacks public documentation, sothe tag format has been reverse-engineered frompacket dumps. As only ingress traffic has been availablefor analysis an egress tag has not been possible todevelop (even using educated guesses about bit fields)so this is as far as it gets. It is not known if theswitch even supports egress tagging.Excessive attempts to figure out the egress tag formatwas made. When nothing else worked, I just tried all bitcombinations with 0xannp where a is protocol and p isport. I looped through all values several times tryingto get a response from ping, without any positiveresult.Using just these ingress tags however, the switchfunctionality is vastly improved and the packets findtheir way into the destination port without anytricky VLAN configuration. On the D-Link DIR-685 theLAN ports now come up and respond to ping withoutany command line configuration so this is a realimprovement for users.Egress packets need to be restricted to the propertarget ports using VLAN, which the RTL8366RB DSAswitch driver already sets up.Cc: DENG Qingfang Cc: Mauri Sandberg Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli Signed-off-by: Linus Walleij Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Makefile

48fda74f - net: dsa: add support for Atheros AR9331 TAG format

Wed, 18 Dec 2019 08:02:14 +0000

net: dsa: add support for Atheros AR9331 TAG formatAdd support for tag format used in Atheros AR9331 built-in switch.Reviewed-by: Vivien Didelot Reviewed-by: Andrew Lunn Signed-off-by: Oleksij Rempel Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Makefile