Changes in Kconfig

6c87e1a4 - net: dsa: vsc73xx: introduce tag 8021q for vsc73xx

Sat, 13 Jul 2024 21:16:13 +0000

net: dsa: vsc73xx: introduce tag 8021q for vsc73xxThis commit introduces a new tagger based on 802.1q tagging.It's designed for the vsc73xx driver. The VSC73xx family doesn't haveany tag support for the RGMII port, but it could be based on VLANs.Reviewed-by: Florian Fainelli Reviewed-by: Vladimir Oltean Signed-off-by: Pawel Dembicki Reviewed-by: Linus Walleij Link: https://patch.msgid.link/20240713211620.1125910-8-paweldembicki@gmail.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Kconfig

983e44f0 - net: dsa: Fix typo in NET_DSA_TAG_RTL4_A Kconfig

Fri, 07 Jun 2024 02:08:43 +0000

net: dsa: Fix typo in NET_DSA_TAG_RTL4_A KconfigFix a minor typo in the help text for the NET_DSA_TAG_RTL4_A configoption.Signed-off-by: Chris Packham Reviewed-by: Andrew Lunn Reviewed-by: Luiz Angelo Daros de Luca Link: https://lore.kernel.org/r/20240607020843.1380735-1-chris.packham@alliedtelesis.co.nzSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Kconfig

d2be3204 - net: dsa: modularize DSA_TAG_PROTO_NONE

Mon, 21 Nov 2022 13:55:40 +0000

net: dsa: modularize DSA_TAG_PROTO_NONEThere is no reason that I can see why the no-op tagging protocol shouldbe registered manually, so make it a module and make all drivers whichhave any sort of reference to DSA_TAG_PROTO_NONE select it.Note that I don't know if ksz_get_tag_protocol() really needs this,or if it's just the logic which is poorly written. All switches seem tohave their own tagging protocol, and DSA_TAG_PROTO_NONE is just afallback that never gets used.Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Signed-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Kconfig

092f8751 - net: dsa: tag_ksz: add tag handling for Microchip LAN937x

Fri, 01 Jul 2022 15:00:20 +0000

net: dsa: tag_ksz: add tag handling for Microchip LAN937xThe Microchip LAN937X switches have a tagging protocol which isvery similar to KSZ tagging. So that the implementation is added totag_ksz.c and reused common APIsSigned-off-by: Prasanna Vengateshan Signed-off-by: Arun Ramadoss Reviewed-by: Vladimir Oltean Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Kconfig

a08d6a6d - net: dsa: add Renesas RZ/N1 switch tag driver

Fri, 24 Jun 2022 14:39:48 +0000

net: dsa: add Renesas RZ/N1 switch tag driverThe switch that is present on the Renesas RZ/N1 SoC uses a specificVLAN value followed by 6 bytes which contains forwarding configuration.Signed-off-by: Clément Léger Reviewed-by: Vladimir Oltean Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Kconfig

1521d5ad - net: dsa: tag_rtl8_4: add realtek 8 byte protocol 4 tag

Mon, 18 Oct 2021 09:38:00 +0000

net: dsa: tag_rtl8_4: add realtek 8 byte protocol 4 tagThis commit implements a basic version of the 8 byte tag protocol usedin the Realtek RTL8365MB-VC unmanaged switch, which carries with it aprotocol version of 0x04.The implementation itself only handles the parsing of the EtherTypevalue and Realtek protocol version, together with the source ordestination port fields. The rest is left unimplemented for now.The tag format is described in a confidential document provided to mycompany by Realtek Semiconductor Corp. Permission has been granted bythe vendor to publish this driver based on that material, together withan extract from the document describing the tag format and its fields.It is hoped that this will help future implementors who do not haveaccess to the material but who wish to extend the functionality ofdrivers for chips which use this protocol.In addition, two possible values of the REASON field are specified,based on experiments on my end. Realtek does not specify what value thisfield can take.Signed-off-by: Alvin Šipraga Reviewed-by: Vladimir Oltean Reviewed-by: Linus Walleij Reviewed-by: Florian Fainelli Tested-by: Arınç ÜNAL Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Kconfig

9cb8edda - net: dsa: move NET_DSA_TAG_RTL4_A to right place in Kconfig/Makefile

Mon, 18 Oct 2021 09:37:58 +0000

net: dsa: move NET_DSA_TAG_RTL4_A to right place in Kconfig/MakefileMove things around a little so that this tag driver is alphabeticallyordered. The Kconfig file is sorted based on the tristate text.Suggested-by: Andrew Lunn Signed-off-by: Alvin Šipraga Reviewed-by: Vladimir Oltean Reviewed-by: Linus Walleij Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Kconfig

49f885b2 - net: dsa: tag_ocelot_8021q: break circular dependency with ocelot switch lib

Tue, 12 Oct 2021 11:40:41 +0000

net: dsa: tag_ocelot_8021q: break circular dependency with ocelot switch libMichael reported that when using the "ocelot-8021q" tagging protocol,the switch driver module must be manually loaded before the taggingprotocol can be loaded/is available.This appears to be the same problem described here:https://lore.kernel.org/netdev/20210908220834.d7gmtnwrorhharna@skbuf/where due to the fact that DSA tagging protocols make use of symbolsexported by the switch drivers, circular dependencies appear and thisbreaks module autoloading.The ocelot_8021q driver needs the ocelot_can_inject() andocelot_port_inject_frame() functions from the switch library. Previouslythe wrong approach was taken to solve that dependency: shims wereprovided for the case where the ocelot switch library was compiled out,but that turns out to be insufficient, because the dependency when theswitch lib _is_ compiled is problematic too.We cannot declare ocelot_can_inject() and ocelot_port_inject_frame() asstatic inline functions, because these access I/O functions like__ocelot_write_ix() which is called by ocelot_write_rix(). Making thosestatic inline basically means exposing the whole guts of the ocelotswitch library, not ideal...We already have one tagging protocol driver which calls into the switchdriver during xmit but not using any exported symbol: sja1105_defer_xmit.We can do the same thing here: create a kthread worker and one work itemper skb, and let the switch driver itself do the register accesses tosend the skb, and then consume it.Fixes: 0a6f17c6ae21 ("net: dsa: tag_ocelot_8021q: add support for PTP timestamping")Reported-by: Michael Walle Signed-off-by: Vladimir Oltean Signed-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Kconfig

deab6b1c - net: dsa: tag_ocelot: break circular dependency with ocelot switch lib driver

Tue, 12 Oct 2021 11:40:40 +0000

net: dsa: tag_ocelot: break circular dependency with ocelot switch lib driverAs explained here:https://lore.kernel.org/netdev/20210908220834.d7gmtnwrorhharna@skbuf/DSA tagging protocol drivers cannot depend on symbols exported by switchdrivers, because this creates a circular dependency that breaks moduleautoloading.The tag_ocelot.c file depends on the ocelot_ptp_rew_op() functionexported by the common ocelot switch lib. This function looks atOCELOT_SKB_CB(skb) and computes how to populate the REW_OP field of theDSA tag, for PTP timestamping (the command: one-step/two-step, and theTX timestamp identifier).None of that requires deep insight into the driver, it is quitestateless, as it only depends upon the skb->cb. So let's make it astatic inline function and put it in include/linux/dsa/ocelot.h, afile that despite its name is used by the ocelot switch driver forpopulating the injection header too - since commit 40d3f295b5fe ("net:mscc: ocelot: use common tag parsing code with DSA").With that function declared as static inline, its body is expandedinside each call site, so the dependency is broken and the DSA taggercan be built without the switch library, upon which the felix driverdepends.Fixes: 39e5308b3250 ("net: mscc: ocelot: support PTP Sync one-step timestamping")Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Signed-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Kconfig

4ac0567e - net: dsa: sja1105: break dependency between dsa_port_is_sja1105 and switch driver

Wed, 22 Sep 2021 14:37:26 +0000

net: dsa: sja1105: break dependency between dsa_port_is_sja1105 and switch driverIt's nice to be able to test a tagging protocol with dsa_loop, but notat the cost of losing the ability of building the tagging protocol andswitch driver as modules, because as things stand, there is a circulardependency between the two. Tagging protocol drivers cannot depend onswitch drivers, that is a hard fact.The reasoning behind the blamed patch was that accessing dp->priv shouldfirst make sure that the structure behind that pointer is what we reallythink it is.Currently the "sja1105" and "sja1110" tagging protocols only operatewith the sja1105 switch driver, just like any other tagging protocol andswitch combination. The only way to mix and match them is by modifyingthe code, and this applies to dsa_loop as well (by default that usesDSA_TAG_PROTO_NONE). So while in principle there is an issue, inpractice there isn't one.Until we extend dsa_loop to allow user space configuration, treat theproblem as a non-issue and just say that DSA ports found by tag_sja1105are always sja1105 ports, which is in fact true. But keep thedsa_port_is_sja1105 function so that it's easy to patch it duringtesting, and rely on dead code elimination.Fixes: 994d2cbb08ca ("net: dsa: tag_sja1105: be dsa_loop-safe")Link: https://lore.kernel.org/netdev/20210908220834.d7gmtnwrorhharna@skbuf/Signed-off-by: Vladimir Oltean Signed-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Kconfig

f5aef424 - net: dsa: sja1105: break dependency between dsa_port_is_sja1105 and switch driver

Wed, 22 Sep 2021 14:37:26 +0000

net: dsa: sja1105: break dependency between dsa_port_is_sja1105 and switch driverIt's nice to be able to test a tagging protocol with dsa_loop, but notat the cost of losing the ability of building the tagging protocol andswitch driver as modules, because as things stand, there is a circulardependency between the two. Tagging protocol drivers cannot depend onswitch drivers, that is a hard fact.The reasoning behind the blamed patch was that accessing dp->priv shouldfirst make sure that the structure behind that pointer is what we reallythink it is.Currently the "sja1105" and "sja1110" tagging protocols only operatewith the sja1105 switch driver, just like any other tagging protocol andswitch combination. The only way to mix and match them is by modifyingthe code, and this applies to dsa_loop as well (by default that usesDSA_TAG_PROTO_NONE). So while in principle there is an issue, inpractice there isn't one.Until we extend dsa_loop to allow user space configuration, treat theproblem as a non-issue and just say that DSA ports found by tag_sja1105are always sja1105 ports, which is in fact true. But keep thedsa_port_is_sja1105 function so that it's easy to patch it duringtesting, and rely on dead code elimination.Fixes: 994d2cbb08ca ("net: dsa: tag_sja1105: be dsa_loop-safe")Link: https://lore.kernel.org/netdev/20210908220834.d7gmtnwrorhharna@skbuf/Signed-off-by: Vladimir Oltean Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Kconfig

994d2cbb - net: dsa: tag_sja1105: be dsa_loop-safe

Tue, 17 Aug 2021 14:58:47 +0000

net: dsa: tag_sja1105: be dsa_loop-safeAdd support for tag_sja1105 running on non-sja1105 DSA ports, by makingsure that every time we dereference dp->priv, we check the switch'sdsa_switch_ops (otherwise we access a struct sja1105_port structure thatis in fact something else).This adds an unconditional build-time dependency between sja1105 beingbuilt as module => tag_sja1105 must also be built as module. This wasthere only for PTP before.Some sane defaults must also take place when not running on sja1105hardware. These are:- sja1105_xmit_tpid: the sja1105 driver uses different VLAN protocols depending on VLAN awareness and switch revision (when an encapsulated VLAN must be sent). Default to 0x8100.- sja1105_rcv_meta_state_machine: this aggregates PTP frames with their metadata timestamp frames. When running on non-sja1105 hardware, don't do that and accept all frames unmodified.- sja1105_defer_xmit: calls sja1105_port_deferred_xmit in sja1105_main.c which writes a management route over SPI. When not running on sja1105 hardware, bypass the SPI write and send the frame as-is.Signed-off-by: Vladimir Oltean Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Kconfig

f8b17a0b - net: dsa: tag_sja1105: optionally build as module when switch driver is module if PTP is enabled

Thu, 05 Aug 2021 11:36:12 +0000

net: dsa: tag_sja1105: optionally build as module when switch driver is module if PTP is enabledTX timestamps are sent by SJA1110 as Ethernet packets containingmetadata, so they are received by the tagging driver but must beprocessed by the switch driver - the one that is stateful since itkeeps the TX timestamp queue.This means that there is an sja1110_process_meta_tstamp() symbolexported by the switch driver which is called by the tagging driver.There is a shim definition for that function when the switch driver isnot compiled, which does nothing, but that shim is not effective whenthe tagging protocol driver is built-in and the switch driver is amodule, because built-in code cannot call symbols exported by modules.So add an optional dependency between the tagger and the switch driver,if PTP support is enabled in the switch driver. If PTP is not enabled,sja1110_process_meta_tstamp() will translate into the shim "do nothingwith these meta frames" function.Fixes: 566b18c8b752 ("net: dsa: sja1105: implement TX timestamping for SJA1110")Reported-by: Arnd Bergmann Signed-off-by: Vladimir Oltean Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Kconfig

8b6e638b - net: dsa: build tag_8021q.c as part of DSA core

Mon, 19 Jul 2021 17:14:47 +0000

net: dsa: build tag_8021q.c as part of DSA coreUpcoming patches will add tag_8021q related logic to switch.c andport.c, in order to allow it to make use of cross-chip notifiers.In addition, a struct dsa_8021q_context *ctx pointer will be added tostruct dsa_switch.It seems fairly low-reward to #ifdef the *ctx from struct dsa_switch andto provide shim implementations of the entire tag_8021q.c callingsurface (not even clear what to do about the tag_8021q cross-chipnotifiers to avoid compiling them). The runtime overhead for switcheswhich don't use tag_8021q is fairly small because all helpers will checkfor ds->tag_8021q_ctx being a NULL pointer and stop there.So let's make it part of dsa_core.o.Signed-off-by: Vladimir Oltean Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Kconfig

4a52dd8f - net: selftest: fix build issue if INET is disabled

Wed, 28 Apr 2021 13:09:46 +0000

net: selftest: fix build issue if INET is disabledIn case ethernet driver is enabled and INET is disabled, selftest willfail to build.Reported-by: Randy Dunlap Fixes: 3e1e58d64c3d ("net: add generic selftest support")Signed-off-by: Oleksij Rempel Acked-by: Randy Dunlap # build-testedReviewed-by: Florian Fainelli Link: https://lore.kernel.org/r/20210428130947.29649-1-o.rempel@pengutronix.deSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Kconfig

39e5308b - net: mscc: ocelot: support PTP Sync one-step timestamping

Tue, 27 Apr 2021 04:22:03 +0000

net: mscc: ocelot: support PTP Sync one-step timestampingAlthough HWTSTAMP_TX_ONESTEP_SYNC existed in ioctl for hardware timestampconfiguration, the PTP Sync one-step timestamping had never been supported.This patch is to truely support it.- ocelot_port_txtstamp_request() This function handles tx timestamp request by storing ptp_cmd(tx timestamp type) in OCELOT_SKB_CB(skb)->ptp_cmd, and additionally for two-step timestamp storing ts_id in OCELOT_SKB_CB(clone)->ptp_cmd.- ocelot_ptp_rew_op() During xmit, this function is called to get rew_op (rewriter option) by checking skb->cb for tx timestamp request, and configure to transmitting.Non-onestep-Sync packet with one-step timestamp request falls back to usetwo-step timestamp.Signed-off-by: Yangbo Lu Acked-by: Richard Cochran Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Kconfig

a71acad9 - net: dsa: enable selftest support for all switches by default

Mon, 19 Apr 2021 13:01:06 +0000

net: dsa: enable selftest support for all switches by defaultMost of generic selftest should be able to work with probably all ethernetcontrollers. The DSA switches are not exception, so enable it by default atleast for DSA.This patch was tested with SJA1105 and AR9331.Signed-off-by: Oleksij Rempel Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Kconfig

227d7206 - dsa: simplify Kconfig symbols and dependencies

Fri, 19 Mar 2021 15:46:30 +0000

dsa: simplify Kconfig symbols and dependencies1. Remove CONFIG_HAVE_NET_DSA.CONFIG_HAVE_NET_DSA is a legacy leftover from the times when driversshould have selected CONFIG_NET_DSA manually.Currently, all drivers has explicit 'depends on NET_DSA', so this isno more needed.2. CONFIG_HAVE_NET_DSA dependencies became CONFIG_NET_DSA's ones. - dropped !S390 dependency which was introduced to be sure NET_DSA can select CONFIG_PHYLIB. DSA migrated to Phylink almost 3 years ago and the PHY library itself doesn't depend on !S390 since commit 870a2b5e4fcd ("phylib: remove !S390 dependeny from Kconfig"); - INET dependency is kept to be sure we can select NET_SWITCHDEV; - NETDEVICES dependency is kept to be sure we can select PHYLINK.3. DSA drivers menu now depends on NET_DSA.Instead on 'depends on NET_DSA' on every single driver, the entiremenu now depends on it. This eliminates a lot of duplicated linesfrom Kconfig with no loss (when CONFIG_NET_DSA=m, drivers also canbe only m or n).This also has a nice side effect that there's no more empty menu onconfigurations without DSA.4. Kbuild will now descend into 'drivers/net/dsa' only when CONFIG_NET_DSA is y or m.This is safe since no objects inside this folder can be built withoutDSA core, as well as when CONFIG_NET_DSA=m, no objects can bebuilt-in.Signed-off-by: Alexander Lobakin Reviewed-by: Vladimir Oltean Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Kconfig

964dbf18 - net: dsa: tag_brcm: add support for legacy tags

Wed, 17 Mar 2021 10:29:26 +0000

net: dsa: tag_brcm: add support for legacy tagsAdd support for legacy Broadcom tags, which are similar to DSA_TAG_PROTO_BRCM.These tags are used on BCM5325, BCM5365 and BCM63xx switches.Signed-off-by: Álvaro Fernández Rojas Signed-off-by: David S. Miller List of files: /linux-6.15/net/dsa/Kconfig

01c2c1ad - net: dsa: tag_ocelot_8021q: fix driver dependency

Thu, 25 Feb 2021 14:38:32 +0000

net: dsa: tag_ocelot_8021q: fix driver dependencyWhen the ocelot driver code is in a library, the dsa tagcode cannot be built-in:ld.lld: error: undefined symbol: ocelot_can_inject>>> referenced by tag_ocelot_8021q.c>>> dsa/tag_ocelot_8021q.o:(ocelot_xmit) in archive net/built-in.ald.lld: error: undefined symbol: ocelot_port_inject_frame>>> referenced by tag_ocelot_8021q.c>>> dsa/tag_ocelot_8021q.o:(ocelot_xmit) in archive net/built-in.aBuilding the tag support only really makes sense for compile-testingwhen the driver is available, so add a Kconfig dependency that preventsthe broken configuration while allowing COMPILE_TEST alternative whenMSCC_OCELOT_SWITCH_LIB is disabled entirely. This case is handledthrough the #ifdef check in include/soc/mscc/ocelot.h.Fixes: 0a6f17c6ae21 ("net: dsa: tag_ocelot_8021q: add support for PTP timestamping")Signed-off-by: Arnd Bergmann Acked-by: Vladimir Oltean Link: https://lore.kernel.org/r/20210225143910.3964364-2-arnd@kernel.orgSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/dsa/Kconfig