Changes in Makefile

b912d599 - net: rename rtnl_net_debug to lock_debug

Tue, 01 Apr 2025 16:34:45 +0000

net: rename rtnl_net_debug to lock_debugAnd make it selected by CONFIG_DEBUG_NET. Don't rename any ofthe structs/functions. Next patch will use rtnl_net_debug_event innetdevsim.Reviewed-by: Jakub Kicinski Signed-off-by: Stanislav Fomichev Link: https://patch.msgid.link/20250401163452.622454-5-sdf@fomichev.meSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/core/Makefile

7e4d784f - net: hold netdev instance lock during rtnetlink operations

Wed, 05 Mar 2025 16:37:24 +0000

net: hold netdev instance lock during rtnetlink operationsTo preserve the atomicity, hold the lock while applying multipleattributes. The major issue with a full conversion to the instancelock are software nesting devices (bonding/team/vrf/etc). Thosedevices call into the core stack for their lower (potentiallyreal hw) devices. To avoid explicitly wrapping all those placesinto instance lock/unlock, introduce new API boundaries:- (some) existing dev_xxx calls are now considered "external" (to drivers) APIs and they transparently grab the instance lock if needed (dev_api.c)- new netif_xxx calls are internal core stack API (naming is sketchy, I've tried netdev_xxx_locked per Jakub's suggestion, but it feels a bit verbose; but happy to get back to this naming scheme if this is the preference)This avoids touching most of the existing ioctl/sysfs/drivers paths.Note the special handling of ndo_xxx_slave operations: I exploitthe fact that none of the drivers that call these functionsneed/use instance lock. At the same time, they use dev_xxxAPIs, so the lower device has to be unlocked.Changes in unregister_netdevice_many_notify (to protect dev->statewith instance lock) trigger lockdep - the loop over close_list(mostly from cleanup_net) introduces spurious ordering issues.netdev_lock_cmp_fn has a justification on why it's ok to suppressfor now.Cc: Saeed Mahameed Signed-off-by: Stanislav Fomichev Link: https://patch.msgid.link/20250305163732.2766420-7-sdf@fomichev.meSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/core/Makefile

12079a59 - net: Implement fault injection forcing skb reallocation

Thu, 07 Nov 2024 16:11:44 +0000

net: Implement fault injection forcing skb reallocationIntroduce a fault injection mechanism to force skb reallocation. Theprimary goal is to catch bugs related to pointer invalidation afterpotential skb reallocation.The fault injection mechanism aims to identify scenarios where callersretain pointers to various headers in the skb but fail to reload thesepointers after calling a function that may reallocate the data. Thistype of bug can lead to memory corruption or crashes if the old,now-invalid pointers are used.By forcing reallocation through fault injection, we can stress-test codepaths and ensure proper pointer management after potential skbreallocations.Add a hook for fault injection in the following functions: * pskb_trim_rcsum() * pskb_may_pull_reason() * pskb_trim()As the other fault injection mechanism, protect it under a debug Kconfigcalled CONFIG_FAIL_SKB_REALLOC.This patch was *heavily* inspired by Jakub's proposal from:https://lore.kernel.org/all/20240719174140.47a868e6@kernel.org/CC: Akinobu Mita Suggested-by: Jakub Kicinski Signed-off-by: Breno Leitao Reviewed-by: Akinobu Mita Acked-by: Paolo Abeni Acked-by: Guillaume Nault Link: https://patch.msgid.link/20241107-fault_v6-v6-1-1b82cb6ecacd@debian.orgSigned-off-by: Paolo Abeni List of files: /linux-6.15/net/core/Makefile

03fa5348 - rtnetlink: Add ASSERT_RTNL_NET() placeholder for netdev notifier.

Fri, 04 Oct 2024 22:10:31 +0000

rtnetlink: Add ASSERT_RTNL_NET() placeholder for netdev notifier.The global and per-netns netdev notifier depend on RTNL, and itsdependency is not so clear due to nested calls.Let's add a placeholder to place ASSERT_RTNL_NET() for each event.Signed-off-by: Kuniyuki Iwashima Reviewed-by: Eric Dumazet Signed-off-by: Paolo Abeni List of files: /linux-6.15/net/core/Makefile

170aafe3 - netdev: support binding dma-buf to netdevice

Tue, 10 Sep 2024 17:14:47 +0000

netdev: support binding dma-buf to netdeviceAdd a netdev_dmabuf_binding struct which represents thedma-buf-to-netdevice binding. The netlink API will bind the dma-buf torx queues on the netdevice. On the binding, the dma_buf_attach& dma_buf_map_attachment will occur. The entries in the sg_table frommapping will be inserted into a genpool to make it readyfor allocation.The chunks in the genpool are owned by a dmabuf_chunk_owner struct whichholds the dma-buf offset of the base of the chunk and the dma_addr ofthe chunk. Both are needed to use allocations that come from this chunk.We create a new type that represents an allocation from the genpool:net_iov. We setup the net_iov allocation size in thegenpool to PAGE_SIZE for simplicity: to match the PAGE_SIZE normallyallocated by the page pool and given to the drivers.The user can unbind the dmabuf from the netdevice by closing the netlinksocket that established the binding. We do this so that the binding isautomatically unbound even if the userspace process crashes.The binding and unbinding leaves an indicator in struct netdev_rx_queuethat the given queue is bound, and the binding is actuated by resettingthe rx queue using the queue API.The netdev_dmabuf_binding struct is refcounted, and releases itsresources only when all the refs are released.Signed-off-by: Willem de Bruijn Signed-off-by: Kaiyuan Zhang Signed-off-by: Mina Almasry Reviewed-by: Pavel Begunkov # excluding netlinkAcked-by: Daniel Vetter Reviewed-by: Jakub Kicinski Link: https://patch.msgid.link/20240910171458.219195-4-almasrymina@google.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/core/Makefile

7c88f865 - netdev: add netdev_rx_queue_restart()

Tue, 10 Sep 2024 17:14:45 +0000

netdev: add netdev_rx_queue_restart()Add netdev_rx_queue_restart(), which resets an rx queue using thequeue API recently merged[1].The queue API was merged to enable the core net stack to reset individualrx queues to actuate changes in the rx queue's configuration. In laterpatches in this series, we will use netdev_rx_queue_restart() to resetrx queues after binding or unbinding dmabuf configuration, which willcause reallocation of the page_pool to repopulate its memory using thenew configuration.[1] https://lore.kernel.org/netdev/20240430231420.699177-1-shailend@google.com/T/Signed-off-by: David Wei Signed-off-by: Mina Almasry Reviewed-by: Pavel Begunkov Reviewed-by: Jakub Kicinski Link: https://patch.msgid.link/20240910171458.219195-2-almasrymina@google.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/core/Makefile

768cf841 - net: add IEEE 802.1q specific helpers

Fri, 03 May 2024 13:13:42 +0000

net: add IEEE 802.1q specific helpersIEEE 802.1q specification provides recommendation and examples which canbe used as good default values for different drivers.This patch implements mapping examples documented in IEEE 802.1Q-2022 inAnnex I "I.3 Traffic type to traffic class mapping" and IETF DSCP namingand mapping DSCP to Traffic Type inspired by RFC8325.This helpers will be used in followup patches for dsa/microchip DCBimplementation.Signed-off-by: Oleksij Rempel Signed-off-by: David S. Miller List of files: /linux-6.15/net/core/Makefile

5b2be2ab - net: net_test: add tests for IP tunnel flags conversion helpers

Wed, 27 Mar 2024 15:23:54 +0000

net: net_test: add tests for IP tunnel flags conversion helpersNow that there are helpers for converting IP tunnel flags between theold __be16 format and the bitmap format, make sure they work as expectedby adding a couple of tests to the networking testing suite. The helpersare all inline, so no dependencies on the related CONFIG_* (or astandalone module) are needed.Cover three possible cases:1. No bits past BIT(15) are set, VTI/SIT bits are not set. This conversion is almost a direct assignment.2. No bits past BIT(15) are set, but VTI/SIT bit is set. During the conversion, it must be transformed into BIT(16) in the bitmap, but still compatible with the __be16 format.3. The bitmap has bits past BIT(15) set (not the VTI/SIT one). The result will be truncated. Note that currently __IP_TUNNEL_FLAG_NUM is 17 (incl. special), which means that the result of this case is currently semi-false-positive. When BIT(17) is finally here, it will be adjusted accordingly.Signed-off-by: Alexander Lobakin Signed-off-by: David S. Miller List of files: /linux-6.15/net/core/Makefile

2658b5a8 - net: introduce struct net_hotdata

Wed, 06 Mar 2024 16:00:14 +0000

net: introduce struct net_hotdataInstead of spreading networking critical fieldsall over the places, add a custom net_hotdatastructure so that we can precisely control its layout.In this first patch, move :- gro_normal_batch used in rx (GRO stack)- offload_base used in rx and tx (GRO and TSO stacks)Signed-off-by: Eric Dumazet Acked-by: Soheil Hassas Yeganeh Reviewed-by: David Ahern Link: https://lore.kernel.org/r/20240306160031.874438-2-edumazet@google.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/core/Makefile

f17c6964 - net: page_pool: id the page pools

Sun, 26 Nov 2023 23:07:29 +0000

net: page_pool: id the page poolsTo give ourselves the flexibility of creating netlink commandsand ability to refer to page pool instances in uAPIs createIDs for page pools.Reviewed-by: Ilias Apalodimas Reviewed-by: Eric Dumazet Acked-by: Jesper Dangaard Brouer Signed-off-by: Jakub Kicinski Reviewed-by: Shakeel Butt Signed-off-by: Paolo Abeni List of files: /linux-6.15/net/core/Makefile

b3098d32 - net: add skb_segment kunit test

Mon, 09 Oct 2023 14:41:51 +0000

net: add skb_segment kunit testAdd unit testing for skb segment. This function is exercised by manydifferent code paths, such as GSO_PARTIAL or GSO_BY_FRAGS, linear(with or without head_frag), frags or frag_list skbs, etc.It is infeasible to manually run tests that cover all code paths whenmaking changes. The long and complex function also makes it hard toestablish through analysis alone that a patch has no unintendedside-effects.Add code coverage through kunit regression testing. Introduce kunitinfrastructure for tests under net/core, and add this first test.This first skb_segment test exercises a simple case: a linear skb.Follow-on patches will parametrize the test and add more variants.Tested: Built and ran the test with make ARCH=um mrproper ./tools/testing/kunit/kunit.py run \ --kconfig_add CONFIG_NET=y \ --kconfig_add CONFIG_DEBUG_KERNEL=y \ --kconfig_add CONFIG_DEBUG_INFO=y \ --kconfig_add=CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y \ net_core_gsoSigned-off-by: Willem de Bruijn Reviewed-by: Florian Westphal Signed-off-by: David S. Miller List of files: /linux-6.15/net/core/Makefile

d457a0e3 - net: move gso declarations and functions to their own files

Thu, 08 Jun 2023 19:17:37 +0000

net: move gso declarations and functions to their own filesMove declarations into include/net/gso.h and code into net/core/gso.cSigned-off-by: Eric Dumazet Cc: Stanislav Fomichev Reviewed-by: Simon Horman Reviewed-by: David Ahern Link: https://lore.kernel.org/r/20230608191738.3947077-1-edumazet@google.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/core/Makefile

d3d854fd - netdev-genl: create a simple family for netdev stuff

Wed, 01 Feb 2023 10:24:17 +0000

netdev-genl: create a simple family for netdev stuffAdd a Netlink spec-compatible family for netdevs.This is a very simple implementation without muchthought going into it.It allows us to reap all the benefits of Netlink specs,one can use the generic client to issue the commands: $ ./cli.py --spec netdev.yaml --dump dev_get [{'ifindex': 1, 'xdp-features': set()}, {'ifindex': 2, 'xdp-features': {'basic', 'ndo-xmit', 'redirect'}}, {'ifindex': 3, 'xdp-features': {'rx-sg'}}]the generic python library does not have flags-by-namesupport, yet, but we also don't have to carry stringsin the messages, as user space can get the names fromthe spec.Acked-by: Jesper Dangaard Brouer Co-developed-by: Lorenzo Bianconi Signed-off-by: Lorenzo Bianconi Co-developed-by: Kumar Kartikeya Dwivedi Signed-off-by: Kumar Kartikeya Dwivedi Co-developed-by: Marek Majtyka Signed-off-by: Marek Majtyka Signed-off-by: Jakub Kicinski Link: https://lore.kernel.org/r/327ad9c9868becbe1e601b580c962549c8cd81f2.1675245258.git.lorenzo@kernel.orgSigned-off-by: Alexei Starovoitov List of files: /linux-6.15/net/core/Makefile

f05bd8eb - devlink: move code to a dedicated directory

Thu, 05 Jan 2023 04:05:17 +0000

devlink: move code to a dedicated directoryThe devlink code is hard to navigate with 13kLoC in one file.I really like the way Michal split the ethtool into per-commandfiles and core. It'd probably be too much to split it all up,but we can at least separate the core parts out of the per-cmdimplementations and put it in a directory so that new commandscan be separate files.Move the code, subsequent commit will do a partial split.Reviewed-by: Jacob Keller Reviewed-by: Jiri Pirko Signed-off-by: Jakub Kicinski List of files: /linux-6.15/net/core/Makefile

9cb252c4 - net: skb: export skb drop reaons to user by TRACE_DEFINE_ENUM

Mon, 05 Sep 2022 03:50:15 +0000

net: skb: export skb drop reaons to user by TRACE_DEFINE_ENUMAs Eric reported, the 'reason' field is not presented when trace thekfree_skb event by perf:$ perf record -e skb:kfree_skb -a sleep 10$ perf script ip_defrag 14605 [021] 221.614303: skb:kfree_skb: skbaddr=0xffff9d2851242700 protocol=34525 location=0xffffffffa39346b1 reason:The cause seems to be passing kernel address directly to TP_printk(),which is not right. As the enum 'skb_drop_reason' is not exported touser space through TRACE_DEFINE_ENUM(), perf can't get the drop reasonstring from the 'reason' field, which is a number.Therefore, we introduce the macro DEFINE_DROP_REASON(), which is usedto define the trace enum by TRACE_DEFINE_ENUM(). With the help ofDEFINE_DROP_REASON(), now we can remove the auto-generate that weintroduced in the commit ec43908dd556("net: skb: use auto-generation to convert skb drop reason to string"),and define the string array 'drop_reasons'.Hmmmm...now we come back to the situation that have to maintain dropreasons in both enum skb_drop_reason and DEFINE_DROP_REASON. But theyare both in dropreason.h, which makes it easier.After this commit, now the format of kfree_skb is like this:$ cat /tracing/events/skb/kfree_skb/formatname: kfree_skbID: 1524format: field:unsigned short common_type; offset:0; size:2; signed:0; field:unsigned char common_flags; offset:2; size:1; signed:0; field:unsigned char common_preempt_count; offset:3; size:1; signed:0; field:int common_pid; offset:4; size:4; signed:1; field:void * skbaddr; offset:8; size:8; signed:0; field:void * location; offset:16; size:8; signed:0; field:unsigned short protocol; offset:24; size:2; signed:0; field:enum skb_drop_reason reason; offset:28; size:4; signed:0;print fmt: "skbaddr=%p protocol=%u location=%p reason: %s", REC->skbaddr, REC->protocol, REC->location, __print_symbolic(REC->reason, { 1, "NOT_SPECIFIED" }, { 2, "NO_SOCKET" } ......Fixes: ec43908dd556 ("net: skb: use auto-generation to convert skb drop reason to string")Link: https://lore.kernel.org/netdev/CANn89i+bx0ybvE55iMYf5GJM48WwV1HNpdm9Q6t-HaEstqpCSA@mail.gmail.com/Reported-by: Eric Dumazet Signed-off-by: Menglong Dong Signed-off-by: David S. Miller List of files: /linux-6.15/net/core/Makefile

ec43908d - net: skb: use auto-generation to convert skb drop reason to string

Mon, 06 Jun 2022 02:24:35 +0000

net: skb: use auto-generation to convert skb drop reason to stringIt is annoying to add new skb drop reasons to 'enum skb_drop_reason'and TRACE_SKB_DROP_REASON in trace/event/skb.h, and it's easy to forgetto add the new reasons we added to TRACE_SKB_DROP_REASON.TRACE_SKB_DROP_REASON is used to convert drop reason of type numberto string. For now, the string we passed to user space is exactly thesame as the name in 'enum skb_drop_reason' with a 'SKB_DROP_REASON_'prefix. Therefore, we can use 'auto-generation' to generate thesedrop reasons to string at build time.The new source 'dropreason_str.c' will be auto generated during buildtime, which contains the string array'const char * const drop_reasons[]'.Signed-off-by: Menglong Dong Signed-off-by: Paolo Abeni List of files: /linux-6.15/net/core/Makefile

2c193f2c - net: kunit: add a test for dev_addr_lists

Fri, 19 Nov 2021 14:21:55 +0000

net: kunit: add a test for dev_addr_listsAdd a KUnit test for the dev_addr API.Signed-off-by: Jakub Kicinski Signed-off-by: David S. Miller List of files: /linux-6.15/net/core/Makefile

e456a18a - net: gro: move skb_gro_receive into net/core/gro.c

Mon, 15 Nov 2021 17:05:53 +0000

net: gro: move skb_gro_receive into net/core/gro.cnet/core/gro.c will contain all core gro functions,to shrink net/core/skbuff.c and net/core/dev.cSigned-off-by: Eric Dumazet Signed-off-by: David S. Miller List of files: /linux-6.15/net/core/Makefile

e330fb14 - of: net: move of_net under net/

Thu, 07 Oct 2021 01:06:54 +0000

of: net: move of_net under net/Rob suggests to move of_net.c from under drivers/of/ somewhereto the networking code.Suggested-by: Rob Herring Signed-off-by: Jakub Kicinski Reviewed-by: Rob Herring Signed-off-by: David S. Miller List of files: /linux-6.15/net/core/Makefile

17edea21 - sock_map: Relax config dependency to CONFIG_NET

Sun, 04 Jul 2021 19:02:42 +0000

sock_map: Relax config dependency to CONFIG_NETCurrently sock_map still has Kconfig dependency on CONFIG_INET,but there is no actual functional dependency on it after weintroduce ->psock_update_sk_prot().We have to extend it to CONFIG_NET now as we are going tosupport AF_UNIX.Signed-off-by: Cong Wang Signed-off-by: Alexei Starovoitov Link: https://lore.kernel.org/bpf/20210704190252.11866-2-xiyou.wangcong@gmail.com List of files: /linux-6.15/net/core/Makefile