Changes in proc.c

80b5f901 - can: statistics: use atomic access in hot path

Mon, 10 Mar 2025 14:33:53 +0000

can: statistics: use atomic access in hot pathIn can_send() and can_receive() CAN messages and CAN filter matches arecounted to be visible in the CAN procfs files.KCSAN detected a data race within can_send() when two CAN frames havebeen generated by a timer event writing to the same CAN netdevice at thesame time. Use atomic operations to access the statistics in the hot pathto fix the KCSAN complaint.Reported-by: syzbot+78ce4489b812515d5e4d@syzkaller.appspotmail.comCloses: https://lore.kernel.org/all/67cd717d.050a0220.e1a89.0006.GAE@google.comSigned-off-by: Oliver Hartkopp Reviewed-by: Vincent Mailhol Link: https://patch.msgid.link/20250310143353.3242-1-socketcan@hartkopp.netSigned-off-by: Marc Kleine-Budde List of files: /linux-6.15/net/can/proc.c

359745d7 - proc: remove PDE_DATA() completely

Sat, 22 Jan 2022 06:14:23 +0000

proc: remove PDE_DATA() completelyRemove PDE_DATA() completely and replace it with pde_data().[akpm@linux-foundation.org: fix naming clash in drivers/nubus/proc.c][akpm@linux-foundation.org: now fix it properly]Link: https://lkml.kernel.org/r/20211124081956.87711-2-songmuchun@bytedance.comSigned-off-by: Muchun Song Acked-by: Christian Brauner Cc: Alexey Dobriyan Cc: Alexey Gladkov Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/net/can/proc.c

24a774a4 - can: proc: remove unnecessary variables

Fri, 14 May 2021 10:08:06 +0000

can: proc: remove unnecessary variablesThere is no need to define the variable "rate" to receive, just returndirectly.Link: https://lore.kernel.org/r/20210514100806.792-1-zuoqilin1@163.comSigned-off-by: zuoqilin Signed-off-by: Marc Kleine-Budde List of files: /linux-6.15/net/can/proc.c

e6b031d3 - can: proc: fix rcvlist_* header alignment on 64-bit system

Sun, 25 Apr 2021 14:14:35 +0000

can: proc: fix rcvlist_* header alignment on 64-bit systemBefore this fix, the function and userdata columns weren't aligned: device can_id can_mask function userdata matches ident vcan0 92345678 9fffffff 0000000000000000 0000000000000000 0 raw vcan0 123 00000123 0000000000000000 0000000000000000 0 rawAfter the fix they are: device can_id can_mask function userdata matches ident vcan0 92345678 9fffffff 0000000000000000 0000000000000000 0 raw vcan0 123 00000123 0000000000000000 0000000000000000 0 rawLink: Link: https://lore.kernel.org/r/20210425141440.229653-1-erik@flodin.meSigned-off-by: Erik Flodin Signed-off-by: Marc Kleine-Budde List of files: /linux-6.15/net/can/proc.c

4e096a18 - net: introduce CAN specific pointer in the struct net_device

Tue, 23 Feb 2021 07:01:26 +0000

net: introduce CAN specific pointer in the struct net_deviceSince 20dd3850bcf8 ("can: Speed up CAN frame receiption by usingml_priv") the CAN framework uses per device specific data in the AF_CANprotocol. For this purpose the struct net_device->ml_priv is used. Laterthe ml_priv usage in CAN was extended for other users, one of them beingCAN_J1939.Later in the kernel ml_priv was converted to an union, used by otherdrivers. E.g. the tun driver started storing it's stats pointer.Since tun devices can claim to be a CAN device, CAN specific protocolswill wrongly interpret this pointer, which will cause system crashes.Mostly this issue is visible in the CAN_J1939 stack.To fix this issue, we request a dedicated CAN pointer within thenet_device struct.Reported-by: syzbot+5138c4dd15a0401bec7b@syzkaller.appspotmail.comFixes: 20dd3850bcf8 ("can: Speed up CAN frame receiption by using ml_priv")Fixes: ffd956eef69b ("can: introduce CAN midlayer private and allocate it automatically")Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")Fixes: 497a5757ce4e ("tun: switch to net core provided statistics counters")Signed-off-by: Oleksij Rempel Link: https://lore.kernel.org/r/20210223070127.4538-1-o.rempel@pengutronix.deSigned-off-by: Jakub Kicinski List of files: /linux-6.15/net/can/proc.c

3accbfdc - can: proc: can_remove_proc(): silence remove_proc_entry warning

Tue, 14 Jul 2020 06:44:50 +0000

can: proc: can_remove_proc(): silence remove_proc_entry warningIf can_init_proc() fail to create /proc/net/can directory, can_remove_proc()will trigger a warning:WARNING: CPU: 6 PID: 7133 at fs/proc/generic.c:672 remove_proc_entry+0x17b0Kernel panic - not syncing: panic_on_warn set ...Fix to return early from can_remove_proc() if can proc_dir does not exists.Signed-off-by: Zhang Changzhong Link: https://lore.kernel.org/r/1594709090-3203-1-git-send-email-zhangchangzhong@huawei.comFixes: 8e8cda6d737d ("can: initial support for network namespaces")Acked-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde List of files: /linux-6.15/net/can/proc.c

f726f3d3 - can: remove obsolete version strings

Mon, 12 Oct 2020 07:43:54 +0000

can: remove obsolete version stringsAs pointed out by Jakub Kicinski here:http://lore.kernel.org/r/20201009175751.5c54097f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.comthis patch removes the obsolete version information of the differentCAN protocols and the AF_CAN core module.Signed-off-by: Oliver Hartkopp Link: https://lore.kernel.org/r/20201012074354.25839-2-socketcan@hartkopp.netSigned-off-by: Marc Kleine-Budde List of files: /linux-6.15/net/can/proc.c

d77cd7fe - can: remove "WITH Linux-syscall-note" from SPDX tag of C files

Fri, 03 Apr 2020 07:37:41 +0000

can: remove "WITH Linux-syscall-note" from SPDX tag of C filesThe "WITH Linux-syscall-note" exception is intended for UAPI headers.See LICENSES/exceptions/Linux-syscall-noteSigned-off-by: Masahiro Yamada Link: https://lore.kernel.org/r/20200403073741.18352-1-masahiroy@kernel.orgAcked-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde List of files: /linux-6.15/net/can/proc.c

ffd956ee - can: introduce CAN midlayer private and allocate it automatically

Mon, 08 Oct 2018 07:02:38 +0000

can: introduce CAN midlayer private and allocate it automaticallyThis patch introduces the CAN midlayer private structure ("structcan_ml_priv") which should be used to hold protocol specific per devicedata structures. For now it's only member is "struct can_dev_rcv_lists".The CAN midlayer private is allocated via alloc_netdev()'s private andassigned to "struct net_device::ml_priv" during device creation. This isdone transparently for CAN drivers using alloc_candev(). The slcan, vcanand vxcan drivers which are not using alloc_candev() have been adoptedmanually. The memory layout of the netdev_priv allocated viaalloc_candev() will looke like this: +-------------------------+ | driver's priv | +-------------------------+ | struct can_ml_priv | +-------------------------+ | array of struct sk_buff | +-------------------------+Signed-off-by: Oleksij Rempel Signed-off-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde List of files: /linux-6.15/net/can/proc.c

ff7fbea4 - can: proc: give variable holding the CAN per device receive lists a sensible name

Mon, 08 Oct 2018 07:02:32 +0000

can: proc: give variable holding the CAN per device receive lists a sensible nameThis patch gives the variables holding the CAN per device receive filter listsa better name by renaming them from "d" to "dev_rcv_lists".Signed-off-by: Oleksij Rempel Acked-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde List of files: /linux-6.15/net/can/proc.c

564577df - can: netns: remove "can_" prefix from members struct netns_can

Mon, 08 Oct 2018 07:02:30 +0000

can: netns: remove "can_" prefix from members struct netns_canThis patch improves the code reability by removing the redundant "can_"prefix from the members of struct netns_can (as the struct netns_can itselfis the member "can" of the struct net.)The conversion is done with: sed -i \ -e "s/struct can_dev_rcv_lists \*can_rx_alldev_list;/struct can_dev_rcv_lists *rx_alldev_list;/" \ -e "s/spinlock_t can_rcvlists_lock;/spinlock_t rcvlists_lock;/" \ -e "s/struct timer_list can_stattimer;/struct timer_list stattimer; /" \ -e "s/can\.can_rx_alldev_list/can.rx_alldev_list/g" \ -e "s/can\.can_rcvlists_lock/can.rcvlists_lock/g" \ -e "s/can\.can_stattimer/can.stattimer/g" \ include/net/netns/can.h \ net/can/*.[ch]Signed-off-by: Oleksij Rempel Acked-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde List of files: /linux-6.15/net/can/proc.c

448c7074 - can: proc: give variables holding CAN statistics a sensible name

Mon, 08 Oct 2018 07:02:29 +0000

can: proc: give variables holding CAN statistics a sensible nameThis patch rename the variables holding the CAN statistics (can_statsand can_pstats) to pkg_stats and rcv_lists_stats which reflect bettertheir meaning.The conversion is done with: sed -i \ -e "s/can_stats$[^_]$/pkg_stats\1/g" \ -e "s/can_pstats/rcv_lists_stats/g" \ net/can/proc.cSigned-off-by: Oleksij Rempel Acked-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde List of files: /linux-6.15/net/can/proc.c

2341086d - can: netns: give members of struct netns_can holding the statistics a sensible name

Mon, 08 Oct 2018 07:02:27 +0000

can: netns: give members of struct netns_can holding the statistics a sensible nameThis patch gives the members of the struct netns_can that are holdingthe statistics a sensible name, by renaming struct netns_can::can_statsinto struct netns_can::pkg_stats and struct netns_can::can_pstats intostruct netns_can::rcv_lists_stats.The conversion is done with: sed -i \ -e "s:$struct[^*]*\*$can_stats;.*:\1pkg_stats;:" \ -e "s:$struct[^*]*\*$can_pstats;.*:\1rcv_lists_stats;:" \ -e "s/can\.can_stats/can.pkg_stats/g" \ -e "s/can\.can_pstats/can.rcv_lists_stats/g" \ net/can/*.[ch] \ include/net/netns/can.hSigned-off-by: Oleksij Rempel Acked-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde List of files: /linux-6.15/net/can/proc.c

6c43bb3a - can: netns: give structs holding the CAN statistics a sensible name

Mon, 08 Oct 2018 07:02:26 +0000

can: netns: give structs holding the CAN statistics a sensible nameThis patch renames both "struct s_stats" and "struct s_pstats", to"struct can_pkg_stats" and "struct can_rcv_lists_stats" to betterreflect their meaning and improve code readability.The conversion is done with: sed -i \ -e "s/struct s_stats/struct can_pkg_stats/g" \ -e "s/struct s_pstats/struct can_rcv_lists_stats/g" \ net/can/*.[ch] \ include/net/netns/can.hSigned-off-by: Oleksij Rempel Acked-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde List of files: /linux-6.15/net/can/proc.c

fba76a58 - can: Add SPDX license identifiers for CAN subsystem

Tue, 23 Jul 2019 13:17:55 +0000

can: Add SPDX license identifiers for CAN subsystemAdd missing SPDX identifiers for the CAN network layer and correct the SPDXlicense for two of its include files to make sure the BSD-3-Clause appliesfor the entire subsystem.Signed-off-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde List of files: /linux-6.15/net/can/proc.c

3617d949 - proc: introduce proc_create_net_single

Fri, 13 Apr 2018 18:38:35 +0000

proc: introduce proc_create_net_singleVariant of proc_create_data that directly take a seq_file showcallback and deals with network namespaces in ->open and ->release.All callers of proc_create + single_open_net converted over, andsingle_{open,release}_net are removed entirely.Signed-off-by: Christoph Hellwig List of files: /linux-6.15/net/can/proc.c

441bc627 - net/can: single_open_net needs to be paired with single_release_net

Wed, 11 Apr 2018 10:16:13 +0000

net/can: single_open_net needs to be paired with single_release_netOtherwise we will leak a reference to the network namespace.Signed-off-by: Christoph Hellwig List of files: /linux-6.15/net/can/proc.c

96890d62 - net: delete /proc THIS_MODULE references

Mon, 15 Jan 2018 21:42:40 +0000

net: delete /proc THIS_MODULE references/proc has been ignoring struct file_operations::owner field for 10 years.Specifically, it started with commit 786d7e1612f0b0adb6046f19b906609e4fe8b1ba("Fix rmmod/read/write races in /proc entries"). Notice the chunk whereinode->i_fop is initialized with proxy struct file_operations forregular files: - if (de->proc_fops) - inode->i_fop = de->proc_fops; + if (de->proc_fops) { + if (S_ISREG(inode->i_mode)) + inode->i_fop = &proc_reg_file_ops; + else + inode->i_fop = de->proc_fops; + }VFS stopped pinning module at this point.Signed-off-by: Alexey Dobriyan Signed-off-by: David S. Miller List of files: /linux-6.15/net/can/proc.c

ff847ee4 - can: af_can: give struct holding the CAN per device receive lists a sensible name

Sat, 03 Jun 2017 18:10:03 +0000

can: af_can: give struct holding the CAN per device receive lists a sensible nameThis patch adds a "can_" prefix to the "struct dev_rcv_lists" to betterreflect the meaning and improbe code readability.The conversion is done with: sed -i \ -e "s/struct dev_rcv_lists/struct can_dev_rcv_lists/g" \ net/can/*.[ch] include/net/netns/can.hAcked-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde List of files: /linux-6.15/net/can/proc.c

841b86f3 - treewide: Remove TIMER_FUNC_TYPE and TIMER_DATA_TYPE casts

Mon, 23 Oct 2017 07:40:42 +0000

treewide: Remove TIMER_FUNC_TYPE and TIMER_DATA_TYPE castsWith all callbacks converted, and the timer callback prototypeswitched over, the TIMER_FUNC_TYPE cast is no longer needed,so remove it. Conversion was done with the following scripts: perl -pi -e 's|$TIMER_FUNC_TYPE$||g' \ $(git grep TIMER_FUNC_TYPE | cut -d: -f1 | sort -u) perl -pi -e 's|$TIMER_DATA_TYPE$||g' \ $(git grep TIMER_DATA_TYPE | cut -d: -f1 | sort -u)The now unused macros are also dropped from include/linux/timer.h.Signed-off-by: Kees Cook List of files: /linux-6.15/net/can/proc.c