Changes in Makefile

f2091321 - raid6: Add LoongArch SIMD recovery implementation

Wed, 06 Sep 2023 14:53:55 +0000

raid6: Add LoongArch SIMD recovery implementationSimilar to the syndrome calculation, the recovery algorithms also workon 64 bytes at a time to align with the L1 cache line size of currentand future LoongArch cores (that we care about). Which meansunrolled-by-4 LSX and unrolled-by-2 LASX code.The assembly is originally based on the x86 SSSE3/AVX2 ports, butregister allocation has been redone to take advantage of LSX/LASX's 32vector registers, and instruction sequence has been optimized to suit(e.g. LoongArch can perform per-byte srl and andi on vectors, but x86cannot).Performance numbers measured by instrumenting the raid6test code, on a3A5000 system clocked at 2.5GHz:> lasx 2data: 354.987 MiB/s> lasx datap: 350.430 MiB/s> lsx 2data: 340.026 MiB/s> lsx datap: 337.318 MiB/s> intx1 2data: 164.280 MiB/s> intx1 datap: 187.966 MiB/sBecause recovery algorithms are chosen solely based on priority andavailability, lasx is marked as priority 2 and lsx priority 1. At leastfor the current generation of LoongArch micro-architectures, LASX shouldalways be faster than LSX whenever supported, and have similar powerconsumption characteristics (because the only known LASX-capable uarch,the LA464, always compute the full 256-bit result for vector ops).Acked-by: Song Liu Signed-off-by: WANG Xuerui Signed-off-by: Huacai Chen List of files: /linux-6.15/lib/raid6/test/Makefile

8f3f06df - raid6: Add LoongArch SIMD syndrome calculation

Wed, 06 Sep 2023 14:53:55 +0000

raid6: Add LoongArch SIMD syndrome calculationThe algorithms work on 64 bytes at a time, which is the L1 cache linesize of all current and future LoongArch cores (that we care about), asconfirmed by Huacai. The code is based on the generic int.uc algorithm,unrolled 4 times for LSX and 2 times for LASX. Further unrolling doesnot meaningfully improve the performance according to experiments.Performance numbers measured during system boot on a 3A5000 @ 2.5GHz:> raid6: lasx gen() 12726 MB/s> raid6: lsx gen() 10001 MB/s> raid6: int64x8 gen() 2876 MB/s> raid6: int64x4 gen() 3867 MB/s> raid6: int64x2 gen() 2531 MB/s> raid6: int64x1 gen() 1945 MB/sComparison of xor() speeds (from different boots but meaningful anyway):> lasx: 11226 MB/s> lsx: 6395 MB/s> int64x4: 2147 MB/sPerformance as measured by raid6test:> raid6: lasx gen() 25109 MB/s> raid6: lsx gen() 13233 MB/s> raid6: int64x8 gen() 4164 MB/s> raid6: int64x4 gen() 6005 MB/s> raid6: int64x2 gen() 5781 MB/s> raid6: int64x1 gen() 4119 MB/s> raid6: using algorithm lasx gen() 25109 MB/s> raid6: .... xor() 14439 MB/s, rmw enabledAcked-by: Song Liu Signed-off-by: WANG Xuerui Signed-off-by: Huacai Chen List of files: /linux-6.15/lib/raid6/test/Makefile

7b3c70c4 - raid6: test: only check for Altivec if building on powerpc hosts

Mon, 31 Jul 2023 10:49:11 +0000

raid6: test: only check for Altivec if building on powerpc hostsAltivec is only available for powerpc hosts, so only check for itsavailability when the host is powerpc, to avoid error messages beingshown on architectures other than x86, arm or powerpc.Signed-off-by: WANG Xuerui Link: https://lore.kernel.org/r/20230731104911.411964-6-kernel@xen0n.nameSigned-off-by: Song Liu List of files: /linux-6.15/lib/raid6/test/Makefile

2008d89f - raid6: test: cosmetic cleanups for the test Makefile

Mon, 31 Jul 2023 10:49:09 +0000

raid6: test: cosmetic cleanups for the test MakefileUse tabs/spaces consistently: hard tabs for marking recipe lines only,spaces for everything else.Also, the OPTFLAGS declaration actually included the tabs preceding theline comment, making compiler invocation lines unnecessarily long. Asthe entire block of declarations are meant for ad-hoc customization(otherwise they would probably make use of `?=` instead of `=`), movethe "Adjust as desired" comment above the block too to fix the longinvocation lines.Signed-off-by: WANG Xuerui Link: https://lore.kernel.org/r/20230731104911.411964-4-kernel@xen0n.nameSigned-off-by: Song Liu List of files: /linux-6.15/lib/raid6/test/Makefile

633174a7 - lib/raid6/test/Makefile: Use $(pound) instead of \# for Make 4.3

Tue, 08 Feb 2022 15:21:48 +0000

lib/raid6/test/Makefile: Use $(pound) instead of \# for Make 4.3Buidling raid6test on Ubuntu 21.10 (ppc64le) with GNU Make 4.3 shows theerrors below: $ cd lib/raid6/test/ $ make :1:1: error: stray ‘\’ in program :1:2: error: stray ‘#’ in program :1:11: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ \ before ‘<’ token [...]The errors come from the HAS_ALTIVEC test, which fails, and the POWERoptimized versions are not built. That’s also reason nobody noticed on theother architectures.GNU Make 4.3 does not remove the backslash anymore. From the 4.3 releaseannouncment:> * WARNING: Backward-incompatibility!> Number signs (#) appearing inside a macro reference or function invocation> no longer introduce comments and should not be escaped with backslashes:> thus a call such as:> foo := $(shell echo '#')> is legal. Previously the number sign needed to be escaped, for example:> foo := $(shell echo '\#')> Now this latter will resolve to "\#". If you want to write makefiles> portable to both versions, assign the number sign to a variable:> H := \#> foo := $(shell echo '$H')> This was claimed to be fixed in 3.81, but wasn't, for some reason.> To detect this change search for 'nocomment' in the .FEATURES variable.So, do the same as commit 9564a8cf422d ("Kbuild: fix # escaping in .cmdfiles for future Make") and commit 929bef467771 ("bpf: Use $(pound) insteadof \# in Makefiles") and define and use a $(pound) variable.Reference for the change in make:https://git.savannah.gnu.org/cgit/make.git/commit/?id=c6966b323811c37acedff05b57Cc: Matt Brown Signed-off-by: Paul Menzel Signed-off-by: Song Liu List of files: /linux-6.15/lib/raid6/test/Makefile

e6abef61 - x86: update AS_* macros to binutils >=2.23, supporting ADX and AVX2

Thu, 26 Mar 2020 20:26:00 +0000

x86: update AS_* macros to binutils >=2.23, supporting ADX and AVX2Now that the kernel specifies binutils 2.23 as the minimum version, wecan remove ifdefs for AVX2 and ADX throughout.Signed-off-by: Jason A. Donenfeld Acked-by: Ingo Molnar Reviewed-by: Nick Desaulniers Signed-off-by: Masahiro Yamada List of files: /linux-6.15/lib/raid6/test/Makefile

92203b02 - x86: remove always-defined CONFIG_AS_SSSE3

Thu, 26 Mar 2020 08:00:54 +0000

x86: remove always-defined CONFIG_AS_SSSE3CONFIG_AS_SSSE3 was introduced by commit 75aaf4c3e6a4 ("x86/raid6:correctly check for assembler capabilities").We raise the minimal supported binutils version from time to time.The last bump was commit 1fb12b35e5ff ("kbuild: Raise the minimumrequired binutils version to 2.21").I confirmed the code in $(call as-instr,...) can be assembled by thebinutils 2.21 assembler and also by LLVM integrated assembler.Remove CONFIG_AS_SSSE3, which is always defined.I added ifdef CONFIG_X86 to lib/raid6/algos.c to avoid link errorson non-x86 architectures.lib/raid6/algos.c is built not only for the kernel but also fortesting the library code from userspace. I added -DCONFIG_X86 tolib/raid6/test/Makefile to cator to this usecase.Signed-off-by: Masahiro Yamada Reviewed-by: Jason A. Donenfeld Reviewed-by: Nick Desaulniers Acked-by: Ingo Molnar List of files: /linux-6.15/lib/raid6/test/Makefile

06bd48b6 - lib/raid6/test: fix build on distros whose /bin/sh is not bash

Thu, 26 Mar 2020 08:00:49 +0000

lib/raid6/test: fix build on distros whose /bin/sh is not bashYou can build a user-space test program for the raid6 library code,like this: $ cd lib/raid6/test $ makeThe command in $(shell ...) function is evaluated by /bin/sh by default.(or, you can specify the shell by passing SHELL= from command line)Currently '>&/dev/null' is used to sink both stdout and stderr. Becausethis code is bash-ism, it only works when /bin/sh is a symbolic link tobash (this is the case on RHEL etc.)This does not work on Ubuntu where /bin/sh is a symbolic link to dash.I see lots of /bin/sh: 1: Syntax error: Bad fd numberand warning "your version of binutils lacks ... support"Replace it with portable '>/dev/null 2>&1'.Fixes: 4f8c55c5ad49 ("lib/raid6: build proper files on corresponding arch")Signed-off-by: Masahiro Yamada Acked-by: H. Peter Anvin (Intel) Reviewed-by: Jason A. Donenfeld Acked-by: Ingo Molnar Reviewed-by: Nick Desaulniers List of files: /linux-6.15/lib/raid6/test/Makefile

86919f9d - lib/raid6: check for assembler SSSE3 support

Mon, 12 Nov 2018 23:22:18 +0000

lib/raid6: check for assembler SSSE3 supportAllow the x86 SSSE3 recovery function to be tested in raid6test.Signed-off-by: Daniel Verkamp Signed-off-by: Shaohua Li List of files: /linux-6.15/lib/raid6/test/Makefile

313a06e6 - lib/raid6: Fix arm64 test build

Tue, 06 Nov 2018 00:14:41 +0000

lib/raid6: Fix arm64 test buildThe lib/raid6/test fails to build the neon objectson arm64 because the correct machine type is 'aarch64'.Once this is correctly enabled, the neon recovery objectsneed to be added to the build.Reviewed-by: Ard Biesheuvel Signed-off-by: Jeremy Linton Signed-off-by: Catalin Marinas List of files: /linux-6.15/lib/raid6/test/Makefile

889ce12b - raid: remove tile specific raid6 implementation

Fri, 09 Mar 2018 15:05:23 +0000

raid: remove tile specific raid6 implementationThe Tile architecture is getting removed, so we no longer need this either.Acked-by: Ard Biesheuvel Signed-off-by: Arnd Bergmann List of files: /linux-6.15/lib/raid6/test/Makefile

aa9532d4 - lib/raid6: Build proper raid6test files on powerpc

Fri, 04 Aug 2017 03:42:33 +0000

lib/raid6: Build proper raid6test files on powerpcPreviously the raid6 test Makefile did not build the POWER specific files(altivec and vpermxor).This patch fixes the bug, so that all appropriate files for powerpc are built.This patch also fixes the missing and mismatched ifdef statements to allow thealtivec.uc file to be built correctly.Signed-off-by: Matt Brown Signed-off-by: Michael Ellerman List of files: /linux-6.15/lib/raid6/test/Makefile

751ba79c - lib/raid6/altivec: Add vpermxor implementation for raid6 Q syndrome

Fri, 04 Aug 2017 03:42:32 +0000

lib/raid6/altivec: Add vpermxor implementation for raid6 Q syndromeThis patch uses the vpermxor instruction to optimise the raid6 Qsyndrome. This instruction was made available with POWER8, ISA version2.07. It allows for both vperm and vxor instructions to be done in asingle instruction. This has been tested for correctness on a ppc64levm with a basic RAID6 setup containing 5 drives.The performance benchmarks are from the raid6test in the/lib/raid6/test directory. These results are from an IBM Firestonemachine with ppc64le architecture. The benchmark results show a 35%speed increase over the best existing algorithm for powerpc (altivec).The raid6test has also been run on a big-endian ppc64 vm to ensure italso works for big-endian architectures.Performance benchmarks: raid6: altivecx4 gen() 18773 MB/s raid6: altivecx8 gen() 19438 MB/s raid6: vpermxor4 gen() 25112 MB/s raid6: vpermxor8 gen() 26279 MB/sSigned-off-by: Matt Brown Reviewed-by: Daniel Axtens [mpe: Add VPERMXOR macro so we can build with old binutils]Signed-off-by: Michael Ellerman List of files: /linux-6.15/lib/raid6/test/Makefile

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/lib/raid6/test/Makefile

161db5d1 - lib/raid6/test/Makefile: Add avx512 gen_syndrome and recovery functions

Sat, 13 Aug 2016 01:03:21 +0000

lib/raid6/test/Makefile: Add avx512 gen_syndrome and recovery functionsAdding avx512 gen_syndrome and recovery functions so as to allow code tobe compiled and tested successfully in userspace.This patch is tested in userspace and improvement in performace isobserved.Cc: H. Peter Anvin Cc: Jim Kukunas Cc: Fenghua Yu Signed-off-by: Megha Dey Signed-off-by: Gayatri Kammela Reviewed-by: Fenghua Yu Signed-off-by: Shaohua Li List of files: /linux-6.15/lib/raid6/test/Makefile

c28399b5 - raid6/test: replace echo -e with printf

Thu, 22 Aug 2013 14:53:06 +0000

raid6/test: replace echo -e with printf-e is a non-standard echo option, echo output isimplementation-dependent when it is used. Replace echo -e with printf assuggested by POSIX echo manual.Cc: NeilBrown Cc: Jim Kukunas Cc: "H. Peter Anvin" Cc: Yuanhan Liu Acked-by: H. Peter Anvin Signed-off-by: Max Filippov Signed-off-by: NeilBrown List of files: /linux-6.15/lib/raid6/test/Makefile

ae77cbc1 - RAID: add tilegx SIMD implementation of raid6

Wed, 07 Aug 2013 16:39:56 +0000

RAID: add tilegx SIMD implementation of raid6This change adds TILE-Gx SIMD instructions to the software raid(md), modeling the Altivec implementation. This is only for Syndromegeneration; there is more that could be done to improve recovery,as in the recent Intel SSE3 recovery implementation.The code unrolls 8 times; this turns out to be the best on tilegxhardware among the set 1, 2, 4, 8 or 16. The code reads onecache-line of data from each disk, stores P and Q then goes to thenext cache-line.The test code in sys/linux/lib/raid6/test reports 2008 MB/s dataread rate for syndrome generation using 18 disks (16 data and 2parity). It was 1512 MB/s before this SIMD optimizations. This isrunning on 1 core with all the data in cache.This is based on the paper The Mathematics of RAID-6.(http://kernel.org/pub/linux/kernel/people/hpa/raid6.pdf).Signed-off-by: Ken Steele Signed-off-by: Chris Metcalf Signed-off-by: NeilBrown List of files: /linux-6.15/lib/raid6/test/Makefile

7d11965d - lib/raid6: add ARM-NEON accelerated syndrome calculation

Thu, 16 May 2013 15:20:32 +0000

lib/raid6: add ARM-NEON accelerated syndrome calculationRebased/reworked a patch contributed by Rob Herring that usesNEON intrinsics to perform the RAID-6 syndrome calculations.It uses the existing unroll.awk code to generate severalunrolled versions of which the best performing one is selectedat boot time.Signed-off-by: Ard Biesheuvel Acked-by: Nicolas Pitre Cc: hpa@linux.intel.com List of files: /linux-6.15/lib/raid6/test/Makefile

4f8c55c5 - lib/raid6: build proper files on corresponding arch

Fri, 30 Nov 2012 21:10:40 +0000

lib/raid6: build proper files on corresponding archsse and avx2 stuff only exist on x86 arch, and we don't need to buildaltivec on x86. And we can do that at lib/raid6/Makefile.Proposed-by: H. Peter Anvin Signed-off-by: Yuanhan Liu Reviewed-by: H. Peter Anvin Signed-off-by: Jim Kukunas Signed-off-by: NeilBrown List of files: /linux-6.15/lib/raid6/test/Makefile

2c935842 - lib/raid6: Add AVX2 optimized gen_syndrome functions

Fri, 30 Nov 2012 21:10:39 +0000

lib/raid6: Add AVX2 optimized gen_syndrome functionsAdd AVX2 optimized gen_syndrom functions, which is simply based onsse2.c written by hpa.Signed-off-by: Yuanhan Liu Reviewed-by: H. Peter Anvin Signed-off-by: Jim Kukunas Signed-off-by: NeilBrown List of files: /linux-6.15/lib/raid6/test/Makefile