Changes in sha256.c

5f60d5f6 - move asm/unaligned.h to linux/unaligned.h

Tue, 01 Oct 2024 19:35:57 +0000

move asm/unaligned.h to linux/unaligned.hasm/unaligned.h is always an include of asm-generic/unaligned.h;might as well move that thing to linux/unaligned.h and includethat - there's nothing arch-specific in that header.auto-generated by the following:for i in `git grep -l -w asm/unaligned.h`; do sed -i -e "s/asm\/unaligned.h/linux\/unaligned.h/" $idonefor i in `git grep -l -w asm-generic/unaligned.h`; do sed -i -e "s/asm-generic\/unaligned.h/linux\/unaligned.h/" $idonegit mv include/asm-generic/unaligned.h include/linux/unaligned.hgit mv tools/include/asm-generic/unaligned.h tools/include/linux/unaligned.hsed -i -e "/unaligned.h/d" include/asm-generic/Kbuildsed -i -e "s/__ASM_GENERIC/__LINUX/" include/linux/unaligned.h tools/include/linux/unaligned.h List of files: /linux-6.15/lib/crypto/sha256.c

3cbe18b0 - crypto: lib - add missing MODULE_DESCRIPTION() macros

Sun, 16 Jun 2024 06:14:57 +0000

crypto: lib - add missing MODULE_DESCRIPTION() macrosWith ARCH=arm, make allmodconfig && make W=1 C=1 reports:WARNING: modpost: missing MODULE_DESCRIPTION() in lib/crypto/libsha256.oAdd the missing invocation of the MODULE_DESCRIPTION() macro to allfiles which have a MODULE_LICENSE().This includes sha1.c and utils.c which, although they did not producea warning with the arm allmodconfig configuration, may cause thiswarning with other configurations.Signed-off-by: Jeff Johnson Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c

6c19f3bf - crypto: lib/sha256 - Use generic code from sha256_base

Thu, 11 May 2023 04:30:29 +0000

crypto: lib/sha256 - Use generic code from sha256_baseInstead of duplicating the sha256 block processing code, reusethe common code from crypto/sha256_base.h.Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c

70d391a8 - crypto: lib/sha256 - Remove redundant and unused sha224_update

Thu, 11 May 2023 04:29:36 +0000

crypto: lib/sha256 - Remove redundant and unused sha224_updateThe function sha224_update is exactly the same as sha256_update.Moreover it's not even used in the kernel so it can be removed.Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c

a24d22b2 - crypto: sha - split sha.h into sha1.h and sha2.h

Fri, 13 Nov 2020 05:20:21 +0000

crypto: sha - split sha.h into sha1.h and sha2.hCurrently contains declarations for both SHA-1 and SHA-2,and contains declarations for SHA-3.This organization is inconsistent, but more importantly SHA-1 is nolonger considered to be cryptographically secure. So to the extentpossible, SHA-1 shouldn't be grouped together with any of the other SHAversions, and usage of it should be phased out.Therefore, split into two headers and, and make everyone explicitly specify whether they wantthe declarations for SHA-1, SHA-2, or both.This avoids making the SHA-1 declarations visible to files that don'twant anything to do with SHA-1. It also prepares for potentially movingsha1.h into a new insecure/ or dangerous/ directory.Signed-off-by: Eric Biggers Acked-by: Ard Biesheuvel Acked-by: Jason A. Donenfeld Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c

18d05ca4 - crypto: lib/sha256 - Unroll LOAD and BLEND loops

Sun, 25 Oct 2020 14:31:19 +0000

crypto: lib/sha256 - Unroll LOAD and BLEND loopsUnrolling the LOAD and BLEND loops improves performance by ~8% on x86_64(tested on Broadwell Xeon) while not increasing code size too much.Signed-off-by: Arvind Sankar Reviewed-by: Eric Biggers Acked-by: Ard Biesheuvel Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c

63642d5c - crypto: lib/sha256 - Unroll SHA256 loop 8 times intead of 64

Sun, 25 Oct 2020 14:31:18 +0000

crypto: lib/sha256 - Unroll SHA256 loop 8 times intead of 64This reduces code size substantially (on x86_64 with gcc-10 the size ofsha256_update() goes from 7593 bytes to 1952 bytes including the newSHA256_K array), and on x86 is slightly faster than the full unroll(tested on Broadwell Xeon).Signed-off-by: Arvind Sankar Reviewed-by: Eric Biggers Acked-by: Ard Biesheuvel Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c

b8399819 - crypto: lib/sha256 - Clear W[] in sha256_update() instead of sha256_transform()

Sun, 25 Oct 2020 14:31:17 +0000

crypto: lib/sha256 - Clear W[] in sha256_update() instead of sha256_transform()The temporary W[] array is currently zeroed out once every call tosha256_transform(), i.e. once every 64 bytes of input data. Moving it tosha256_update() instead so that it is cleared only once per update cansave about 2-3% of the total time taken to compute the digest, with areasonable memset() implementation, and considerably more (~20%) with abad one (eg the x86 purgatory currently uses a memset() coded in C).Signed-off-by: Arvind Sankar Reviewed-by: Eric Biggers Acked-by: Ard Biesheuvel Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c

7a4295f6 - crypto: lib/sha256 - Don't clear temporary variables

Sun, 25 Oct 2020 14:31:16 +0000

crypto: lib/sha256 - Don't clear temporary variablesThe assignments to clear a through h and t1/t2 are optimized out by thecompiler because they are unused after the assignments.Clearing individual scalar variables is unlikely to be useful, as theymay have been assigned to registers, and even if stack spilling wasrequired, there may be compiler-generated temporaries that areimpossible to clear in any case.So drop the clearing of a through h and t1/t2.Signed-off-by: Arvind Sankar Reviewed-by: Eric Biggers Acked-by: Ard Biesheuvel Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c

1762818f - crypto: lib/sha256 - Use memzero_explicit() for clearing state

Sun, 25 Oct 2020 14:31:14 +0000

crypto: lib/sha256 - Use memzero_explicit() for clearing stateWithout the barrier_data() inside memzero_explicit(), the compiler mayoptimize away the state-clearing if it can tell that the state is notused afterwards. At least in lib/crypto/sha256.c:__sha256_final(), thefunction can get inlined into sha256(), in which case the memset isoptimized away.Signed-off-by: Arvind Sankar Reviewed-by: Eric Biggers Acked-by: Ard Biesheuvel Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c

9ea9c58b - crypto: lib/sha256 - add sha256() function

Wed, 08 Jul 2020 16:39:40 +0000

crypto: lib/sha256 - add sha256() functionAdd a function sha256() which computes a SHA-256 digest in one step,combining sha256_init() + sha256_update() + sha256_final().This is similar to how we also have blake2s().Reviewed-by: Ard Biesheuvel Tested-by: Hans de Goede Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c

13855fd8 - crypto: lib/sha256 - return void

Fri, 01 May 2020 16:42:29 +0000

crypto: lib/sha256 - return voidThe SHA-256 / SHA-224 library functions can't fail, so remove theuseless return value.Also long as the declarations are being changed anyway, also fix someparameter names in the declarations to match the definitions.Signed-off-by: Eric Biggers Reviewed-by: Jason A. Donenfeld Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c

c75c66bb - crypto: sha256 - Remove sha256/224_init code duplication

Sun, 01 Sep 2019 20:35:32 +0000

crypto: sha256 - Remove sha256/224_init code duplicationlib/crypto/sha256.c and include/crypto/sha256_base.h define99% identical functions to init a sha256_state struct for sha224 orsha256 use.This commit moves the functions from lib/crypto/sha256.c toinclude/crypto/sha.h (making them static inline) and makes thesha224/256_base_init static inline functions frominclude/crypto/sha256_base.h wrappers around the now alsostatic inline include/crypto/sha.h functions.Signed-off-by: Hans de Goede Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c

34d6245f - crypto: sha256 - Merge crypto/sha256.h into crypto/sha.h

Sun, 01 Sep 2019 20:35:31 +0000

crypto: sha256 - Merge crypto/sha256.h into crypto/sha.hThe generic sha256 implementation from lib/crypto/sha256.c uses datastructs defined in crypto/sha.h, so lets move the function prototypesthere too.Signed-off-by: Hans de Goede Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c

9ecf5ad5 - crypto: sha256 - Add missing MODULE_LICENSE() to lib/crypto/sha256.c

Sun, 25 Aug 2019 18:18:41 +0000

crypto: sha256 - Add missing MODULE_LICENSE() to lib/crypto/sha256.clib/crypto/sha256.c / lib/crypto/libsha256.o may end up being a module,so it needs a MODULE_LICENSE() line, add this.Signed-off-by: Hans de Goede Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c

7d2f5b0c - crypto: sha256 - Add sha224 support to sha256 library code

Sat, 17 Aug 2019 14:24:34 +0000

crypto: sha256 - Add sha224 support to sha256 library codeAdd sha224 support to the lib/crypto/sha256 library code. This will allowus to replace both the sha256 and sha224 parts of crypto/sha256_generic.cwhen we remove the code duplication in further patches in this series.Suggested-by: Eric Biggers Signed-off-by: Hans de Goede Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c

01d3aee8 - crypto: sha256 - Make lib/crypto/sha256.c suitable for generic use

Sat, 17 Aug 2019 14:24:33 +0000

crypto: sha256 - Make lib/crypto/sha256.c suitable for generic useBefore this commit lib/crypto/sha256.c has only been used in the s390 andx86 purgatory code, make it suitable for generic use:* Export interesting symbols* Add -D__DISABLE_EXPORTS to CFLAGS_sha256.o for purgatory builds to avoid the exports for the purgatory builds* Add to lib/crypto/Makefile and crypto/KconfigSigned-off-by: Hans de Goede Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c

906a4bb9 - crypto: sha256 - Use get/put_unaligned_be32 to get input, memzero_explicit

Sat, 17 Aug 2019 14:24:32 +0000

crypto: sha256 - Use get/put_unaligned_be32 to get input, memzero_explicitUse get/put_unaligned_be32 in lib/crypto/sha256.c to load / store dataso that it can be used with unaligned buffers too, making it more generic.And use memzero_explicit for better clearing of sensitive data.Note unlike other patches in this series this commit actually makesfunctional changes to the sha256 code as used by the purgatory code.This fully aligns the lib/crypto/sha256.c sha256 implementation with theone from crypto/sha256_generic.c allowing us to remove the latter infurther patches in this series.Signed-off-by: Hans de Goede Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c

ad767ee8 - crypto: sha256 - Move lib/sha256.c to lib/crypto

Sat, 17 Aug 2019 14:24:31 +0000

crypto: sha256 - Move lib/sha256.c to lib/cryptoGeneric crypto implementations belong under lib/crypto not directly inlib, likewise the header should be in include/crypto, not include/linux.Note that the code in lib/crypto/sha256.c is not yet available forgeneric use after this commit, it is still only used by the s390 and x86purgatory code. Making it suitable for generic use is done in furtherpatches in this series.Signed-off-by: Hans de Goede Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/sha256.c