Changes in Kconfig

edc8e80b - crypto: lib/Kconfig - hide library options

Fri, 14 Mar 2025 16:05:32 +0000

crypto: lib/Kconfig - hide library optionsAny driver that needs these library functions should already be selectingthe corresponding Kconfig symbols, so there is no real point in makingthese visible.The original patch that made these user selectable described problemswith drivers failing to select the code they use, but for consistencyit's better to always use 'select' on a symbol than to mix it with'depends on'.Fixes: e56e18985596 ("lib/crypto: add prompts back to crypto libraries")Signed-off-by: Arnd Bergmann Acked-by: Jarkko Sakkinen Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/Kconfig

ba89b4ea - crypto: lib/chachapoly - Drop dependency on CRYPTO_ALGAPI

Fri, 28 Feb 2025 12:11:38 +0000

crypto: lib/chachapoly - Drop dependency on CRYPTO_ALGAPIThe ChaCha20-Poly1305 library code uses the sg_miter API to processinput presented via scatterlists, except for the special case where thedigest buffer is not covered entirely by the same scatterlist entry asthe last byte of input. In that case, it uses scatterwalk_map_and_copy()to access the memory in the input scatterlist where the digest is stored.This results in a dependency on crypto/scatterwalk.c and therefore onCONFIG_CRYPTO_ALGAPI, which is unnecessary, as the sg_miter API alreadyprovides this functionality via sg_copy_to_buffer(). So use thatinstead, and drop the dependencies on CONFIG_CRYPTO_ALGAPI andCONFIG_CRYPTO.Reported-by: Arnd Bergmann Acked-by: Eric Biggers Signed-off-by: Ard Biesheuvel Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/Kconfig

17ec3e71 - crypto: lib/Kconfig - Hide arch options from user

Thu, 27 Feb 2025 07:48:39 +0000

crypto: lib/Kconfig - Hide arch options from userThe ARCH_MAY_HAVE patch missed arm64, mips and s390. But it mayalso lead to arch options being enabled but ineffective becauseof modular/built-in conflicts.As the primary user of all these options wireguard is selectingthe arch options anyway, make the same selections at the lib/cryptooption level and hide the arch options from the user.Instead of selecting them centrally from lib/crypto, simply setthe default of each arch option as suggested by Eric Biggers.Change the Crypto API generic algorithms to select the top-levellib/crypto options instead of the generic one as otherwise thereis no way to enable the arch options (Eric Biggers). Introduce aset of INTERNAL options to work around dependency cycles on theCONFIG_CRYPTO symbol.Fixes: 1047e21aecdf ("crypto: lib/Kconfig - Fix lib built-in failure when arch is modular")Reported-by: kernel test robot Reported-by: Arnd Bergmann Closes: https://lore.kernel.org/oe-kbuild-all/202502232152.JC84YDLp-lkp@intel.com/Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/Kconfig

1047e21a - crypto: lib/Kconfig - Fix lib built-in failure when arch is modular

Wed, 12 Feb 2025 04:48:55 +0000

crypto: lib/Kconfig - Fix lib built-in failure when arch is modularThe HAVE_ARCH Kconfig options in lib/crypto try to solve themodular versus built-in problem, but it still fails when thethe LIB option (e.g., CRYPTO_LIB_CURVE25519) is selected externally.Fix this by introducing a level of indirection with ARCH_MAY_HAVEKconfig options, these then go on to select the ARCH_HAVE optionsif the ARCH Kconfig options matches that of the LIB option.Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202501230223.ikroNDr1-lkp@intel.com/Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/Kconfig

f1354404 - crypto: lib - implement library version of AES in CFB mode

Mon, 29 Apr 2024 20:27:58 +0000

crypto: lib - implement library version of AES in CFB modeImplement AES in CFB mode using the existing, mostly constant-timegeneric AES library implementation. This will be used by the TPM codeto encrypt communications with TPM hardware, which is often a discretecomponent connected using sniffable wires or traces.While a CFB template does exist, using a skcipher is a major pain fornon-performance critical synchronous crypto where the algorithm is knownat compile time and the data is in contiguous buffers with valid kernelvirtual addresses.Tested-by: James Bottomley Reviewed-by: James Bottomley Reviewed-by: Jarkko Sakkinen Link: https://lore.kernel.org/all/20230216201410.15010-1-James.Bottomley@HansenPartnership.com/Signed-off-by: Ard Biesheuvel Signed-off-by: James Bottomley Tested-by: Jarkko Sakkinen Signed-off-by: Jarkko Sakkinen List of files: /linux-6.15/lib/crypto/Kconfig

520af5da - crypto: lib/aesgcm - Provide minimal library implementation

Thu, 03 Nov 2022 19:22:59 +0000

crypto: lib/aesgcm - Provide minimal library implementationImplement a minimal library version of AES-GCM based on the existinglibrary implementations of AES and multiplication in GF(2^128). Usingthese primitives, GCM can be implemented in a straight-forward manner.GCM has a couple of sharp edges, i.e., the amount of input dataprocessed with the same initialization vector (IV) should be capped toprotect the counter from 32-bit rollover (or carry), and the size of theauthentication tag should be fixed for a given key. [0]The former concern is addressed trivially, given that the function callAPI uses 32-bit signed types for the input lengths. It is still up tothe caller to avoid IV reuse in general, but this is not something wecan police at the implementation level.As for the latter concern, let's make the authentication tag size partof the key schedule, and only permit it to be configured as part of thekey expansion routine.Note that table based AES implementations are susceptible to knownplaintext timing attacks on the encryption key. The AES library alreadyattempts to mitigate this to some extent, but given that the countermode encryption used by GCM operates exclusively on known plaintext byconstruction (the IV and therefore the initial counter value are knownto an attacker), let's take some extra care to mitigate this, by callingthe AES library with interrupts disabled.[0] https://nvlpubs.nist.gov/nistpubs/legacy/sp/nistspecialpublication800-38d.pdfLink: https://lore.kernel.org/all/c6fb9b25-a4b6-2e4a-2dd1-63adda055a49@amd.com/Signed-off-by: Ard Biesheuvel Tested-by: Nikunj A Dadhania Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/Kconfig

61c581a4 - crypto: move gf128mul library into lib/crypto

Thu, 03 Nov 2022 19:22:57 +0000

crypto: move gf128mul library into lib/cryptoThe gf128mul library does not depend on the crypto API at all, so it canbe moved into lib/crypto. This will allow us to use it in other librarycode in a subsequent patch without having to depend on CONFIG_CRYPTO.While at it, change the Kconfig symbol name to align with other cryptolibrary implementations. However, the source file name is retained, asit is reflected in the module .ko filename, and changing this mightbreak things for users.Signed-off-by: Ard Biesheuvel Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/Kconfig

874b3019 - crypto: lib - remove unneeded selection of XOR_BLOCKS

Fri, 26 Aug 2022 05:04:56 +0000

crypto: lib - remove unneeded selection of XOR_BLOCKSCRYPTO_LIB_CHACHA_GENERIC doesn't need to select XOR_BLOCKS. It perhapswas thought that it's needed for __crypto_xor, but that's not the case.Enabling XOR_BLOCKS is problematic because the XOR_BLOCKS code runs abenchmark when it is initialized. That causes a boot time regression onsystems that didn't have it enabled before.Therefore, remove this unnecessary and problematic selection.Fixes: e56e18985596 ("lib/crypto: add prompts back to crypto libraries")Cc: stable@vger.kernel.orgSigned-off-by: Eric Biggers Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/Kconfig

6e78ad0b - crypto: lib - move __crypto_xor into utils

Mon, 25 Jul 2022 18:36:35 +0000

crypto: lib - move __crypto_xor into utilsCRYPTO_LIB_CHACHA depends on CRYPTO for __crypto_xor, defined incrypto/algapi.c. This is a layering violation because the dependenciesshould only go in the other direction (crypto/ => lib/crypto/). Alsothe correct dependency would be CRYPTO_ALGAPI, not CRYPTO. Fix this bymoving __crypto_xor into the utils module in lib/crypto/.Note that CRYPTO_LIB_CHACHA_GENERIC selected XOR_BLOCKS, which isunrelated and unnecessary. It was perhaps thought that XOR_BLOCKS wasneeded for __crypto_xor, but that's not the case.Signed-off-by: Eric Biggers Reviewed-by: Jason A. Donenfeld Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/Kconfig

7033b937 - crypto: lib - create utils module and move __crypto_memneq into it

Mon, 25 Jul 2022 18:36:34 +0000

crypto: lib - create utils module and move __crypto_memneq into itAs requested athttps://lore.kernel.org/r/YtEgzHuuMts0YBCz@gondor.apana.org.au, move__crypto_memneq into lib/crypto/ and put it under a new tristate. Thetristate is CRYPTO_LIB_UTILS, and it builds a module libcryptoutils. Asmore crypto library utilities are being added, this creates a singleplace for them to go without cluttering up the main lib directory.The module's main file will be lib/crypto/utils.c. However, leavememneq.c as its own file because of its nonstandard license.Signed-off-by: Eric Biggers Reviewed-by: Jason A. Donenfeld Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/Kconfig

ec8f7f48 - crypto: lib - make the sha1 library optional

Sat, 09 Jul 2022 21:18:49 +0000

crypto: lib - make the sha1 library optionalSince the Linux RNG no longer uses sha1_transform(), the SHA-1 libraryis no longer needed unconditionally. Make it possible to build theLinux kernel without the SHA-1 library by putting it behind a kconfigoption, and selecting this new option from the kconfig options that gatethe remaining users: CRYPTO_SHA1 for crypto/sha1_generic.c, BPF forkernel/bpf/core.c, and IPV6 for net/ipv6/addrconf.c.Unfortunately, since BPF is selected by NET, for now this can only makea difference for kernels built without networking support.Signed-off-by: Eric Biggers Reviewed-by: Jason A. Donenfeld Acked-by: Jakub Kicinski Acked-by: Alexei Starovoitov Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/Kconfig

abfed87e - crypto: memneq - move into lib/

Sat, 28 May 2022 10:24:29 +0000

crypto: memneq - move into lib/This is used by code that doesn't need CONFIG_CRYPTO, so move this intolib/ with a Kconfig option so that it can be selected by whatever needsit.This fixes a linker error Zheng pointed out whenCRYPTO_MANAGER_DISABLE_TESTS!=y and CRYPTO=m: lib/crypto/curve25519-selftest.o: In function `curve25519_selftest': curve25519-selftest.c:(.init.text+0x60): undefined reference to `__crypto_memneq' curve25519-selftest.c:(.init.text+0xec): undefined reference to `__crypto_memneq' curve25519-selftest.c:(.init.text+0x114): undefined reference to `__crypto_memneq' curve25519-selftest.c:(.init.text+0x154): undefined reference to `__crypto_memneq'Reported-by: Zheng Bin Cc: Eric Biggers Cc: stable@vger.kernel.orgFixes: aa127963f1ca ("crypto: lib/curve25519 - re-add selftests")Signed-off-by: Jason A. Donenfeld Reviewed-by: Eric Biggers Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/Kconfig

920b0442 - crypto: memneq - move into lib/

Sat, 28 May 2022 10:24:29 +0000

ca7984df - Revert "crypto: poly1305 - cleanup stray CRYPTO_LIB_POLY1305_RSIZE"

Sat, 28 May 2022 11:09:18 +0000

Revert "crypto: poly1305 - cleanup stray CRYPTO_LIB_POLY1305_RSIZE"This reverts commit 8bdc2a190105e862dfe7a4033f2fd385b7e58ae8.It got merged a bit prematurely and shortly after the kernel test robotand Sudip pointed out build failures: arm: imx_v6_v7_defconfig and multi_v7_defconfig mips: decstation_64_defconfig, decstation_defconfig, decstation_r4k_defconfig In file included from crypto/chacha20poly1305.c:13: include/crypto/poly1305.h:56:46: error: 'CONFIG_CRYPTO_LIB_POLY1305_RSIZE' undeclared here (not in a function); did you mean 'CONFIG_CRYPTO_POLY1305_MODULE'? 56 | struct poly1305_key opaque_r[CONFIG_CRYPTO_LIB_POLY1305_RSIZE]; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~We could attempt to fix this by listing the dependencies piecemeal, butit's not as obvious as it looks: drivers like caam use this macro inheaders even if there's no .o compiled in that makes use of it. Soactually fixing this might require a bit more of a comprehensiveapproach, rather than whack-a-mole with hunting down which drivers usewhich headers which use this macro.Therefore, this commit just reverts the change, and maybe the problemcan be visited on the next rainy day.Reported-by: Sudip Mukherjee Reported-by: kernel test robot Fixes: 8bdc2a190105 ("crypto: poly1305 - cleanup stray CRYPTO_LIB_POLY1305_RSIZE")Signed-off-by: Jason A. Donenfeld Signed-off-by: Linus Torvalds List of files: /linux-6.15/lib/crypto/Kconfig

8bdc2a19 - crypto: poly1305 - cleanup stray CRYPTO_LIB_POLY1305_RSIZE

Thu, 26 May 2022 09:35:47 +0000

crypto: poly1305 - cleanup stray CRYPTO_LIB_POLY1305_RSIZEWhen CRYPTO_LIB_POLY1305 is unset, CRYPTO_LIB_POLY1305_RSIZEis still set in the Kconfig, cluttering things.Fix this by making CRYPTO_LIB_POLY1305_RSIZE depend onCRYPTO_LIB_POLY1305.Suggested-by: Linus Torvalds Signed-off-by: Jason A. Donenfeld Signed-off-by: Linus Torvalds List of files: /linux-6.15/lib/crypto/Kconfig

d2825fa9 - crypto: sm3,sm4 - move into crypto directory

Mon, 14 Mar 2022 03:11:01 +0000

crypto: sm3,sm4 - move into crypto directoryThe lib/crypto libraries live in lib because they are used by variousdrivers of the kernel. In contrast, the various helper functions incrypto are there because they're used exclusively by the crypto API. TheSM3 and SM4 helper functions were erroniously moved into lib/crypto/instead of crypto/, even though there are no in-kernel users outside ofthe crypto API of those functions. This commit moves them into crypto/.Cc: Herbert Xu Cc: Tianjia Zhang Cc: Eric Biggers Signed-off-by: Jason A. Donenfeld Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/Kconfig

eb90686d - crypto: sm3 - create SM3 stand-alone library

Fri, 07 Jan 2022 12:06:55 +0000

crypto: sm3 - create SM3 stand-alone libraryStand-alone implementation of the SM3 algorithm. It is designedto have as little dependencies as possible. In other cases youshould generally use the hash APIs from include/crypto/hash.h.Especially when hashing large amounts of data as those APIs maybe hw-accelerated. In the new SM3 stand-alone library,sm3_transform() has also been optimized, instead of simply usingthe code in sm3_generic.Signed-off-by: Tianjia Zhang Reviewed-by: Gilad Ben-Yossef Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/Kconfig

e56e1898 - lib/crypto: add prompts back to crypto libraries

Wed, 12 Jan 2022 14:01:38 +0000

lib/crypto: add prompts back to crypto librariesCommit 6048fdcc5f269 ("lib/crypto: blake2s: include as built-in") tookaway a number of prompt texts from other crypto libraries. This makesvalues flip from built-in to module when oldconfig runs, and causesproblems when these crypto libs need to be built in for thingslikeBIG_KEYS.Fixes: 6048fdcc5f269 ("lib/crypto: blake2s: include as built-in")Cc: Herbert Xu Cc: linux-crypto@vger.kernel.orgSigned-off-by: Justin M. Forbes [Jason: - moved menu into submenu of lib/ instead of root menu - fixed chacha sub-dependencies for CONFIG_CRYPTO]Signed-off-by: Jason A. Donenfeld List of files: /linux-6.15/lib/crypto/Kconfig

6048fdcc - lib/crypto: blake2s: include as built-in

Wed, 22 Dec 2021 13:56:58 +0000

lib/crypto: blake2s: include as built-inIn preparation for using blake2s in the RNG, we change the way that itis wired-in to the build system. Instead of using ifdefs to select theright symbol, we use weak symbols. And because ARM doesn't need thegeneric implementation, we make the generic one default only if an archlibrary doesn't need it already, and then have arch libraries that doneed it opt-in. So that the arch libraries can remain tristate ratherthan bool, we then split the shash part from the glue code.Acked-by: Herbert Xu Acked-by: Ard Biesheuvel Acked-by: Greg Kroah-Hartman Cc: Masahiro Yamada Cc: linux-kbuild@vger.kernel.orgCc: linux-crypto@vger.kernel.orgSigned-off-by: Jason A. Donenfeld List of files: /linux-6.15/lib/crypto/Kconfig

2b31277a - crypto: sm4 - create SM4 library based on sm4 generic code

Tue, 20 Jul 2021 03:46:39 +0000

crypto: sm4 - create SM4 library based on sm4 generic codeTake the existing small footprint and mostly time invariant C codeand turn it into a SM4 library that can be used for non-performancecritical, casual use of SM4, and as a fallback for, e.g., SIMD codethat needs a secondary path that can be taken in contexts where theSIMD unit is off limits.Secondly, some codes have been optimized, such as unrolling smalltimes loop, removing unnecessary memory shifts, exporting sbox, fk,ck arrays, and basic encryption and decryption functions.Signed-off-by: Tianjia Zhang Signed-off-by: Herbert Xu List of files: /linux-6.15/lib/crypto/Kconfig