Changes in rdma_user_cm.h

94dfc73e - treewide: uapi: Replace zero-length arrays with flexible-array members

Thu, 07 Apr 2022 00:36:51 +0000

treewide: uapi: Replace zero-length arrays with flexible-array membersThere is a regular need in the kernel to provide a way to declarehaving a dynamically sized set of trailing elements in a structure.Kernel code should always use “flexible array members”[1] for thesecases. The older style of one-element or zero-length arrays shouldno longer be used[2].This code was transformed with the help of Coccinelle:(linux-5.19-rc2$ spatch --jobs $(getconf _NPROCESSORS_ONLN) --sp-file script.cocci --include-headers --dir . > output.patch)@@identifier S, member, array;type T1, T2;@@struct S { ... T1 member; T2 array[- 0 ];};-fstrict-flex-arrays=3 is coming and we need to land these changesto prevent issues like these in the short future:../fs/minix/dir.c:337:3: warning: 'strcpy' will always overflow; destination buffer has size 0,but the source string has length 2 (including NUL byte) [-Wfortify-source] strcpy(de3->name, "."); ^Since these are all [0] to [] changes, the risk to UAPI is nearly zero. Ifthis breaks anything, we can use a union with a new member name.[1] https://en.wikipedia.org/wiki/Flexible_array_member[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arraysLink: https://github.com/KSPP/linux/issues/78Build-tested-by: kernel test robot Link: https://lore.kernel.org/lkml/62b675ec.wKX6AOZ6cbE71vtF%25lkp@intel.com/Acked-by: Dan Williams # For ndctl.hSigned-off-by: Gustavo A. R. Silva List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

8094ba0a - RDMA/cma: Provide ECE reject reason

Tue, 26 May 2020 10:33:04 +0000

RDMA/cma: Provide ECE reject reasonIBTA declares "vendor option not supported" reject reason in REJ messagesif passive side doesn't want to accept proposed ECE options.Due to the fact that ECE is managed by userspace, there is a need to letusers to provide such rejected reason.Link: https://lore.kernel.org/r/20200526103304.196371-7-leon@kernel.orgSigned-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

0cb15372 - RDMA/cma: Connect ECE to rdma_accept

Tue, 26 May 2020 10:33:03 +0000

RDMA/cma: Connect ECE to rdma_acceptThe rdma_accept() is called by both passive and active sides of CMIDconnection to mark readiness to start data transfer. For passive side,this is called explicitly, for active side, it is called implicitly whilereceiving REP message.Provide ECE data to rdma_accept function needed for passive side to sendthat REP message.Link: https://lore.kernel.org/r/20200526103304.196371-6-leon@kernel.orgSigned-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

93531ee7 - RDMA/ucma: Deliver ECE parameters through UCMA events

Tue, 26 May 2020 10:33:01 +0000

RDMA/ucma: Deliver ECE parameters through UCMA eventsPassive side of CMID connection receives ECE request through REQ messageand needs to respond with relevant REP message which will be forwarded toactive side.The UCMA events interface is responsible for such communication with theuser space (librdmacm). Extend it to provide ECE wire data.Link: https://lore.kernel.org/r/20200526103304.196371-4-leon@kernel.orgSigned-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

34e2ab57 - RDMA/ucma: Extend ucma_connect to receive ECE parameters

Tue, 26 May 2020 10:33:00 +0000

RDMA/ucma: Extend ucma_connect to receive ECE parametersActive side of CMID initiates connection through librdmacm'srdma_connect() and kernel's ucma_connect(). Extend UCMA interface tohandle those new parameters.Link: https://lore.kernel.org/r/20200526103304.196371-3-leon@kernel.orgSigned-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

17793833 - RDMA/ucma: Return stable IB device index as identifier

Mon, 04 May 2020 13:25:41 +0000

RDMA/ucma: Return stable IB device index as identifierThe librdmacm uses node_guid as identifier to correlate between IB devicesand CMA devices. However FW resets cause to such "connection" to be lostand require from the user to restart its application.Extend UCMA to return IB device index, which is stable identifier.Link: https://lore.kernel.org/r/20200504132541.355710-1-leon@kernel.orgSigned-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

2c1619ed - IB/cma: Define option to set ack timeout and pack tos_set

Thu, 24 Jan 2019 12:18:15 +0000

IB/cma: Define option to set ack timeout and pack tos_setDefine new option in 'rdma_set_option' to override calculated QP timeoutwhen requested to provide QP attributes to modify a QP.At the same time, pack tos_set to be bitfield.Signed-off-by: Danit Goldberg Reviewed-by: Moni Shoua Signed-off-by: Leon Romanovsky Reviewed-by: Parav Pandit Signed-off-by: Jason Gunthorpe List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

d50e14ab - uapi: Fix SPDX tags for files referring to the 'OpenIB.org' license

Fri, 20 Apr 2018 15:49:10 +0000

uapi: Fix SPDX tags for files referring to the 'OpenIB.org' licenseBased on discussion with Kate Stewart this license is not aBSD-2-Clause, but is now formally identified as Linux-OpenIBby SPDX.The key difference between the licenses is in the 'warranty'paragraph.if_infiniband.h refers to the 'OpenIB.org' license, butdoes not include the text, instead it links to an obsoleteweb site that contains a license that matches the BSD-2-ClauseSPX. There is no 'three clause' version of the OpenIB.orglicense.Signed-off-by: Jason Gunthorpe Acked-by: David S. Miller Signed-off-by: Doug Ledford List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

2253fc0c - RDMA/CMA: Add rdma_port_space to UAPI

Tue, 27 Mar 2018 15:38:07 +0000

RDMA/CMA: Add rdma_port_space to UAPISince the rdma_port_space enum is being passed between user and kernel foruser cm_id setup, we need it in a UAPI header. So add it tordma_user_cm.h.This also fixes the cm_id restrack changes which pass up the port spacevalue via the RDMA_NLDEV_ATTR_RES_PS attribute.Fixes: 00313983cda6 ("RDMA/nldev: provide detailed CM_ID information")Signed-off-by: Steve Wise Signed-off-by: Jason Gunthorpe List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

26b99066 - RDMA: Change all uapi headers to use __aligned_u64 instead of __u64

Tue, 20 Mar 2018 20:19:51 +0000

RDMA: Change all uapi headers to use __aligned_u64 instead of __u64The new auditing standard for the subsystem will be to only use__aligned_64 in uapi headers to try and prevent 32/64 compat bugsfrom existing in the future.Changing all existing usage will help ensure new developers copy theright idea.The before/after of this patch was tested using pahole on 32 and 64bit compiles to confirm it has no change in the structure layout, sothis patch is a NOP.Signed-off-by: Jason Gunthorpe List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

611cb92b - RDMA/ucma: Fix uABI structure layouts for 32/64 compat

Tue, 20 Mar 2018 20:19:47 +0000

RDMA/ucma: Fix uABI structure layouts for 32/64 compatThe rdma_ucm_event_resp is a different length on 32 and 64 bit compiles.The kernel requires it to be the expected length or longer so 32 bitbuilds running on a 64 bit kernel will not work.Retain full compat by having all kernels accept a struct with or withoutthe trailing reserved field.Signed-off-by: Jason Gunthorpe List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

e2be04c7 - License cleanup: add SPDX license identifier to uapi header files with a license

Wed, 01 Nov 2017 14:09:13 +0000

License cleanup: add SPDX license identifier to uapi header files with a licenseMany user space API headers have licensing information, which is eitherincomplete, badly formatted or just a shorthand for referring to thelicense under which the file is supposed to be. This makes it hard forcompliance tools to determine the correct license.Update these files with an SPDX license identifier. The identifier waschosen based on the license information in the file.GPL/LGPL licensed headers get the matching GPL/LGPL SPDX licenseidentifier with the added 'WITH Linux-syscall-note' exception, which isthe officially assigned exception identifier for the kernel syscallexception: NOTE! This copyright does *not* cover user programs that use kernel services by normal system calls - this is merely considered normal use of the kernel, and does *not* fall under the heading of "derived work".This exception makes it possible to include GPL headers into non GPLcode, without confusing license compliance tools.Headers which have either explicit dual licensing or are just licensedunder a non GPL license are updated with the corresponding SPDXidentifier and the GPLv2 with syscall exception identifier. The formatis: ((GPL-2.0 WITH Linux-syscall-note) OR SPDX-ID-OF-OTHER-LICENSE)SPDX license identifiers are a legally binding shorthand, which can beused instead of the full boiler plate text. The update does not removeexisting license information as this has to be done on a case by casebasis and the copyright holders might have to be consulted. This willhappen in a separate step.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne. See the previous patch in this series for themethodology of how this patch was researched.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

35493294 - rdma UAPI: Use __kernel_sockaddr_storage

Thu, 27 Oct 2016 16:51:17 +0000

rdma UAPI: Use __kernel_sockaddr_storageThe kernel side is #ifdef'd to this type, and the UAPI headershould use it directly. It has slightly different alignmentrequirments from the usual user space version.Signed-off-by: Jason Gunthorpe Reviewed-by: Leon Romanovsky Signed-off-by: Doug Ledford List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

ab15c95a - IB/core: Support for CMA multicast join flags

Wed, 06 Jul 2016 13:36:35 +0000

IB/core: Support for CMA multicast join flagsAdded UCMA and CMA support for multicast join flags. Flags arepassed using UCMA CM join command previously reserved fields.Currently supporting two join flags indicating two differentmulticast JoinStates:1. Full Member: The initiator creates the Multicast group(MCG) if it wasn't previously created, can send Multicast messages to the group and receive messages from the MCG.2. Send Only Full Member: The initiator creates the Multicast group(MCG) if it wasn't previously created, can send Multicast messages to the group but doesn't receive any messages from the MCG. IB: Send Only Full Member requires a query of ClassPortInfo to determine if SM/SA supports this option. If SM/SA doesn't support Send-Only there will be no join request sent and an error will be returned. ETH: When Send Only Full Member is requested no IGMP join will be sent.Signed-off-by: Alex Vesker Reviewed by: Hal Rosenstock Signed-off-by: Leon Romanovsky Signed-off-by: Doug Ledford List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

db1044d4 - RDMA/uapi: Include socket.h in rdma_user_cm.h

Tue, 12 Aug 2014 23:20:11 +0000

RDMA/uapi: Include socket.h in rdma_user_cm.hadded struct sockaddr_storage to rdma_user_cm.h without also adding aninclude for linux/socket.h to make sure it is defined. Systemtapneeds the header files to build standalone and cannot rely on otherfiles to pre-include other headers, so add linux/socket.h to the listof includes in this file.Fixes: ee7aed4528f ("RDMA/ucma: Support querying for AF_IB addresses")Signed-off-by: Doug Ledford Signed-off-by: Roland Dreier List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

5bc2b7b3 - RDMA/ucma: Allow user space to specify AF_IB when joining multicast

Wed, 29 May 2013 17:09:33 +0000

RDMA/ucma: Allow user space to specify AF_IB when joining multicastAllow user space applications to join multicast groups using MGIDsdirectly. MGIDs may be passed using AF_IB addresses. Since thecurrent multicast join command only supports addresses as large assockaddr_in6, define a new structure for joining addresses specifiedusing sockaddr_ib.Since AF_IB allows the user to specify the qkey when resolving aremote UD QP address, when joining the multicast group use the qkeyvalue, if one has been assigned.Signed-off-by: Sean Hefty Signed-off-by: Roland Dreier List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

209cf2a7 - RDMA/ucma: Allow user space to pass AF_IB into resolve

Wed, 29 May 2013 17:09:32 +0000

RDMA/ucma: Allow user space to pass AF_IB into resolveAllow user space applications to call resolve_addr using AF_IB. Tosupport sockaddr_ib, we need to define a new structure capable ofhandling the larger address size.Signed-off-by: Sean Hefty Signed-off-by: Roland Dreier List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

eebe4c3a - RDMA/ucma: Allow user space to bind to AF_IB

Wed, 29 May 2013 17:09:31 +0000

RDMA/ucma: Allow user space to bind to AF_IBSupport user space binding to addresses using AF_IB. Sincesockaddr_ib is larger than sockaddr_in6, we need to define a largerstructure when binding using AF_IB. This time we use sockaddr_storageto cover future cases.Signed-off-by: Sean Hefty Signed-off-by: Roland Dreier List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

05ad9457 - RDMA/ucma: Name changes to indicate only IP addresses supported

Wed, 29 May 2013 17:09:30 +0000

RDMA/ucma: Name changes to indicate only IP addresses supportedSeveral commands into the RDMA CM from user space are restricted tosupporting addresses which fit into a sockaddr_in6 structure: bindaddress, resolve address, and join multicast.With the addition of AF_IB, we need to support addresses which arelarger than sockaddr_in6. This will be done by adding new commandsthat exchange address information using sockaddr_storage. However, tosupport existing applications, we maintain the current commands andstructures, but rename them to indicate that they only support IPv4and v6 addresses.Signed-off-by: Sean Hefty Signed-off-by: Roland Dreier List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h

edaa7a55 - RDMA/ucma: Add ability to query GID addresses

Wed, 29 May 2013 17:09:29 +0000

RDMA/ucma: Add ability to query GID addressesPart of address resolution is mapping IP addresses to IB GIDs. Withthe changes to support querying larger addresses and more path records,also provide a way to query IB GIDs after resolution completes.Signed-off-by: Sean Hefty Signed-off-by: Roland Dreier List of files: /linux-6.15/include/uapi/rdma/rdma_user_cm.h