Changes in jbd2.h

b98dba27 - jbd2: remove journal_clean_one_cp_list()

Tue, 06 Jun 2023 13:59:25 +0000

jbd2: remove journal_clean_one_cp_list()journal_clean_one_cp_list() and journal_shrink_one_cp_list() are almostthe same, so merge them into journal_shrink_one_cp_list(), remove thenr_to_scan parameter, always scan and try to free the whole checkpointlist.Signed-off-by: Zhang Yi Reviewed-by: Jan Kara Link: https://lore.kernel.org/r/20230606135928.434610-4-yi.zhang@huaweicloud.comSigned-off-by: Theodore Ts'o List of files: /linux-6.15/include/trace/events/jbd2.h

d87a7b4c - jbd2: use the correct print format

Tue, 11 Oct 2022 11:33:44 +0000

jbd2: use the correct print formatThe print format error was found when using ftrace event: <...>-1406 [000] .... 23599442.895823: jbd2_end_commit: dev 252,8 transaction -1866216965 sync 0 head -1866217368 <...>-1406 [000] .... 23599442.896299: jbd2_start_commit: dev 252,8 transaction -1866216964 sync 0Use the correct print format for transaction, head and tid.Fixes: 879c5e6b7cb4 ('jbd2: convert instrumentation from markers to tracepoints')Signed-off-by: Bixuan Cui Reviewed-by: Jason Yan Link: https://lore.kernel.org/r/1665488024-95172-1-git-send-email-cuibixuan@linux.alibaba.comSigned-off-by: Theodore Ts'o Cc: stable@kernel.org List of files: /linux-6.15/include/trace/events/jbd2.h

6669797b - fs/jbd2: Fix the documentation of the jbd2_write_superblock() callers

Thu, 14 Jul 2022 18:07:22 +0000

fs/jbd2: Fix the documentation of the jbd2_write_superblock() callersCommit 2a222ca992c3 ("fs: have submit_bh users pass in op and flagsseparately") renamed the jbd2_write_superblock() 'write_op' argument into'write_flags'. Propagate this change to the jbd2_write_superblock()callers. Additionally, change the type of 'write_flags' into blk_opf_t.Cc: Mike Christie Cc: Theodore Ts'o Signed-off-by: Bart Van Assche Link: https://lore.kernel.org/r/20220714180729.1065367-57-bvanassche@acm.orgSigned-off-by: Jens Axboe List of files: /linux-6.15/include/trace/events/jbd2.h

4ba3fcdd - jbd2,ext4: add a shrinker to release checkpointed buffers

Thu, 10 Jun 2021 11:24:37 +0000

jbd2,ext4: add a shrinker to release checkpointed buffersCurrent metadata buffer release logic in bdev_try_to_free_page() havea lot of use-after-free issues when umount filesystem concurrently, andit is difficult to fix directly because ext4 is the only user ofs_op->bdev_try_to_free_page callback and we may have to add more specialrefcount or lock that is only used by ext4 into the common vfs layer,which is unacceptable.One better solution is remove the bdev_try_to_free_page callback, butthe real problem is we cannot easily release journal_head on thecheckpointed buffer, so try_to_free_buffers() cannot release buffers andpage under memory pressure, which is more likely to triggerout-of-memory. So we cannot remove the callback directly before we findanother way to release journal_head.This patch introduce a shrinker to free journal_head on the checkpointedtransaction. After the journal_head got freed, try_to_free_buffers()could free buffer properly.Signed-off-by: Zhang Yi Suggested-by: Jan Kara Reviewed-by: Jan Kara Link: https://lore.kernel.org/r/20210610112440.3438139-6-yi.zhang@huawei.comSigned-off-by: Theodore Ts'o List of files: /linux-6.15/include/trace/events/jbd2.h

0094f981 - jbd2: Provide trace event for handle restarts

Tue, 05 Nov 2019 16:44:30 +0000

jbd2: Provide trace event for handle restartsProvide trace event for handle restarts to ease debugging.Reviewed-by: Theodore Ts'o Signed-off-by: Jan Kara Link: https://lore.kernel.org/r/20191105164437.32602-24-jack@suse.czSigned-off-by: Theodore Ts'o List of files: /linux-6.15/include/trace/events/jbd2.h

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/include/trace/events/jbd2.h

f783f091 - jbd2: trace when lock_buffer in do_get_write_access takes a long time

Sun, 21 Apr 2013 20:47:54 +0000

jbd2: trace when lock_buffer in do_get_write_access takes a long timeWhile investigating interactivity problems it was clear that processessometimes stall for long periods of times if an attempt is made tolock a buffer which is undergoing writeback. It would stall ina trace looking something like[] __lock_buffer+0x2e/0x30[] do_get_write_access+0x43f/0x4b0[] jbd2_journal_get_write_access+0x2b/0x50[] __ext4_journal_get_write_access+0x39/0x80[] ext4_reserve_inode_write+0x78/0xa0[] ext4_mark_inode_dirty+0x49/0x220[] ext4_dirty_inode+0x41/0x60[] __mark_inode_dirty+0x4e/0x2d0[] update_time+0x79/0xc0[] file_update_time+0x98/0x100[] __generic_file_aio_write+0x17c/0x3b0[] generic_file_aio_write+0x7a/0xf0[] ext4_file_write+0x83/0xd0[] do_sync_write+0xa3/0xe0[] vfs_write+0xae/0x180[] sys_write+0x4d/0x90[] system_call_fastpath+0x1a/0x1f[] 0xffffffffffffffffSigned-off-by: Mel Gorman Signed-off-by: "Theodore Ts'o" List of files: /linux-6.15/include/trace/events/jbd2.h

343d9c28 - jbd2: add tracepoints which provide per-handle statistics

Fri, 08 Feb 2013 18:00:22 +0000

jbd2: add tracepoints which provide per-handle statistics Handles which stay open a long time are problematic when it comes timeto close down a transaction so it can be committed. These tracepointswill help us determine which ones are the problematic ones, and tovalidate whether changes makes things better or worse.Signed-off-by: "Theodore Ts'o" List of files: /linux-6.15/include/trace/events/jbd2.h

9fff24aa - jbd2: track request delay statistics

Thu, 07 Feb 2013 03:30:23 +0000

jbd2: track request delay statisticsTrack the delay between when we first request that the commit beginand when it actually begins, so we can see how much of a gap exists.In theory, this should just be the remaining scheduling quantuum ofthe thread which requested the commit (assuming it was not asynchronous operation which triggered the commit request) plusscheduling overhead; however, it's possible that real time processesmight get in the way of letting the kjournald thread from executing.Signed-off-by: "Theodore Ts'o" List of files: /linux-6.15/include/trace/events/jbd2.h

79feb521 - jbd2: issue cache flush after checkpointing even with internal journal

Wed, 14 Mar 2012 02:22:54 +0000

jbd2: issue cache flush after checkpointing even with internal journalWhen we reach jbd2_cleanup_journal_tail(), there is no guarantee thatcheckpointed buffers are on a stable storage - especially if buffers werewritten out by jbd2_log_do_checkpoint(), they are likely to be only in disk'scaches. Thus when we update journal superblock effectively removing oldtransaction from journal, this write of superblock can get to stable storagebefore those checkpointed buffers which can result in filesystem corruptionafter a crash. Thus we must unconditionally issue a cache flush before weupdate journal superblock in these cases.A similar problem can also occur if journal superblock is written only indisk's caches, other transaction starts reusing space of the transactioncleaned from the log and power failure happens. Subsequent journal replay wouldstill try to replay the old transaction but some of it's blocks may be alreadyoverwritten by the new transaction. For this reason we must use WRITE_FUA whenupdating log tail and we must first write new log tail to disk and updatein-memory information only after that.Signed-off-by: Jan Kara Signed-off-by: "Theodore Ts'o" List of files: /linux-6.15/include/trace/events/jbd2.h

24bcc89c - jbd2: split updating of journal superblock and marking journal empty

Tue, 13 Mar 2012 19:41:04 +0000

jbd2: split updating of journal superblock and marking journal emptyThere are three case of updating journal superblock. In the first case, we wantto mark journal as empty (setting s_sequence to 0), in the second case we wantto update log tail, in the third case we want to update s_errno. Split thesecases into separate functions. It makes the code slightly more straightforwardand later patches will make the distinction even more important.Signed-off-by: Jan Kara Signed-off-by: "Theodore Ts'o" List of files: /linux-6.15/include/trace/events/jbd2.h

2201c590 - jbd2: add drop_transaction/update_superblock_end tracepoints

Mon, 20 Feb 2012 22:53:01 +0000

jbd2: add drop_transaction/update_superblock_end tracepointsThis patch adds trace_jbd2_drop_transaction andtrace_jbd2_update_superblock_end because there are similar tracepointsin jbd and they are needed in jbd2 as well.Reviewed-by: Lukas Czerner Signed-off-by: Seiji Aguchi Signed-off-by: "Theodore Ts'o" List of files: /linux-6.15/include/trace/events/jbd2.h

4862fd60 - jbd2: remove jbd2_dev_to_name() from jbd2 tracepoints

Mon, 11 Jul 2011 02:05:08 +0000

jbd2: remove jbd2_dev_to_name() from jbd2 tracepointsUsing function calls in TP_printk causes perf heartburn, so print theMAJOR/MINOR device numbers instead.Signed-off-by: "Theodore Ts'o" List of files: /linux-6.15/include/trace/events/jbd2.h

0562e0ba - ext4: add more tracepoints and use dev_t in the trace buffer

Tue, 22 Mar 2011 01:38:05 +0000

ext4: add more tracepoints and use dev_t in the trace buffer- Add more ext4 tracepoints.- Change ext4 tracepoints to use dev_t field with MAJOR/MINOR macrosso that we can save 4 bytes in the ring buffer on some platforms.- Add sync_mode to ext4_da_writepages, ext4_da_write_pages, andext4_da_writepages_result tracepoints. Also remove for_reclaimfield from ext4_da_writepages since it is usually not very useful.Signed-off-by: Jiaying Zhang Signed-off-by: "Theodore Ts'o" List of files: /linux-6.15/include/trace/events/jbd2.h

a269029d - ext4,jbd2: convert tracepoints to use major/minor numbers

Thu, 28 Oct 2010 02:08:50 +0000

ext4,jbd2: convert tracepoints to use major/minor numbersUnfortunately perf can't deal with anything other than direct structureaccesses in the TP_printk() section. It will drop dead when it seesjbd2_dev_to_name() in the "print fmt" section of the tracepoint.Addresses-Google-Bug: 3138508Signed-off-by: "Theodore Ts'o" List of files: /linux-6.15/include/trace/events/jbd2.h

71f2be21 - ext4: Add new tracepoint for jbd2_cleanup_journal_tail

Wed, 23 Dec 2009 12:45:44 +0000

ext4: Add new tracepoint for jbd2_cleanup_journal_tailSigned-off-by: "Theodore Ts'o" List of files: /linux-6.15/include/trace/events/jbd2.h

071688f3 - tracing: Convert some jbd2 events to DEFINE_EVENT

Thu, 26 Nov 2009 07:06:55 +0000

tracing: Convert some jbd2 events to DEFINE_EVENTUse DECLARE_EVENT_CLASS to remove duplicate code: text data bss dec hex filename 34903 1693 448 37044 90b4 fs/jbd2/journal.o.old 31931 1693 416 34040 84f8 fs/jbd2/journal.oFour events are converted: jbd2_commit: jbd2_start_commit, jbd2_commit_{locking, flushing, logging}No change in functionality.Signed-off-by: Li Zefan Cc: Theodore Ts'o Cc: Steven Rostedt Cc: Frederic Weisbecker LKML-Reference: <4B0E290F.7030909@cn.fujitsu.com>Signed-off-by: Ingo Molnar List of files: /linux-6.15/include/trace/events/jbd2.h

bf699327 - jbd2: Use tracepoints for history file

Wed, 30 Sep 2009 04:32:06 +0000

jbd2: Use tracepoints for history fileThe /proc/fs/jbd2//history was maintained manually; by usingtracepoints, we can get all of the existing functionality of the /procfile plus extra capabilities thanks to the ftrace infrastructure. Wesave memory as a bonus.Signed-off-by: "Theodore Ts'o" List of files: /linux-6.15/include/trace/events/jbd2.h

a3710fd1 - ext4: fix tracepoint format string warnings

Thu, 17 Sep 2009 12:50:18 +0000

ext4: fix tracepoint format string warningsUnlike on some other architectures ino_t is an unsigned int on s390.So add an explicit cast to avoid lots of compile warnings:In file included from include/trace/ftrace.h:285, from include/trace/define_trace.h:61, from include/trace/events/ext4.h:711, from fs/ext4/super.c:50:include/trace/events/ext4.h: In function 'ftrace_raw_output_ext4_free_inode':include/trace/events/ext4.h:12: warning: format '%lu' expects type 'long unsigned int', but argument 4 has type 'ino_t'Signed-off-by: Heiko Carstens Signed-off-by: "Theodore Ts'o" List of files: /linux-6.15/include/trace/events/jbd2.h

d0b6e04a - tracing/events: Move TRACE_SYSTEM outside of include guard

Mon, 13 Jul 2009 02:33:21 +0000

tracing/events: Move TRACE_SYSTEM outside of include guardIf TRACE_INCLDUE_FILE is defined, will be included and compiled, otherwise it will beSo TRACE_SYSTEM should be defined outside of #if proctection,just like TRACE_INCLUDE_FILE.Imaging this scenario: #include -> TRACE_SYSTEM == foo ... #include -> TRACE_SYSTEM == bar ... #define CREATE_TRACE_POINTS #include -> TRACE_SYSTEM == bar !!!and then bar.h will be included and compiled.Signed-off-by: Li Zefan Cc: Steven Rostedt Cc: Frederic Weisbecker LKML-Reference: <4A5A9CF1.2010007@cn.fujitsu.com>Signed-off-by: Ingo Molnar List of files: /linux-6.15/include/trace/events/jbd2.h