Changes in x25.h

01d86846 - x25: Correct spelling in x25.h

Thu, 22 Aug 2024 12:57:32 +0000

x25: Correct spelling in x25.hCorrect spelling in x25.hAs reported by codespell.Signed-off-by: Simon Horman Reviewed-by: Martin Schiller Link: https://patch.msgid.link/20240822-net-spell-v1-11-3a98971ce2d2@kernel.orgSigned-off-by: Jakub Kicinski List of files: /linux-6.15/include/net/x25.h

c7154ca8 - x25: preserve const qualifier in [a]x25_sk()

Fri, 17 Mar 2023 15:55:37 +0000

x25: preserve const qualifier in [a]x25_sk()We can change [a]x25_sk() to propagate their argument const qualifier,thanks to container_of_const().Signed-off-by: Eric Dumazet Reviewed-by: Simon Horman Signed-off-by: David S. Miller List of files: /linux-6.15/include/net/x25.h

f8fc57e8 - net/x25: add new state X25_STATE_5

Mon, 09 Dec 2019 07:21:34 +0000

net/x25: add new state X25_STATE_5This is needed, because if the flag X25_ACCPT_APPRV_FLAG is not set on asocket (manual call confirmation) and the channel is cleared by remotebefore the manual call confirmation was sent, this situation needs tobe handled.Signed-off-by: Martin Schiller Signed-off-by: David S. Miller List of files: /linux-6.15/include/net/x25.h

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/include/net/x25.h

5534a51a - net, x25: convert x25_neigh.refcnt from atomic_t to refcount_t

Tue, 04 Jul 2017 12:53:20 +0000

net, x25: convert x25_neigh.refcnt from atomic_t to refcount_trefcount_t type and corresponding API should beused instead of atomic_t when the variable is used asa reference counter. This allows to avoid accidentalrefcounter overflows that might lead to use-after-freesituations.Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-by: Kees Cook Signed-off-by: David Windsor Signed-off-by: David S. Miller List of files: /linux-6.15/include/net/x25.h

5f9ccf6f - net, x25: convert x25_route.refcnt from atomic_t to refcount_t

Tue, 04 Jul 2017 12:53:19 +0000

net, x25: convert x25_route.refcnt from atomic_t to refcount_trefcount_t type and corresponding API should beused instead of atomic_t when the variable is used asa reference counter. This allows to avoid accidentalrefcounter overflows that might lead to use-after-freesituations.Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-by: Kees Cook Signed-off-by: David Windsor Signed-off-by: David S. Miller List of files: /linux-6.15/include/net/x25.h

64df6d52 - net: x25: fix one potential use-after-free issue

Wed, 17 May 2017 04:05:07 +0000

net: x25: fix one potential use-after-free issueThe function x25_init is not properly unregister related resourceson error handler.It is will result in kernel oops if x25_init initfailed, so add properly unregister call on error handler.Also, i adjust the coding style and make x25_register_sysctl properlyreturn failure.Signed-off-by: linzhang Signed-off-by: David S. Miller List of files: /linux-6.15/include/net/x25.h

5db50ee6 - x25.h: Remove extern from function prototypes

Mon, 23 Sep 2013 18:33:49 +0000

x25.h: Remove extern from function prototypesThere are a mix of function prototypes with and without externin the kernel sources. Standardize on not using extern forfunction prototypes.Function prototypes don't need to be written with extern.extern is assumed by the compiler. Its use is as unnecessary asusing auto to declare automatic/local variables in a block.Signed-off-by: Joe Perches Signed-off-by: David S. Miller List of files: /linux-6.15/include/net/x25.h

95c96174 - net: cleanup unsigned to unsigned int

Sun, 15 Apr 2012 05:58:06 +0000

net: cleanup unsigned to unsigned intUse of "unsigned int" is preferred to bare "unsigned" in net tree.Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller List of files: /linux-6.15/include/net/x25.h

5595a1a5 - X25 remove bkl in subscription ioctls

Thu, 25 Nov 2010 02:18:15 +0000

X25 remove bkl in subscription ioctlsSigned-off-by: Andrew Hendry Signed-off-by: David S. Miller List of files: /linux-6.15/include/net/x25.h

37cda787 - X25: Move accept approve flag to bitfield

Sun, 16 May 2010 23:00:27 +0000

X25: Move accept approve flag to bitfieldMoves the x25 accept approve flag from char into bitfield.Signed-off-by: Andrew Hendry Signed-off-by: David S. Miller List of files: /linux-6.15/include/net/x25.h

b7792e34 - X25: Move interrupt flag to bitfield

Sun, 16 May 2010 23:00:02 +0000

X25: Move interrupt flag to bitfieldMoves the x25 interrupt flag from char into bitfield.Signed-off-by: Andrew Hendry Signed-off-by: David S. Miller List of files: /linux-6.15/include/net/x25.h

cb863ffd - X25: Move qbit flag to bitfield

Sun, 16 May 2010 22:59:41 +0000

X25: Move qbit flag to bitfieldMoves the X25 q bit flag from char into a bitfield to allow BKL cleanup.Signed-off-by: Andrew Hendry Signed-off-by: David S. Miller List of files: /linux-6.15/include/net/x25.h

f5eb917b - x25: Patch to fix bug 15678 - x25 accesses fields beyond end of packet.

Thu, 08 Apr 2010 04:29:25 +0000

x25: Patch to fix bug 15678 - x25 accesses fields beyond end of packet.Here is a patch to stop X.25 examining fields beyond the end of the packet.For example, when a simple CALL ACCEPTED was received: 10 10 0fx25_parse_facilities was attempting to decode the FACILITIES field, but thispacket contains no facilities field.Signed-off-by: John Hughes Signed-off-by: David S. Miller List of files: /linux-6.15/include/net/x25.h

5a0e3ad6 - include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h

Wed, 24 Mar 2010 08:04:11 +0000

include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.hpercpu.h is included by sched.h and module.h and thus ends up beingincluded when building most .c files. percpu.h includes slab.h whichin turn includes gfp.h making everything defined by the two filesuniversally available and complicating inclusion dependencies.percpu.h -> slab.h dependency is about to be removed. Prepare forthis change by updating users of gfp and slab facilities include thoseheaders directly instead of assuming availability. As this conversionneeds to touch large number of source files, the following script isused as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.pyThe script does the followings.* Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h.* When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order.* If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file.The conversion was done in the following steps.1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files.2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files.3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind.4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually.5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary.6. percpu.h was updated not to include slab.h.7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point.Given the fact that I had only a couple of failures from tests on step6, I'm fairly confident about the coverage of this conversion patch.If there is a breakage, it's likely to be something in one of the archheaders which should be easily discoverable easily on most builds ofthe specific arch.Signed-off-by: Tejun Heo Guess-its-ok-by: Christoph Lameter Cc: Ingo Molnar Cc: Lee Schermerhorn List of files: /linux-6.15/include/net/x25.h

2f5517ae - X25: Move SYSCTL ifdefs into header

Tue, 24 Nov 2009 15:15:26 +0000

X25: Move SYSCTL ifdefs into headerMoves the CONFIG_SYSCTL ifdefs in x25_init into header.Signed-off-by: Andrew Hendry Acked-by: "Eric W. Biederman" Signed-off-by: David S. Miller List of files: /linux-6.15/include/net/x25.h

14ebaf81 - x25: Fix sleep from timer on socket destroy.

Tue, 16 Jun 2009 12:40:30 +0000

x25: Fix sleep from timer on socket destroy.If socket destuction gets delayed to a timer, we try tolock_sock() from that timer which won't work.Use bh_lock_sock() in that case.Signed-off-by: David S. Miller Tested-by: Ingo Molnar List of files: /linux-6.15/include/net/x25.h

39e21c0d - [X.25]: Adds /proc/sys/net/x25/x25_forward to control forwarding.

Thu, 08 Feb 2007 21:34:36 +0000

[X.25]: Adds /proc/sys/net/x25/x25_forward to control forwarding.echo "1" > /proc/sys/net/x25/x25_forward To turn on x25_forwarding, defaults to offRequires the previous patch.Signed-off-by: Andrew Hendry Signed-off-by: David S. Miller List of files: /linux-6.15/include/net/x25.h

95a9dc43 - [X.25]: Add call forwarding

Thu, 08 Feb 2007 21:34:02 +0000

[X.25]: Add call forwardingAdds call forwarding to X.25, allowing it to operate like an X.25 router.Useful if one needs to manipulate X.25 traffic with tools like tc.This is an update/cleanup based off a patch submitted by Daniel Ferenci a few years ago.Thanks Alan for the feedback.Added the null check to the clones.Moved the skb_clone's into the forwarding functions.Worked ok with Cisco XoT, linux X.25 back to back, and some old NTUs/PADs.Signed-off-by: Andrew Hendry Signed-off-by: David S. Miller List of files: /linux-6.15/include/net/x25.h

7f18ba62 - [X25]: proper prototype for x25_init_timers()

Thu, 04 Jan 2007 02:48:13 +0000

[X25]: proper prototype for x25_init_timers()This patch adds a proper prototype for x25_init_timers() in include/net/x25.hSigned-off-by: Adrian Bunk Signed-off-by: David S. Miller List of files: /linux-6.15/include/net/x25.h