Changes in scx200_gpio.h

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/include/linux/scx200_gpio.h

64b33619 - long vs. unsigned long - low-hanging fruits in drivers

Sun, 14 Oct 2007 18:35:20 +0000

long vs. unsigned long - low-hanging fruits in driversdeal with signedness of the stuff passed to set_bit() et.al.Signed-off-by: Al Viro Signed-off-by: Linus Torvalds List of files: /linux-6.15/include/linux/scx200_gpio.h

0a3021f4 - Remove unnecessary includes of spinlock.h under include/linux

Mon, 16 Jul 2007 06:39:57 +0000

Remove unnecessary includes of spinlock.h under include/linuxRemove the obviously unnecessary includes of under theinclude/linux/ directory, and fix the couple errors that are introduced asa result of that.Signed-off-by: Robert P. J. Day Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/include/linux/scx200_gpio.h

58012cd7 - [PATCH] scx200_gpio export cleanups

Fri, 29 Sep 2006 08:59:07 +0000

[PATCH] scx200_gpio export cleanupsUse EXPORT_SYMBOL_GPL for new symbols, and declare the struct in the headerfile for access by other modules.Signed-off-by: Chris Boot Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/include/linux/scx200_gpio.h

55b8c045 - [PATCH] chardev: GPIO for SCx200 & PC-8736x: device minor numbers are unsigned ints

Tue, 27 Jun 2006 09:54:15 +0000

[PATCH] chardev: GPIO for SCx200 & PC-8736x: device minor numbers are unsigned intsPer kernel headers, device minor numbers are unsigned ints. Do the same inthis driver.Signed-off-by: Jim Cromie Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/include/linux/scx200_gpio.h

62c83cde - [PATCH] chardev: GPIO for SCx200 & PC-8736x: whitespace pre-clean

Tue, 27 Jun 2006 09:54:13 +0000

[PATCH] chardev: GPIO for SCx200 & PC-8736x: whitespace pre-cleanGPIO SUPPORT FOR SCx200 & PC8736xThe patch-set reworks the 2.4 vintage scx200_gpio driver for modern 2.6, andrefactors GPIO support to reuse it in a new driver for the GPIO on PC-8736xchips. Its handy for the Soekris.com net-4801, which has both chips.These patches have been seen recently on Kernel-Mentors, and thenKernel-Newbies ML, where Jesper Juhl kindly reviewed it. His feedback hasbeen incorporated. Thanks Jesper !Its also gone to soekris-tech@soekris.com for possible testing by linux folks,I've gotten 1 promise so far. Theyre mostly BSD folk over there, but we'llsee..Device-file & SysfsThe driver preserves the existing device-file interface, including thewrite/cmd set, but adds v to 'view' the pin-settings & configs by inducing,via gpio_dump(), a dev_info() call. Its a fairly crappy way to get status,but it sticks to the syslog approach, conservatively.Allowing users to voluntarily trigger logging is good, it gives them afamiliar way to confirm their app's control & use of the pins, and I've thusreduced the pin-mode-updates from dev_info to dev_dbg.I've recently bolted on a proto sysfs interface for both new drivers. Im notincluding those patches here; they (the patch + doc-pre-patch) are still quiteraw (and unreviewed on KNML), and since they 'invent' a convention for GPIO, aproper vetting is needed. Since this patchset is much bigger than my previousones, Id like to keep things simpler, and address it 1st, before bolting onmore stuff.The driver-splitThe Geode CPU and the PC-87366 Super-IO chip have GPIO units which share acommon pin-architecture (same pin features, with same bits controlling), butwith different addressing mechanics and port organizations.The vintage driver expresses the pin capabilities with pin-mode commands[OoPpTt],etc that change the pin configurations, and since the 2 chips sharepin-arch, we can reuse the read(), write() commands, once the implementationis suitably adjusted.The patchset adds a vtable: struct nsc_gpio_ops, to abstract the existing gpiooperations, then adjusts fileops.write() code to invoke operations via thatvtable. Driver specific open()s set private_data to the vtable so itsavailable for use by write().The vtable gets the gpio_dump() too, since its user-friendly, and (could beconstrued as) part of the current device-file interface. To support use ofdev_dbg() in write() & _dump(), the vtable gets a dev ptr too, set by bothscx200 & pc8736x _gpio drivers.heres how the pins are presented in syslog:[ 1890.176223] scx200_gpio.0: io00: 0x0044 TS OD PUE EDGE LO DEBOUNCE[ 1890.287223] scx200_gpio.0: io01: 0x0003 OE PP PUD EDGE LOnsc_gpio.c: new file is new home of several file-ops methods, which aremodified to get their vtable from filp->private_data, and use it where needed.scx200_gpio.c: keeps some of its existing gpio routines, but now wires them upvia the vtable (they're invoked by nsc_gpio.c:nsc_gpio_write() thru thisvtable). A driver-spcific open() initializes filp->private_data with thevtable.Once the split is clean, and the scx200_gpio driver is working, we copy andmodify the function and variable names, and rework the access-method bodiesfor the different addressing scheme.Heres a working overview of the patchset:# series file for GPIO# Spring Cleaninggpio-scx/patch.preclean # scripts/Lindent fixes, editor-ctrl comments# API Modernizationgpio-scx/patch.api26 # what I learned from LDD3gpio-scx/patch.platform-dev-2 # get pdev, support for dev_dbg()gpio-scx/patch.unsigned-minor # fix to match std practice# Debuggabilitygpio-scx/patch.dump-diet # shrink gpio_dump()gpio-scx/patch.viewpins # add new 'command' to call dump()gpio-scx/patch.init-refactor # pull shadow-register init to sub# Access-Abstraction (add vtable)gpio-scx/patch.access-vtable # introduce nsg_gpio_ops vtable, w dumpgpio-scx/patch.vtable-calls # add & use the vtable in scx200_gpiogpio-scx/patch.nscgpio-shell # add empty driver for common-fops# move code under abstractiongpio-scx/patch.migrate-fops # move file-ops methods from scx200_gpiogpio-scx/patch.common-dump # mv scx200.c:scx200_gpio_dump() to nsc_gpio.cgpio-scx/patch.add-pc8736x-gpio # add new driver, like old, w chip adapt# gpio-scx/patch.add-DEBUG # enable all dev_dbg()s# Cleanups# finish printk -> dev_dbg() etcgpio-scx/patch.pdev-pc8736x # new drvr needs pdev too,gpio-scx/patch.devdbg-nscgpio # add device to 'vtable', use in dev_dbg()# gpio-scx/patch.pin-config-view # another 'c' 'command'# gpio-scx/quiet-getset # take out excess dbg stuff (pretty quietnow)gpio-scx/patch.shadow-current # imitate scx200_gpio's shadow regs inpc87*# post KMentors-post patches ..gpio-scx/patch.mutexes # use mutexes for config-locksgpio-scx/patch.viewpins-values # extend dump to obsolete separate 'c' cmdgpio-scx/patch.kconfig # add stuff for kbuild# TBC# combine api26 with pdev, which is just one step.# merge c&v commands to single do-all-fn# delay viewpins, dump-diet should also un-ifdef it too.diff.sys-gpio-rollup-1This patch:Removed editor format-control comments, and used scripts/Lindent to clean upwhitespace, then deleted the bogus chunks :-(Signed-off-by: Jim Cromie Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/include/linux/scx200_gpio.h

1da177e4 - Linux-2.6.12-rc2

Sat, 16 Apr 2005 22:20:36 +0000

Linux-2.6.12-rc2Initial git repository build. I'm not bothering with the full history,even though we have it. We can create a separate "historical" gitarchive of that later if we want to, and in the meantime it's about3.2GB when imported into git - space that would just make the earlygit days unnecessarily complicated, when we don't have a lot of goodinfrastructure for it.Let it rip! List of files: /linux-6.15/include/linux/scx200_gpio.h