Changes in Kconfig

438b8050 - pstore: Replace crypto API compression with zlib_deflate library calls

Wed, 12 Jul 2023 16:23:32 +0000

pstore: Replace crypto API compression with zlib_deflate library callsPstore supports compression using a variety of algorithms exposed by thecrypto API. This uses the deprecated comp (as opposed to scomp/acomp)API, and so we should stop using that, and either move to the new API,or switch to a different approach entirely.Given that we only compress ASCII text in pstore, and considering thatthis happens when the system is likely to be in an unstable state, theflexibility that the complex crypto API provides does not outweigh itsimpact on the risk that we might encounter additional problems whentrying to commit the kernel log contents to the pstore backend.So let's switch [back] to the zlib deflate library API, and remove allthe complexity that really has no place in a low-level diagnosticfacility. Note that, while more modern compression algorithms have beenadded to the kernel in recent years, the code size of zlib deflate issubstantially smaller than, e.g., zstd, while its performance in termsof compression ratio is comparable for ASCII text, and speed is deemedirrelevant in this context.Note that this means that compressed pstore records may no longer beaccessible after a kernel upgrade, but this has never been part of thecontract. (The choice of compression algorithm is not stored in thepstore records either)Tested-by: "Guilherme G. Piccoli" # Steam DeckSigned-off-by: Ard Biesheuvel Reviewed-by: Eric Biggers Link: https://lore.kernel.org/r/20230712162332.2670437-3-ardb@kernel.orgSigned-off-by: Kees Cook List of files: /linux-6.15/fs/pstore/Kconfig

2f4fec59 - pstore: Make sure CONFIG_PSTORE_PMSG selects CONFIG_RT_MUTEXES

Wed, 21 Dec 2022 05:18:55 +0000

pstore: Make sure CONFIG_PSTORE_PMSG selects CONFIG_RT_MUTEXESIn commit 76d62f24db07 ("pstore: Switch pmsg_lock to an rt_mutexto avoid priority inversion") I changed a lock to an rt_mutex.However, its possible that CONFIG_RT_MUTEXES is not enabled,which then results in a build failure, as the 0day bot detected: https://lore.kernel.org/linux-mm/202212211244.TwzWZD3H-lkp@intel.com/Thus this patch changes CONFIG_PSTORE_PMSG to selectCONFIG_RT_MUTEXES, which ensures the build will not fail.Cc: Wei Wang Cc: Midas ChienCc: Connor O'Brien Cc: Kees Cook Cc: Anton Vorontsov Cc: Colin Cross Cc: Tony Luck Cc: kernel test robot Cc: kernel-team@android.comFixes: 76d62f24db07 ("pstore: Switch pmsg_lock to an rt_mutex to avoid priority inversion")Reported-by: kernel test robot Signed-off-by: John Stultz Signed-off-by: Kees Cook Link: https://lore.kernel.org/r/20221221051855.15761-1-jstultz@google.com List of files: /linux-6.15/fs/pstore/Kconfig

d1faacbf - Revert "mark pstore-blk as broken"

Tue, 16 Nov 2021 18:15:59 +0000

Revert "mark pstore-blk as broken"This reverts commit d07f3b081ee632268786601f55e1334d1f68b997.pstore-blk was fixed to avoid the unwanted APIs in commit 7bb9557b48fc("pstore/blk: Use the normal block device I/O path"), which landed inthe same release as the commit adding BROKEN.Cc: Jens Axboe Cc: Christoph Hellwig Cc: stable@vger.kernel.orgSigned-off-by: Kees Cook Link: https://lore.kernel.org/r/20211116181559.3975566-1-keescook@chromium.orgSigned-off-by: Jens Axboe List of files: /linux-6.15/fs/pstore/Kconfig

d07f3b08 - mark pstore-blk as broken

Tue, 08 Jun 2021 16:13:27 +0000

mark pstore-blk as brokenpstore-blk just pokes directly into the pagecache for the blockdevice without going through the file operations for that by fakingup it's own file operations that do not match the block device ones.As this breaks the control of the block layer of it's page cache,and even now just works by accident only the best thing is to justdisable this driver.Fixes: 17639f67c1d6 ("pstore/blk: Introduce backend for block devices")Signed-off-by: Christoph Hellwig Link: https://lore.kernel.org/r/20210608161327.1537919-1-hch@lst.deSigned-off-by: Jens Axboe List of files: /linux-6.15/fs/pstore/Kconfig

26fecbf7 - pstore: Move kmsg_bytes default into Kconfig

Wed, 04 Nov 2020 13:05:32 +0000

pstore: Move kmsg_bytes default into KconfigWhile kmsg_bytes can be set for pstore via mount, if a crash occursbefore the mount only partial console log will be stored as kmsg_bytesdefaults to a potentially different hardcoded value in the kernel(PSTORE_DEFAULT_KMSG_BYTES). This makes it impossible to analyze valuablepost-mortem data especially on the embedded development or in the processof bringing up new boards. Change this value to be a Kconfig optionwith the default of old PSTORE_DEFAULT_KMSG_BYTESSigned-off-by: Vasile-Laurentiu Stanimir Signed-off-by: Kees Cook List of files: /linux-6.15/fs/pstore/Kconfig

649304c9 - Documentation: Add details for pstore/blk

Wed, 25 Mar 2020 08:55:02 +0000

Documentation: Add details for pstore/blkAdd details on using pstore/blk, the new backend of pstore to recorddumps to block devices, in Documentation/admin-guide/pstore-blk.rstSigned-off-by: WeiXiong Liao Link: https://lore.kernel.org/lkml/20200511233229.27745-7-keescook@chromium.org/Signed-off-by: Kees Cook List of files: /linux-6.15/fs/pstore/Kconfig

34327e9f - pstore/zone,blk: Add ftrace frontend support

Wed, 25 Mar 2020 08:55:01 +0000

pstore/zone,blk: Add ftrace frontend supportSupport backend for ftrace. To enable ftrace backend, just makeftrace_size be greater than 0 and a multiple of 4096.Signed-off-by: WeiXiong Liao Link: https://lore.kernel.org/lkml/20200511233229.27745-6-keescook@chromium.org/Co-developed-by: Colin Ian King Signed-off-by: Colin Ian King Link: https://lore.kernel.org/lkml/20200512170719.221514-1-colin.king@canonical.comSigned-off-by: Kees Cook List of files: /linux-6.15/fs/pstore/Kconfig

cc9c4d1b - pstore/zone,blk: Add console frontend support

Wed, 25 Mar 2020 08:55:00 +0000

pstore/zone,blk: Add console frontend supportSupport backend for console. To enable console backend, just makeconsole_size be greater than 0 and a multiple of 4096.Signed-off-by: WeiXiong Liao Link: https://lore.kernel.org/lkml/20200511233229.27745-5-keescook@chromium.org/Signed-off-by: Kees Cook List of files: /linux-6.15/fs/pstore/Kconfig

0dc06826 - pstore/zone,blk: Add support for pmsg frontend

Wed, 25 Mar 2020 08:54:59 +0000

pstore/zone,blk: Add support for pmsg frontendAdd pmsg support to pstore/blk (through pstore/zone). To enable, pmsg_sizemust be greater than 0 and a multiple of 4096.Signed-off-by: WeiXiong Liao Link: https://lore.kernel.org/lkml/20200511233229.27745-4-keescook@chromium.org/Co-developed-by: Colin Ian King Signed-off-by: Colin Ian King Link: https://lore.kernel.org/lkml/20200512171932.222102-1-colin.king@canonical.comCo-developed-by: Kees Cook Signed-off-by: Kees Cook List of files: /linux-6.15/fs/pstore/Kconfig

17639f67 - pstore/blk: Introduce backend for block devices

Wed, 25 Mar 2020 08:54:57 +0000

pstore/blk: Introduce backend for block devicespstore/blk is similar to pstore/ram, but uses a block device as thestorage rather than persistent ram.The pstore/blk backend solves two common use-cases that used to precludeusing pstore/ram:- not all devices have a battery that could be used to persist regular RAM across power failures.- most embedded intelligent equipment have no persistent ram, which increases costs, instead preferring cheaper solutions, like block devices.pstore/blk provides separate configurations for the end user and for theblock drivers. User configuration determines how pstore/blk operates, suchas record sizes, max kmsg dump reasons, etc. These can be set by Kconfigand/or module parameters, but module parameter have priority over Kconfig.Driver configuration covers all the details about the target block device,such as total size of the device and how to perform read/write operations.These are provided by block drivers, calling pstore_register_blkdev(),including an optional panic_write callback used to bypass regular IOAPIs in an effort to avoid potentially destabilized kernel code duringa panic.Signed-off-by: WeiXiong Liao Link: https://lore.kernel.org/lkml/20200511233229.27745-3-keescook@chromium.org/Co-developed-by: Kees Cook Signed-off-by: Kees Cook List of files: /linux-6.15/fs/pstore/Kconfig

d26c3321 - pstore/zone: Introduce common layer to manage storage zones

Wed, 25 Mar 2020 08:54:56 +0000

pstore/zone: Introduce common layer to manage storage zonesImplement a common set of APIs needed to support pstore storage zones,based on how ramoops is designed. This will be used by pstore/blk withthe intention of migrating pstore/ram in the future.Signed-off-by: WeiXiong Liao Link: https://lore.kernel.org/lkml/20200511233229.27745-2-keescook@chromium.org/Co-developed-by: Kees Cook Signed-off-by: Kees Cook List of files: /linux-6.15/fs/pstore/Kconfig

ec8f24b7 - treewide: Add SPDX license identifier - Makefile/Kconfig

Sun, 19 May 2019 12:07:45 +0000

treewide: Add SPDX license identifier - Makefile/KconfigAdd SPDX license identifiers to all Make/Kconfig files which: - Have no license information of any formThese files fall under the project license, GPL v2 only. The resulting SPDXlicense identifier is: GPL-2.0-onlySigned-off-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/fs/pstore/Kconfig

aca52c39 - mm: remove CONFIG_HAVE_MEMBLOCK

Tue, 30 Oct 2018 22:07:44 +0000

mm: remove CONFIG_HAVE_MEMBLOCKAll architecures use memblock for early memory management. There is no needfor the CONFIG_HAVE_MEMBLOCK configuration option.[rppt@linux.vnet.ibm.com: of/fdt: fixup #ifdefs] Link: http://lkml.kernel.org/r/20180919103457.GA20545@rapoport-lnx[rppt@linux.vnet.ibm.com: csky: fixups after bootmem removal] Link: http://lkml.kernel.org/r/20180926112744.GC4628@rapoport-lnx[rppt@linux.vnet.ibm.com: remove stale #else and the code it protects] Link: http://lkml.kernel.org/r/1538067825-24835-1-git-send-email-rppt@linux.vnet.ibm.comLink: http://lkml.kernel.org/r/1536927045-23536-4-git-send-email-rppt@linux.vnet.ibm.comSigned-off-by: Mike Rapoport Acked-by: Michal Hocko Tested-by: Jonathan Cameron Cc: Catalin Marinas Cc: Chris Zankel Cc: "David S. Miller" Cc: Geert Uytterhoeven Cc: Greentime Hu Cc: Greg Kroah-Hartman Cc: Guan Xuetao Cc: Ingo Molnar Cc: "James E.J. Bottomley" Cc: Jonas Bonn Cc: Jonathan Corbet Cc: Ley Foon Tan Cc: Mark Salter Cc: Martin Schwidefsky Cc: Matt Turner Cc: Michael Ellerman Cc: Michal Simek Cc: Palmer Dabbelt Cc: Paul Burton Cc: Richard Kuo Cc: Richard Weinberger Cc: Rich Felker Cc: Russell King Cc: Serge Semin Cc: Thomas Gleixner Cc: Tony Luck Cc: Vineet Gupta Cc: Yoshinori Sato Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/fs/pstore/Kconfig

1021bcf4 - pstore: add zstd compression support

Wed, 01 Aug 2018 11:23:37 +0000

pstore: add zstd compression supportThis patch added the 6th compression algorithm support for pstore: zstd.Signed-off-by: Geliang Tang Signed-off-by: Kees Cook List of files: /linux-6.15/fs/pstore/Kconfig

58eb5b67 - pstore: fix crypto dependencies

Thu, 15 Mar 2018 15:34:08 +0000

pstore: fix crypto dependenciesThe new crypto API use causes some problems with Kconfig dependencies,including this link error:fs/pstore/platform.o: In function `pstore_register':platform.c:(.text+0x248): undefined reference to `crypto_has_alg'platform.c:(.text+0x2a0): undefined reference to `crypto_alloc_base'fs/pstore/platform.o: In function `pstore_unregister':platform.c:(.text+0x498): undefined reference to `crypto_destroy_tfm'crypto/lz4hc.o: In function `lz4hc_sdecompress':lz4hc.c:(.text+0x1a): undefined reference to `LZ4_decompress_safe'crypto/lz4hc.o: In function `lz4hc_decompress_crypto':lz4hc.c:(.text+0x5a): undefined reference to `LZ4_decompress_safe'crypto/lz4hc.o: In function `lz4hc_scompress':lz4hc.c:(.text+0xaa): undefined reference to `LZ4_compress_HC'crypto/lz4hc.o: In function `lz4hc_mod_init':lz4hc.c:(.init.text+0xf): undefined reference to `crypto_register_alg'lz4hc.c:(.init.text+0x1f): undefined reference to `crypto_register_scomp'lz4hc.c:(.init.text+0x2f): undefined reference to `crypto_unregister_alg'The problem is that with CONFIG_CRYPTO=m, we must not 'select CRYPTO_LZ4'from a bool symbol, or call crypto API functions from a built-inmodule.This turns the sub-options into 'tristate' ones so the dependenciesare honored, and makes the pstore itself select the crypto coreif necessary.Fixes: cb3bee0369bc ("pstore: Use crypto compress API")Signed-off-by: Arnd Bergmann Signed-off-by: Kees Cook List of files: /linux-6.15/fs/pstore/Kconfig

cb3bee03 - pstore: Use crypto compress API

Fri, 09 Mar 2018 10:51:07 +0000

pstore: Use crypto compress APIIn the pstore compression part, we use zlib/lzo/lz4/lz4hc/842compression algorithm API to implement pstore compression backends. Butthere are many repeat codes in these implementations. This patch usescrypto compress API to simplify these codes.1) rewrite allocate_buf_for_compression, free_buf_for_compression,pstore_compress, pstore_decompress functions using crypto compress API.2) drop compress, decompress, allocate, free functions in pstore_zbackend,and add zbufsize function to get each different compress buffer size.3) use late_initcall to call ramoops_init later, to make sure the cryptosubsystem has already initialized.4) use 'unsigned int' type instead of 'size_t' in pstore_compress,pstore_decompress functions' length arguments.5) rename 'zlib' to 'deflate' to follow the crypto API's name convention.Signed-off-by: Geliang Tang [kees: tweaked error messages on allocation failures and Kconfig help]Signed-off-by: Kees Cook List of files: /linux-6.15/fs/pstore/Kconfig

fe1d4758 - pstore: Select compression at runtime

Tue, 06 Mar 2018 23:57:38 +0000

pstore: Select compression at runtimeTo allow for easier build test coverage and run-time testing, this allowsmultiple compression algorithms to be built into pstore. Still only oneis supported to operate at a time (which can be selected at build timeor at boot time, similar to how LSMs are selected).Signed-off-by: Kees Cook List of files: /linux-6.15/fs/pstore/Kconfig

239b7161 - pstore: Add lz4hc and 842 compression support

Tue, 13 Feb 2018 06:40:39 +0000

pstore: Add lz4hc and 842 compression supportCurrently, pstore has supported three compression algorithms: zlib,lzo and lz4. This patch added two more compression algorithms: lz4hcand 842.Signed-off-by: Geliang Tang [kees: tweaked Kconfig help text slightly]Signed-off-by: Kees Cook List of files: /linux-6.15/fs/pstore/Kconfig

8c27ceff - docs: fix locations of several documents that got moved

Tue, 18 Oct 2016 12:12:27 +0000

docs: fix locations of several documents that got movedThe previous patch renamed several files that are cross-referencedalong the Kernel documentation. Adjust the links to point tothe right places.Signed-off-by: Mauro Carvalho Chehab List of files: /linux-6.15/fs/pstore/Kconfig

8cfc8ddc - pstore: add lzo/lz4 compression support

Thu, 18 Feb 2016 14:04:22 +0000

pstore: add lzo/lz4 compression supportLike zlib compression in pstore, this patch added lzo and lz4compression support so that users can have more options and bettercompression ratio.The original code treats the compressed data together with theuncompressed ECC correction notice by using zlib decompress. TheECC correction notice is missing in the decompression process. Thetreatment also makes lzo and lz4 not working. So I treat themseparately by using pstore_decompress() to treat the compresseddata, and memcpy() to treat the uncompressed ECC correction notice.Signed-off-by: Geliang Tang Signed-off-by: Kees Cook List of files: /linux-6.15/fs/pstore/Kconfig