Changes in localalloc.c

7782e3b3 - ocfs2: fix the space leak in LA when releasing LA

Thu, 05 Dec 2024 10:48:33 +0000

ocfs2: fix the space leak in LA when releasing LACommit 30dd3478c3cd ("ocfs2: correctly use ocfs2_find_next_zero_bit()")introduced an issue, the ocfs2_sync_local_to_main() ignores the lastcontiguous free bits, which causes an OCFS2 volume to lose the last freeclusters of LA window during the release routine.Please note, because commit dfe6c5692fb5 ("ocfs2: fix the la space leakwhen unmounting an ocfs2 volume") was reverted, this commit is areplacement fix for commit dfe6c5692fb5.Link: https://lkml.kernel.org/r/20241205104835.18223-3-heming.zhao@suse.comFixes: 30dd3478c3cd ("ocfs2: correctly use ocfs2_find_next_zero_bit()")Signed-off-by: Heming Zhao Suggested-by: Joseph Qi Reviewed-by: Joseph Qi Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Jun Piao Cc: Signed-off-by: Andrew Morton List of files: /linux-6.15/fs/ocfs2/localalloc.c

1a72d2eb - ocfs2: revert "ocfs2: fix the la space leak when unmounting an ocfs2 volume"

Thu, 05 Dec 2024 10:48:32 +0000

ocfs2: revert "ocfs2: fix the la space leak when unmounting an ocfs2 volume"Patch series "Revert ocfs2 commit dfe6c5692fb5 and provide a new fix".SUSE QA team detected a mistake in my commit dfe6c5692fb5 ("ocfs2: fix thela space leak when unmounting an ocfs2 volume"). I am very sorry for myerror. (If my eyes are correct) From the mailling list mails, this patchshouldn't be applied to 4.19 5.4 5.10 5.15 6.1 6.6, and these branchesshould perform a revert operation.Reason for revert:In commit dfe6c5692fb5, I mistakenly wrote: "This bug has existed sincethe initial OCFS2 code.". The statement is wrong. The correctintroduction commit is 30dd3478c3cd. IOW, if the branch doesn't include30dd3478c3cd, dfe6c5692fb5 should also not be included.This reverts commit dfe6c5692fb5 ("ocfs2: fix the la space leak whenunmounting an ocfs2 volume").In commit dfe6c5692fb5, the commit log "This bug has existed since theinitial OCFS2 code." is wrong. The correct introduction commit is30dd3478c3cd ("ocfs2: correctly use ocfs2_find_next_zero_bit()").The influence of commit dfe6c5692fb5 is that it provides a correct fix forthe latest kernel. however, it shouldn't be pushed to stable branches. Let's use this commit to revert all branches that include dfe6c5692fb5 anduse a new fix method to fix commit 30dd3478c3cd.Link: https://lkml.kernel.org/r/20241205104835.18223-1-heming.zhao@suse.comLink: https://lkml.kernel.org/r/20241205104835.18223-2-heming.zhao@suse.comFixes: dfe6c5692fb5 ("ocfs2: fix the la space leak when unmounting an ocfs2 volume")Signed-off-by: Heming Zhao Reviewed-by: Joseph Qi Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Jun Piao Cc: Signed-off-by: Andrew Morton List of files: /linux-6.15/fs/ocfs2/localalloc.c

dfe6c569 - ocfs2: fix the la space leak when unmounting an ocfs2 volume

Fri, 19 Jul 2024 11:43:10 +0000

ocfs2: fix the la space leak when unmounting an ocfs2 volumeThis bug has existed since the initial OCFS2 code. The code logic inocfs2_sync_local_to_main() is wrong, as it ignores the last contiguousfree bits, which causes an OCFS2 volume to lose the last free clusters ofLA window on each umount command.Link: https://lkml.kernel.org/r/20240719114310.14245-1-heming.zhao@suse.comSigned-off-by: Heming Zhao Reviewed-by: Su Yue Reviewed-by: Joseph Qi Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Gang He Cc: Jun Piao Cc: Heming Zhao Cc: Signed-off-by: Andrew Morton List of files: /linux-6.15/fs/ocfs2/localalloc.c

fc07d2a2 - ocfs2: fix sparse warnings

Thu, 28 Mar 2024 12:52:03 +0000

ocfs2: fix sparse warnings1.fs/ocfs2/localalloc.c:1224:41: warning: incorrect type in argument 1 (different base types)fs/ocfs2/localalloc.c:1224:41: expected unsigned long long val1fs/ocfs2/localalloc.c:1224:41: got restricted __le32 [usertype] la_bm_off2.fs/ocfs2/export.c:258:32: warning: cast to restricted __le32fs/ocfs2/export.c:259:33: warning: cast to restricted __le32fs/ocfs2/export.c:260:32: warning: cast to restricted __le32fs/ocfs2/export.c:272:32: warning: cast to restricted __le32fs/ocfs2/export.c:273:33: warning: cast to restricted __le32fs/ocfs2/export.c:274:32: warning: cast to restricted __le323.fs/ocfs2/inode.c:1623:13: warning: context imbalance in 'ocfs2_inode_cache_lock' - wrong count at exitfs/ocfs2/inode.c:1630:13: warning: context imbalance in 'ocfs2_inode_cache_unlock' - unexpected unlock4.fs/ocfs2/refcounttree.c:633:27: warning: incorrect type in assignment (different base types)fs/ocfs2/refcounttree.c:633:27: expected restricted __le32 [usertype] rf_generationfs/ocfs2/refcounttree.c:633:27: got unsigned int5.fs/ocfs2/dlm/dlmdomain.c:1316:20: warning: context imbalance in 'dlm_query_nodeinfo_handler' - different lock contexts for basic blockLink: https://lkml.kernel.org/r/20240328125203.20892-5-heming.zhao@suse.comSigned-off-by: Heming Zhao Reviewed-by: Joseph Qi Cc: Changwei Ge Cc: Gang He Cc: Joel Becker Cc: Jun Piao Cc: Junxiao Bi Cc: Mark Fasheh Signed-off-by: Andrew Morton List of files: /linux-6.15/fs/ocfs2/localalloc.c

f51dac02 - ocfs2: adjust enabling place for la window

Thu, 28 Mar 2024 12:52:01 +0000

ocfs2: adjust enabling place for la windowPatch series "improve write IO performance when fragmentation is high",v6.This patch (of 4):After introducing gd->bg_contig_free_bits, the code path'ocfs2_cluster_group_search() => ocfs2_local_alloc_seen_free_bits()'becomes death when all the gd->bg_contig_free_bits are set to the correctvalue. This patch relocates ocfs2_local_alloc_seen_free_bits() to a moreappropriate location. (The new place being ocfs2_block_group_set_bits().)In ocfs2_local_alloc_seen_free_bits(), the scope of the spin-lock has beenadjusted to reduce meaningless lock races. e.g: when userspace creates &deletes 1 cluster_size files in parallel, acquiring the spin-lock inocfs2_local_alloc_seen_free_bits() is totally pointless and impedes IOperformance.Link: https://lkml.kernel.org/r/20240328125203.20892-3-heming.zhao@suse.comSigned-off-by: Heming Zhao Reviewed-by: Joseph Qi Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Gang He Cc: Jun Piao Signed-off-by: Andrew Morton List of files: /linux-6.15/fs/ocfs2/localalloc.c

30dd3478 - ocfs2: correctly use ocfs2_find_next_zero_bit()

Thu, 14 Mar 2024 02:17:13 +0000

ocfs2: correctly use ocfs2_find_next_zero_bit()If no bits are zero, ocfs2_find_next_zero_bit() will return max size, socheck the return value with -1 is meaningless. Correct this usage andcleanup the code.Link: https://lkml.kernel.org/r/20240314021713.240796-1-joseph.qi@linux.alibaba.comSigned-off-by: Joseph Qi Reviewed-by: Heming Zhao Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Gang He Cc: Jun Piao Signed-off-by: Andrew Morton List of files: /linux-6.15/fs/ocfs2/localalloc.c

7982f975 - ocfs2: remove redundant assignment to variable bit_off

Thu, 22 Jun 2023 10:27:36 +0000

ocfs2: remove redundant assignment to variable bit_offVariable bit_off is being assigned a value that is never read, it is beingre-assigned a new value in the following while loop. Remove theassignment. Cleans up clang scan build warning:fs/ocfs2/localalloc.c:976:18: warning: Although the value stored to'bit_off' is used in the enclosing expression, the value is neveractually read from 'bit_off' [deadcode.DeadStores]Link: https://lkml.kernel.org/r/20230622102736.2831126-1-colin.i.king@gmail.comSigned-off-by: Colin Ian King Reviewed-by: Joseph Qi Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Gang He Cc: Jun Piao Signed-off-by: Andrew Morton List of files: /linux-6.15/fs/ocfs2/localalloc.c

137cebf9 - fs/ocfs2: fix comments mentioning i_mutex

Tue, 22 Mar 2022 21:38:45 +0000

fs/ocfs2: fix comments mentioning i_mutexinode->i_mutex has been replaced with inode->i_rwsem long ago. Fixcomments still mentioning i_mutex.Link: https://lkml.kernel.org/r/20220214031314.100094-1-hongnan.li@linux.alibaba.comSigned-off-by: hongnanli Acked-by: Joseph Qi Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Gang He Cc: Jun Piao Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/fs/ocfs2/localalloc.c

fa60ce2c - treewide: remove editor modelines and cruft

Fri, 07 May 2021 01:06:44 +0000

treewide: remove editor modelines and cruftThe section "19) Editor modelines and other cruft" inDocumentation/process/coding-style.rst clearly says, "Do not include anyof these in source files."I recently receive a patch to explicitly add a new one.Let's do treewide cleanups, otherwise some people follow the existing codeand attempt to upstream their favoriate editor setups.It is even nicer if scripts/checkpatch.pl can check it.If we like to impose coding style in an editor-independent manner, I thinkeditorconfig (patch [1]) is a saner solution.[1] https://lore.kernel.org/lkml/20200703073143.423557-1-danny@kdrag0n.dev/Link: https://lkml.kernel.org/r/20210324054457.1477489-1-masahiroy@kernel.orgSigned-off-by: Masahiro Yamada Acked-by: Geert Uytterhoeven Reviewed-by: Miguel Ojeda [auxdisplay]Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/fs/ocfs2/localalloc.c

679edeb0 - ocfs2: delete repeated words in comments

Tue, 13 Oct 2020 23:48:21 +0000

ocfs2: delete repeated words in commentsDrop duplicated words {the, and} in comments.Signed-off-by: Randy Dunlap Signed-off-by: Andrew Morton Acked-by: Joseph Qi Cc: Mark Fasheh Cc: Joel Becker Link: https://lkml.kernel.org/r/20200811021845.25134-1-rdunlap@infradead.orgSigned-off-by: Linus Torvalds List of files: /linux-6.15/fs/ocfs2/localalloc.c

b918c430 - ocfs2: fix panic due to ocfs2_wq is null

Sat, 19 Oct 2019 03:20:08 +0000

ocfs2: fix panic due to ocfs2_wq is nullmount.ocfs2 failed when reading ocfs2 filesystem superblock encountersan error. ocfs2_initialize_super() returns before allocating ocfs2_wq.ocfs2_dismount_volume() triggers the following panic. Oct 15 16:09:27 cnwarekv-205120 kernel: On-disk corruption discovered.Please run fsck.ocfs2 once the filesystem is unmounted. Oct 15 16:09:27 cnwarekv-205120 kernel: (mount.ocfs2,22804,44): ocfs2_read_locked_inode:537 ERROR: status = -30 Oct 15 16:09:27 cnwarekv-205120 kernel: (mount.ocfs2,22804,44): ocfs2_init_global_system_inodes:458 ERROR: status = -30 Oct 15 16:09:27 cnwarekv-205120 kernel: (mount.ocfs2,22804,44): ocfs2_init_global_system_inodes:491 ERROR: status = -30 Oct 15 16:09:27 cnwarekv-205120 kernel: (mount.ocfs2,22804,44): ocfs2_initialize_super:2313 ERROR: status = -30 Oct 15 16:09:27 cnwarekv-205120 kernel: (mount.ocfs2,22804,44): ocfs2_fill_super:1033 ERROR: status = -30 ------------[ cut here ]------------ Oops: 0002 [#1] SMP NOPTI CPU: 1 PID: 11753 Comm: mount.ocfs2 Tainted: G E 4.14.148-200.ckv.x86_64 #1 Hardware name: Sugon H320-G30/35N16-US, BIOS 0SSDX017 12/21/2018 task: ffff967af0520000 task.stack: ffffa5f05484000 RIP: 0010:mutex_lock+0x19/0x20 Call Trace: flush_workqueue+0x81/0x460 ocfs2_shutdown_local_alloc+0x47/0x440 [ocfs2] ocfs2_dismount_volume+0x84/0x400 [ocfs2] ocfs2_fill_super+0xa4/0x1270 [ocfs2] ? ocfs2_initialize_super.isa.211+0xf20/0xf20 [ocfs2] mount_bdev+0x17f/0x1c0 mount_fs+0x3a/0x160Link: http://lkml.kernel.org/r/1571139611-24107-1-git-send-email-yili@winhong.comSigned-off-by: Yi Li Reviewed-by: Joseph Qi Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Gang He Cc: Jun Piao Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/fs/ocfs2/localalloc.c

d8b2fa65 - ocfs2: use kmemdup rather than duplicating its implementation

Fri, 12 Jul 2019 03:53:19 +0000

ocfs2: use kmemdup rather than duplicating its implementationkmemdup is introduced to duplicate a region of memory in a neat way.Rather than kmalloc/kzalloc + memcpy, which the programmer needs towrite the size twice (sometimes lead to mistakes), kmemdup improvesreadability, leads to smaller code and also reduce the chances ofmistakes.Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.[akpm@linux-foundation.org: coding style fixes]Link: http://lkml.kernel.org/r/20190703163147.881-1-huangfq.daxian@gmail.comSigned-off-by: Fuqian Huang Reviewed-by: Joseph Qi Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Gang He Cc: Jun Piao Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/fs/ocfs2/localalloc.c

328970de - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 145

Fri, 24 May 2019 10:04:05 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 145Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later version this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more details you should have received a copy of the gnu general public license along with this program if not write to the free software foundation inc 59 temple place suite 330 boston ma 021110 1307 usaextracted by the scancode license scanner the SPDX license identifier GPL-2.0-or-laterhas been chosen to replace the boilerplate/reference in 84 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Richard Fontana Reviewed-by: Allison Randal Reviewed-by: Kate Stewart Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190524100844.756442981@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/fs/ocfs2/localalloc.c

532e1e54 - ocfs2: fix panic due to unrecovered local alloc

Fri, 28 Dec 2018 08:32:50 +0000

ocfs2: fix panic due to unrecovered local allocmount.ocfs2 ignore the inconsistent error that journal is clean butlocal alloc is unrecovered. After mount, local alloc not empty, thenreserver cluster didn't alloc a new local alloc window, reserverationmap is empty(ocfs2_reservation_map.m_bitmap_len = 0), that triggered thefollowing panic.This issue was reported at https://oss.oracle.com/pipermail/ocfs2-devel/2015-May/010854.htmland was advised to fixed during mount. But this is a very unusualinconsistent state, usually journal dirty flag should be cleared at thelast stage of umount until every other things go right. We may need dofurther debug to check that. Any way to avoid possible futhercorruption, mount should be abort and fsck should be run. (mount.ocfs2,1765,1):ocfs2_load_local_alloc:353 ERROR: Local alloc hasn't been recovered! found = 6518, set = 6518, taken = 8192, off = 15912372 ocfs2: Mounting device (202,64) on (node 0, slot 3) with ordered data mode. o2dlm: Joining domain 89CEAC63CC4F4D03AC185B44E0EE0F3F ( 0 1 2 3 4 5 6 8 ) 8 nodes ocfs2: Mounting device (202,80) on (node 0, slot 3) with ordered data mode. o2hb: Region 89CEAC63CC4F4D03AC185B44E0EE0F3F (xvdf) is now a quorum device o2net: Accepted connection from node yvwsoa17p (num 7) at 172.22.77.88:7777 o2dlm: Node 7 joins domain 64FE421C8C984E6D96ED12C55FEE2435 ( 0 1 2 3 4 5 6 7 8 ) 9 nodes o2dlm: Node 7 joins domain 89CEAC63CC4F4D03AC185B44E0EE0F3F ( 0 1 2 3 4 5 6 7 8 ) 9 nodes ------------[ cut here ]------------ kernel BUG at fs/ocfs2/reservations.c:507! invalid opcode: 0000 [#1] SMP Modules linked in: ocfs2 rpcsec_gss_krb5 auth_rpcgss nfsv4 nfs fscache lockd grace ocfs2_dlmfs ocfs2_stack_o2cb ocfs2_dlm ocfs2_nodemanager ocfs2_stackglue configfs sunrpc ipt_REJECT nf_reject_ipv4 nf_conntrack_ipv4 nf_defrag_ipv4 iptable_filter ip_tables ip6t_REJECT nf_reject_ipv6 nf_conntrack_ipv6 nf_defrag_ipv6 xt_state nf_conntrack ip6table_filter ip6_tables ib_ipoib rdma_ucm ib_ucm ib_uverbs ib_umad rdma_cm ib_cm iw_cm ib_sa ib_mad ib_core ib_addr ipv6 ovmapi ppdev parport_pc parport xen_netfront fb_sys_fops sysimgblt sysfillrect syscopyarea acpi_cpufreq pcspkr i2c_piix4 i2c_core sg ext4 jbd2 mbcache2 sr_mod cdrom xen_blkfront pata_acpi ata_generic ata_piix floppy dm_mirror dm_region_hash dm_log dm_mod CPU: 0 PID: 4349 Comm: startWebLogic.s Not tainted 4.1.12-124.19.2.el6uek.x86_64 #2 Hardware name: Xen HVM domU, BIOS 4.4.4OVM 09/06/2018 task: ffff8803fb04e200 ti: ffff8800ea4d8000 task.ti: ffff8800ea4d8000 RIP: 0010:[] [] __ocfs2_resv_find_window+0x498/0x760 [ocfs2] Call Trace: ocfs2_resmap_resv_bits+0x10d/0x400 [ocfs2] ocfs2_claim_local_alloc_bits+0xd0/0x640 [ocfs2] __ocfs2_claim_clusters+0x178/0x360 [ocfs2] ocfs2_claim_clusters+0x1f/0x30 [ocfs2] ocfs2_convert_inline_data_to_extents+0x634/0xa60 [ocfs2] ocfs2_write_begin_nolock+0x1c6/0x1da0 [ocfs2] ocfs2_write_begin+0x13e/0x230 [ocfs2] generic_perform_write+0xbf/0x1c0 __generic_file_write_iter+0x19c/0x1d0 ocfs2_file_write_iter+0x589/0x1360 [ocfs2] __vfs_write+0xb8/0x110 vfs_write+0xa9/0x1b0 SyS_write+0x46/0xb0 system_call_fastpath+0x18/0xd7 Code: ff ff 8b 75 b8 39 75 b0 8b 45 c8 89 45 98 0f 84 e5 fe ff ff 45 8b 74 24 18 41 8b 54 24 1c e9 56 fc ff ff 85 c0 0f 85 48 ff ff ff <0f> 0b 48 8b 05 cf c3 de ff 48 ba 00 00 00 00 00 00 00 10 48 85 RIP __ocfs2_resv_find_window+0x498/0x760 [ocfs2] RSP ---[ end trace 566f07529f2edf3c ]--- Kernel panic - not syncing: Fatal exception Kernel Offset: disabledLink: http://lkml.kernel.org/r/20181121020023.3034-2-junxiao.bi@oracle.comSigned-off-by: Junxiao Bi Reviewed-by: Yiwen Jiang Acked-by: Joseph Qi Cc: Jun Piao Cc: Mark Fasheh Cc: Joel Becker Cc: Changwei Ge Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/fs/ocfs2/localalloc.c

dec5b0d4 - ocfs2: remove set but not used variable 'lastzero'

Fri, 28 Dec 2018 08:32:43 +0000

ocfs2: remove set but not used variable 'lastzero'lastzero is not used after setting its value. It is safe to remove theunused variable.Link: http://lkml.kernel.org/r/1540296942-24533-1-git-send-email-zhongjiang@huawei.comSigned-off-by: zhong jiang Reviewed-by: Andrew Morton Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Joseph Qi Cc: Changwei Ge Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/fs/ocfs2/localalloc.c

93f5920d - ocfs2: return -EROFS when filesystem becomes read-only

Fri, 17 Aug 2018 22:44:24 +0000

ocfs2: return -EROFS when filesystem becomes read-onlyWe should return -EROFS rather than other errno if filesystem becomesread-only.[akpm@linux-foundation.org: coding-style fixes]Link: http://lkml.kernel.org/r/5B191B26.9010501@huawei.comSigned-off-by: Jun Piao Reviewed-by: Yiwen Jiang Acked-by: Joseph Qi Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/fs/ocfs2/localalloc.c

35ddf78e - ocfs2: fix occurring deadlock by changing ocfs2_wq from global to local

Fri, 25 Mar 2016 21:21:32 +0000

ocfs2: fix occurring deadlock by changing ocfs2_wq from global to localThis patch fixes a deadlock, as follows: Node 1 Node 2 Node 31)volume a and b are only mount vol a only mount vol b mounted2) start to mount b start to mount a3) check hb of Node 3 check hb of Node 2 in vol a, qs_holds++ in vol b, qs_holds++4) -------------------- all nodes' network down --------------------5) progress of mount b the same situation as failed, and then call Node 2 ocfs2_dismount_volume. but the process is hung, since there is a work in ocfs2_wq cannot beo completed. This work is about vol a, because ocfs2_wq is global wq. BTW, this work which is scheduled in ocfs2_wq is ocfs2_orphan_scan_work, and the context in this work needs to take inode lock of orphan_dir, because lockres owner are Node 1 and all nodes' nework has been down at the same time, so it can't get the inode lock.6) Why can't this node be fenced when network disconnected? Because the process of mount is hung what caused qs_holds is not equal 0.Because all works in the ocfs2_wq are relative to the super block.The solution is to change the ocfs2_wq from global to local. In otherwords, move it into struct ocfs2_super.Signed-off-by: Yiwen Jiang Reviewed-by: Joseph Qi Cc: Xue jiufei Cc: Mark Fasheh Cc: Joel Becker Cc: Cc: Junxiao Bi Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/fs/ocfs2/localalloc.c

5955102c - wrappers for ->i_mutex access

Fri, 22 Jan 2016 20:40:57 +0000

wrappers for ->i_mutex accessparallel to mutex_{lock,unlock,trylock,is_locked,lock_nested},inode_foo(inode) being mutex_foo(&inode->i_mutex).Please, use those for access to ->i_mutex; over the coming cycle->i_mutex will become rwsem, with ->lookup() done with it heldonly shared.Signed-off-by: Al Viro List of files: /linux-6.15/fs/ocfs2/localalloc.c

72865d92 - ocfs2: clean up redundant NULL check before iput

Thu, 14 Jan 2016 23:17:27 +0000

ocfs2: clean up redundant NULL check before iputSince iput will take care the NULL check itself, NULL check beforecalling it is redundant. So clean them up.Signed-off-by: Joseph Qi Cc: Mark Fasheh Cc: Joel Becker Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/fs/ocfs2/localalloc.c

7ecef14a - ocfs2: neaten do_error, ocfs2_error and ocfs2_abort

Fri, 04 Sep 2015 22:44:51 +0000

ocfs2: neaten do_error, ocfs2_error and ocfs2_abortThese uses sometimes do and sometimes don't have '\n' terminations. Makethe uses consistently use '\n' terminations and remove the newline fromthe functions.Miscellanea:o Coalesce formatso Realign argumentsSigned-off-by: Joe Perches Reviewed-by: Mark Fasheh Cc: Joel Becker Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/fs/ocfs2/localalloc.c