Changes in bitmap.c

bac89bb3 - fs/ntfs3: Accumulated refactoring changes

Thu, 10 Oct 2024 17:06:59 +0000

fs/ntfs3: Accumulated refactoring changesChanges made to improve readability and debuggability.Signed-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c

2cbbd968 - fs/ntfs3: Missed error return

Mon, 17 Jun 2024 10:43:09 +0000

fs/ntfs3: Missed error returnFixes: 3f3b442b5ad2 ("fs/ntfs3: Add bitmap")Signed-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c

3f5ef510 - fs/ntfs3: add prefix to bitmap_size() and use BITS_TO_U64()

Wed, 27 Mar 2024 15:23:46 +0000

fs/ntfs3: add prefix to bitmap_size() and use BITS_TO_U64()bitmap_size() is a pretty generic name and one may want to use it fora generic bitmap API function. At the same time, its logic isNTFS-specific, as it aligns to the sizeof(u64), not the sizeof(long)(although it uses ideologically right ALIGN() instead of division).Add the prefix 'ntfs3_' used for that FS (not just 'ntfs_' to not mixit with the legacy module) and use generic BITS_TO_U64() while at it.Suggested-by: Yury Norov # BITS_TO_U64()Reviewed-by: Przemek Kitszel Reviewed-by: Yury Norov Signed-off-by: Alexander Lobakin Signed-off-by: David S. Miller List of files: /linux-6.15/fs/ntfs3/bitmap.c

ddb17dc8 - fs/ntfs3: Use kvfree to free memory allocated by kvmalloc

Tue, 16 Jan 2024 07:32:20 +0000

fs/ntfs3: Use kvfree to free memory allocated by kvmallocSigned-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c

4ad5c924 - fs/ntfs3: Allow repeated call to ntfs3_put_sbi

Fri, 22 Sep 2023 10:07:59 +0000

fs/ntfs3: Allow repeated call to ntfs3_put_sbiSigned-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c

fc471e39 - fs/ntfs3: Use kvmalloc instead of kmalloc(... __GFP_NOWARN)

Fri, 30 Jun 2023 12:12:58 +0000

fs/ntfs3: Use kvmalloc instead of kmalloc(... __GFP_NOWARN)Signed-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c

f0377761 - fs/ntfs3: Code formatting

Mon, 08 May 2023 08:22:05 +0000

fs/ntfs3: Code formattingclang-format-15 was used to format code according kernel's .clang-format.Signed-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c

96de65a9 - fs/ntfs3: Code formatting and refactoring

Tue, 17 Jan 2023 11:01:00 +0000

fs/ntfs3: Code formatting and refactoringAdded minor refactoring.Added and fixed some comments.In some places, the code has been reformatted to fit into 80 columns.clang-format-12 was used to format code according kernel's .clang-format.Signed-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c

6827d50b - fs/ntfs3: Refactoring of various minor issues

Fri, 30 Dec 2022 10:58:25 +0000

fs/ntfs3: Refactoring of various minor issuesRemoved unused macro.Changed null pointer checking.Fixed inconsistent indenting.Signed-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c

ec5fc720 - fs/ntfs3: Improve checking of bad clusters

Tue, 11 Oct 2022 17:19:36 +0000

fs/ntfs3: Improve checking of bad clustersAdded new function wnd_set_used_safe.Load $BadClus before $AttrDef instead of before $Bitmap.Signed-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c

08811ba5 - fs/ntfs3: Add ntfs_bitmap_weight_le function and refactoring

Thu, 06 Oct 2022 16:42:24 +0000

fs/ntfs3: Add ntfs_bitmap_weight_le function and refactoringAdded ntfs_bitmap_weight_le function.Changed argument types of bits/bitmap functions.Signed-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c

095d8ce6 - fs/ntfs3: Use _le variants of bitops functions

Tue, 07 Dec 2021 10:24:55 +0000

fs/ntfs3: Use _le variants of bitops functionsThe functions from bitops.h already have _le variants so use them toprevent invalid reads/writes of the bitmap on big endian systems.Signed-off-by: Thomas Kühnel Signed-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c

88a8d0d2 - fs/ntfs3: Add functions to modify LE bitmaps

Tue, 07 Dec 2021 10:24:54 +0000

fs/ntfs3: Add functions to modify LE bitmaps__bitmap_set/__bitmap_clear only works with bitmaps in CPU order.Define a variant of these functions in ntfs3 to handle modifying bitmapsread from the filesystem.Signed-off-by: Thomas Kühnel Reviewed-by: Nicolas Schier Signed-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c

0d0f659b - fs/ntfs3: Use __GFP_NOWARN allocation at wnd_init()

Sun, 02 Oct 2022 14:39:15 +0000

fs/ntfs3: Use __GFP_NOWARN allocation at wnd_init()syzbot is reporting too large allocation at wnd_init() [1], for a craftedfilesystem can become wnd->nwnd close to UINT_MAX. Add __GFP_NOWARN inorder to avoid too large allocation warning, than exhausting memory byusing kvcalloc().Link: https://syzkaller.appspot.com/bug?extid=fa4648a5446460b7b963 [1]Reported-by: syzot Signed-off-by: Tetsuo Handa Signed-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c

557d1967 - fs/ntfs3: Fix slab-out-of-bounds read in ntfs_trim_fs

Sat, 01 Oct 2022 07:00:24 +0000

fs/ntfs3: Fix slab-out-of-bounds read in ntfs_trim_fsSyzbot reports an out of bound access in ntfs_trim_fs.The cause of this is using a loop termination condition that compareswindow index (iw) with wnd->nbits instead of wnd->nwnd, due to which theindex used for wnd->free_bits exceeds the size of the array allocated.Fix the loop condition.Fixes: 3f3b442b5ad2 ("fs/ntfs3: Add bitmap")Link: https://syzkaller.appspot.com/bug?extid=b892240eac461e488d51Reported-by: syzbot+b892240eac461e488d51@syzkaller.appspotmail.comSigned-off-by: Abdun Nihaal Signed-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c

92f017c4 - fs/ntfs3: Use kmalloc_array for allocating multiple elements

Fri, 19 Aug 2022 05:51:17 +0000

fs/ntfs3: Use kmalloc_array for allocating multiple elementsPrefer using kmalloc_array(a, b) over kmalloc(a * b) as thisimproves semantics since kmalloc is intended for allocating anarray of memory.Signed-off-by: Kenneth Lee Signed-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c

70a1cb10 - lib/bitmap: don't call __bitmap_weight() in kernel code

Sun, 18 Sep 2022 03:07:11 +0000

lib/bitmap: don't call __bitmap_weight() in kernel code__bitmap_weight() is not to be used directly in the kernel code becauseit's a helper for bitmap_weight(). Switch everything to bitmap_weight().Signed-off-by: Yury Norov List of files: /linux-6.15/fs/ntfs3/bitmap.c

96964352 - fs/ntfs3: Remove unused function wnd_bits

Thu, 21 Jul 2022 03:18:41 +0000

fs/ntfs3: Remove unused function wnd_bitsSince the function wnd_bits is defined but not called in any file, it isa useless function, and we delete it in view of the brevity of the code.Remove some warnings found by running scripts/kernel-doc, which iscaused by using 'make W=1'.fs/ntfs3/bitmap.c:54:19: warning: unused function 'wnd_bits' [-Wunused-function].Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Signed-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c

54033c13 - fs/ntfs3: Added comments to frecord functions

Wed, 06 Jul 2022 17:01:11 +0000

fs/ntfs3: Added comments to frecord functionsAdded some comments in frecord.c for more context.Also changed run_lookup to static because it's an internal function.Signed-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c

548744f8 - fs/ntfs3: Remove a useless test

Thu, 23 Dec 2021 12:20:00 +0000

fs/ntfs3: Remove a useless test'new_free' has just been allocated by kmalloc() and is known to be notNULL.So this pointer can't be equal to a previous memory allocation.Signed-off-by: Christophe JAILLET Signed-off-by: Konstantin Komarov List of files: /linux-6.15/fs/ntfs3/bitmap.c