Changes in Kconfig

cd35b6cb - nfs: add missing selections of CONFIG_CRC32

Tue, 01 Apr 2025 22:02:21 +0000

nfs: add missing selections of CONFIG_CRC32nfs.ko, nfsd.ko, and lockd.ko all use crc32_le(), which is availableonly when CONFIG_CRC32 is enabled. But the only NFS kconfig option thatselected CONFIG_CRC32 was CONFIG_NFS_DEBUG, which is client-specific anddid not actually guard the use of crc32_le() even on the client.The code worked around this bug by only actually calling crc32_le() whenCONFIG_CRC32 is built-in, instead hard-coding '0' in other cases. Thisavoided randconfig build errors, and in real kernels the fallback codewas unlikely to be reached since CONFIG_CRC32 is 'default y'. But, thisreally needs to just be done properly, especially now that I'm planningto update CONFIG_CRC32 to not be 'default y'.Therefore, make CONFIG_NFS_FS, CONFIG_NFSD, and CONFIG_LOCKD selectCONFIG_CRC32. Then remove the fallback code that becomes unnecessary,as well as the selection of CONFIG_CRC32 from CONFIG_NFS_DEBUG.Fixes: 1264a2f053a3 ("NFS: refactor code for calculating the crc32 hash of a filehandle")Signed-off-by: Eric Biggers Acked-by: Anna Schumaker Signed-off-by: Chuck Lever List of files: /linux-6.15/fs/nfsd/Kconfig

26a80762 - NFSD: Add a Kconfig setting to enable delegated timestamps

Wed, 12 Mar 2025 03:06:38 +0000

NFSD: Add a Kconfig setting to enable delegated timestampsAfter three tries, we still see test failures with delegatedtimestamps. Disable them by default, but leave the implementationintact so that development can continue.Cc: stable@vger.kernel.org # v6.14Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever List of files: /linux-6.15/fs/nfsd/Kconfig

4806ded4 - nfs_common: factor out nfs_errtbl and nfs_stat_to_errno

Thu, 05 Sep 2024 19:09:35 +0000

nfs_common: factor out nfs_errtbl and nfs_stat_to_errnoCommon nfs_stat_to_errno() is used by both fs/nfs/nfs2xdr.c andfs/nfs/nfs3xdr.cWill also be used by fs/nfsd/localio.cSigned-off-by: Mike Snitzer Reviewed-by: Jeff Layton Reviewed-by: NeilBrown Signed-off-by: Anna Schumaker List of files: /linux-6.15/fs/nfsd/Kconfig

18a54506 - NFSD: Fix nfsdcld warning

Tue, 04 Jun 2024 15:24:00 +0000

NFSD: Fix nfsdcld warningSince CONFIG_NFSD_LEGACY_CLIENT_TRACKING is a new config option, itsinitial default setting should have been Y (if we are to follow thecommon practice of "default Y, wait, default N, wait, remove code").Paul also suggested adding a clearer remedy action to the warningmessage.Reported-by: Paul Menzel Message-Id: Fixes: 74fd48739d04 ("nfsd: new Kconfig option for legacy client tracking")Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever List of files: /linux-6.15/fs/nfsd/Kconfig

74fd4873 - nfsd: new Kconfig option for legacy client tracking

Fri, 13 Oct 2023 13:03:53 +0000

nfsd: new Kconfig option for legacy client trackingWe've had a number of attempts at different NFSv4 client trackingmethods over the years, but now nfsdcld has emerged as the clear winnersince the others (recoverydir and the usermodehelper upcall) areproblematic.As a case in point, the recoverydir backend uses MD5 hashes to encodelong form clientid strings, which means that nfsd repeatedly gets dingedon FIPS audits, since MD5 isn't considered secure. Its use of MD5 is notcryptographically significant, so there is no danger there, but allowingus to compile that out allows us to sidestep the issue entirely.As a prelude to eventually removing support for these client trackingmethods, add a new Kconfig option that enables them. Mark it deprecatedand make it default to N.Acked-by: NeilBrown Signed-off-by: Jeff Layton Signed-off-by: Chuck Lever List of files: /linux-6.15/fs/nfsd/Kconfig

e57d0652 - NFS & NFSD: Update GSS dependencies

Wed, 08 Mar 2023 14:45:09 +0000

NFS & NFSD: Update GSS dependenciesGeert reports that:> On v6.2, "make ARCH=m68k defconfig" gives you> CONFIG_RPCSEC_GSS_KRB5=m> On v6.3, it became builtin, due to dropping the dependencies on> the individual crypto modules.>> $ grep -E "CRYPTO_(MD5|DES|CBC|CTS|ECB|HMAC|SHA1|AES)" .config> CONFIG_CRYPTO_AES=y> CONFIG_CRYPTO_AES_TI=m> CONFIG_CRYPTO_DES=m> CONFIG_CRYPTO_CBC=m> CONFIG_CRYPTO_CTS=m> CONFIG_CRYPTO_ECB=m> CONFIG_CRYPTO_HMAC=m> CONFIG_CRYPTO_MD5=m> CONFIG_CRYPTO_SHA1=mThis behavior is triggered by the "default y" in the definition ofRPCSEC_GSS.The "default y" was added in 2010 by commit df486a25900f ("NFS: Fixthe selection of security flavours in Kconfig"). However,svc_gss_principal was removed in 2012 by commit 03a4e1f6ddf2("nfsd4: move principal name into svc_cred"), so the 2010 fix isno longer necessary. We can safely change the NFS_V4 and NFSD_V4dependencies back to RPCSEC_GSS_KRB5 to get the nicer v6.2behavior back.Selecting KRB5 symbolically represents the true requirement here:that all spec-compliant NFSv4 implementations must have Kerberosavailable to use.Reported-by: Geert Uytterhoeven Fixes: dfe9a123451a ("SUNRPC: Enable rpcsec_gss_krb5.ko to be built without CRYPTO_DES")Signed-off-by: Chuck Lever List of files: /linux-6.15/fs/nfsd/Kconfig

2f3a4b2a - nfsd: allow disabling NFSv2 at compile time

Tue, 18 Oct 2022 11:47:56 +0000

nfsd: allow disabling NFSv2 at compile timerpc.nfsd stopped supporting NFSv2 a year ago. Take the next logicalstep toward deprecating it and allow NFSv2 support to be compiled out.Add a new CONFIG_NFSD_V2 option that can be turned off and rework theCONFIG_NFSD_V?_ACL option dependencies. Add a description thatdiscourages enabling it.Also, change the description of CONFIG_NFSD to state that the always-onversion is now 3 instead of 2.Finally, add an #ifdef around "case 2:" in __write_versions. When NFSv2is disabled at compile time, this should make the kernel ignore attemptsto disable it at runtime, but still error out when trying to enable it.Signed-off-by: Jeff Layton Reviewed-by: Tom Talpey Signed-off-by: Chuck Lever List of files: /linux-6.15/fs/nfsd/Kconfig

5f9a62ff - NFSD: Remove CONFIG_NFSD_V3

Sun, 06 Feb 2022 17:25:47 +0000

NFSD: Remove CONFIG_NFSD_V3Eventually support for NFSv2 in the Linux NFS server is to bedeprecated and then removed.However, NFSv2 is the "always supported" version that is availableas soon as CONFIG_NFSD is set. Before NFSv2 support can be removed,we need to choose a different "always supported" version.This patch removes CONFIG_NFSD_V3 so that NFSv3 is always supported,as NFSv2 is today. When NFSv2 support is removed, NFSv3 will becomethe only "always supported" NFS version.The defconfigs still need to be updated to remove CONFIG_NFSD_V3=y.Signed-off-by: Chuck Lever List of files: /linux-6.15/fs/nfsd/Kconfig

8c6aabd1 - nfsd/blocklayout: use ->get_unique_id instead of sending SCSI commands

Thu, 21 Oct 2021 06:06:03 +0000

nfsd/blocklayout: use ->get_unique_id instead of sending SCSI commandsCall the ->get_unique_id method to query the SCSI identifiers. This canuse the cached VPD page in the sd driver instead of sending a commandon every LAYOUTGET. It will also allow to support NVMe based volumesif the draft for that ever takes off.Signed-off-by: Christoph Hellwig Acked-by: J. Bruce Fields Reviewed-by: Hannes Reinecke Link: https://lore.kernel.org/r/20211021060607.264371-4-hch@lst.deSigned-off-by: Jens Axboe List of files: /linux-6.15/fs/nfsd/Kconfig

33ff4ce4 - scsi: core: Rename CONFIG_BLK_SCSI_REQUEST to CONFIG_SCSI_COMMON

Sat, 24 Jul 2021 07:20:28 +0000

scsi: core: Rename CONFIG_BLK_SCSI_REQUEST to CONFIG_SCSI_COMMONCONFIG_BLK_SCSI_REQUEST is rather misnamed as it enables building a smallamount of code shared by the SCSI initiator, target, and consumers of thescsi_request passthrough API. Rename it and also allow building it as amodule.[mkp: add module license]Link: https://lore.kernel.org/r/20210724072033.1284840-20-hch@lst.deSigned-off-by: Christoph Hellwig Signed-off-by: Martin K. Petersen List of files: /linux-6.15/fs/nfsd/Kconfig

d9092b4b - NFSv4.2: Remove ifdef CONFIG_NFSD from NFSv4.2 client SSC code.

Thu, 22 Apr 2021 07:37:49 +0000

NFSv4.2: Remove ifdef CONFIG_NFSD from NFSv4.2 client SSC code.The client SSC code should not depend on any of the CONFIG_NFSD config.This patch removes all CONFIG_NFSD from NFSv4.2 client SSC code andsimplifies the config of CONFIG_NFS_V4_2_SSC_HELPER, NFSD_V4_2_INTER_SSC.Signed-off-by: Dai Ngo Signed-off-by: Trond Myklebust List of files: /linux-6.15/fs/nfsd/Kconfig

34a62493 - nfsd: Fix typo "accesible"

Thu, 18 Mar 2021 20:22:21 +0000

nfsd: Fix typo "accesible"Trivial fix.Cc: linux-nfs@vger.kernel.orgSigned-off-by: Ricardo Ribalda Signed-off-by: Chuck Lever List of files: /linux-6.15/fs/nfsd/Kconfig

70052273 - fs: nfsd: fix kconfig dependency warning for NFSD_V4

Fri, 19 Feb 2021 21:56:10 +0000

fs: nfsd: fix kconfig dependency warning for NFSD_V4When NFSD_V4 is enabled and CRYPTO is disabled,Kbuild gives the following warning:WARNING: unmet direct dependencies detected for CRYPTO_SHA256 Depends on [n]: CRYPTO [=n] Selected by [y]: - NFSD_V4 [=y] && NETWORK_FILESYSTEMS [=y] && NFSD [=y] && PROC_FS [=y]WARNING: unmet direct dependencies detected for CRYPTO_MD5 Depends on [n]: CRYPTO [=n] Selected by [y]: - NFSD_V4 [=y] && NETWORK_FILESYSTEMS [=y] && NFSD [=y] && PROC_FS [=y]This is because NFSD_V4 selects CRYPTO_MD5 and CRYPTO_SHA256,without depending on or selecting CRYPTO, despite those config optionsbeing subordinate to CRYPTO.Signed-off-by: Julian Braha Signed-off-by: Chuck Lever List of files: /linux-6.15/fs/nfsd/Kconfig

02591f9f - NFSv4_2: SSC helper should use its own config.

Thu, 28 Jan 2021 06:42:26 +0000

NFSv4_2: SSC helper should use its own config.Currently NFSv4_2 SSC helper, nfs_ssc, incorrectly uses GRACE_PERIODas its config. Fix by adding new config NFS_V4_2_SSC_HELPER whichdepends on NFS_V4_2 and is automatically selected when NFSD_V4 isenabled. Also removed the file name from a comment in nfs_ssc.c.Signed-off-by: Dai Ngo Signed-off-by: Chuck Lever List of files: /linux-6.15/fs/nfsd/Kconfig

0cfcd405 - NFSv4.2: Fix NFS4ERR_STALE error when doing inter server copy

Mon, 19 Oct 2020 03:42:49 +0000

NFSv4.2: Fix NFS4ERR_STALE error when doing inter server copyNFS_FS=y as dependency of CONFIG_NFSD_V4_2_INTER_SSC still havebuild errors and some configs with NFSD=m to get NFS4ERR_STALEerror when doing inter server copy.Added ops table in nfs_common for knfsd to access NFS client modules.Fixes: 3ac3711adb88 ("NFSD: Fix NFS server build errors")Signed-off-by: Dai Ngo Signed-off-by: J. Bruce Fields List of files: /linux-6.15/fs/nfsd/Kconfig

e56dc9e2 - nfsd: remove fault injection code

Fri, 31 Jul 2020 00:33:57 +0000

nfsd: remove fault injection codeIt was an interesting idea but nobody seems to be using it, it's buggyat this point, and nfs4state.c is already complicated enough without it.The new nfsd/clients/ code provides some of the same functionality, andcould probably do more if desired.This feature has been deprecated since 9d60d93198c6 ("Deprecate nfsdfault injection").Signed-off-by: J. Bruce Fields List of files: /linux-6.15/fs/nfsd/Kconfig

3ac3711a - NFSD: Fix NFS server build errors

Thu, 05 Mar 2020 23:27:36 +0000

NFSD: Fix NFS server build errorsyuehaibing@huawei.com reports the following build errors arise whenCONFIG_NFSD_V4_2_INTER_SSC is set and the NFS client is not builtinto the kernel:fs/nfsd/nfs4proc.o: In function `nfsd4_do_copy':nfs4proc.c:(.text+0x23b7): undefined reference to `nfs42_ssc_close'fs/nfsd/nfs4proc.o: In function `nfsd4_copy':nfs4proc.c:(.text+0x5d2a): undefined reference to `nfs_sb_deactive'fs/nfsd/nfs4proc.o: In function `nfsd4_do_async_copy':nfs4proc.c:(.text+0x61d5): undefined reference to `nfs42_ssc_open'nfs4proc.c:(.text+0x6389): undefined reference to `nfs_sb_deactive'The new inter-server copy code invokes client functions. Until theNFS server has infrastructure to load the appropriate NFS clientmodules to handle inter-server copy requests, let's constrain theway this feature is built.Reported-by: YueHaibing Fixes: ce0887ac96d3 ("NFSD add nfs4 inter ssc to nfsd4_copy")Signed-off-by: Chuck Lever Tested-by: YueHaibing # build-tested List of files: /linux-6.15/fs/nfsd/Kconfig

b9e8638e - NFSD: allow inter server COPY to have a STALE source server fh

Mon, 07 Oct 2019 14:56:48 +0000

NFSD: allow inter server COPY to have a STALE source server fhThe inter server to server COPY source server filehandleis a foreign filehandle as the COPY is sent to the destinationserver.Signed-off-by: Olga Kornievskaia List of files: /linux-6.15/fs/nfsd/Kconfig

38a2204f - nfsd: depend on CRYPTO_MD5 for legacy client tracking

Wed, 04 Dec 2019 06:13:22 +0000

nfsd: depend on CRYPTO_MD5 for legacy client trackingThe legacy client tracking infrastructure of nfsd makes use of MD5 toderive a client's recovery directory name. As the nfsd module doesn'tdeclare any dependency on CRYPTO_MD5, though, it may fail to allocatethe hash if the kernel was compiled without it. As a result, generationof client recovery directories will fail with the following error: NFSD: unable to generate recoverydir nameThe explicit dependency on CRYPTO_MD5 was removed as redundant back in6aaa67b5f3b9 (NFSD: Remove redundant "select" clauses in fs/Kconfig2008-02-11) as it was already implicitly selected via RPCSEC_GSS_KRB5.This broke when RPCSEC_GSS_KRB5 was made optional for NFSv4 in commitdf486a25900f (NFS: Fix the selection of security flavours in Kconfig) ata later point.Fix the issue by adding back an explicit dependency on CRYPTO_MD5.Fixes: df486a25900f (NFS: Fix the selection of security flavours in Kconfig)Signed-off-by: Patrick Steinhardt Signed-off-by: J. Bruce Fields List of files: /linux-6.15/fs/nfsd/Kconfig

a2e2f2dc - nfsd: v4 support requires CRYPTO_SHA256

Tue, 12 Nov 2019 19:01:55 +0000

nfsd: v4 support requires CRYPTO_SHA256The new nfsdcld client tracking operations use sha256 to compute hashesof the kerberos principals, so make sure CRYPTO_SHA256 is enabled.Fixes: 6ee95d1c8991 ("nfsd: add support for upcall version 2")Reported-by: Jamie Heilman Signed-off-by: Scott Mayhew Signed-off-by: J. Bruce Fields List of files: /linux-6.15/fs/nfsd/Kconfig