Changes in Kconfig

cd35b6cb - nfs: add missing selections of CONFIG_CRC32

Tue, 01 Apr 2025 22:02:21 +0000

nfs: add missing selections of CONFIG_CRC32nfs.ko, nfsd.ko, and lockd.ko all use crc32_le(), which is availableonly when CONFIG_CRC32 is enabled. But the only NFS kconfig option thatselected CONFIG_CRC32 was CONFIG_NFS_DEBUG, which is client-specific anddid not actually guard the use of crc32_le() even on the client.The code worked around this bug by only actually calling crc32_le() whenCONFIG_CRC32 is built-in, instead hard-coding '0' in other cases. Thisavoided randconfig build errors, and in real kernels the fallback codewas unlikely to be reached since CONFIG_CRC32 is 'default y'. But, thisreally needs to just be done properly, especially now that I'm planningto update CONFIG_CRC32 to not be 'default y'.Therefore, make CONFIG_NFS_FS, CONFIG_NFSD, and CONFIG_LOCKD selectCONFIG_CRC32. Then remove the fallback code that becomes unnecessary,as well as the selection of CONFIG_CRC32 from CONFIG_NFS_DEBUG.Fixes: 1264a2f053a3 ("NFS: refactor code for calculating the crc32 hash of a filehandle")Signed-off-by: Eric Biggers Acked-by: Anna Schumaker Signed-off-by: Chuck Lever List of files: /linux-6.15/fs/nfs/Kconfig

90190ba1 - nfs: Make NFS_FSCACHE select NETFS_SUPPORT instead of depending on it

Fri, 27 Dec 2024 19:17:58 +0000

nfs: Make NFS_FSCACHE select NETFS_SUPPORT instead of depending on itHaving the NFS_FSCACHE option depend on the NETFS_SUPPORT options makesselecting NFS_FSCACHE impossible unless another option that additionallyselects NETFS_SUPPORT is already selected.As a result, for example, being able to reach and select the NFS_FSCACHEoption requires the CEPH_FS or CIFS option to be selected beforehand, whichobviously doesn't make much sense.Let's correct this by making the NFS_FSCACHE option actually select theNETFS_SUPPORT option, instead of depending on it.Fixes: 915cd30cdea8 ("netfs, fscache: Combine fscache with netfs")Cc: stable@vger.kernel.orgReported-by: Diederik de Haas Signed-off-by: Dragan Simic Signed-off-by: Anna Schumaker List of files: /linux-6.15/fs/nfs/Kconfig

4806ded4 - nfs_common: factor out nfs_errtbl and nfs_stat_to_errno

Thu, 05 Sep 2024 19:09:35 +0000

nfs_common: factor out nfs_errtbl and nfs_stat_to_errnoCommon nfs_stat_to_errno() is used by both fs/nfs/nfs2xdr.c andfs/nfs/nfs3xdr.cWill also be used by fs/nfsd/localio.cSigned-off-by: Mike Snitzer Reviewed-by: Jeff Layton Reviewed-by: NeilBrown Signed-off-by: Anna Schumaker List of files: /linux-6.15/fs/nfs/Kconfig

d1404e46 - NFS: Don't enable NFS v2 by default

Thu, 25 Apr 2024 20:34:40 +0000

NFS: Don't enable NFS v2 by defaultThis came up during one of the Bake-a-thon discussions. NFS v2 supportwas dropped from nfs-utils/mount.nfs in December 2021. Let's turn itoff by default in the kernel too, since this means there isn't a wayto mount and test it.Signed-off-by: Anna Schumaker Reviewed-by: Jeffrey Layton Signed-off-by: Trond Myklebust List of files: /linux-6.15/fs/nfs/Kconfig

915cd30c - netfs, fscache: Combine fscache with netfs

Mon, 20 Nov 2023 15:55:18 +0000

netfs, fscache: Combine fscache with netfsNow that the fscache code is moved to be colocated with the netfslib codeso that they combined into one module, do the combining.Signed-off-by: David Howells Reviewed-by: Jeff Layton cc: Christian Brauner cc: linux-fsdevel@vger.kernel.orgcc: linux-cachefs@redhat.comcc: linux-nfs@vger.kernel.org,cc: linux-erofs@lists.ozlabs.org List of files: /linux-6.15/fs/nfs/Kconfig

a68c6fbb - nfs41: drop dependency between flexfiles layout driver and NFSv3 modules

Mon, 11 Sep 2023 14:59:04 +0000

nfs41: drop dependency between flexfiles layout driver and NFSv3 modulesThe flexfiles layout driver depends on NFSv3 module as data serversmight be configure to provide nfsv3 only.Disabling the nfsv3 protocol completely disables the flexfiles layout driver,however, the data server still might support v4.1 protocol. Thus the strondcouling betwwen flexfiles and nfsv3 modules should be relaxed, as layout driverwill return UNSUPPORTED if not matching protocol is found.Signed-off-by: Tigran Mkrtchyan Signed-off-by: Trond Myklebust List of files: /linux-6.15/fs/nfs/Kconfig

9cf2744d - NFS: Enable the READ_PLUS operation by default

Mon, 17 Jul 2023 20:33:14 +0000

NFS: Enable the READ_PLUS operation by defaultNow that the remaining issues have been worked out, including someunexpected 32 bit issues, we can safely enable the feature by default.Signed-off-by: Anna Schumaker List of files: /linux-6.15/fs/nfs/Kconfig

88a4d7bd - NFS: Configure support for netfs when NFS fscache is configured

Mon, 20 Feb 2023 13:43:05 +0000

NFS: Configure support for netfs when NFS fscache is configuredAs first steps for support of the netfs library when NFS_FSCACHE isconfigured, add NETFS_SUPPORT to Kconfig and add the required netfs_inodeinto struct nfs_inode.Using netfs requires we move the VFS inode structure to be storedinside struct netfs_inode, along with the fscache_cookie.Thus, if NFS_FSCACHE is configured, place netfs_inode inside ananonymous union so the vfs_inode memory is the same and we donot need to modify other non-fscache areas of NFS.In addition, inside the NFS fscache code, use the new helpers,netfs_inode() and netfs_i_cookie() helpers, and remove our ownhelper, nfs_i_fscache().Later patches will convert NFS fscache to fully use netfs.Signed-off-by: Dave Wysochanski Tested-by: Daire Byrne Signed-off-by: Anna Schumaker List of files: /linux-6.15/fs/nfs/Kconfig

8be8f170 - NFS: Remove "select RPCSEC_GSS_KRB5

Tue, 28 Mar 2023 17:47:58 +0000

NFS: Remove "select RPCSEC_GSS_KRB5If CONFIG_CRYPTO=n (e.g. arm/shmobile_defconfig): WARNING: unmet direct dependencies detected for RPCSEC_GSS_KRB5 Depends on [n]: NETWORK_FILESYSTEMS [=y] && SUNRPC [=y] && CRYPTO [=n] Selected by [y]: - NFS_V4 [=y] && NETWORK_FILESYSTEMS [=y] && NFS_FS [=y]As NFSv4 can work without crypto enabled, remove the RPCSEC_GSS_KRB5dependency altogether.Trond says:> It is possible to use the NFSv4.1 client with just AUTH_SYS, and> in fact there are plenty of people out there using only that. The> fact that RFC5661 gets its knickers in a twist about RPCSEC_GSS> support is largely irrelevant to those people.>> The other issue is that ’select’ enforces the strict dependency> that if the NFS client is compiled into the kernel, then the> RPCSEC_GSS and kerberos code needs to be compiled in as well: they> cannot exist as modules.Fixes: e57d06527738 ("NFS & NFSD: Update GSS dependencies")Reported-by: kernel test robot Reported-by: Niklas Söderlund Suggested-by: Trond Myklebust Signed-off-by: Chuck Lever List of files: /linux-6.15/fs/nfs/Kconfig

e57d0652 - NFS & NFSD: Update GSS dependencies

Wed, 08 Mar 2023 14:45:09 +0000

NFS & NFSD: Update GSS dependenciesGeert reports that:> On v6.2, "make ARCH=m68k defconfig" gives you> CONFIG_RPCSEC_GSS_KRB5=m> On v6.3, it became builtin, due to dropping the dependencies on> the individual crypto modules.>> $ grep -E "CRYPTO_(MD5|DES|CBC|CTS|ECB|HMAC|SHA1|AES)" .config> CONFIG_CRYPTO_AES=y> CONFIG_CRYPTO_AES_TI=m> CONFIG_CRYPTO_DES=m> CONFIG_CRYPTO_CBC=m> CONFIG_CRYPTO_CTS=m> CONFIG_CRYPTO_ECB=m> CONFIG_CRYPTO_HMAC=m> CONFIG_CRYPTO_MD5=m> CONFIG_CRYPTO_SHA1=mThis behavior is triggered by the "default y" in the definition ofRPCSEC_GSS.The "default y" was added in 2010 by commit df486a25900f ("NFS: Fixthe selection of security flavours in Kconfig"). However,svc_gss_principal was removed in 2012 by commit 03a4e1f6ddf2("nfsd4: move principal name into svc_cred"), so the 2010 fix isno longer necessary. We can safely change the NFS_V4 and NFSD_V4dependencies back to RPCSEC_GSS_KRB5 to get the nicer v6.2behavior back.Selecting KRB5 symbolically represents the true requirement here:that all spec-compliant NFSv4 implementations must have Kerberosavailable to use.Reported-by: Geert Uytterhoeven Fixes: dfe9a123451a ("SUNRPC: Enable rpcsec_gss_krb5.ko to be built without CRYPTO_DES")Signed-off-by: Chuck Lever List of files: /linux-6.15/fs/nfs/Kconfig

896e090e - Revert "NFSv4.2: Change the default KConfig value for READ_PLUS"

Wed, 15 Feb 2023 21:49:22 +0000

Revert "NFSv4.2: Change the default KConfig value for READ_PLUS"This reverts commit 7fd461c47c6cfab4ca4d003790ec276209e52978.Unfortunately, it has come to our attention that there is still a bugsomewhere in the READ_PLUS code that can result in nfsroot systems onARM to crash during boot.Let's do the right thing and revert this change so we don't breakpeople's nfsroot setups.Signed-off-by: Anna Schumaker Signed-off-by: Trond Myklebust List of files: /linux-6.15/fs/nfs/Kconfig

7fd461c4 - NFSv4.2: Change the default KConfig value for READ_PLUS

Wed, 30 Nov 2022 18:15:27 +0000

NFSv4.2: Change the default KConfig value for READ_PLUSNow that we've worked out performance issues and have a server patchaddressing the failed xfstests, we can safely enable this feature bydefault.Signed-off-by: Anna Schumaker Signed-off-by: Trond Myklebust List of files: /linux-6.15/fs/nfs/Kconfig

830f1111 - NFS: Replace readdir's use of xxhash() with hash_64()

Thu, 31 Mar 2022 00:00:07 +0000

NFS: Replace readdir's use of xxhash() with hash_64()Both xxhash() and hash_64() appear to give similarly low collisionrates with a standard linearly increasing readdir offset. They both givesimilarly higher collision rates when applied to ext4's offsets.So switch to using the standard hash_64().Signed-off-by: Trond Myklebust List of files: /linux-6.15/fs/nfs/Kconfig

f648022f - NFS: Convert readdir page cache to use a cookie based index

Wed, 23 Feb 2022 16:31:51 +0000

NFS: Convert readdir page cache to use a cookie based indexInstead of using a linear index to address the pages, use the cookie ofthe first entry, since that is what we use to match the page anyway.This allows us to avoid re-reading the entire cache on a seekdir() typeof operation. The latter is very common when re-exporting NFS, and is amajor performance drain.The change does affect our duplicate cookie detection, since we can nolonger rely on the page index as a linear offset for detecting whetherwe looped backwards. However since we no longer do a linear searchthrough all the pages on each call to nfs_readdir(), this is less of aconcern than it was previously.The other downside is that invalidate_mapping_pages() no longer can usethe page index to avoid clearing pages that have been read. A subsequentpatch will restore the functionality this provides to the 'ls -l'heuristic.Signed-off-by: Trond Myklebust List of files: /linux-6.15/fs/nfs/Kconfig

a6b5a28e - nfs: Convert to new fscache volume/cookie API

Sat, 14 Nov 2020 18:43:54 +0000

nfs: Convert to new fscache volume/cookie APIChange the nfs filesystem to support fscache's indexing rewrite andreenable caching in nfs.The following changes have been made: (1) The fscache_netfs struct is no more, and there's no need to register the filesystem as a whole. (2) The session cookie is now an fscache_volume cookie, allocated with fscache_acquire_volume(). That takes three parameters: a string representing the "volume" in the index, a string naming the cache to use (or NULL) and a u64 that conveys coherency metadata for the volume. For nfs, I've made it render the volume name string as: "nfs,,,

,,,*<,param>[,]" (3) The fscache_cookie_def is no more and needed information is passed directly to fscache_acquire_cookie(). The cache no longer calls back into the filesystem, but rather metadata changes are indicated at other times. fscache_acquire_cookie() is passed the same keying and coherency information as before. (4) fscache_enable/disable_cookie() have been removed. Call fscache_use_cookie() and fscache_unuse_cookie() when a file is opened or closed to prevent a cache file from being culled and to keep resources to hand that are needed to do I/O. If a file is opened for writing, we invalidate it with FSCACHE_INVAL_DIO_WRITE in lieu of doing writeback to the cache, thereby making it cease caching until all currently open files are closed. This should give the same behaviour as the uptream code. Making the cache store local modifications isn't straightforward for NFS, so that's left for future patches. (5) fscache_invalidate() now needs to be given uptodate auxiliary data and a file size. It also takes a flag to indicate if this was due to a DIO write. (6) Call nfs_fscache_invalidate() with FSCACHE_INVAL_DIO_WRITE on a file to which a DIO write is made. (7) Call fscache_note_page_release() from nfs_release_page(). (8) Use a killable wait in nfs_vm_page_mkwrite() when waiting for PG_fscache to be cleared. (9) The functions to read and write data to/from the cache are stubbed out pending a conversion to use netfslib.Changes=======ver #3: - Added missing =n fallback for nfs_fscache_release_file()[1][2].ver #2: - Use gfpflags_allow_blocking() rather than using flag directly. - fscache_acquire_volume() now returns errors. - Remove NFS_INO_FSCACHE as it's no longer used. - Need to unuse a cookie on file-release, not inode-clear.Signed-off-by: Dave Wysochanski Co-developed-by: David Howells Signed-off-by: David Howells Tested-by: Dave Wysochanski Acked-by: Jeff Layton cc: Trond Myklebust cc: Anna Schumaker cc: linux-nfs@vger.kernel.orgcc: linux-cachefs@redhat.comLink: https://lore.kernel.org/r/202112100804.nksO8K4u-lkp@intel.com/ [1]Link: https://lore.kernel.org/r/202112100957.2oEDT20W-lkp@intel.com/ [2]Link: https://lore.kernel.org/r/163819668938.215744.14448852181937731615.stgit@warthog.procyon.org.uk/ # v1Link: https://lore.kernel.org/r/163906979003.143852.2601189243864854724.stgit@warthog.procyon.org.uk/ # v2Link: https://lore.kernel.org/r/163967182112.1823006.7791504655391213379.stgit@warthog.procyon.org.uk/ # v3Link: https://lore.kernel.org/r/164021575950.640689.12069642327533368467.stgit@warthog.procyon.org.uk/ # v4 List of files: /linux-6.15/fs/nfs/Kconfig

01491a75 - fscache, cachefiles: Disable configuration

Mon, 25 Oct 2021 20:41:26 +0000

fscache, cachefiles: Disable configurationDisable fscache and cachefiles in Kconfig whilst it is rewritten.Signed-off-by: David Howells Reviewed-by: Jeff Layton cc: linux-cachefs@redhat.comLink: https://lore.kernel.org/r/163819576672.215744.12444272479560406780.stgit@warthog.procyon.org.uk/ # v1Link: https://lore.kernel.org/r/163906882835.143852.11073015983885872901.stgit@warthog.procyon.org.uk/ # v2Link: https://lore.kernel.org/r/163967075113.1823006.277316290062782998.stgit@warthog.procyon.org.uk/ # v3Link: https://lore.kernel.org/r/164021481179.640689.2004199594774033658.stgit@warthog.procyon.org.uk/ # v4 List of files: /linux-6.15/fs/nfs/Kconfig

a0590473 - nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default

Tue, 23 Feb 2021 14:19:01 +0000

nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig defaultThis follows what was done in 8c2fabc6542d9d0f8b16bd1045c2eda59bdcde13.With the default being m, it's impossible to build the module into thekernel.Signed-off-by: Timo Rothenpieler Signed-off-by: Anna Schumaker List of files: /linux-6.15/fs/nfs/Kconfig

21e31401 - NFS: Disable READ_PLUS by default

Thu, 03 Dec 2020 20:18:39 +0000

NFS: Disable READ_PLUS by defaultWe've been seeing failures with xfstests generic/091 and generic/263when using READ_PLUS. I've made some progress on these issues, and thetests fail later on but still don't pass. Let's disable READ_PLUS bydefault until we can work out what is going on.Signed-off-by: Anna Schumaker List of files: /linux-6.15/fs/nfs/Kconfig

3eb30c51 - Documentation: nfsroot.rst: Fix references to nfsroot.rst

Wed, 12 Feb 2020 18:13:32 +0000

Documentation: nfsroot.rst: Fix references to nfsroot.rstWhen converting and moving nfsroot.txt to nfsroot.rst the references tothe old text file was not updated to match the change, fix this.Fixes: f9a9349846f92b2d ("Documentation: nfsroot.txt: convert to ReST")Signed-off-by: Niklas Söderlund Reviewed-by: Geert Uytterhoeven Link: https://lore.kernel.org/r/20200212181332.520545-1-niklas.soderlund+renesas@ragnatech.seSigned-off-by: Jonathan Corbet List of files: /linux-6.15/fs/nfs/Kconfig

b24ee6c6 - NFS: allow deprecation of NFS UDP protocol

Mon, 16 Dec 2019 21:34:02 +0000

NFS: allow deprecation of NFS UDP protocolAdd a kernel config CONFIG_NFS_DISABLE_UDP_SUPPORT to disallow NFSUDP mounts and enable it by default.Signed-off-by: Olga Kornievskaia Signed-off-by: Anna Schumaker List of files: /linux-6.15/fs/nfs/Kconfig