Changes in Makefile

2b34879d - btrfs: selftests: add delayed ref self test cases

Thu, 14 Nov 2024 15:03:34 +0000

btrfs: selftests: add delayed ref self test casesThe recent fix for a stupid mistake I made uncovered the fact that wedon't have adequate testing in the delayed refs code, as it took apretty extensive and long running stress test to uncover something thata unit test would have uncovered right away.Fix this by adding a delayed refs self test suite. This will validatethat the btrfs_ref transformation does the correct thing, that we do thecorrect thing when merging delayed refs, and that we get the delayedrefs in the order that we expect. These are all crucial to how thedelayed refs operate.I introduced various bugs (including the original bug) into the delayedrefs code to validate that these tests caught all of the shenanigansthat I could think of.Reviewed-by: Boris Burkov Signed-off-by: Josef Bacik Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

506be4d5 - btrfs: tests: add selftests for raid-stripe-tree

Wed, 02 Oct 2024 10:11:48 +0000

btrfs: tests: add selftests for raid-stripe-treeAdd first stash of very basic self tests for the RAID stripe-tree.More test cases will follow exercising the tree.Reviewed-by: Filipe Manana Signed-off-by: Johannes Thumshirn Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

9aa29a20 - btrfs: move the direct IO code into its own file

Tue, 25 Jun 2024 14:52:28 +0000

btrfs: move the direct IO code into its own fileThe direct IO code is over a thousand lines and it's currently spreadbetween file.c and inode.c, which makes it not easy to locate some partsof it sometimes. Also inode.c is about 11 thousand lines and file.c about4 thousand lines, both too big. So move all the direct IO code into adedicated file, so that it's easy to locate all its code and reduce thesizes of inode.c and file.c.This is a pure move of code without any other changes except export aa couple functions from inode.c (get_extent_allocation_hint() andcreate_io_em()) because they are used in inode.c and the new direct-io.cfile, and a couple functions from file.c (btrfs_buffered_write() andbtrfs_write_check()) because they are used both in file.c and in the newdirect-io.c file.Reviewed-by: Boris Burkov Reviewed-by: Qu Wenruo Signed-off-by: Filipe Manana Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

8996f61a - btrfs: move fiemap code into its own file

Wed, 22 May 2024 14:29:05 +0000

btrfs: move fiemap code into its own fileCurrently the core of the fiemap code lives in extent_io.c, which doesnot make any sense because it's not related to extent IO at all (and itwas not as well before the big rewrite of fiemap I did some time ago).The entry point for fiemap, btrfs_fiemap(), lives in inode.c since it'san inode operation.Since there's a significant amount of fiemap code, move all of it into adedicated file, including its entry point inode.c:btrfs_fiemap().Reviewed-by: Johannes Thumshirn Signed-off-by: Filipe Manana Reviewed-by: David Sterba Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

02c372e1 - btrfs: add support for inserting raid stripe extents

Thu, 14 Sep 2023 16:06:58 +0000

btrfs: add support for inserting raid stripe extentsAdd support for inserting stripe extents into the raid stripe tree oncompletion of every write that needs an extra logical-to-physicaltranslation when using RAID.Inserting the stripe extents happens after the data I/O has completed,this is done to a) support zone-append and b) rule out the possibility of a RAID-write-hole.Signed-off-by: Johannes Thumshirn Reviewed-by: David Sterba Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

fb2a836d - btrfs: check-integrity: remove btrfsic_unmount() function

Fri, 08 Sep 2023 06:42:16 +0000

btrfs: check-integrity: remove btrfsic_unmount() functionThe function btrfsic_mount() is part of the deprecated check-integrityfunctionality.Now let's remove the main entry point of check-integrity, and thankfullymost of the check-integrity code is self-contained insidecheck-integrity.c, we can safely remove the function without hugechanges to btrfs code base.Signed-off-by: Qu Wenruo Reviewed-by: David Sterba Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

90b90d4a - btrfs: send: genericize the backref cache to allow it to be reused

Wed, 11 Jan 2023 11:36:13 +0000

btrfs: send: genericize the backref cache to allow it to be reusedThe backref cache is a cache backed by a maple tree and a linked list tokeep track of temporal access to cached entries (the LRU entry always atthe head of the list). This type of caching method is going to be usefulin other scenarios, so make the cache implementation more generic andmove it into its own header and source files.This patch is part of a larger patchset and the changelog of the lastpatch in the series contains a sample performance test and results.The patches that comprise the patchset are the following: btrfs: send: directly return from did_overwrite_ref() and simplify it btrfs: send: avoid unnecessary generation search at did_overwrite_ref() btrfs: send: directly return from will_overwrite_ref() and simplify it btrfs: send: avoid extra b+tree searches when checking reference overrides btrfs: send: remove send_progress argument from can_rmdir() btrfs: send: avoid duplicated orphan dir allocation and initialization btrfs: send: avoid unnecessary orphan dir rbtree search at can_rmdir() btrfs: send: reduce searches on parent root when checking if dir can be removed btrfs: send: iterate waiting dir move rbtree only once when processing refs btrfs: send: initialize all the red black trees earlier btrfs: send: genericize the backref cache to allow it to be reused btrfs: adapt lru cache to allow for 64 bits keys on 32 bits systems btrfs: send: cache information about created directories btrfs: allow a generation number to be associated with lru cache entries btrfs: add an api to delete a specific entry from the lru cache btrfs: send: use the lru cache to implement the name cache btrfs: send: update size of roots array for backref cache entries btrfs: send: cache utimes operations for directories if possibleSigned-off-by: Filipe Manana Reviewed-by: David Sterba Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

1ec49744 - btrfs: turn on -Wmaybe-uninitialized

Fri, 16 Dec 2022 20:15:58 +0000

btrfs: turn on -Wmaybe-uninitializedWe had a recent bug that would have been caught by a newer compiler with-Wmaybe-uninitialized and would have saved us a month of failing teststhat I didn't have time to investigate.Reviewed-by: Qu Wenruo Signed-off-by: Josef Bacik Reviewed-by: David Sterba Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

103c1972 - btrfs: split the bio submission path into a separate file

Tue, 15 Nov 2022 09:44:05 +0000

btrfs: split the bio submission path into a separate fileThe code used by btrfs_submit_bio only interacts with the rest ofvolumes.c through __btrfs_map_block (which itself is a more genericversion of two exported helpers) and does not really have anythingto do with volumes.c. Create a new bio.c file and a bio.h headergoing along with it for the btrfs_bio-based storage layer, whichwill grow even more going forward.Also update the file with my copyright notice given that a largepart of the moved code was written or rewritten by me.Reviewed-by: Josef Bacik Reviewed-by: Johannes Thumshirn Signed-off-by: Christoph Hellwig Reviewed-by: David Sterba Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

778dd695 - btrfs: rename tree-defrag.c to defrag.c

Wed, 26 Oct 2022 19:08:22 +0000

btrfs: rename tree-defrag.c to defrag.cThis currently has only one helper in it, and it's for tree baseddefrag. We have the various defrag code in 3 different places, sorename this to defrag.c. Followup patches will move the code into thisnew file.Reviewed-by: Johannes Thumshirn Signed-off-by: Josef Bacik Reviewed-by: David Sterba Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

083bd7e5 - btrfs: move the printk and assert helpers to messages.c

Wed, 26 Oct 2022 19:08:20 +0000

btrfs: move the printk and assert helpers to messages.cThese helpers are core to btrfs, and in order to more easily syncvarious parts of the btrfs kernel code into btrfs-progs we need to beable to carry these helpers with us. However we want to have our ownimplementation for the helpers themselves, currently they're implementedin different files that we want to sync inside of btrfs-progs itself.Move these into their own C file, this will allow us to contain ouroverrides in btrfs-progs in it's own file without messing with the restof the codebase.In copying things over I fixed up a few whitespace errors that alreadyexisted.Signed-off-by: Josef Bacik Reviewed-by: David Sterba Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

818fe33a - btrfs: rename struct-funcs.c to accessors.c

Wed, 19 Oct 2022 14:50:58 +0000

btrfs: rename struct-funcs.c to accessors.cRename struct-funcs.c to accessors.c so we can move the item accessorsout of ctree.h. accessors.c is a better description of the code that iscontained in these files.Reviewed-by: Johannes Thumshirn Reviewed-by: Anand Jain Signed-off-by: Josef Bacik Reviewed-by: David Sterba Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

c7f13d42 - btrfs: move fs wide helpers out of ctree.h

Wed, 19 Oct 2022 14:50:47 +0000

btrfs: move fs wide helpers out of ctree.hWe have several fs wide related helpers in ctree.h. The bulk of theseare the incompat flag test helpers, but there are things such asbtrfs_fs_closing() and the read only helpers that also aren't directlyrelated to the ctree code. Move these into a fs.h header, which willserve as the location for file system wide related helpers.Reviewed-by: Johannes Thumshirn Reviewed-by: Anand Jain Signed-off-by: Josef Bacik Reviewed-by: David Sterba Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

83cf709a - btrfs: move extent state init and alloc functions to their own file

Fri, 09 Sep 2022 21:53:21 +0000

btrfs: move extent state init and alloc functions to their own fileStart cleaning up extent_io.c by moving the extent state code out of it.This patch starts with the extent state allocation code and theextent_io_tree init code.Signed-off-by: Josef Bacik Reviewed-by: David Sterba Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

1344794a - Kbuild: add -Wno-shift-negative-value where -Wextra is used

Tue, 08 Mar 2022 21:56:12 +0000

Kbuild: add -Wno-shift-negative-value where -Wextra is usedAs a preparation for moving to -std=gnu11, turn off the-Wshift-negative-value option. This warning is enabled by gcc whenbuilding with -Wextra for c99 or higher, but not for c89. Sincethe kernel already relies on well-defined overflow behavior,the warning is not helpful and can simply be disabled inall locations that use -Wextra.Signed-off-by: Arnd Bergmann Acked-by: Jani Nikula Reviewed-by: Nathan Chancellor Tested-by: Sedat Dilek # LLVM/Clang v13.0.0 (x86-64)Signed-off-by: Masahiro Yamada List of files: /linux-6.15/fs/btrfs/Makefile

f26c9238 - btrfs: remove reada infrastructure

Tue, 14 Dec 2021 13:01:45 +0000

btrfs: remove reada infrastructureCurrently there is only one user for btrfs metadata readahead, andthat's scrub.But even for the single user, it's not providing the correctfunctionality it needs, as scrub needs reada for commit root, whichcurrent readahead can't provide. (Although it's pretty easy to add suchfeature).Despite this, there are some extra problems related to metadatareadahead:- Duplicated feature with btrfs_path::reada- Partly duplicated feature of btrfs_fs_info::buffer_radix Btrfs already caches its metadata in buffer_radix, while readahead tries to read the tree block no matter if it's already cached.- Poor layer separation Metadata readahead works kinda at device level. This is definitely not the correct layer it should be, since metadata is at btrfs logical address space, it should not bother device at all. This brings extra chance for bugs to sneak in, while brings unnecessary complexity.- Dead code In the very beginning of scrub.c we have #undef DEBUG, rendering all the debug related code useless and unable to test.Thus here I purpose to remove the metadata readahead mechanismcompletely.[BENCHMARK]There is a full benchmark for the scrub performance difference using theold btrfs_reada_add() and btrfs_path::reada.For the worst case (no dirty metadata, slow HDD), there could be a 5%performance drop for scrub.For other cases (even SATA SSD), there is no distinguishable performancedifference.The number is reported scrub speed, in MiB/s.The resolution is limited by the reported duration, which only has aresolution of 1 second. Old New DiffSSD 455.3 466.332 +2.42%HDD 103.927 98.012 -5.69%Comprehensive test methodology is in the cover letter of the patch.Signed-off-by: Qu Wenruo Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

14605409 - btrfs: initial fsverity support

Wed, 30 Jun 2021 20:01:49 +0000

btrfs: initial fsverity supportAdd support for fsverity in btrfs. To support the generic interface infs/verity, we add two new item types in the fs tree for inodes withverity enabled. One stores the per-file verity descriptor and btrfsverity item and the other stores the Merkle tree data itself.Verity checking is done in end_page_read just before a page is markeduptodate. This naturally handles a variety of edge cases like holes,preallocated extents, and inline extents. Some care needs to be taken tonot try to verity pages past the end of the file, which are accessed bythe generic buffered file reading code under some circumstances likereading to the end of the last page and trying to read again. Direct IOon a verity file falls back to buffered reads.Verity relies on PageChecked for the Merkle tree data itself to avoidre-walking up shared paths in the tree. For this reason, we need tocache the Merkle tree data. Since the file is immutable after verity isturned on, we can cache it at an index past EOF.Use the new inode ro_flags to store verity on the inode item, so that wecan enable verity on a file, then rollback to an older kernel and stillmount the file system and read the file. Since we can't safely write thefile anymore without ruining the invariants of the Merkle tree, we marka ro_compat flag on the file system when a file has verity enabled.Acked-by: Eric Biggers Co-developed-by: Chris Mason Signed-off-by: Chris Mason Signed-off-by: Boris Burkov Reviewed-by: David Sterba Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

f3a84ccd - btrfs: move the tree mod log code into its own file

Thu, 11 Mar 2021 14:31:07 +0000

btrfs: move the tree mod log code into its own fileThe tree modification log, which records modifications done to btrees, isquite large and currently spread all over ctree.c, which is a huge filealready.To make things better organized, move all that code into its own separatesource and header files. Functions and definitions that are used outsideof the module (mostly by ctree.c) are renamed so that they start with a"btrfs_" prefix. Everything else remains unchanged.This makes it easier to go over the tree modification log code everytime I need to go read it to fix a bug.Reviewed-by: Anand Jain Signed-off-by: Filipe Manana Reviewed-by: David Sterba [ minor comment updates ]Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

ebd99a6b - btrfs: fix build when using M=fs/btrfs

Wed, 17 Mar 2021 10:43:13 +0000

btrfs: fix build when using M=fs/btrfsThere are people building the module with M= that's supposed to be usedfor external modules. This got broken in e9aa7c285d20 ("btrfs: enableW=1 checks for btrfs"). $ make M=fs/btrfs scripts/Makefile.lib:10: *** Recursive variable 'KBUILD_CFLAGS' references itself (eventually). Stop. make: *** [Makefile:1755: modules] Error 2There's a difference compared to 'make fs/btrfs/btrfs.ko' which needsto rebuild a few more things and also the dependency modules need to beavailable. It could fail with eg. WARNING: Symbol version dump "Module.symvers" is missing. Modules may not have dependencies or modversions.In some environments it's more convenient to rebuild just the btrfsmodule by M= so let's make it work.The problem is with recursive variable evaluation in += so theconditional C options are stored in a temporary variable to avoid therecursion.Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile

cac06d84 - btrfs: introduce the skeleton of btrfs_subpage structure

Tue, 26 Jan 2021 08:33:47 +0000

btrfs: introduce the skeleton of btrfs_subpage structureFor sectorsize < page size support, we need a structure to record extrastatus info for each sector of a page.Introduce the skeleton structure, all subpage related code would go tosubpage.[ch].Reviewed-by: Josef Bacik Signed-off-by: Qu Wenruo Reviewed-by: David Sterba Signed-off-by: David Sterba List of files: /linux-6.15/fs/btrfs/Makefile