Changes in init301.c

688cf598 - fbdev: sisfb: hide unused variables

Wed, 03 Apr 2024 08:06:31 +0000

fbdev: sisfb: hide unused variablesBuilding with W=1 shows that a couple of variables in this driver are onlyused in certain configurations:drivers/video/fbdev/sis/init301.c:239:28: error: 'SiS_Part2CLVX_6' defined but not used [-Werror=unused-const-variable=] 239 | static const unsigned char SiS_Part2CLVX_6[] = { /* 1080i */ | ^~~~~~~~~~~~~~~drivers/video/fbdev/sis/init301.c:230:28: error: 'SiS_Part2CLVX_5' defined but not used [-Werror=unused-const-variable=] 230 | static const unsigned char SiS_Part2CLVX_5[] = { /* 750p */ | ^~~~~~~~~~~~~~~drivers/video/fbdev/sis/init301.c:211:28: error: 'SiS_Part2CLVX_4' defined but not used [-Werror=unused-const-variable=] 211 | static const unsigned char SiS_Part2CLVX_4[] = { /* PAL */ | ^~~~~~~~~~~~~~~drivers/video/fbdev/sis/init301.c:192:28: error: 'SiS_Part2CLVX_3' defined but not used [-Werror=unused-const-variable=] 192 | static const unsigned char SiS_Part2CLVX_3[] = { /* NTSC, 525i, 525p */ | ^~~~~~~~~~~~~~~drivers/video/fbdev/sis/init301.c:184:28: error: 'SiS_Part2CLVX_2' defined but not used [-Werror=unused-const-variable=] 184 | static const unsigned char SiS_Part2CLVX_2[] = { | ^~~~~~~~~~~~~~~drivers/video/fbdev/sis/init301.c:176:28: error: 'SiS_Part2CLVX_1' defined but not used [-Werror=unused-const-variable=] 176 | static const unsigned char SiS_Part2CLVX_1[] = { | ^~~~~~~~~~~~~~~This started showing up after the definitions were moved into thesource file from the header, which was not flagged by the compiler.Move the definition into the appropriate #ifdef block that alreadyexists next to them.Fixes: 5908986ef348 ("video: fbdev: sis: avoid mismatched prototypes")Signed-off-by: Arnd Bergmann Signed-off-by: Helge Deller List of files: /linux-6.15/drivers/video/fbdev/sis/init301.c

864eb1af - video: fbdev: sis: Remove unnecessary parentheses and commented code

Mon, 08 Oct 2018 10:57:36 +0000

video: fbdev: sis: Remove unnecessary parentheses and commented codeClang warns when multiple pairs of parentheses are used for a singleconditional statement.drivers/video/fbdev/sis/init301.c:851:42: warning: equality comparisonwith extraneous parentheses [-Wparentheses-equality] } else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* || ~~~~~~~~~~~~~~~~~~~~~~~~^~~~drivers/video/fbdev/sis/init301.c:851:42: note: remove extraneousparentheses around the comparison to silence this warning } else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* || ~ ^ ~drivers/video/fbdev/sis/init301.c:851:42: note: use '=' to turn thisequality comparison into an assignment } else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* || ^~ =1 warning generated.Remove the parentheses and while we're at it, clean up the commentedcode, which has been here since the beginning of git history.Link: https://github.com/ClangBuiltLinux/linux/issues/118Signed-off-by: Nathan Chancellor Cc: Thomas Winischhofer Signed-off-by: Bartlomiej Zolnierkiewicz List of files: /linux-6.15/drivers/video/fbdev/sis/init301.c

5908986e - video: fbdev: sis: avoid mismatched prototypes

Mon, 12 Mar 2018 16:06:52 +0000

video: fbdev: sis: avoid mismatched prototypesBuilding with LTO enabled reveals some functions whose prototypesin the header are different from the definition:drivers/video/fbdev/sis/sis_main.h:765:0: error: type of 'SiS_SetCH70xxANDOR' does not match original declaration [-Werror=lto-type-mismatch] extern void SiS_SetCH70xxANDOR(struct SiS_Private *SiS_Pr, unsigned short reg,drivers/video/fbdev/sis/init301.c:8937:0: note: type mismatch in parameter 4 SiS_SetCH70xxANDOR(struct SiS_Private *SiS_Pr, unsigned short reg,drivers/video/fbdev/sis/init301.c:8937:0: note: type 'short unsigned int' should match type 'unsigned char'drivers/video/fbdev/sis/init301.c:8937:0: note: 'SiS_SetCH70xxANDOR' was previously declared hereThe root cause appears to be the way that header files are used in thisdriver, where they contain both static variable and declarations forsymbols in other files.To clean that up, I'm changing all mixed headers to only containdeclarations the way we normally do in C, or contain only staticvariables, and move the rest to a more appropriate place. Once thatis done, the headers can be included in the other files as well, andguarantee that the prototypes match.There are a few headers that now only contain static variables, andI'm leaving those alone here as the patch is already too big. Thesecould be trivially moved into the respective .c files.Signed-off-by: Arnd Bergmann Cc: Thomas Winischhofer Cc: Nicolas Pitre Cc: Andi Kleen Cc: "Gustavo A. R. Silva" ,Signed-off-by: Bartlomiej Zolnierkiewicz List of files: /linux-6.15/drivers/video/fbdev/sis/init301.c

b90b3eca - video: fbdev: sis: make const array specialtv static, reduces object code size

Thu, 12 Oct 2017 16:18:23 +0000

video: fbdev: sis: make const array specialtv static, reduces object code sizeDon't populate the const array specialtv on the stack, instead make itstatic. Makes the object code smaller by over 1100 bytes:Before: text data bss dec hex filename 179899 7504 0 187403 2dc0b drivers/video/fbdev/sis/init301.oAfter: text data bss dec hex filename 178720 7568 0 186288 2d7b0 drivers/video/fbdev/sis/init301.o(gcc version 7.2.0, x86_64)Signed-off-by: Colin Ian King Cc: Thomas Winischhofer Signed-off-by: Bartlomiej Zolnierkiewicz List of files: /linux-6.15/drivers/video/fbdev/sis/init301.c

d3e329b3 - video: fbdev: sis: fix duplicated code for different branches

Mon, 04 Sep 2017 14:00:50 +0000

video: fbdev: sis: fix duplicated code for different branchesRefactor code in order to avoid identical code for different branches.This issue was detected with the help of Coccinelle.Addresses-Coverity-ID: 1226761Signed-off-by: Gustavo A. R. Silva Cc: Thomas Winischhofer Signed-off-by: Bartlomiej Zolnierkiewicz List of files: /linux-6.15/drivers/video/fbdev/sis/init301.c

32ad6195 - video: fbdev: sis: remove unused variable

Mon, 29 Feb 2016 18:02:29 +0000

video: fbdev: sis: remove unused variableThe variables modeflag and resinfo were only assigned some value butwere never used.Signed-off-by: Sudip Mukherjee Signed-off-by: Tomi Valkeinen List of files: /linux-6.15/drivers/video/fbdev/sis/init301.c

a9a3cac6 - video: fbdev: sis: delete double assignment

Sat, 23 Aug 2014 18:33:27 +0000

video: fbdev: sis: delete double assignmentDelete successive assignments to the same location. The second assignmentis changed to update a different field, as done in other nearby code.A simplified version of the semantic match that finds this problem is asfollows: (http://coccinelle.lip6.fr/)// @@expression i;@@*i = ...; i = ...;// Signed-off-by: Julia Lawall Signed-off-by: Tomi Valkeinen List of files: /linux-6.15/drivers/video/fbdev/sis/init301.c

f7018c21 - video: move fbdev to drivers/video/fbdev

Thu, 13 Feb 2014 13:31:38 +0000

video: move fbdev to drivers/video/fbdevThe drivers/video directory is a mess. It contains generic video relatedfiles, directories for backlight, console, linux logo, lots of fbdevdevice drivers, fbdev framework files.Make some order into the chaos by creating drivers/video/fbdevdirectory, and move all fbdev related files there.No functionality is changed, although I guess it is possible that somesubtle Makefile build order related issue could be created by thispatch.Signed-off-by: Tomi Valkeinen Acked-by: Laurent Pinchart Acked-by: Geert Uytterhoeven Acked-by: Rob Clark Acked-by: Jingoo Han Acked-by: Daniel Vetter List of files: /linux-6.15/drivers/video/fbdev/sis/init301.c