Changes in s3c-fb.c

01ecc142 - fbdev: Switch back to struct platform_driver::remove()

Mon, 07 Oct 2024 16:35:17 +0000

fbdev: Switch back to struct platform_driver::remove()After commit 0edb555a65d1 ("platform: Make platform_driver::remove()return void") .remove() is (again) the right callback to implement forplatform drivers.Convert all platform drivers below drivers/video/fbdev to use .remove(),with the eventual goal to drop struct platform_driver::remove_new(). As.remove() and .remove_new() have the same prototypes, conversion is doneby just changing the structure member name in the driver initializer.While touching these files, make indention of the struct initializerconsistent in several files.Signed-off-by: Uwe Kleine-König Reviewed-by: Thomas Zimmermann Signed-off-by: Helge Deller List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

588a25e0 - fbdev/s3cfb: Use fbdev I/O helpers

Thu, 03 Aug 2023 18:36:02 +0000

fbdev/s3cfb: Use fbdev I/O helpersSet struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializerfor I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.The macro and token set the currently selected values, so there isno functional change.v3: * use _IOMEM_ in commit messagev2: * updated to use _IOMEM_ tokensSigned-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg Acked-by: Helge Deller Cc: Jingoo Han Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-38-tzimmermann@suse.de List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

8a4675eb - fbdev: Remove FBINFO_FLAG_DEFAULT from framebuffer_alloc()'ed structs

Sat, 15 Jul 2023 18:51:56 +0000

fbdev: Remove FBINFO_FLAG_DEFAULT from framebuffer_alloc()'ed structsThe flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as structfbinfo.flags has been allocated to zero by framebuffer_alloc(). Sodo not set it.Flags should signal differences from the default values. After cleaningup all occurrences of FBINFO_DEFAULT, the token will be removed.v4: * clarify commit message (Geert, Dan)v2: * fix commit message (Miguel)Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Jaya Kumar Cc: Helge Deller Cc: Peter Jones Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Shawn Guo Cc: Fabio Estevam Cc: NXP Linux Team Cc: Maik Broemme Cc: Jingoo Han Cc: Sudip Mukherjee Cc: Teddy Wang Cc: Michal Januszewski Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-15-tzimmermann@suse.de List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

f2f34fb9 - fbdev: s3c-fb: Convert to platform remove callback returning void

Sat, 18 Mar 2023 23:54:14 +0000

fbdev: s3c-fb: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is (mostly) ignoredand this typically results in resource leaks. To improve here there is aquest to make the remove callback return void. In the first step of thisquest all drivers are converted to .remove_new() which already returnsvoid.Trivially convert this driver from always returning zero in the removecallback to the void returning variant.Signed-off-by: Uwe Kleine-König Signed-off-by: Helge Deller List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

961e366c - video: fbdev: s3c-fb: fix platform_get_irq.cocci warning

Wed, 02 Mar 2022 03:44:08 +0000

video: fbdev: s3c-fb: fix platform_get_irq.cocci warningRemove dev_err() messages after platform_get_irq*() failures.platform_get_irq() already prints an error.Generated by: scripts/coccinelle/api/platform_get_irq.cocciSigned-off-by: Yihao Han Signed-off-by: Helge Deller List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

4f37ea5d - video: fbdev: s3c-fb: Use platform_get_irq() to get the interrupt

Fri, 11 Feb 2022 03:27:55 +0000

video: fbdev: s3c-fb: Use platform_get_irq() to get the interruptplatform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on staticallocation of IRQ resources in DT core code, this causes an issuewhen using hierarchical interrupt domains using "interrupts" propertyin the node as this bypassed the hierarchical setup and messed up theirq chaining.In preparation for removal of static setup of IRQ resource from DT corecode use platform_get_irq().Signed-off-by: zhaoxiao Signed-off-by: Helge Deller List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

b1d8c84a - video: fbdev: s3c-fb: Make use of the helper function dev_err_probe()

Fri, 17 Sep 2021 04:22:11 +0000

video: fbdev: s3c-fb: Make use of the helper function dev_err_probe()When possible use dev_err_probe help to properly deal with thePROBE_DEFER error, the benefit is that DEFER issue will be loggedin the devices_deferred debugfs file.Using dev_err_probe() can reduce code size, and the error valuegets printed.Signed-off-by: Cai Huoqing Signed-off-by: Helge Deller List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

3bfa3f1b - video: fbdev: s3c-fb: drop unneeded MODULE_ALIAS

Thu, 16 Sep 2021 17:04:59 +0000

video: fbdev: s3c-fb: drop unneeded MODULE_ALIASThe MODULE_DEVICE_TABLE already creates proper alias for platformdriver. Having another MODULE_ALIAS causes the alias to be duplicated.Signed-off-by: Krzysztof Kozlowski Signed-off-by: Helge Deller List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

61cc4816 - video: fbdev: s3c-fb: remove redundant initialization of pointer bufs

Thu, 30 Dec 2021 16:06:26 +0000

video: fbdev: s3c-fb: remove redundant initialization of pointer bufsPointer bufs is being initialized with a value that is never read, itis being re-assigned with a different value later on. The assignmentis redundant and can be removed. Cleans up clang-scan warning:drivers/video/fbdev/s3c-fb.c:492:16: warning: Value stored to 'buf'during its initialization is never read [deadcode.DeadStores] void __iomem *buf = regs;Signed-off-by: Colin Ian King Signed-off-by: Daniel Vetter Link: https://patchwork.freedesktop.org/patch/msgid/20211230160626.404072-1-colin.i.king@gmail.com List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

ab2b29e6 - video: fbdev: s3c-fb: Fix kernel-doc and set but not used warnings

Sat, 28 Nov 2020 22:41:10 +0000

video: fbdev: s3c-fb: Fix kernel-doc and set but not used warningsFix several W=1 warnings- Updated kernel-doc as needed- Deleted unused local variable, it was assigned but never usedv2: - Updated subject (Lee)Signed-off-by: Sam Ravnborg Acked-by: Thomas Zimmermann Cc: Jingoo Han Cc: linux-fbdev@vger.kernel.orgCc: Lee Jones Link: https://patchwork.freedesktop.org/patch/msgid/20201128224114.1033617-25-sam@ravnborg.org List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

ad04fae0 - fbdev: Use fallthrough pseudo-keyword

Tue, 07 Jul 2020 21:05:39 +0000

fbdev: Use fallthrough pseudo-keywordReplace the existing /* fall through */ comments and its variants withthe new pseudo-keyword macro fallthrough[1]. Also, remove unnecessaryfall-through markings when it is the case.[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-throughSigned-off-by: Gustavo A. R. Silva Signed-off-by: Sam Ravnborg Link: https://patchwork.freedesktop.org/patch/msgid/20200707210539.GA12530@embeddedor List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

df561f66 - treewide: Use fallthrough pseudo-keyword

Sun, 23 Aug 2020 22:36:59 +0000

treewide: Use fallthrough pseudo-keywordReplace the existing /* fall through */ comments and its variants withthe new pseudo-keyword macro fallthrough[1]. Also, remove unnecessaryfall-through markings when it is the case.[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-throughSigned-off-by: Gustavo A. R. Silva List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

8d5598f1 - fbdev: s3c-fb: use devm_platform_ioremap_resource() to simplify code

Wed, 04 Sep 2019 11:55:23 +0000

fbdev: s3c-fb: use devm_platform_ioremap_resource() to simplify codeUse devm_platform_ioremap_resource() to simplify the code a bit.This is detected by coccinelle.Reported-by: Hulk Robot Signed-off-by: YueHaibing Acked-by: Jingoo Han Signed-off-by: Bartlomiej Zolnierkiewicz Link: https://patchwork.freedesktop.org/patch/msgid/20190904115523.25068-1-yuehaibing@huawei.com List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

8a48ac33 - video: constify fb ops across all drivers

Tue, 03 Dec 2019 16:38:50 +0000

video: constify fb ops across all driversNow that the fbops member of struct fb_info is const, we can startmaking the ops const as well.This does not cover all drivers; some actually modify the fbops struct,for example to adjust for different configurations, and others do moreinvolved things that I'd rather not touch in practically obsoletedrivers. Mostly this is the low hanging fruit where we can add "const"and be done with it.v3:- un-constify atyfb, mb862xx, nvidia and uvesabf (0day)v2:- fix typo (Christophe de Dinechin)- use "static const" instead of "const static" in mx3fb.c- also constify smscufx.cCc: linux-fbdev@vger.kernel.orgReviewed-by: Daniel Vetter Signed-off-by: Jani Nikula Link: https://patchwork.freedesktop.org/patch/msgid/ce67f14435f3af498f2e8bf35ce4be11f7504132.1575390740.git.jani.nikula@intel.com List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

6eaa79ff - video: fbdev: s3c-fb: Mark expected switch fall-throughs

Fri, 05 Jul 2019 15:42:13 +0000

video: fbdev: s3c-fb: Mark expected switch fall-throughsIn preparation to enabling -Wimplicit-fallthrough, mark switchcases where we are expecting to fall through.This patch fixes the following warnings:drivers/video/fbdev/s3c-fb.c: In function ‘s3c_fb_blank’:drivers/video/fbdev/s3c-fb.c:811:16: warning: this statement may fall through [-Wimplicit-fallthrough=] sfb->enabled &= ~(1 << index); ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~drivers/video/fbdev/s3c-fb.c:814:2: note: here case FB_BLANK_NORMAL: ^~~~ LD [M] drivers/staging/greybus/gb-light.o CC [M] drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gp10b.odrivers/video/fbdev/s3c-fb.c: In function ‘s3c_fb_check_var’:drivers/video/fbdev/s3c-fb.c:286:22: warning: this statement may fall through [-Wimplicit-fallthrough=] var->transp.length = 1; ~~~~~~~~~~~~~~~~~~~^~~drivers/video/fbdev/s3c-fb.c:288:2: note: here case 18: ^~~~drivers/video/fbdev/s3c-fb.c:314:22: warning: this statement may fall through [-Wimplicit-fallthrough=] var->transp.offset = 24; ~~~~~~~~~~~~~~~~~~~^~~~drivers/video/fbdev/s3c-fb.c:316:2: note: here case 24: ^~~~Warning level 3 was used: -Wimplicit-fallthrough=3Notice that, in this particular case, the code comments are modifiedin accordance with what GCC is expecting to find.This patch is part of the ongoing efforts to enable-Wimplicit-fallthrough.Signed-off-by: Gustavo A. R. Silva Cc: Jingoo Han Cc: Kees Cook Signed-off-by: Bartlomiej Zolnierkiewicz List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

796e2f41 - video: fbdev: s3c-fb: fix sparse warnings about using incorrect types

Fri, 28 Jun 2019 10:36:22 +0000

video: fbdev: s3c-fb: fix sparse warnings about using incorrect typesUse ->screen_buffer instead of ->screen_base to fix sparse warnings.[ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base pointer") for details. ]Reported-by: kbuild test robot Acked-by: Jingoo Han Signed-off-by: Bartlomiej Zolnierkiewicz List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

0adcdbcb - video: fbdev: don't print error message on framebuffer_alloc() failure

Fri, 28 Jun 2019 10:30:08 +0000

video: fbdev: don't print error message on framebuffer_alloc() failureframebuffer_alloc() can fail only on kzalloc() memory allocationfailure and since kzalloc() will print error message in such casewe can omit printing extra error message in drivers (which BTW iswhat the majority of framebuffer_alloc() users is doing already).Cc: "Bruno Prémont" Cc: Jiri Kosina Cc: Benjamin Tissoires Signed-off-by: Bartlomiej Zolnierkiewicz List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

602ecfbc - video: fbdev: s3c-fb: return -ENOMEM on framebuffer_alloc() failure

Fri, 28 Jun 2019 10:30:05 +0000

video: fbdev: s3c-fb: return -ENOMEM on framebuffer_alloc() failureFix error code from -ENOENT to -ENOMEM.Acked-by: Jingoo Han Signed-off-by: Bartlomiej Zolnierkiewicz List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

d2912cb1 - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500

Tue, 04 Jun 2019 08:11:33 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500Based on 2 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation #extracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 4122 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Enrico Weigelt Reviewed-by: Kate Stewart Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c

7c9b845e - video: fbdev: s3c-fb: remove dead platform code for Exynos and S5PV210 platforms

Wed, 28 Mar 2018 14:34:29 +0000

video: fbdev: s3c-fb: remove dead platform code for Exynos and S5PV210 platformsExynos5, Exynos4 and S5PV210 platforms have been converted touse Device Tree and Exynos DRM driver long time ago. Removedead platform code for these platforms and update Kconfigs3c-fb entry accordingly.Acked-by: Jingoo Han Signed-off-by: Bartlomiej Zolnierkiewicz List of files: /linux-6.15/drivers/video/fbdev/s3c-fb.c