Changes in cirrusfb.c

0296ddfe - fbdev/cirrusfb: Initialize fb_ops to fbdev I/O-memory helpers

Wed, 27 Sep 2023 07:26:42 +0000

fbdev/cirrusfb: Initialize fb_ops to fbdev I/O-memory helpersInitialize the instance of struct fb_ops with fbdev initializermacros for framebuffers in I/O address space. Set the read/write,draw and mmap callbacks to the correct implementation and avoidimplicit defaults. Also select the necessary I/O helpers in Kconfig.Fbdev drivers sometimes rely on the callbacks being NULL for adefault implementation to be invoked; hence requiring the I/Ohelpers to be built in any case. Setting all callbacks in alldrivers explicitly will allow to make the I/O helpers optional.This benefits systems that do not use these functions.No functional changes.Signed-off-by: Thomas Zimmermann Acked-by: Javier Martinez Canillas Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-10-tzimmermann@suse.de List of files: /linux-6.15/drivers/video/fbdev/cirrusfb.c

b3e148d7 - fbdev: Remove FBINFO_DEFAULT from framebuffer_alloc()'ed structs

Sat, 15 Jul 2023 18:51:47 +0000

fbdev: Remove FBINFO_DEFAULT from framebuffer_alloc()'ed structsThe flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flagshas been allocated to zero by framebuffer_alloc(). So do not set it.Flags should signal differences from the default values. After cleaningup all occurrences of FBINFO_DEFAULT, the token will be removed.v4: * clarify commit message (Geert, Dan)v2: * fix commit message (Miguel)Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Helge Deller Cc: Nicolas Ferre Cc: Benjamin Herrenschmidt Cc: Ferenc Bakonyi Cc: "K. Y. Srinivasan" Cc: Haiyang Zhang Cc: Wei Liu Cc: Dexuan Cui Cc: Antonino Daplas Cc: Maik Broemme Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: Kristoffer Ericson Cc: Hans de Goede Cc: Steve Glendinning Cc: Bernie Thompson Cc: Florian Tobias Schandinat Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-6-tzimmermann@suse.de List of files: /linux-6.15/drivers/video/fbdev/cirrusfb.c

0ba2fa8c - fbdev: Add support for the nomodeset kernel parameter

Fri, 11 Nov 2022 13:30:24 +0000

fbdev: Add support for the nomodeset kernel parameterSupport the kernel's nomodeset parameter for all PCI-based fbdevdrivers that use aperture helpers to remove other, hardware-agnosticgraphics drivers.The parameter is a simple way of using the firmware-provided scanoutbuffer if the hardware's native driver is broken. The same effectcould be achieved with per-driver options, but the importance of thegraphics output for many users makes a single, unified approachworthwhile.With nomodeset specified, the fbdev driver module will not load. Thisunifies behavior with similar DRM drivers. In DRM helpers, modulesfirst check the nomodeset parameter before registering the PCIdriver. As fbdev has no such module helpers, we have to modify eachdriver individually.The name 'nomodeset' is slightly misleading, but has been chosen forhistorical reasons. Several drivers implemented it before it became ageneral option for DRM. So keeping the existing name was preferred overintroducing a new one.v2: * print a warning if a driver does not init (Helge) * wrap video_firmware_drivers_only() in helperSigned-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Link: https://patchwork.freedesktop.org/patch/msgid/20221111133024.9897-3-tzimmermann@suse.de List of files: /linux-6.15/drivers/video/fbdev/cirrusfb.c

8d026858 - fbdev: Move fbdev drivers from strlcpy to strscpy

Thu, 18 Aug 2022 21:01:17 +0000

fbdev: Move fbdev drivers from strlcpy to strscpyFollow the advice of the below link and prefer 'strscpy' in thissubsystem. Conversion is 1:1 because the return value is not used.Generated by a coccinelle script.Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/Signed-off-by: Wolfram Sang Signed-off-by: Helge Deller List of files: /linux-6.15/drivers/video/fbdev/cirrusfb.c

145eed48 - fbdev: Remove conflicting devices on PCI bus

Mon, 18 Jul 2022 07:23:17 +0000

fbdev: Remove conflicting devices on PCI busRemove firmware devices on the PCI bus, by callingaperture_remove_conflicting_pci_devices() in the probe function ofeach related fbdev driver. iSo far, most of these drivers did notremove conflicting VESA or EFI devices, or outride failed forresource conflicts (i.e., matroxfb.) This must have been brokenfor quite some time.Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Link: https://patchwork.freedesktop.org/patch/msgid/20220718072322.8927-7-tzimmermann@suse.de List of files: /linux-6.15/drivers/video/fbdev/cirrusfb.c

f45566fb - video: fbdev: cirrusfb: Make cirrusfb_zorro_unregister() static

Mon, 11 Jul 2022 15:39:30 +0000

video: fbdev: cirrusfb: Make cirrusfb_zorro_unregister() staticcirrusfb_zorro_unregister() is only used locally, hence make it static.Signed-off-by: Geert Uytterhoeven Signed-off-by: Helge Deller List of files: /linux-6.15/drivers/video/fbdev/cirrusfb.c

e146a096 - video: fbdev: cirrusfb: Remove useless reference to PCI power management

Tue, 07 Jun 2022 23:11:11 +0000

video: fbdev: cirrusfb: Remove useless reference to PCI power managementPCI-specific power management (pci_driver.suspend and pci_driver.resume) isdeprecated. The cirrusfb driver has never implemented power management atall, but if it ever does, it should use the generic power managementframework, not the PCI-specific hooks.Remove the commented-out references to the PCI-specific power managementhooks.Signed-off-by: Bjorn Helgaas Acked-by: Daniel Vetter Signed-off-by: Helge Deller List of files: /linux-6.15/drivers/video/fbdev/cirrusfb.c

5c6f402b - video: fbdev: cirrusfb: check pixclock to avoid divide by zero

Wed, 27 Oct 2021 20:30:13 +0000

video: fbdev: cirrusfb: check pixclock to avoid divide by zeroDo a sanity check on pixclock value to avoid divide by zero.If the pixclock value is zero, the cirrusfb driver will round uppixclock to get the derived frequency as close to maxclock aspossible.Syzkaller reported a divide error in cirrusfb_check_pixclock.divide error: 0000 [#1] SMP KASAN PTICPU: 0 PID: 14938 Comm: cirrusfb_test Not tainted 5.15.0-rc6 #1Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.11.0-2RIP: 0010:cirrusfb_check_var+0x6f1/0x1260Call Trace: fb_set_var+0x398/0xf90 do_fb_ioctl+0x4b8/0x6f0 fb_ioctl+0xeb/0x130 __x64_sys_ioctl+0x19d/0x220 do_syscall_64+0x3a/0x80 entry_SYSCALL_64_after_hwframe+0x44/0xaeSigned-off-by: George Kennedy Reviewed-by: Geert Uytterhoeven Signed-off-by: Helge Deller List of files: /linux-6.15/drivers/video/fbdev/cirrusfb.c

630a159a - video: fbdev: cirrusfb: Fix kernel-doc and set but not used warnings

Sat, 28 Nov 2020 22:41:13 +0000

video: fbdev: cirrusfb: Fix kernel-doc and set but not used warningsFix warnings:- drop kernel-doc for the two debug functions to avoid the warnings- delete unused codev2: - Updated subject (Lee)Signed-off-by: Sam Ravnborg Acked-by: Thomas Zimmermann Cc: Thomas Zimemrmann Cc: Sam Ravnborg Cc: "Gustavo A. R. Silva" Cc: Daniel Vetter Cc: Saeed Mirzamohammadi Cc: Jani Nikula Cc: Mike Rapoport Cc: Lee Jones Link: https://patchwork.freedesktop.org/patch/msgid/20201128224114.1033617-28-sam@ravnborg.org List of files: /linux-6.15/drivers/video/fbdev/cirrusfb.c

cc07057c - video: fbdev: fix divide error in fbcon_switch

Wed, 21 Oct 2020 23:57:58 +0000

video: fbdev: fix divide error in fbcon_switchThis patch fixes the issue due to:[ 89.572883] divide_error: 0000 [#1] SMP KASAN PTI[ 89.572897] CPU: 3 PID: 16083 Comm: repro Not tainted 5.9.0-rc7.20200930.rc1.allarch-19-g3e32d0d.syzk #5[ 89.572902] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.5.1 01/01/2011[ 89.572934] RIP: 0010:cirrusfb_check_var+0x84/0x1260The error happens when the pixels value is calculated before performing the sanity checks on bits_per_pixel.A bits_per_pixel set to zero causes divide by zero error.This patch moves the calculation after the sanity check.Signed-off-by: Saeed Mirzamohammadi Tested-by: Saeed Mirzamohammadi Reviewed-by: Thomas Zimemrmann Signed-off-by: Thomas Zimmermann Link: https://patchwork.freedesktop.org/patch/msgid/20201021235758.59993-1-saeed.mirzamohammadi@oracle.com List of files: /linux-6.15/drivers/video/fbdev/cirrusfb.c

ad04fae0 - fbdev: Use fallthrough pseudo-keyword

Tue, 07 Jul 2020 21:05:39 +0000

fbdev: Use fallthrough pseudo-keywordReplace the existing /* fall through */ comments and its variants withthe new pseudo-keyword macro fallthrough[1]. Also, remove unnecessaryfall-through markings when it is the case.[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-throughSigned-off-by: Gustavo A. R. Silva Signed-off-by: Sam Ravnborg Link: https://patchwork.freedesktop.org/patch/msgid/20200707210539.GA12530@embeddedor List of files: /linux-6.15/drivers/video/fbdev/cirrusfb.c

df561f66 - treewide: Use fallthrough pseudo-keyword

Sun, 23 Aug 2020 22:36:59 +0000

treewide: Use fallthrough pseudo-keywordReplace the existing /* fall through */ comments and its variants withthe new pseudo-keyword macro fallthrough[1]. Also, remove unnecessaryfall-through markings when it is the case.[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-throughSigned-off-by: Gustavo A. R. Silva List of files: /linux-6.15/drivers/video/fbdev/cirrusfb.c

e31cf2f4 - mm: don't include asm/pgtable.h if linux/mm.h is already included

Tue, 09 Jun 2020 04:32:33 +0000

mm: don't include asm/pgtable.h if linux/mm.h is already includedPatch series "mm: consolidate definitions of page table accessors", v2.The low level page table accessors (pXY_index(), pXY_offset()) areduplicated across all architectures and sometimes more than once. Forinstance, we have 31 definition of pgd_offset() for 25 supportedarchitectures.Most of these definitions are actually identical and typically it boilsdown to, e.g.static inline unsigned long pmd_index(unsigned long address){ return (address >> PMD_SHIFT) & (PTRS_PER_PMD - 1);}static inline pmd_t *pmd_offset(pud_t *pud, unsigned long address){ return (pmd_t *)pud_page_vaddr(*pud) + pmd_index(address);}These definitions can be shared among 90% of the arches providedXYZ_SHIFT, PTRS_PER_XYZ and xyz_page_vaddr() are defined.For architectures that really need a custom version there is alwayspossibility to override the generic version with the usual ifdefs magic.These patches introduce include/linux/pgtable.h that replacesinclude/asm-generic/pgtable.h and add the definitions of the page tableaccessors to the new header.This patch (of 12):The linux/mm.h header includes to allow inlining of thefunctions involving page table manipulations, e.g. pte_alloc() andpmd_alloc(). So, there is no point to explicitly include in the files that include .The include statements in such cases are remove with a simple loop: for f in $(git grep -l "include ") ; do sed -i -e '/include / d' $f doneSigned-off-by: Mike Rapoport Signed-off-by: Andrew Morton Cc: Arnd Bergmann Cc: Borislav Petkov Cc: Brian Cain Cc: Catalin Marinas Cc: Chris Zankel Cc: "David S. Miller" Cc: Geert Uytterhoeven Cc: Greentime Hu Cc: Greg Ungerer Cc: Guan Xuetao Cc: Guo Ren Cc: Heiko Carstens Cc: Helge Deller Cc: Ingo Molnar Cc: Ley Foon Tan Cc: Mark Salter Cc: Matthew Wilcox Cc: Matt Turner Cc: Max Filippov Cc: Michael Ellerman Cc: Michal Simek Cc: Mike Rapoport Cc: Nick Hu Cc: Paul Walmsley Cc: Richard Weinberger Cc: Rich Felker Cc: Russell King Cc: Stafford Horne Cc: Thomas Bogendoerfer Cc: Thomas Gleixner Cc: Tony Luck Cc: Vincent Chen Cc: Vineet Gupta Cc: Will Deacon Cc: Yoshinori Sato Link: http://lkml.kernel.org/r/20200514170327.31389-1-rppt@kernel.orgLink: http://lkml.kernel.org/r/20200514170327.31389-2-rppt@kernel.orgSigned-off-by: Linus Torvalds List of files: /linux-6.15/drivers/video/fbdev/cirrusfb.c

8a48ac33 - video: constify fb ops across all drivers

Tue, 03 Dec 2019 16:38:50 +0000

video: constify fb ops across all driversNow that the fbops member of struct fb_info is const, we can startmaking the ops const as well.This does not cover all drivers; some actually modify the fbops struct,for example to adjust for different configurations, and others do moreinvolved things that I'd rather not touch in practically obsoletedrivers. Mostly this is the low hanging fruit where we can add "const"and be done with it.v3:- un-constify atyfb, mb862xx, nvidia and uvesabf (0day)v2:- fix typo (Christophe de Dinechin)- use "static const" instead of "const static" in mx3fb.c- also constify smscufx.cCc: linux-fbdev@vger.kernel.orgReviewed-by: Daniel Vetter Signed-off-by: Jani Nikula Link: https://patchwork.freedesktop.org/patch/msgid/ce67f14435f3af498f2e8bf35ce4be11f7504132.1575390740.git.jani.nikula@intel.com List of files: /linux-6.15/drivers/video/fbdev/cirrusfb.c

0adcdbcb - video: fbdev: don't print error message on framebuffer_alloc() failure

Fri, 28 Jun 2019 10:30:08 +0000

video: fbdev: don't print error message on framebuffer_alloc() failureframebuffer_alloc() can fail only on kzalloc() memory allocationfailure and since kzalloc() will print error message in such casewe can omit printing extra error message in drivers (which BTW iswhat the majority of framebuffer_alloc() users is doing already).Cc: "Bruno Prémont" Cc: Jiri Kosina Cc: Benjamin Tissoires Signed-off-by: Bartlomiej Zolnierkiewicz List of files: /linux-6.15/drivers/video/fbdev/cirrusfb.c

8c152208 - video: fbdev: cirrusfb: mark expected switch fall-throughs

Thu, 09 Nov 2017 17:09:32 +0000

video: fbdev: cirrusfb: mark expected switch fall-throughsIn preparation to enabling -Wimplicit-fallthrough, mark switch caseswhere we are expecting to fall through.Notice that in this particular case I placed the "fall through" commenton its own line, which is what GCC is expecting to find.Signed-off-by: Gustavo A. R. Silva Signed-off-by: Bartlomiej Zolnierkiewicz List of files: /linux-6.15/drivers/video/fbdev/cirrusfb.c

f7018c21 - video: move fbdev to drivers/video/fbdev

Thu, 13 Feb 2014 13:31:38 +0000

video: move fbdev to drivers/video/fbdevThe drivers/video directory is a mess. It contains generic video relatedfiles, directories for backlight, console, linux logo, lots of fbdevdevice drivers, fbdev framework files.Make some order into the chaos by creating drivers/video/fbdevdirectory, and move all fbdev related files there.No functionality is changed, although I guess it is possible that somesubtle Makefile build order related issue could be created by thispatch.Signed-off-by: Tomi Valkeinen Acked-by: Laurent Pinchart Acked-by: Geert Uytterhoeven Acked-by: Rob Clark Acked-by: Jingoo Han Acked-by: Daniel Vetter List of files: /linux-6.15/drivers/video/fbdev/cirrusfb.c