Changes in bus.c

8541bf02 - usb: typec: Only use SVID for matching altmodes

Fri, 13 Dec 2024 23:35:42 +0000

usb: typec: Only use SVID for matching altmodesMode in struct typec_altmode is used to indicate the index of thealtmode on a port, partner or plug. It is used in enter mode VDMs butdoesn't make much sense for matching against altmode drivers or formatching partner to port altmodes.Signed-off-by: Abhishek Pandit-Subedi Reviewed-by: Heikki Krogerus Reviewed-by: Benson Leung Link: https://lore.kernel.org/r/20241213153543.v5.1.Ie0d37646f18461234777d88b4c3e21faed92ed4f@changeidSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

d69d8048 - driver core: have match() callback in struct bus_type take a const *

Mon, 01 Jul 2024 12:07:37 +0000

driver core: have match() callback in struct bus_type take a const *In the match() callback, the struct device_driver * should not bechanged, so change the function callback to be a const *. This is onestep of many towards making the driver core safe to have structdevice_driver in read-only memory.Because the match() callback is in all busses, all busses are modifiedto handle this properly. This does entail switching some container_of()calls to container_of_const() to properly handle the constant *.For some busses, like PCI and USB and HV, the const * is cast away inthe match callback as those busses do want to modify those structures atthis point in time (they have a local lock in the driver structure.)That will have to be changed in the future if they wish to have theirstruct device * in read-only-memory.Cc: Rafael J. Wysocki Reviewed-by: Alex Elder Acked-by: Sumit Garg Link: https://lore.kernel.org/r/2024070136-wrongdoer-busily-01e8@gregkhSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

7494d4bc - usb: typec: altmodes: add typec_cable_ops to typec_altmode

Mon, 08 Jan 2024 19:16:14 +0000

usb: typec: altmodes: add typec_cable_ops to typec_altmodeAdd typec_cable_ops struct for enter, exit, and vdm. The struct is addedto typec_altmode so port alt modes can have access to partner and cablespecific callbacks, and alt mode drivers can specify operations over SOP'and SOP'' without modifying the existing API.typec_port_register_cable_ops is added as a new symbol for port driversto use to register cable operations to their registered port alt modes.Signed-off-by: RD Babiera Reviewed-by: Heikki Krogerus Link: https://lore.kernel.org/r/20240108191620.987785-15-rdbabiera@google.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

f2364330 - usb: typec: bus: verify partner exists in typec_altmode_attention

Mon, 14 Aug 2023 18:05:59 +0000

usb: typec: bus: verify partner exists in typec_altmode_attentionSome usb hubs will negotiate DisplayPort Alt mode with the devicebut will then negotiate a data role swap after entering the altmode. The data role swap causes the device to unregister all altmodes, however the usb hub will still send Attention messageseven after failing to reregister the Alt Mode. type_altmode_attentioncurrently does not verify whether or not a device's altmode partnerexists, which results in a NULL pointer error when dereferencingthe typec_altmode and typec_altmode_ops belonging to the altmodepartner.Verify the presence of a device's altmode partner before sendingthe Attention message to the Alt Mode driver.Fixes: 8a37d87d72f0 ("usb: typec: Bus type for alternate modes")Cc: stable@vger.kernel.orgSigned-off-by: RD Babiera Reviewed-by: Heikki Krogerus Reviewed-by: Guenter Roeck Link: https://lore.kernel.org/r/20230814180559.923475-1-rdbabiera@google.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

9d11b134 - USB: mark all struct bus_type as const

Mon, 13 Mar 2023 18:29:18 +0000

USB: mark all struct bus_type as constNow that the driver core can properly handle constant struct bus_type,move all of the USB subsystem struct bus_type structures as const,placing them into read-only memory which can not be modified at runtime.Cc: Johan Hovold Cc: Evan Green Cc: Alan Stern Cc: linux-usb@vger.kernel.orgAcked-by: Heikki Krogerus Link: https://lore.kernel.org/r/20230313182918.1312597-36-gregkh@linuxfoundation.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

2a81ada3 - driver core: make struct bus_type.uevent() take a const *

Wed, 11 Jan 2023 11:30:17 +0000

driver core: make struct bus_type.uevent() take a const *The uevent() callback in struct bus_type should not be modifying thedevice that is passed into it, so mark it as a const * and propagate thefunction signature changes out into all relevant subsystems that usethis callback.Acked-by: Rafael J. Wysocki Acked-by: Hans de Goede Link: https://lore.kernel.org/r/20230111113018.459199-16-gregkh@linuxfoundation.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

6681e43f - usb: typec: Make bus switch code retimer-aware

Thu, 12 Jan 2023 22:16:08 +0000

usb: typec: Make bus switch code retimer-awareSince ports can have retimers associated with them, update the Type-Calternate mode bus code to also set retimer state when the switch stateis updated.While we are here, make the typec_retimer_dev_type declaration in theretimer.h file as extern, so that the header file can be successfullyincluded in the bus code without redeclaration compilation errors.Signed-off-by: Prashant Malani Reviewed-by: Heikki Krogerus Link: https://lore.kernel.org/r/20230112221609.540754-4-pmalani@chromium.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

2c8cb236 - usb: typec: Add wrapper for bus switch set code

Thu, 12 Jan 2023 22:16:07 +0000

usb: typec: Add wrapper for bus switch set codeAdd a wrapper that calls the set() function for various switchesassociated with a port altmode.Right now, it just wraps the existing typec_mux_set() command,but it can be expanded to include other switches in future patches.No functional changes introduced by this patch.Signed-off-by: Prashant Malani Reviewed-by: Heikki Krogerus Link: https://lore.kernel.org/r/20230112221609.540754-3-pmalani@chromium.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

b6ddd180 - usb: typec: Check for ops->exit instead of ops->enter in altmode_exit

Mon, 14 Nov 2022 16:59:24 +0000

usb: typec: Check for ops->exit instead of ops->enter in altmode_exittypec_altmode_exit checks if ops->enter is not NULL but then callsops->exit a few lines below. Fix that and check for the functionpointer it's about to call instead.Fixes: 8a37d87d72f0 ("usb: typec: Bus type for alternate modes")Signed-off-by: Sven Peter Reviewed-by: Heikki Krogerus Link: https://lore.kernel.org/r/20221114165924.33487-1-sven@svenpeter.devSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

713fd49b - usb: typec: mux: Introduce indirection

Fri, 22 Apr 2022 22:23:48 +0000

usb: typec: mux: Introduce indirectionRather than directly exposing the implementation's representation of thetypec muxes to the controller/clients, introduce an indirection object.This enables the introduction of turning this relationship into aone-to-many in the following patch.Acked-by: Heikki Krogerus Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220422222351.1297276-5-bjorn.andersson@linaro.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

fc7a6209 - bus: Make remove callback return void

Tue, 13 Jul 2021 19:35:22 +0000

bus: Make remove callback return voidThe driver core ignores the return value of this callback because thereis only little it can do when a device disappears.This is the final bit of a long lasting cleanup quest where severalbuses were converted to also return void from their remove callback.Additionally some resource leaks were fixed that were caused by driversreturning an error code in the expectation that the driver won't goaway.With struct bus_type::remove returning void it's prevented that newlyimplemented buses return an ignored error code and so don't anticipatewrong expectations for driver authors.Reviewed-by: Tom Rix (For fpga)Reviewed-by: Mathieu Poirier Reviewed-by: Cornelia Huck (For drivers/s390 and drivers/vfio)Acked-by: Russell King (Oracle) (For ARM, Amba and related parts)Acked-by: Mark Brown Acked-by: Chen-Yu Tsai (for sunxi-rsb)Acked-by: Pali Rohár Acked-by: Mauro Carvalho Chehab (for media)Acked-by: Hans de Goede (For drivers/platform)Acked-by: Alexandre Belloni Acked-By: Vinod Koul Acked-by: Juergen Gross (For xen)Acked-by: Lee Jones (For mfd)Acked-by: Johannes Thumshirn (For mcb)Acked-by: Johan Hovold Acked-by: Srinivas Kandagatla (For slimbus)Acked-by: Kirti Wankhede (For vfio)Acked-by: Maximilian Luz Acked-by: Heikki Krogerus (For ulpi and typec)Acked-by: Samuel Iglesias Gonsálvez (For ipack)Acked-by: Geoff Levand (For ps3)Acked-by: Yehezkel Bernat (For thunderbolt)Acked-by: Alexander Shishkin (For intel_th)Acked-by: Dominik Brodowski (For pcmcia)Acked-by: Rafael J. Wysocki (For ACPI)Acked-by: Bjorn Andersson (rpmsg and apr)Acked-by: Srinivas Pandruvada (For intel-ish-hid)Acked-by: Dan Williams (For CXL, DAX, and NVDIMM)Acked-by: William Breathitt Gray (For isa)Acked-by: Stefan Richter (For firewire)Acked-by: Benjamin Tissoires (For hid)Acked-by: Thorsten Scherer (For siox)Acked-by: Sven Van Asbroeck (For anybuss)Acked-by: Ulf Hansson (For MMC)Acked-by: Wolfram Sang # for I2CAcked-by: Sudeep Holla Acked-by: Geert Uytterhoeven Acked-by: Dmitry Torokhov Acked-by: Finn Thain Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20210713193522.1770306-6-u.kleine-koenig@pengutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

1e2ed7b2 - usb: typec: Organize the private headers properly

Thu, 01 Apr 2021 10:58:42 +0000

usb: typec: Organize the private headers properlyAdding a header file for each subsystem - the connectorclass, alt mode bus and the class for the muxes.Signed-off-by: Heikki Krogerus Link: https://lore.kernel.org/r/20210401105847.13026-2-heikki.krogerus@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

0df9433f - usb: typec: altmode: Fix typec_altmode_get_partner sometimes returning an invalid pointer

Wed, 22 Apr 2020 14:43:45 +0000

usb: typec: altmode: Fix typec_altmode_get_partner sometimes returning an invalid pointerBefore this commit, typec_altmode_get_partner would return aconst struct typec_altmode * pointing to address 0x08 whento_altmode(adev)->partner was NULL.Add a check for to_altmode(adev)->partner being NULL to fix this.BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206365BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1785972Fixes: 5f54a85db5df ("usb: typec: Make sure an alt mode exist before getting its partner")Cc: stable@vger.kernel.orgSigned-off-by: Naoki Kiryu Signed-off-by: Hans de Goede Link: https://lore.kernel.org/r/20200422144345.43262-1-hdegoede@redhat.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

bbe80c9a - usb: typec: altmode: Remove the notification chain

Tue, 11 Feb 2020 11:25:30 +0000

usb: typec: altmode: Remove the notification chainUsing the generic notification chain is not reasonable withthe alternate modes because it would require dependenciesbetween the drivers of the components that need thenotifications, and the typec drivers.There are no users for the alternate mode notifications, soremoving the chain and the API for it completely.Signed-off-by: Heikki Krogerus Link: https://lore.kernel.org/r/20200211112531.86510-6-heikki.krogerus@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

87e3daa0 - usb: typec: Give the mux drivers all the details regarding the port state

Mon, 30 Dec 2019 14:26:08 +0000

usb: typec: Give the mux drivers all the details regarding the port statePassing all the details that the alternate mode driversprovide to the mux drivers during mode changes.The mux drivers will in practice need to be able to makedecisions on their own. It is not enough that they get onlythe requested port state. With the Thunderbolt 3 alternatemode for example the mux driver will need to consider alsothe capabilities of the cable before configuring the mux.Signed-off-by: Heikki Krogerus Link: https://lore.kernel.org/r/20191230142611.24921-13-heikki.krogerus@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

8face9aa - usb: typec: Add parameter for the VDO to typec_altmode_enter()

Mon, 30 Dec 2019 14:25:58 +0000

usb: typec: Add parameter for the VDO to typec_altmode_enter()Enter Mode Command may contain one VDO.Signed-off-by: Heikki Krogerus Link: https://lore.kernel.org/r/20191230142611.24921-3-heikki.krogerus@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

cf2f58fb - usb: typec: Block mode entry if the port has the mode disabled

Mon, 30 Dec 2019 14:25:57 +0000

usb: typec: Block mode entry if the port has the mode disabledOriginally the port drivers were expected to check does theconnector have the mode enabled or disabled when the altmode drivers attempted to enter the mode, but sincetypec_altmode_enter() puts the connector into USB SafeState before calling the port driver, it really has to dothe check on its own, and before changing the state.Otherwise the connector may be left in USB Safe State if theport driver does not move it back to normal USB operationwhen the mode is disabled.Signed-off-by: Heikki Krogerus Link: https://lore.kernel.org/r/20191230142611.24921-2-heikki.krogerus@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

2d686c73 - usb: typec: fix non-kernel-doc comments

Wed, 08 Jan 2020 06:24:50 +0000

usb: typec: fix non-kernel-doc commentsUse "/*" for non-kernel-doc comments instead of "/**", which isintended to be used only for kernel-doc notation.Signed-off-by: Randy Dunlap Reviewed-by: Heikki Krogerus Link: https://lore.kernel.org/r/88821011-2128-a8dd-68b8-c5ae8f43271f@infradead.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

5f54a85d - usb: typec: Make sure an alt mode exist before getting its partner

Wed, 12 Jun 2019 14:15:40 +0000

usb: typec: Make sure an alt mode exist before getting its partnerAdding check to typec_altmode_get_partner() to preventpotential NULL pointer dereference.Reported-by: Vladimir Yerilov Fixes: ad74b8649bea ("usb: typec: ucsi: Preliminary support for alternate modes")Signed-off-by: Heikki Krogerus Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c

40de5fe4 - usb/typec: fix kernel-doc notation warning for typec_match_altmode

Mon, 03 Sep 2018 19:58:35 +0000

usb/typec: fix kernel-doc notation warning for typec_match_altmodeFix kernel-doc warning for missing function parameter 'mode' description:../drivers/usb/typec/bus.c:268: warning: Function parameter or member 'mode' not described in 'typec_match_altmode'Also fix typos for same function documentation.Fixes: 8a37d87d72f0 ("usb: typec: Bus type for alternate modes")Signed-off-by: Randy Dunlap Acked-by: Heikki Krogerus Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/typec/bus.c