Changes in uhci-debug.c

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

b25472f9 - new helpers: no_seek_end_llseek{,_size}()

Sun, 06 Dec 2015 03:04:48 +0000

new helpers: no_seek_end_llseek{,_size}()Signed-off-by: Al Viro List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

1c20163d - usb: kill DEBUG compile option

Mon, 18 Nov 2013 12:23:16 +0000

usb: kill DEBUG compile optionIn the drivers that no longer need it, it is removed.It is removed from the Makefile. Drivers not fully convertedto dynamic debug have it shifted down into the individualdrivers.Signed-off-by: Oliver Neukum Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

9bab24af - uhci: compile debugfs conditional on CONFIG_DYNAMIC_DEBUG || DEBUG

Mon, 18 Nov 2013 12:23:10 +0000

uhci: compile debugfs conditional on CONFIG_DYNAMIC_DEBUG || DEBUGThis makes sure the header files are all thereSigned-off-by: Oliver Neukum Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

f1125f81 - USB/host: Use existing macros instead of hard-coded values in uhci-debug.c

Fri, 04 Oct 2013 22:14:34 +0000

USB/host: Use existing macros instead of hard-coded values in uhci-debug.cNow that UHCI IO registers have been defined in uhci-hcd.h, use them.Reviewed-by: James Hogan Signed-off-by: Deng-Cheng Zhu Acked-by: Alan Stern Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

3171fcab - USB: uhci: beautify source code

Thu, 24 Jan 2013 01:41:45 +0000

USB: uhci: beautify source code get rid of the line breaks in string constants. let comments within 80 with limitation. delete ' \' at the end of a statement.Signed-off-by: Chen Gang Acked-by: Alan Stern Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

13996ca7 - USB: uhci: check buffer length to avoid memory overflow

Wed, 23 Jan 2013 08:13:41 +0000

USB: uhci: check buffer length to avoid memory overflow for function uhci_sprint_schedule: the buffer len is MAX_OUTPUT: 64 * 1024, which may not be enough: may loop UHCI_NUMFRAMES times (UHCI_NUMFRAMES is 1024) each time of loop may get more than 64 bytes so need check the buffer length to avoid memory overflow this patch fix it like this: at first, make enough room for buffering the exceeding contents judge the contents which written whether bigger than buffer length if bigger (the exceeding contents will be in the exceeding buffer) break current work flow, and return.Signed-off-by: Chen Gang Acked-by: Alan Stern Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

51e2f62f - USB: UHCI: Add support for big endian descriptors

Wed, 18 May 2011 08:44:51 +0000

USB: UHCI: Add support for big endian descriptorsThis patch adds support for universal host controllers that usebig endian descriptors. Support for BE descriptors requires a non-PCIhost controller. For kernels with PCI-only UHCI there should be nochange in behaviour.This patch tries to replicate the technique used to support BE descriptorsin the EHCI HCD. Parts added to uhci-hcd.h are basically copy'n'paste fromehci.h.Signed-off-by: Jan Andersson Acked-by: Alan Stern Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

9faa091a - USB: UHCI: Wrap I/O register accesses

Fri, 06 May 2011 10:00:16 +0000

USB: UHCI: Wrap I/O register accessesThis patch is part of a series that extend the UHCI HCD to supportnon-PCI controllers.This patch replaces in{b,w,l} and out{b,wl} with calls to local inlinefunctions. This is done so that the register access functions can beextended to support register areas not mapped in PCI I/O space.Signed-off-by: Jan Andersson Acked-by: Alan Stern Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

451a3c24 - BKL: remove extraneous #include

Wed, 17 Nov 2010 15:26:55 +0000

BKL: remove extraneous #include The big kernel lock has been removed from all these files at some point,leaving only the #include.Remove this too as a cleanup.Signed-off-by: Arnd Bergmann Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

b409214c - USB: remove fake "address-of" expressions

Thu, 05 Aug 2010 17:12:14 +0000

USB: remove fake "address-of" expressionsFake "address-of" expressions that evaluate to NULL generally confusereaders and can provoke compiler warnings. This patch (as1412)removes three such fake expressions, using "#ifdef"s in their place.Signed-off-by: Alan Stern Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

00b81fb2 - USB-BKL: Remove BKL use in uhci-debug

Tue, 01 Jun 2010 21:04:43 +0000

USB-BKL: Remove BKL use in uhci-debugBKL was not really needed, just came from earlier push downs.The only part that's a bit dodgy is the lseek function. Wouldneed another lock or atomic access to fpos on 32bit?Better to have a libfs lseekSigned-off-by: Andi Kleen Cc: Arnd Bergmann Cc: Alan Stern Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

5a0e3ad6 - include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h

Wed, 24 Mar 2010 08:04:11 +0000

include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.hpercpu.h is included by sched.h and module.h and thus ends up beingincluded when building most .c files. percpu.h includes slab.h whichin turn includes gfp.h making everything defined by the two filesuniversally available and complicating inclusion dependencies.percpu.h -> slab.h dependency is about to be removed. Prepare forthis change by updating users of gfp and slab facilities include thoseheaders directly instead of assuming availability. As this conversionneeds to touch large number of source files, the following script isused as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.pyThe script does the followings.* Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h.* When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order.* If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file.The conversion was done in the following steps.1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files.2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files.3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind.4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually.5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary.6. percpu.h was updated not to include slab.h.7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point.Given the fact that I had only a couple of failures from tests on step6, I'm fairly confident about the coverage of this conversion patch.If there is a breakage, it's likely to be something in one of the archheaders which should be easily discoverable easily on most builds ofthe specific arch.Signed-off-by: Tejun Heo Guess-its-ok-by: Christoph Lameter Cc: Ingo Molnar Cc: Lee Schermerhorn List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

7ea0a2bc - USB: uhci: don't use pseudo negative values

Thu, 05 Mar 2009 16:01:11 +0000

USB: uhci: don't use pseudo negative valuesThe code in uhci-q.c doesn't have to use pseudo-negative values. I didit that way because it was easy and because it would give the expectedoutput during debugging. But it doesn't have to work that way. Here'sanother approach.Signed-off-by: Alan Stern Cc: Roel Kluin Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

eb231054 - USB: add urb->unlinked field

Tue, 21 Aug 2007 19:40:36 +0000

USB: add urb->unlinked fieldThis patch (as970) adds a new urb->unlinked field, which is used tostore the status of unlinked URBs since we can't use urb->status forthat purpose any more. To help simplify the HCDs, usbcore will checkurb->unlinked before calling the completion handler; if the value isset it will automatically override the status reported by the HCD.Signed-off-by: Alan Stern CC: David Brownell CC: Olav Kongas CC: Yoshihiro Shimoda CC: Tony Olech Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

e009f1b2 - UHCI: Fix problem caused by lack of terminating QH

Mon, 19 Mar 2007 19:31:42 +0000

UHCI: Fix problem caused by lack of terminating QHThis patch (as871) fixes a problem introduced by an earlier change.It turns out that some systems really do need to have a terminatingskeleton QH present whenever FSBR is on. I don't know any way to tellwhich systems do need it and which don't; the easiest answer is tohave it there always.This fixes the NumLock-hang bug reported by Jiri Slaby.Signed-off-by: Alan Stern Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

17230acd - UHCI: Eliminate asynchronous skeleton Queue Headers

Mon, 19 Feb 2007 20:52:45 +0000

UHCI: Eliminate asynchronous skeleton Queue HeadersThis patch (as856) attempts to improve the performance of uhci-hcd byremoving the asynchronous skeleton Queue Headers. They don't containany useful information but the controller has to read through them atleast once every millisecond, incurring a non-zero DMA overhead.Now all the asynchronous queues are combined, along with the period-1interrupt queue, into a single list with a single skeleton QH. Thestart of the low-speed control, full-speed control, and bulk sublistsis determined by linear search. Since there should rarely be morethan a couple of QHs in the list, the searches should incur a muchsmaller total load than keeping the skeleton QHs.Signed-off-by: Alan Stern Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

28b9325e - UHCI: Add macros for computing DMA values

Mon, 19 Feb 2007 20:51:51 +0000

UHCI: Add macros for computing DMA valuesThis patch (as855) adds some convenience macros to uhci-hcd, to helpsimplify the code for computing hardware DMA pointers.Signed-off-by: Alan Stern Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

3ca2a321 - UHCI: fix bandwidth allocation

Tue, 16 Jan 2007 16:56:32 +0000

UHCI: fix bandwidth allocationThis patch (as840) fixes the bandwidth allocation mechanism inuhci-hcd. It has never worked correctly.Signed-off-by: Alan Stern Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/host/uhci-debug.c

85a975d0 - UHCI: no dummy TDs for Iso QHs

Mon, 08 Jan 2007 17:01:43 +0000

UHCI: no dummy TDs for Iso QHsIsochronous queues don't need a dummy TD because the Queue Headerisn't managed by the hardware. This patch (as836) removes theunnecessary dummy TDs.The patch also fixes a long-standing typo in a comment (a "don't" wasmissing -- potentially very confusing!).Signed-off-by: Alan Stern Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/host/uhci-debug.c