Changes in host.c

f386bfad - USB: Use str_enable_disable-like helpers

Tue, 14 Jan 2025 20:05:39 +0000

USB: Use str_enable_disable-like helpersReplace ternary (condition ? "enable" : "disable") syntax with helpersfrom string_choices.h because:1. Simple function call with one argument is easier to read. Ternary operator has three arguments and with wrapping might lead to quite long code.2. Is slightly shorter thus also easier to read.3. It brings uniformity in the text - same string.4. Allows deduping by the linker, which results in a smaller binary file.Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20250114-str-enable-disable-usb-v1-6-c8405df47c19@linaro.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/chipidea/host.c

990c2a26 - usb: chipidea: host: Improve port index sanitizing

Mon, 02 Dec 2024 08:34:53 +0000

usb: chipidea: host: Improve port index sanitizingCoverity from Synopsys complains "Illegal address computation (OVERRUN)"on status_reg.After below code executed, port_index = wIndex & 0xff; port_index -= (port_index > 0);the static analysis tool see the value of port_index is now between 0 and254 (inclusive).However, ehci_def.h define port_status as below: #define HCS_N_PORTS_MAX 15 u32 port_status[HCS_N_PORTS_MAX];So the tool think illegal array pointer may be obtained. status_reg = &ehci->regs->port_status[port_index];This will follow "846cbf98cbef USB: EHCI: Improve port index sanitizing" toimprove port index sanitizing.Signed-off-by: Xu Yang Acked-by: Peter Chen Link: https://lore.kernel.org/r/20241202083453.704533-1-xu.yang_2@nxp.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/chipidea/host.c

2ae61a25 - usb: chipidea: Simplify Tegra DMA alignment code

Thu, 28 Sep 2023 21:06:03 +0000

usb: chipidea: Simplify Tegra DMA alignment codeThe USB host on Tegra3 works with 32-bit alignment. Previous code triedto align the buffer, but it did align the wrapper struct instead, sothe buffer was at a constant offset of 8 bytes (two pointers) fromexpected alignment. Since kmalloc() guarantees at least 8-bytealignment already, the alignment-extending is removed.Fixes: fc53d5279094 ("usb: chipidea: tegra: Support host mode")Signed-off-by: Michał Mirosław Link: https://lore.kernel.org/r/a0d917d492b1f91ee0019e68b8e8bca9c585393f.1695934946.git.mirq-linux@rere.qmqm.plSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/chipidea/host.c

7ab87167 - usb: chipidea: Fix DMA overwrite for Tegra

Thu, 28 Sep 2023 21:06:03 +0000

usb: chipidea: Fix DMA overwrite for TegraTegra USB controllers seem to issue DMA in full 32-bit words only and thusmay overwrite unevenly-sized buffers. One such occurrence is detected bySLUB when receiving a reply to a 1-byte buffer (below). Fix this byallocating a bounce buffer also for buffers with sizes not a multiple of 4.=============================================================================BUG kmalloc-64 (Tainted: G B ): kmalloc Redzone overwritten-----------------------------------------------------------------------------0x8555cd02-0x8555cd03 @offset=3330. First byte 0x0 instead of 0xccAllocated in usb_get_status+0x2b/0xac age=1 cpu=3 pid=41 __kmem_cache_alloc_node+0x12f/0x1e4 __kmalloc+0x33/0x8c usb_get_status+0x2b/0xac hub_probe+0x5e9/0xcec usb_probe_interface+0xbf/0x21c really_probe+0xa5/0x2c4 __driver_probe_device+0x75/0x174 driver_probe_device+0x31/0x94 __device_attach_driver+0x65/0xc0 bus_for_each_drv+0x4b/0x74 __device_attach+0x69/0x120 bus_probe_device+0x65/0x6c device_add+0x48b/0x5f8 usb_set_configuration+0x37b/0x6b4 usb_generic_driver_probe+0x37/0x68 usb_probe_device+0x35/0xb4Slab 0xbf622b80 objects=21 used=18 fp=0x8555cdc0 flags=0x800(slab|zone=0)Object 0x8555cd00 @offset=3328 fp=0x00000000Redzone 8555ccc0: cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc ................Redzone 8555ccd0: cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc ................Redzone 8555cce0: cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc ................Redzone 8555ccf0: cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc ................Object 8555cd00: 01 00 00 00 cc cc cc cc cc cc cc cc cc cc cc cc ................Object 8555cd10: cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc ................Object 8555cd20: cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc ................Object 8555cd30: cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc ................Redzone 8555cd40: cc cc cc cc ....Padding 8555cd74: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a ZZZZZZZZZZZZCPU: 3 PID: 41 Comm: kworker/3:1 Tainted: G B 6.6.0-rc1mq-00118-g59786f827ea1 #1115Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)Workqueue: usb_hub_wq hub_event[<8010ca28>] (unwind_backtrace) from [<801090a5>] (show_stack+0x11/0x14)[<801090a5>] (show_stack) from [<805da2fb>] (dump_stack_lvl+0x4d/0x7c)[<805da2fb>] (dump_stack_lvl) from [<8026464f>] (check_bytes_and_report+0xb3/0xe4)[<8026464f>] (check_bytes_and_report) from [<802648e1>] (check_object+0x261/0x290)[<802648e1>] (check_object) from [<802671b1>] (free_to_partial_list+0x105/0x3f8)[<802671b1>] (free_to_partial_list) from [<80268613>] (__kmem_cache_free+0x103/0x128)[<80268613>] (__kmem_cache_free) from [<80425a67>] (usb_get_status+0x73/0xac)[<80425a67>] (usb_get_status) from [<80421b31>] (hub_probe+0x5e9/0xcec)[<80421b31>] (hub_probe) from [<80428bbb>] (usb_probe_interface+0xbf/0x21c)[<80428bbb>] (usb_probe_interface) from [<803ee13d>] (really_probe+0xa5/0x2c4)[<803ee13d>] (really_probe) from [<803ee3d1>] (__driver_probe_device+0x75/0x174)[<803ee3d1>] (__driver_probe_device) from [<803ee501>] (driver_probe_device+0x31/0x94)usb 1-1: device descriptor read/8, error -71Fixes: fc53d5279094 ("usb: chipidea: tegra: Support host mode")Signed-off-by: Michał Mirosław Link: https://lore.kernel.org/r/ef8466b834c1726f5404c95c3e192e90460146f8.1695934946.git.mirq-linux@rere.qmqm.plSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/chipidea/host.c

12e6ac69 - usb: chipidea: add workaround for chipidea PEC bug

Wed, 09 Aug 2023 02:44:32 +0000

usb: chipidea: add workaround for chipidea PEC bugSome NXP processors using ChipIdea USB IP have a bug when frame babble isdetected.Issue description:In USB camera test, our controller is host in HS mode. In ISOC IN, whendevice sends data across the micro frame, it causes the babble in hostcontroller. This will clear the PE bit. In spec, it also requires to setthe PEC bit and then set the PCI bit. Without the PCI interrupt, thesoftware does not know the PE is cleared.This will add a flag CI_HDRC_HAS_PORTSC_PEC_MISSED to some impactedplatform datas. And the ehci host driver will assert PEC by SW whenspecific conditions are satisfied.Signed-off-by: Xu Yang Link: https://lore.kernel.org/r/20230809024432.535160-2-xu.yang_2@nxp.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/chipidea/host.c

2f64d6a6 - usb: chipidea: host: add suspend/resume support for host controller

Thu, 13 Oct 2022 15:14:37 +0000

usb: chipidea: host: add suspend/resume support for host controllerThe controller's power may be powered off during system suspend. Thiswill add suspend/resume support when the controller suffers power lost.Signed-off-by: Xu Yang Link: https://lore.kernel.org/r/20221013151442.3262951-4-xu.yang_2@nxp.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/chipidea/host.c

66d1c802 - usb: chipidea: Add support for VBUS control with PHY

Mon, 22 Aug 2022 05:40:51 +0000

usb: chipidea: Add support for VBUS control with PHYSome platforms make use of VBUS control over PHY which means controllerdriver has to access PHY registers to turn on/off VBUS line.This patchadds support for such platforms in chipidea.Flag 'CI_HDRC_PHY_VBUS_CONTROL' added to support VBus control feature.Acked-by: Peter Chen Signed-off-by: Piyush Mehta Signed-off-by: Piyush Mehta Link: https://lore.kernel.org/r/20220822054051.2941282-1-piyush.mehta@amd.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/chipidea/host.c

e5d6a7c6 - usb: chipidea: host: fix port index underflow and UBSAN complains

Fri, 18 Jun 2021 08:28:58 +0000

usb: chipidea: host: fix port index underflow and UBSAN complainsIf wIndex is 0 (and it often is), these calculations underflow andUBSAN complains, here resolve this by not decrementing the index whenit is equal to 0, this copies the solution from commit 85e3990bea49("USB: EHCI: avoid undefined pointer arithmetic and placate UBSAN")Reported-by: Zhipeng Wang Signed-off-by: Li Jun Link: https://lore.kernel.org/r/1624004938-2399-1-git-send-email-jun.li@nxp.comSigned-off-by: Peter Chen List of files: /linux-6.15/drivers/usb/chipidea/host.c

4294a8c2 - usb: chipidea: tegra: fix flexible_array.cocci warnings

Sat, 13 Feb 2021 20:09:55 +0000

usb: chipidea: tegra: fix flexible_array.cocci warningsZero-length and one-element arrays are deprecated, seeDocumentation/process/deprecated.rstFlexible-array members should be used instead.Generated by: scripts/coccinelle/misc/flexible_array.cocciFixes: fc53d5279094 ("usb: chipidea: tegra: Support host mode")CC: Peter Geis Reported-by: kernel test robot Reviewed-by: Dmitry Osipenko Signed-off-by: kernel test robot Signed-off-by: Julia Lawall Link: https://lore.kernel.org/r/alpine.DEB.2.22.394.2102132108040.2720@hadrienSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/chipidea/host.c

fc53d527 - usb: chipidea: tegra: Support host mode

Fri, 18 Dec 2020 12:02:42 +0000

usb: chipidea: tegra: Support host modeAdd USB host mode to the Tegra HDRC driver. This allows us to benefit fromsupport provided by the generic ChipIdea driver instead of duplicating theeffort in a separate ehci-tegra driver.Tested-by: Matt Merhar Tested-by: Nicolas Chauvet Tested-by: Ion Agorria Acked-by: Thierry Reding Acked-by: Peter Chen Signed-off-by: Peter Geis Signed-off-by: Dmitry Osipenko Link: https://lore.kernel.org/r/20201218120246.7759-6-digetx@gmail.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/chipidea/host.c

c1ffba30 - usb: chipidea: host: Disable port power only if previously enabled

Thu, 26 Dec 2019 15:57:54 +0000

usb: chipidea: host: Disable port power only if previously enabledOn shutdown, ehci_power_off() is called unconditionally to power offeach port, even if it was never called to power on the port.For chipidea, this results in a call to ehci_ci_portpower() with a requestto power off ports even if the port was never powered on.This results in the following warning from the regulator code.WARNING: CPU: 0 PID: 182 at drivers/regulator/core.c:2596 _regulator_disable+0x1a8/0x210unbalanced disables for usb_otg2_vbusModules linked in:CPU: 0 PID: 182 Comm: init Not tainted 5.4.6 #1Hardware name: Freescale i.MX7 Dual (Device Tree)[] (unwind_backtrace) from [] (show_stack+0x10/0x14)[] (show_stack) from [] (dump_stack+0xe0/0x10c)[] (dump_stack) from [] (__warn+0xf4/0x10c)[] (__warn) from [] (warn_slowpath_fmt+0x78/0xbc)[] (warn_slowpath_fmt) from [] (_regulator_disable+0x1a8/0x210)[] (_regulator_disable) from [] (regulator_disable+0x38/0xe8)[] (regulator_disable) from [] (ehci_ci_portpower+0x38/0xdc)[] (ehci_ci_portpower) from [] (ehci_port_power+0x50/0xa4)[] (ehci_port_power) from [] (ehci_silence_controller+0x5c/0xc4)[] (ehci_silence_controller) from [] (ehci_stop+0x3c/0xcc)[] (ehci_stop) from [] (usb_remove_hcd+0xe0/0x19c)[] (usb_remove_hcd) from [] (host_stop+0x38/0xa8)[] (host_stop) from [] (ci_hdrc_remove+0x44/0xe4)...Keeping track of the power enable state avoids the warning and traceback.Fixes: c8679a2fb8dec ("usb: chipidea: host: add portpower override")Cc: Michael Grzeschik Cc: Peter Chen Cc: stable@vger.kernel.orgSigned-off-by: Guenter Roeck Acked-by: Peter Chen Link: https://lore.kernel.org/r/20191226155754.25451-1-linux@roeck-us.netSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/chipidea/host.c

2c4593ec - usb: chipidea: host: override ehci->hub_control

Tue, 16 Oct 2018 02:11:42 +0000

usb: chipidea: host: override ehci->hub_controlThe chipidea controller has some special requirements duringsuspend/resume, override common ehci->hub_control to implementit.Reviewed-by: Frieder Schrempf Tested-by: Frieder Schrempf Signed-off-by: Peter Chen List of files: /linux-6.15/drivers/usb/chipidea/host.c

014abe34 - usb: chipidea: add flag for imx hsic implementation

Mon, 15 Oct 2018 09:02:57 +0000

usb: chipidea: add flag for imx hsic implementationNXP (Freecale) imx HSIC design has some special requirements, addsome flags at host code to handle them.Reviewed-by: Frieder Schrempf Tested-by: Frieder Schrempf Signed-off-by: Peter Chen List of files: /linux-6.15/drivers/usb/chipidea/host.c

16caf1fa - usb: chipidea: Add dynamic pinctrl selection

Tue, 04 Sep 2018 15:18:55 +0000

usb: chipidea: Add dynamic pinctrl selectionSome hardware implementations require to configure pins differentlyaccording to the USB role (host/device), this can be an update of thepins routing or a simple GPIO value change.This patch introduces new optional "host" and "device" pinctrls.If these pinctrls are defined by the device, they are respectivelyselected on host/device role start.If a default pinctrl exist, it is restored on host/device role stop.Signed-off-by: Loic Poulain Signed-off-by: Peter Chen List of files: /linux-6.15/drivers/usb/chipidea/host.c

90f26cc6 - usb: chipidea: host: fix disconnection detect issue

Wed, 06 Jun 2018 01:43:27 +0000

usb: chipidea: host: fix disconnection detect issueThe commit 4e88d4c08301 ("usb: add a flag to skip PHYinitialization to struct usb_hcd") delete the assignmentfor hcd->usb_phy, it causes usb_phy_notify_connect{disconnect)are not called, the USB PHY driver is not notified of hot plugevent, then the disconnection will not be detected by hardware.Fixes: 4e88d4c08301 ("usb: add a flag to skip PHY initialization to struct usb_hcd")Acked-by: Martin Blumenstingl Reported-by: Mats Karrman Tested-by: Mats Karrman Signed-off-by: Peter Chen List of files: /linux-6.15/drivers/usb/chipidea/host.c

4e88d4c0 - usb: add a flag to skip PHY initialization to struct usb_hcd

Sat, 03 Mar 2018 21:43:03 +0000

usb: add a flag to skip PHY initialization to struct usb_hcdThe USB HCD core driver parses the device-tree node for "phys" and"usb-phys" properties. It also manages the power state of these PHYsautomatically.However, drivers may opt-out of this behavior by setting "phy" or"usb_phy" in struct usb_hcd to a non-null value. An example where thisis required is the "Qualcomm USB2 controller", implemented by thechipidea driver. The hardware requires that the PHY is only powered onafter the "reset completed" event from the controller is received.A follow-up patch will allow the USB HCD core driver to manage more thanone PHY. Add a new "skip_phy_initialization" bitflag to struct usb_hcdso drivers can opt-out of any PHY management provided by the USB HCDcore driver.This also updates the existing drivers so they use the new flag if theywant to opt out of the PHY management provided by the USB HCD coredriver. This means that for these drivers the new "multiple PHY"handling (which will be added in a follow-up patch) will be disabled aswell.Signed-off-by: Martin Blumenstingl Acked-by: Peter Chen Tested-by: Neil Armstrong Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/chipidea/host.c

51b751f1 - USB: chipidea: Remove redundant license text

Mon, 06 Nov 2017 14:37:18 +0000

USB: chipidea: Remove redundant license textNow that the SPDX tag is in all USB files, that identifies the licensein a specific and legally-defined manner. So the extra GPL text wordingcan be removed as it is no longer needed at all.This is done on a quest to remove the 700+ different ways that files inthe kernel describe the GPL license text. And there's unneeded stufflike the address (sometimes incorrect) for the FSF which is neverneeded.No copyright headers or other non-license-description text was removed.Cc: Thierry Reding Cc: Jonathan Hunter Acked-by: Peter Chen Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/chipidea/host.c

5fd54ace - USB: add SPDX identifiers to all remaining files in drivers/usb/

Fri, 03 Nov 2017 10:28:30 +0000

USB: add SPDX identifiers to all remaining files in drivers/usb/It's good to have SPDX identifiers in all files to make it easier toaudit the kernel tree for correct licenses.Update the drivers/usb/ and include/linux/usb* files with the correctSPDX license identifier based on the license text in the file itself.The SPDX identifier is a legally binding shorthand, which can be usedinstead of the full boiler plate text.This work is based on a script and data from Thomas Gleixner, PhilippeOmbredanne, and Kate Stewart.Cc: Thomas Gleixner Cc: Kate Stewart Cc: Philippe Ombredanne Signed-off-by: Greg Kroah-Hartman Acked-by: Felipe Balbi Acked-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/chipidea/host.c

aeb78cda - usb: chipidea: use bus->sysdev for DMA configuration

Mon, 13 Mar 2017 02:18:42 +0000

usb: chipidea: use bus->sysdev for DMA configurationSet the dma for chipidea from sysdev. This is inherited from itsparent node. Also, do not set dma mask for child as it is not requirednow.Signed-off-by: Arnd Bergmann Signed-off-by: Sriram Dash Acked-by: Peter Chen Signed-off-by: Mathias Nyman Signed-off-by: Peter Chen Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/usb/chipidea/host.c

11893dae - usb: chipidea: msm: Handle phy power states

Wed, 28 Dec 2016 22:57:06 +0000

usb: chipidea: msm: Handle phy power statesThe ULPI phy on qcom platforms needs to be initialized andpowered on after a USB reset and before we toggle the run/stopbit. Otherwise, the phy locks up and doesn't work properly. Hookthe phy initialization into the RESET event and the phy power offinto the STOPPED event.Acked-by: Peter Chen Cc: Greg Kroah-Hartman Signed-off-by: Stephen Boyd Signed-off-by: Peter Chen List of files: /linux-6.15/drivers/usb/chipidea/host.c