Changes in conmakehash.c

7258fdd7 - tty: vt: conmakehash: remove non-portable code printing comment header

Fri, 09 Aug 2024 16:07:20 +0000

tty: vt: conmakehash: remove non-portable code printing comment headerCommit 6e20753da6bc ("tty: vt: conmakehash: cope with abs_srctree nolonger in env") included , which invoked another(wrong) patch that tried to address a build error on macOS.According to the specification [1], the correct header to use PATH_MAXis .The minimal fix would be to replace with .However, the following commits seem questionable to me: - 3bd85c6c97b2 ("tty: vt: conmakehash: Don't mention the full path of the input in output") - 6e20753da6bc ("tty: vt: conmakehash: cope with abs_srctree no longer in env")These commits made too many efforts to cope with a comment header indrivers/tty/vt/consolemap_deftbl.c: /* * Do not edit this file; it was automatically generated by * * conmakehash drivers/tty/vt/cp437.uni > [this file] * */With this commit, the header part of the generate C file will besimplified as follows: /* * Automatically generated file; Do not edit. */BTW, another series of excessive efforts for a comment header can beseen in the following: - 5ef6dc08cfde ("lib/build_OID_registry: don't mention the full path of the script in output") - 2fe29fe94563 ("lib/build_OID_registry: avoid non-destructive substitution for Perl < 5.13.2 compat")[1]: https://pubs.opengroup.org/onlinepubs/009695399/basedefs/limits.h.htmlFixes: 6e20753da6bc ("tty: vt: conmakehash: cope with abs_srctree no longer in env")Cc: stable Reported-by: Daniel Gomez Closes: https://lore.kernel.org/all/20240807-macos-build-support-v1-11-4cd1ded85694@samsung.com/Signed-off-by: Masahiro Yamada Link: https://lore.kernel.org/r/20240809160853.1269466-1-masahiroy@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/vt/conmakehash.c

6e20753d - tty: vt: conmakehash: cope with abs_srctree no longer in env

Thu, 25 Jul 2024 13:20:45 +0000

tty: vt: conmakehash: cope with abs_srctree no longer in envconmakehash uses getenv("abs_srctree") from the environment to stripthe absolute path from the generated sources.However since commit e2bad142bb3d ("kbuild: unexport abs_srctree andabs_objtree") this environment variable no longer gets set.Instead use basename() to indicate the used file in a comment of thegenerated source file.Fixes: 3bd85c6c97b2 ("tty: vt: conmakehash: Don't mention the full path of the input in output")Cc: stable Signed-off-by: Max Krummenacher Link: https://lore.kernel.org/stable/20240725132056.9151-1-max.oss.09%40gmail.comLink: https://lore.kernel.org/r/20240725132056.9151-1-max.oss.09@gmail.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/vt/conmakehash.c

3bd85c6c - tty: vt: conmakehash: Don't mention the full path of the input in output

Mon, 11 Mar 2024 11:30:18 +0000

tty: vt: conmakehash: Don't mention the full path of the input in outputThis change strips $abs_srctree of the input file containing thecharacter mapping table in the generated output. The motivation for thischange is Yocto emitting a build warning WARNING: linux-lxatac-6.7-r0 do_package_qa: QA Issue: File /usr/src/debug/linux-lxatac/6.7-r0/drivers/tty/vt/consolemap_deftbl.c in package linux-lxatac-src contains reference to TMPDIRSo this change brings us one step closer to make the build resultreproducible independent of the build path.Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20240311113017.483101-2-u.kleine-koenig@pengutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/vt/conmakehash.c

4484aa80 - tty: vt: move conmakehash to drivers/tty/vt/ from scripts/

Tue, 17 Dec 2019 11:06:33 +0000

tty: vt: move conmakehash to drivers/tty/vt/ from scripts/scripts/conmakehash is only used for generatingdrivers/tty/vt/consolemap_deftbl.cMove it to the related directory.Signed-off-by: Masahiro Yamada Link: https://lore.kernel.org/r/20191217110633.8796-1-masahiroy@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/vt/conmakehash.c