Changes in moxa.c

8fa7292f - treewide: Switch/rename to timer_delete[_sync]()

Sat, 05 Apr 2025 08:17:26 +0000

treewide: Switch/rename to timer_delete[_sync]()timer_delete[_sync]() replaces del_timer[_sync](). Convert the whole treeover and remove the historical wrapper inlines.Conversion was done with coccinelle plus manual fixups where necessary.Signed-off-by: Thomas Gleixner Signed-off-by: Ingo Molnar List of files: /linux-6.15/drivers/tty/moxa.c

794d7b27 - tty: moxa: carve out special ioctls and extra tty_port

Mon, 17 Mar 2025 07:00:35 +0000

tty: moxa: carve out special ioctls and extra tty_portThese ioctls are undocumented and not exposed -- they are definedlocally. Given they need a special tty_port just for them, this is veryugly. So drop this whole functionality. It is barely used for somethingreal. (And if it is, we'd need a common functionality to all drivers.)Signed-off-by: Jiri Slaby (SUSE) Link: https://lore.kernel.org/r/20250317070046.24386-21-jirislaby@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

eed0d311 - tty: moxa: drop ISA support

Mon, 17 Mar 2025 07:00:34 +0000

tty: moxa: drop ISA supportI doubt anyone actually uses this driver (unlike mxser.c and serialmoxa driven devices). Even less there is anyone with a moxa ISA card.The newer mxser dropped the support for ISA in 2021. Let this moxafollow now.Good diet.Signed-off-by: Jiri Slaby (SUSE) Link: https://lore.kernel.org/r/20250317070046.24386-20-jirislaby@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

0fdbeabf - tty: moxa: drop version dump to logs

Mon, 17 Mar 2025 07:00:33 +0000

tty: moxa: drop version dump to logsThe arbitrary MOXA_VERSION is dumped to the logs when the driver isloaded. Avoid this as a driver should be silent unless something breaks.Signed-off-by: Jiri Slaby (SUSE) Link: https://lore.kernel.org/r/20250317070046.24386-19-jirislaby@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

cb8566b9 - tty: moxa: convert to u8 and size_t

Wed, 06 Dec 2023 07:37:02 +0000

tty: moxa: convert to u8 and size_tSwitch character types to u8 and sizes to size_t. To conform tocharacters/sizes in the rest of the tty layer.Signed-off-by: "Jiri Slaby (SUSE)" Link: https://lore.kernel.org/r/20231206073712.17776-18-jirislaby@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

95713967 - tty: make tty_operations::write()'s count size_t

Thu, 10 Aug 2023 09:15:03 +0000

tty: make tty_operations::write()'s count size_tUnify with the rest of the code. Use size_t for counts and ssize_t forretval.Signed-off-by: "Jiri Slaby (SUSE)" Link: https://lore.kernel.org/r/20230810091510.13006-30-jirislaby@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

69851e4a - tty: propagate u8 data to tty_operations::write()

Thu, 10 Aug 2023 09:15:01 +0000

tty: propagate u8 data to tty_operations::write()Data are now typed as u8. Propagate this change totty_operations::write().Signed-off-by: "Jiri Slaby (SUSE)" Cc: Richard Henderson Cc: Ivan Kokshaysky Cc: Matt Turner Cc: Geert Uytterhoeven Cc: Richard Weinberger Cc: Anton Ivanov Cc: Johannes Berg Cc: Chris Zankel Cc: Max Filippov Cc: Arnd Bergmann Cc: Vaibhav Gupta Cc: Jens Taprogge Cc: Karsten Keil Cc: Scott Branden Cc: Ulf Hansson Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Alexander Gordeev Cc: Christian Borntraeger Cc: Sven Schnelle Cc: David Lin Cc: Johan Hovold Cc: Alex Elder Cc: Laurentiu Tudor Cc: Jiri Kosina Cc: David Sterba Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: Arnaud Pouliquen Cc: Oliver Neukum Cc: Mathias Nyman Cc: Marcel Holtmann Cc: Johan Hedberg Cc: Luiz Augusto von Dentz Link: https://lore.kernel.org/r/20230810091510.13006-28-jirislaby@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

2d762dab - tty: moxa: Rename dtr/rts parameters/variables to active

Tue, 17 Jan 2023 09:03:58 +0000

tty: moxa: Rename dtr/rts parameters/variables to activeUse active consistently for naming parameters and variables.Reviewed-by: Jiri Slaby Signed-off-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20230117090358.4796-13-ilpo.jarvinen@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

5d420399 - tty: Convert ->dtr_rts() to take bool argument

Tue, 17 Jan 2023 09:03:53 +0000

tty: Convert ->dtr_rts() to take bool argumentConvert the raise/on parameter in ->dtr_rts() to bool through thecallchain. The parameter is used like bool. In USB serial, thereremains a few implicit bool -> larger type conversions because somedevices use u8 in their control messages.In moxa_tiocmget(), dtr variable was reused for line status whichrequires int so use a separate variable for status.Reviewed-by: Jiri Slaby Acked-by: Ulf Hansson # For MMCSigned-off-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20230117090358.4796-8-ilpo.jarvinen@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

b300fb26 - tty: Convert ->carrier_raised() and callchains to bool

Tue, 17 Jan 2023 09:03:52 +0000

tty: Convert ->carrier_raised() and callchains to boolReturn boolean from ->carrier_raised() instead of 0 and 1. Make thereturn type change also to tty_port_carrier_raised() that makes the->carrier_raised() call (+ cd variable in moxa into which its returnvalue is stored).Also cleans up a few unnecessary constructs related to this change: return xx ? 1 : 0; -> return xx; if (xx) return 1; return 0; -> return xx;Reviewed-by: Jiri Slaby Acked-by: Ulf Hansson # For MMCSigned-off-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20230117090358.4796-7-ilpo.jarvinen@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

c2ac4bfa - tty: moxa: Make local var storing tty_port_initialized() bool

Tue, 17 Jan 2023 09:03:50 +0000

tty: moxa: Make local var storing tty_port_initialized() boolReturn type of tty_port_initialized() is bool, use matching type forthe local variable.Also reorder the local vars to reverse-xmas-tree while at it.Reviewed-by: Jiri Slaby Signed-off-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20230117090358.4796-5-ilpo.jarvinen@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

515be7ba - tty: Cleanup tty_port_set_initialized() bool parameter

Tue, 17 Jan 2023 09:03:47 +0000

tty: Cleanup tty_port_set_initialized() bool parameterMake callers pass true/false consistently for bool val.Reviewed-by: Samuel Iglesias Gonsalvez Reviewed-by: Jiri Slaby Signed-off-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20230117090358.4796-2-ilpo.jarvinen@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

a8c11c15 - tty: Make ->set_termios() old ktermios const

Tue, 16 Aug 2022 11:57:39 +0000

tty: Make ->set_termios() old ktermios constThere should be no reason to adjust old ktermios which is going to getdiscarded anyway.Reviewed-by: Andy Shevchenko Signed-off-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20220816115739.10928-9-ilpo.jarvinen@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

5f6a8515 - tty: drivers/tty/, stop using tty_schedule_flip()

Mon, 22 Nov 2021 11:16:46 +0000

tty: drivers/tty/, stop using tty_schedule_flip()Since commit a9c3f68f3cd8d (tty: Fix low_latency BUG) in 2014,tty_flip_buffer_push() is only a wrapper to tty_schedule_flip(). We aregoing to remove the latter (as it is used less), so call the former indrivers/tty/.Cc: Vladimir Zapolskiy Reviewed-by: Johan Hovold Signed-off-by: Jiri Slaby Link: https://lore.kernel.org/r/20211122111648.30379-2-jslaby@suse.czSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

b55c8aa6 - tty: moxa: merge moxa.h into moxa.c

Tue, 14 Sep 2021 09:08:23 +0000

tty: moxa: merge moxa.h into moxa.cThere is no need for existence of a separate header for Moxa's Intelliocards. Merge it into moxa.c to clean up the tty dir a bit.Signed-off-by: Jiri Slaby Link: https://lore.kernel.org/r/20210914090823.17206-1-jslaby@suse.czSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

322003b9 - tty: moxa: use semi-colons instead of commas

Wed, 25 Aug 2021 07:24:05 +0000

tty: moxa: use semi-colons instead of commasThis code works but it's cleaner to use a semi-colon to end a statementinstead of a comma.Acked-by: Jiri Slaby Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/20210825072405.GA13013@kiliSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

9f90a4dd - tty: drop put_tty_driver

Fri, 23 Jul 2021 07:43:16 +0000

tty: drop put_tty_driverput_tty_driver() is an alias for tty_driver_kref_put(). There is no needfor two exported identical functions, therefore switch all users ofold put_tty_driver() to new tty_driver_kref_put() and remove the formerfor good.Cc: Richard Henderson Cc: Ivan Kokshaysky Cc: Matt Turner Cc: Geert Uytterhoeven Cc: Jeff Dike Cc: Richard Weinberger Cc: Anton Ivanov Cc: Chris Zankel Cc: Max Filippov Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Samuel Iglesias Gonsalvez Cc: Jens Taprogge Cc: Karsten Keil Cc: Scott Branden Cc: Ulf Hansson Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Christian Borntraeger Cc: David Lin Cc: Johan Hovold Cc: Alex Elder Cc: Jiri Slaby Cc: Laurentiu Tudor Cc: Jiri Kosina Cc: David Sterba Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: Oliver Neukum Cc: Felipe Balbi Cc: Mathias Nyman Cc: Marcel Holtmann Cc: Johan Hedberg Cc: Luiz Augusto von Dentz Acked-by: Alex Elder Acked-by: Christian Borntraeger Acked-by: Max Filippov Acked-by: David Sterba Acked-by: Samuel Iglesias Gonsálvez Signed-off-by: Jiri Slaby Link: https://lore.kernel.org/r/20210723074317.32690-8-jslaby@suse.czSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

fff4ef17 - tty: make tty_operations::chars_in_buffer return uint

Wed, 05 May 2021 09:19:19 +0000

tty: make tty_operations::chars_in_buffer return uinttty_operations::chars_in_buffer is another hook which is expected toreturn values >= 0. So make it explicit by the return type too -- useunsigned int.Signed-off-by: Jiri Slaby Acked-By: Anton Ivanov Acked-by: David Sterba Cc: Jeff Dike Cc: Richard Weinberger Cc: Arnd Bergmann Cc: Samuel Iglesias Gonsalvez Cc: Jens Taprogge Cc: Karsten Keil Cc: Ulf Hansson Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Christian Borntraeger Cc: David Lin Cc: Johan Hovold Cc: Alex Elder Cc: Jiri Kosina Cc: Shawn Guo Cc: Sascha Hauer Cc: Oliver Neukum Cc: Felipe Balbi Cc: Mathias Nyman Cc: Marcel Holtmann Cc: Johan Hedberg Cc: Luiz Augusto von Dentz Link: https://lore.kernel.org/r/20210505091928.22010-27-jslaby@suse.czSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

03b3b1a2 - tty: make tty_operations::write_room return uint

Wed, 05 May 2021 09:19:15 +0000

tty: make tty_operations::write_room return uintLine disciplines expect a positive value or zero returned fromtty->ops->write_room (invoked by tty_write_room). So make thisassumption explicit by using unsigned int as a return value. Both oftty->ops->write_room and tty_write_room.Signed-off-by: Jiri Slaby Acked-by: Laurentiu Tudor Acked-by: Alex Elder Acked-by: Max Filippov # xtensaAcked-by: David Sterba Acked-By: Anton Ivanov Acked-by: Geert Uytterhoeven Cc: Richard Henderson Cc: Ivan Kokshaysky Cc: Matt Turner Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: Jeff Dike Cc: Richard Weinberger Cc: Chris Zankel Cc: Arnd Bergmann Cc: Samuel Iglesias Gonsalvez Cc: Jens Taprogge Cc: Karsten Keil Cc: Scott Branden Cc: Ulf Hansson Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Christian Borntraeger Cc: David Lin Cc: Johan Hovold Cc: Jiri Kosina Cc: Shawn Guo Cc: Sascha Hauer Cc: Oliver Neukum Cc: Felipe Balbi Cc: Mathias Nyman Cc: Marcel Holtmann Cc: Johan Hedberg Cc: Luiz Augusto von Dentz Link: https://lore.kernel.org/r/20210505091928.22010-23-jslaby@suse.czSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c

6e94dbc7 - tty: cumulate and document tty_struct::flow* members

Wed, 05 May 2021 09:19:05 +0000

tty: cumulate and document tty_struct::flow* membersGroup the flow flags under a single struct called flow. The new structcontains 'stopped' and 'tco_stopped' bools which used to be bits in abitfield. The struct also contains the lock protecting them topotentially share the same cache line.Note that commit c545b66c6922b (tty: Serialize tcflow() with other ttyflow control changes) added a padding to the original bitfield. It wasfor the bitfield to occupy a whole 64b word to avoid interferring storeson Alpha (cannot we evaporate this arch with weird implications to Ccode yet?). But it doesn't work as expected as the padding(tty_struct::unused) is aligned to a 8B boundary too and occupies somebytes from the next word.So make it reliable by:1) setting __aligned of the struct -- that aligns the start, and2) making 'unsigned long unused[0]' as the last member of the struct -- pads the end.This is also the perfect time to start the documentation of tty_structwhere all this lives. So we start by documenting what these boolsactually serve for. And why we do all the alignment dances. Only the fewup-to-date information from the Theodore's comment made it into this newKerneldoc comment.Signed-off-by: Jiri Slaby Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Jonathan Corbet Cc: Arnd Bergmann Cc: Ulf Hansson Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Christian Borntraeger Cc: Shawn Guo Cc: Sascha Hauer Cc: Vineet Gupta Cc: "Maciej W. Rozycki" Link: https://lore.kernel.org/r/20210505091928.22010-13-jslaby@suse.czSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/moxa.c