Changes in amiserial.c

e70140ba - Get rid of 'remove_new' relic from platform driver struct

Sun, 01 Dec 2024 23:12:43 +0000

Get rid of 'remove_new' relic from platform driver structThe continual trickle of small conversion patches is grating on me, andis really not helping. Just get rid of the 'remove_new' memberfunction, which is just an alias for the plain 'remove', and had acomment to that effect: /* * .remove_new() is a relic from a prototype conversion of .remove(). * New drivers are supposed to implement .remove(). Once all drivers are * converted to not use .remove_new any more, it will be dropped. */This was just a tree-wide 'sed' script that replaced '.remove_new' with'.remove', with some care taken to turn a subsequent tab into two tabsto make things line up.I did do some minimal manual whitespace adjustment for places that usedspaces to line things up.Then I just removed the old (sic) .remove_new member function, and thisis the end result. No more unnecessary conversion noise.Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/tty/amiserial.c

f0a17485 - tty: add missing MODULE_DESCRIPTION() macros

Fri, 07 Jun 2024 23:10:20 +0000

tty: add missing MODULE_DESCRIPTION() macrosmake allmodconfig && make W=1 C=1 reports:WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/tty/serial/8250/8250_base.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/tty/serial/8250/8250_pxa.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/tty/serial/8250/serial_cs.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/tty/serial/esp32_uart.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/tty/serial/esp32_acm.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/tty/serial/owl-uart.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/tty/n_hdlc.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/tty/n_gsm.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/tty/ttynull.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/tty/goldfish.oAdd all missing invocations of the MODULE_DESCRIPTION() macro.Signed-off-by: Jeff Johnson Link: https://lore.kernel.org/r/20240607-md-drivers-tty-v1-1-50a7efb8bed8@quicinc.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

90135175 - serial: ami: Mark driver struct with __refdata to prevent section mismatch

Fri, 29 Mar 2024 21:54:40 +0000

serial: ami: Mark driver struct with __refdata to prevent section mismatchAs described in the added code comment, a reference to .exit.text is okfor drivers registered via module_platform_driver_probe(). Make thisexplicit to prevent the following section mismatch warning WARNING: modpost: drivers/tty/amiserial: section mismatch in reference: amiga_serial_driver+0x8 (section: .data) -> amiga_serial_remove (section: .exit.text)that triggers on an allmodconfig W=1 build.Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/043afcbc94ad90079301f3c7738136a7993a1748.1711748999.git.u.kleine-koenig@pengutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

d4c22ec3 - tty: amiserial: Convert to platform remove callback returning void

Sun, 18 Feb 2024 08:53:54 +0000

tty: amiserial: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is ignored (apartfrom emitting a warning) and this typically results in resource leaks.To improve here there is a quest to make the remove callback returnvoid. In the first step of this quest all drivers are converted to.remove_new(), which already returns void. Eventually after all driversare converted, .remove_new() will be renamed to .remove().Trivially convert this driver from always returning zero in the removecallback to the void returning variant.Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/f2ad92c97086c42dab23cdb165d9f978bbf3d3b5.1708246007.git.u.kleine-koenig@pengutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

fbdeead9 - tty: ami: use u8 for characters and flag

Wed, 06 Dec 2023 07:36:51 +0000

tty: ami: use u8 for characters and flagSwitch character types to u8. To conform to characters in the rest ofthe tty layer.Signed-off-by: "Jiri Slaby (SUSE)" Reviewed-by: Geert Uytterhoeven Link: https://lore.kernel.org/r/20231206073712.17776-7-jirislaby@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

3a00da02 - tty: make tty_operations::send_xchar accept u8 char

Wed, 06 Dec 2023 07:36:49 +0000

tty: make tty_operations::send_xchar accept u8 chartty_operations::send_xchar is one of the last users of 'char' type forcharacters in the tty layer. Convert it to u8 now.Signed-off-by: "Jiri Slaby (SUSE)" Cc: Karsten Keil Cc: Ulf Hansson Cc: Marcel Holtmann Cc: Johan Hedberg Cc: Luiz Augusto von Dentz Cc: netdev@vger.kernel.orgCc: linux-mmc@vger.kernel.orgCc: linux-bluetooth@vger.kernel.orgReviewed-by: Geert Uytterhoeven Link: https://lore.kernel.org/r/20231206073712.17776-5-jirislaby@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

73b2ed36 - tty: amiserial: use bool and rename overrun flag in receive_chars()

Tue, 21 Nov 2023 09:22:47 +0000

tty: amiserial: use bool and rename overrun flag in receive_chars()'oe' is a yes-no flag, switch it to boolean. And rename to overrun. Allfor the code to be more obvious.Signed-off-by: "Jiri Slaby (SUSE)" Link: https://lore.kernel.org/r/20231121092258.9334-7-jirislaby@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

c35e6ec1 - tty: amiserial: return from receive_chars() without goto

Tue, 21 Nov 2023 09:22:46 +0000

tty: amiserial: return from receive_chars() without gotoThe 'out' label is just before 'return'. So return immediately and dropboth the label and the return. This makes the code more straightforward.Signed-off-by: "Jiri Slaby (SUSE)" Link: https://lore.kernel.org/r/20231121092258.9334-6-jirislaby@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

95713967 - tty: make tty_operations::write()'s count size_t

Thu, 10 Aug 2023 09:15:03 +0000

tty: make tty_operations::write()'s count size_tUnify with the rest of the code. Use size_t for counts and ssize_t forretval.Signed-off-by: "Jiri Slaby (SUSE)" Link: https://lore.kernel.org/r/20230810091510.13006-30-jirislaby@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

dcaafbe6 - tty: propagate u8 data to tty_operations::put_char()

Thu, 10 Aug 2023 09:15:02 +0000

tty: propagate u8 data to tty_operations::put_char()Data are now typed as u8. Propagate this change totty_operations::put_char().Signed-off-by: "Jiri Slaby (SUSE)" Cc: Geert Uytterhoeven Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Alexander Gordeev Cc: Christian Borntraeger Cc: Sven Schnelle Cc: Karsten Keil Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: Mathias Nyman Link: https://lore.kernel.org/r/20230810091510.13006-29-jirislaby@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

69851e4a - tty: propagate u8 data to tty_operations::write()

Thu, 10 Aug 2023 09:15:01 +0000

tty: propagate u8 data to tty_operations::write()Data are now typed as u8. Propagate this change totty_operations::write().Signed-off-by: "Jiri Slaby (SUSE)" Cc: Richard Henderson Cc: Ivan Kokshaysky Cc: Matt Turner Cc: Geert Uytterhoeven Cc: Richard Weinberger Cc: Anton Ivanov Cc: Johannes Berg Cc: Chris Zankel Cc: Max Filippov Cc: Arnd Bergmann Cc: Vaibhav Gupta Cc: Jens Taprogge Cc: Karsten Keil Cc: Scott Branden Cc: Ulf Hansson Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Alexander Gordeev Cc: Christian Borntraeger Cc: Sven Schnelle Cc: David Lin Cc: Johan Hovold Cc: Alex Elder Cc: Laurentiu Tudor Cc: Jiri Kosina Cc: David Sterba Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: Arnaud Pouliquen Cc: Oliver Neukum Cc: Mathias Nyman Cc: Marcel Holtmann Cc: Johan Hedberg Cc: Luiz Augusto von Dentz Link: https://lore.kernel.org/r/20230810091510.13006-28-jirislaby@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

035173c9 - tty: Convert hw_stopped in tty_struct to bool

Thu, 09 Mar 2023 08:20:35 +0000

tty: Convert hw_stopped in tty_struct to boolhw_stopped in tty_struct is used like bool, convert the variable typeto bool.Signed-off-by: Ilpo Järvinen Acked-by: Ulf Hansson # For MMCLink: https://lore.kernel.org/r/20230309082035.14880-9-ilpo.jarvinen@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

5701cb8b - tty: Call ->dtr_rts() parameter active consistently

Tue, 17 Jan 2023 09:03:57 +0000

tty: Call ->dtr_rts() parameter active consistentlyConvert various parameter names for ->dtr_rts() and related functionsfrom onoff, on, and raise to active.Reviewed-by: Jiri Slaby Acked-by: Ulf Hansson # For MMCSigned-off-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20230117090358.4796-12-ilpo.jarvinen@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

5d420399 - tty: Convert ->dtr_rts() to take bool argument

Tue, 17 Jan 2023 09:03:53 +0000

tty: Convert ->dtr_rts() to take bool argumentConvert the raise/on parameter in ->dtr_rts() to bool through thecallchain. The parameter is used like bool. In USB serial, thereremains a few implicit bool -> larger type conversions because somedevices use u8 in their control messages.In moxa_tiocmget(), dtr variable was reused for line status whichrequires int so use a separate variable for status.Reviewed-by: Jiri Slaby Acked-by: Ulf Hansson # For MMCSigned-off-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20230117090358.4796-8-ilpo.jarvinen@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

b300fb26 - tty: Convert ->carrier_raised() and callchains to bool

Tue, 17 Jan 2023 09:03:52 +0000

tty: Convert ->carrier_raised() and callchains to boolReturn boolean from ->carrier_raised() instead of 0 and 1. Make thereturn type change also to tty_port_carrier_raised() that makes the->carrier_raised() call (+ cd variable in moxa into which its returnvalue is stored).Also cleans up a few unnecessary constructs related to this change: return xx ? 1 : 0; -> return xx; if (xx) return 1; return 0; -> return xx;Reviewed-by: Jiri Slaby Acked-by: Ulf Hansson # For MMCSigned-off-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20230117090358.4796-7-ilpo.jarvinen@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

9b5aa549 - tty: Cleanup tty_port_set_active() bool parameter

Tue, 17 Jan 2023 09:03:49 +0000

tty: Cleanup tty_port_set_active() bool parameterMake callers pass true/false consistently for bool val.Reviewed-by: Jiri Slaby Signed-off-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20230117090358.4796-4-ilpo.jarvinen@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

515be7ba - tty: Cleanup tty_port_set_initialized() bool parameter

Tue, 17 Jan 2023 09:03:47 +0000

tty: Cleanup tty_port_set_initialized() bool parameterMake callers pass true/false consistently for bool val.Reviewed-by: Samuel Iglesias Gonsalvez Reviewed-by: Jiri Slaby Signed-off-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20230117090358.4796-2-ilpo.jarvinen@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

a8c11c15 - tty: Make ->set_termios() old ktermios const

Tue, 16 Aug 2022 11:57:39 +0000

tty: Make ->set_termios() old ktermios constThere should be no reason to adjust old ktermios which is going to getdiscarded anyway.Reviewed-by: Andy Shevchenko Signed-off-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20220816115739.10928-9-ilpo.jarvinen@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

014482b6 - tty: amiserial: Fix comment typo

Fri, 15 Jul 2022 05:44:01 +0000

tty: amiserial: Fix comment typoThe double `should' is duplicated in line 15, remove one.Signed-off-by: Jason Wang Link: https://lore.kernel.org/r/20220715054401.9870-1-wangborong@cdjrlc.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c

eb47b59a - serial: Convert SERIAL_XMIT_SIZE to UART_XMIT_SIZE

Fri, 24 Jun 2022 20:54:23 +0000

serial: Convert SERIAL_XMIT_SIZE to UART_XMIT_SIZEBoth UART_XMIT_SIZE and SERIAL_XMIT_SIZE are defined. Make them allUART_XMIT_SIZE.Reviewed-by: Jiri Slaby Signed-off-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20220624205424.12686-6-ilpo.jarvinen@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/tty/amiserial.c