Changes in Kconfig

ff6ab055 - thunderbolt: Add receiver lane margining support for retimers

Tue, 21 Mar 2023 09:40:49 +0000

thunderbolt: Add receiver lane margining support for retimersRetimers support lane margining as well so make this available throughdebugfs in the same way as we do for the USB4 ports. When this isenabled we also expose retimers on the other side of the cable becausetypically margining is implemented only on direction towards the cable.However, for the retimers on the other side of the cable we do not allowNVM upgrade to avoid confusing the existing userspace (the same retimermay now appear twice with different name) and is probably not a goodidea anyway.Signed-off-by: Mika Westerberg List of files: /linux-6.15/drivers/thunderbolt/Kconfig

2b435067 - thunderbolt: Mention Thunderbolt/USB4 debugging tools in Kconfig

Tue, 23 Apr 2024 11:23:23 +0000

thunderbolt: Mention Thunderbolt/USB4 debugging tools in KconfigThis allows the interested parties to find the Thunderbolt/USB4debugging tools (aka tbtools) easier in case they need to look at theinformation under debugfs entries.Signed-off-by: Mika Westerberg Suggested-by: Mario Limonciello Reviewed-by: Mario Limonciello List of files: /linux-6.15/drivers/thunderbolt/Kconfig

d0f1e0c2 - thunderbolt: Add support for receiver lane margining

Tue, 22 Feb 2022 17:31:47 +0000

thunderbolt: Add support for receiver lane marginingUSB4 spec defines standard set of registers to be used for receiver lanemargining. This is useful for I/O interface quality and electricalrobustness validation during manufacturing. Expose receiver lanemargining through new debugfs directory "margining" that is added undereach connected USB4 port. Users can then run the margining by writing tothe exposed attributes under that directory.Signed-off-by: Mika Westerberg List of files: /linux-6.15/drivers/thunderbolt/Kconfig

793f55b2 - kunit: fix Kconfig for build-in tests USB4 and Nitro Enclaves

Wed, 10 Aug 2022 23:40:56 +0000

kunit: fix Kconfig for build-in tests USB4 and Nitro EnclavesBoth the USB4 and Nitro Enclaves KUNIT tests are now able to be compiledif KUNIT is compiled as a module. This leads to issues if KUNIT is beingpackaged separately from the core kernel and when KUNIT is run baremetalwithout the required driver compiled into the kernel.Fixes: 635dcd16844b ("thunderbolt: test: Use kunit_test_suite() macro")Fixes: fe5be808fa6c ("nitro_enclaves: test: Use kunit_test_suite() macro")Signed-off-by: Nico Pache Reviewed-by: David Gow Reviewed-by: Andra Paraschiv Acked-by: Brendan Higgins Signed-off-by: Shuah Khan List of files: /linux-6.15/drivers/thunderbolt/Kconfig

635dcd16 - thunderbolt: test: Use kunit_test_suite() macro

Sat, 09 Jul 2022 03:19:59 +0000

thunderbolt: test: Use kunit_test_suite() macroThe new implementation of kunit_test_suite() for modules no longerconflicts with module_init, so can now be used by the thunderbolt tests.Also update the Kconfig entry to enable the test when KUNIT_ALL_TESTS isenabled.This means that kunit_tool can now successfully run and parse the testresults with, for example: ./tools/testing/kunit/kunit.py run --arch=x86_64 \ --kconfig_add CONFIG_PCI=y --kconfig_add CONFIG_USB4=y \ 'thunderbolt'Acked-by: Mika Westerberg Acked-by: Daniel Latypov Acked-by: Brendan Higgins Signed-off-by: David Gow Signed-off-by: Shuah Khan List of files: /linux-6.15/drivers/thunderbolt/Kconfig

edc0f494 - thunderbolt: Add DMA traffic test driver

Thu, 24 Sep 2020 08:44:02 +0000

thunderbolt: Add DMA traffic test driverThis driver allows sending DMA traffic over XDomain connection.Specifically over a loopback connection using either a Thunderbolt/USB4cable that is connected back to the host router port, or a specialloopback dongle that has RX and TX lines crossed. This can be useful atmanufacturing floor to check whether Thunderbolt/USB4 ports arefunctional.The driver exposes debugfs directory under the XDomain service that canbe used to configure the driver, start the test and check the results.If a loopback dongle is used the steps to send and receive 1000 packetscan be done like: # modprobe thunderbolt_dma_test # echo 1000 > /sys/kernel/debug/thunderbolt//dma_test/packets_to_receive # echo 1000 > /sys/kernel/debug/thunderbolt//dma_test/packets_to_send # echo 1 > /sys/kernel/debug/thunderbolt//dma_test/test # cat /sys/kernel/debug/thunderbolt//dma_test/statusWhen a cable is connected back to host then there are two Thunderboltservices, one is configured for receiving (does not matter which one): # modprobe thunderbolt_dma_test # echo 1000 > /sys/kernel/debug/thunderbolt//dma_test/packets_to_receive # echo 1 > /sys/kernel/debug/thunderbolt//dma_test/testThe other one for sending: # echo 1000 > /sys/kernel/debug/thunderbolt//dma_test/packets_to_send # echo 1 > /sys/kernel/debug/thunderbolt//dma_test/testResults can be read from both services status attributes.Signed-off-by: Isaac Hazan Signed-off-by: Mika Westerberg Acked-by: Yehezkel Bernat Reviewed-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/thunderbolt/Kconfig

8eabfca5 - thunderbolt: Use "if USB4" instead of "depends on" in Kconfig

Mon, 24 Aug 2020 10:55:52 +0000

thunderbolt: Use "if USB4" instead of "depends on" in KconfigThis groups the USB4 options more nicely, and also does not require thatevery config option lists explicit depends on USB4.Signed-off-by: Mika Westerberg List of files: /linux-6.15/drivers/thunderbolt/Kconfig

2c6ea4e2 - thunderbolt: Allow KUnit tests to be built also when CONFIG_USB4=m

Mon, 24 Aug 2020 09:46:52 +0000

thunderbolt: Allow KUnit tests to be built also when CONFIG_USB4=mThis adds a bit more build coverage for the tests even though these arenot expected to be enabled by normal users and distros. In order to makethis working we need to open-code kunit_test_suite() and call therelevant functions directly in the driver init/exit hook.Signed-off-by: Mika Westerberg List of files: /linux-6.15/drivers/thunderbolt/Kconfig

54e41810 - thunderbolt: Add debugfs interface

Mon, 29 Jun 2020 17:30:52 +0000

thunderbolt: Add debugfs interfaceThis adds debugfs interface that can be used for debugging possibleissues in hardware/software. It exposes router and adapter config spacesthrough files like this: /sys/kernel/debug/thunderbolt//regs /sys/kernel/debug/thunderbolt///regs /sys/kernel/debug/thunderbolt///path /sys/kernel/debug/thunderbolt///counters /sys/kernel/debug/thunderbolt///regs /sys/kernel/debug/thunderbolt///path /sys/kernel/debug/thunderbolt///counters ...The "regs" is either the router or port configuration space registerdump. The "path" is the port path configuration space and "counters" isthe optional counters configuration space.These files contains one register per line so it should be easy to usenormal filtering tools to find the registers of interest if needed.The router and adapter regs file becomes writable whenCONFIG_USB4_DEBUGFS_WRITE is enabled (which is not supposed to be donein production systems) and in this case the developer can write "offsetvalue" lines there to modify the hardware directly. For convenience thisalso supports the long format the read side produces (but ignores theadditional fields). The counters file can be written even whenCONFIG_USB4_DEBUGFS_WRITE is not enabled and it is only used to clearthe counter values.Signed-off-by: Gil Fine Signed-off-by: Mika Westerberg Reviewed-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/thunderbolt/Kconfig

54509f50 - thunderbolt: Add KUnit tests for path walking

Wed, 29 Apr 2020 13:38:39 +0000

thunderbolt: Add KUnit tests for path walkingThis adds KUnit tests for path walking which is only dependent onsoftware structures, so no hardware is needed to run these.We make these available only when both KUnit and the driver itself arebuilt into the kernel image. The reason for this is that KUnit adds itsown module_init() call in kunit_test_suite() which generates linkererror because the driver does the same in nhi.c. This should be fine fornow because these tests are only meant to run by developers anyway.Signed-off-by: Mika Westerberg List of files: /linux-6.15/drivers/thunderbolt/Kconfig

b7c408a5 - thunderbolt: Improve USB4 config symbol help text

Tue, 02 Jun 2020 12:28:15 +0000

thunderbolt: Improve USB4 config symbol help textFix the spelling of "specification", and add a missing "the" article.Signed-off-by: Geert Uytterhoeven Signed-off-by: Mika Westerberg List of files: /linux-6.15/drivers/thunderbolt/Kconfig

eb4a6de4 - thunderbolt: Update Kconfig to allow building on other architectures.

Mon, 11 May 2020 20:36:23 +0000

thunderbolt: Update Kconfig to allow building on other architectures.Thunderbolt 3 and USB4 shouldn't be x86 only.Tested on a SolidRun HoneyComb (ARM Cortex-A72) with aGigabyte Titan Ridge Thunderbolt 3 PCIe card (JHL7540).Signed-off-by: David Manouchehri Signed-off-by: Mika Westerberg List of files: /linux-6.15/drivers/thunderbolt/Kconfig

690ac0d2 - thunderbolt: Update Kconfig entries to USB4

Tue, 17 Dec 2019 12:33:41 +0000

thunderbolt: Update Kconfig entries to USB4Since the driver now supports USB4 which is the standard going forward,update the Kconfig entry to mention this and rename the entry fromCONFIG_THUNDERBOLT to CONFIG_USB4 instead to help people to find thecorrect option if they want to enable USB4.Also do the same for Thunderbolt network driver.Signed-off-by: Mika Westerberg Cc: David S. Miller Link: https://lore.kernel.org/r/20191217123345.31850-6-mika.westerberg@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/thunderbolt/Kconfig

ec8f24b7 - treewide: Add SPDX license identifier - Makefile/Kconfig

Sun, 19 May 2019 12:07:45 +0000

treewide: Add SPDX license identifier - Makefile/KconfigAdd SPDX license identifiers to all Make/Kconfig files which: - Have no license information of any formThese files fall under the project license, GPL v2 only. The resulting SPDXlicense identifier is: GPL-2.0-onlySigned-off-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/thunderbolt/Kconfig

e6b245cc - thunderbolt: Add support for host and device NVM firmware upgrade

Tue, 06 Jun 2017 12:25:17 +0000

thunderbolt: Add support for host and device NVM firmware upgradeStarting from Intel Falcon Ridge the NVM firmware can be upgraded byusing DMA configuration based mailbox commands. If we detect that thehost or device (device support starts from Intel Alpine Ridge) has theDMA configuration based mailbox we expose NVM information to theuserspace as two separate Linux NVMem devices: nvm_active andnvm_non_active. The former is read-only portion of the active NVM whichfirmware upgrade tools can be use to find out suitable NVM image if thedevice identification strings are not enough.The latter is write-only portion where the new NVM image is to bewritten by the userspace. It is up to the userspace to find out rightNVM image (the kernel does very minimal validation). The ICM firmwareitself authenticates the new NVM firmware and fails the operation if itis not what is expected.We also expose two new sysfs files per each switch: nvm_version andnvm_authenticate which can be used to read the active NVM version andstart the upgrade process.We also introduce safe mode which is the mode a switch goes when it doesnot have properly authenticated firmware. In this mode the switch onlyaccepts a couple of commands including flashing a new NVM firmware imageand triggering power cycle.This code is based on the work done by Amir Levy and Michael Jamet.Signed-off-by: Michael Jamet Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Andy Shevchenko Signed-off-by: Andreas Noever Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/thunderbolt/Kconfig

f67cf491 - thunderbolt: Add support for Internal Connection Manager (ICM)

Tue, 06 Jun 2017 12:25:16 +0000

thunderbolt: Add support for Internal Connection Manager (ICM)Starting from Intel Falcon Ridge the internal connection manager runningon the Thunderbolt host controller has been supporting 4 securitylevels. One reason for this is to prevent DMA attacks and only allowconnecting devices the user trusts.The internal connection manager (ICM) is the preferred way of connectingThunderbolt devices over software only implementation typically used onMacs. The driver communicates with ICM using special Thunderbolt ring 0(control channel) messages. In order to handle these messages we addsupport for the ICM messages to the control channel.The security levels are as follows: none - No security, all tunnels are created automatically user - User needs to approve the device before tunnels are created secure - User need to approve the device before tunnels are created. The device is sent a challenge on future connects to be able to verify it is actually the approved device. dponly - Only Display Port and USB tunnels can be created and those are created automatically.The security levels are typically configurable from the system BIOS andby default it is set to "user" on many systems.In this patch each Thunderbolt device will have either one or two newsysfs attributes: authorized and key. The latter appears for devicesthat support secure connect.In order to identify the device the user can read identicationinformation, including UUID and name of the device from sysfs and basedon that make a decision to authorize the device. The device isauthorized by simply writing 1 to the "authorized" sysfs attribute. Thisis following the USB bus device authorization mechanism. The secureconnect requires an additional challenge step (writing 2 to the"authorized" attribute) in future connects when the key has already beenstored to the NVM of the device.Non-ICM systems (before Alpine Ridge) continue to use the existingfunctionality and the security level is set to none. For systems withAlpine Ridge, even on Apple hardware, we will use ICM.This code is based on the work done by Amir Levy and Michael Jamet.Signed-off-by: Michael Jamet Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Andy Shevchenko Signed-off-by: Andreas Noever Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/thunderbolt/Kconfig

b2c74191 - thunderbolt: Compile on x86 only

Fri, 18 Nov 2016 08:22:59 +0000

thunderbolt: Compile on x86 onlySo far Thunderbolt is (unfortunately) an Intel proprietary technologythat is only available on x86, so compiling on other arches is pointlessexcept for testing purposes. Amend Kconfig accordingly.Suggested-by: Arnd Bergmann Signed-off-by: Lukas Wunner Acked-by: Arnd Bergmann Cc: Andreas Noever Cc: Ard Biesheuvel Cc: Linus Torvalds Cc: Matt Fleming Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-efi@vger.kernel.orgLink: http://lkml.kernel.org/r/7dfda728d3ee8a33c80c49b224da7359c6015eea.1479456179.git.lukas@wunner.deSigned-off-by: Ingo Molnar List of files: /linux-6.15/drivers/thunderbolt/Kconfig

5fbc89d3 - thunderbolt, efi: Fix Kconfig dependencies harder

Fri, 18 Nov 2016 08:22:59 +0000

thunderbolt, efi: Fix Kconfig dependencies harderSince commit c9cc3aaa0281 ("thunderbolt: Use Device ROM retrieved fromEFI"), the THUNDERBOLT config option selects APPLE_PROPERTIES.This broke the build for certain configs because APPLE_PROPERTIES islocated in a menu which depends on EFI: If EFI is not enabled, theprerequisites needed for APPLE_PROPERTIES are not selected: Those areEFI_DEV_PATH_PARSER and UCS2_STRING. Additionally EFI_DEV_PATH_PARSERwon't compile unless ACPI is enabled.Commit 79f9cd35b05e ("thunderbolt, efi: Fix Kconfig dependencies")sought to fix the breakage by making THUNDERBOLT select APPLE_PROPERTIESonly if EFI_STUB is enabled. On x86, EFI_STUB depends on EFI and EFIdepends on ACPI, so this fixed the build at least on this architecture.However on arm and arm64, EFI_STUB does not depend on EFI, so once againthe prerequisites needed for APPLE_PROPERTIES are not selected.Additionally ACPI is not available on arm and optional on arm64,therefore EFI_DEV_PATH_PARSER won't compile.Fix by selecting APPLE_PROPERTIES only on x86.Suggested-by: Arnd Bergmann Signed-off-by: Lukas Wunner Acked-by: Arnd Bergmann Cc: Andreas Noever Cc: Ard Biesheuvel Cc: Linus Torvalds Cc: Matt Fleming Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-efi@vger.kernel.orgLink: http://lkml.kernel.org/r/5c241cf92eb1dc2421218c1204c6a9d22c9f847b.1479456179.git.lukas@wunner.deSigned-off-by: Ingo Molnar List of files: /linux-6.15/drivers/thunderbolt/Kconfig

79f9cd35 - thunderbolt, efi: Fix Kconfig dependencies

Mon, 14 Nov 2016 15:10:33 +0000

thunderbolt, efi: Fix Kconfig dependenciesFix this EFI build failure on certain (rand)configs: drivers/firmware/efi/apple-properties.c:149:9: error: implicit declaration of function ???efi_get_device_by_path??? [-Werror=implicit-function-declaration]which is due to: warning: (THUNDERBOLT) selects APPLE_PROPERTIES which has unmet direct dependencies (EFI && EFI_STUB && X86)Signed-off-by: Lukas Wunner Cc: Andreas Noever Cc: Ard Biesheuvel Cc: Linus Torvalds Cc: Matt Fleming Cc: Pedro Vilaça Cc: Peter Jones Cc: Peter Zijlstra Cc: Pierre Moreau [MacBookPro11,3]Cc: Thomas Gleixner Cc: linux-efi@vger.kernel.orgLink: http://lkml.kernel.org/r/20161114151033.GA10141@wunner.deSigned-off-by: Ingo Molnar List of files: /linux-6.15/drivers/thunderbolt/Kconfig

c9cc3aaa - thunderbolt: Use Device ROM retrieved from EFI

Sat, 12 Nov 2016 21:32:37 +0000

thunderbolt: Use Device ROM retrieved from EFIMacs with Thunderbolt 1 do not have a unit-specific DROM: The DROM isempty with uid 0x1000000000000. (Apple started factory-burning a unit-specific DROM with Thunderbolt 2.)Instead, the NHI EFI driver supplies a DROM in a device property. Useit if available. It's only available when booting with the efistub.If it's not available, silently fall back to our hardcoded DROM.The size of the DROM is always 256 bytes. The number is hardcoded intothe NHI EFI driver. This commit can deal with an arbitrary size however,just in case they ever change that.Background information: The EFI firmware volume contains ROM files forthe NHI, GMUX and several other chips as well as key material. Thisstrategy allows Apple to deploy ROM or key updates by simply publishingan EFI firmware update on their website. Drivers do not access thosefiles directly but rather through a file server via EFI protocolAC5E4829-A8FD-440B-AF33-9FFE013B12D8. Files are identified by GUID, theNHI DROM has 339370BD-CFC6-4454-8EF7-704653120818.The NHI EFI driver amends that file with a unit-specific uid. The uidhas 64 bit but its entropy is much lower: 24 bit represent the model,24 bit are taken from a serial number, 16 bit are fixed. The NHI EFIdriver obtains the serial number via the DataHub protocol, copies itinto the DROM, calculates the CRC and submits the result as a deviceproperty.A modification is needed in the resume code where we currently read theuid of all switches in the hierarchy to detect plug events that occurredduring sleep. On Thunderbolt 1 root switches this will now lead to amismatch between the uid of the empty DROM and the EFI DROM. Exempt theroot switch from this check: It's built in, so the uid should neverchange. However we continue to *read* the uid of the root switch, thisseems like a good way to test its reachability after resume.Tested-by: Lukas Wunner [MacBookPro9,1]Tested-by: Pierre Moreau [MacBookPro11,3]Signed-off-by: Lukas Wunner Signed-off-by: Matt Fleming Acked-by: Andreas Noever Cc: Ard Biesheuvel Cc: Linus Torvalds Cc: Pedro Vilaça Cc: Peter Jones Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-efi@vger.kernel.orgLink: http://lkml.kernel.org/r/20161112213237.8804-10-matt@codeblueprint.co.ukSigned-off-by: Ingo Molnar List of files: /linux-6.15/drivers/thunderbolt/Kconfig