Changes in Makefile

e84a3bf7 - staging: gpib: Fix allyesconfig build failures

Tue, 17 Dec 2024 15:19:04 +0000

staging: gpib: Fix allyesconfig build failuresMy tests run an allyesconfig build and it failed with the following errors: LD [M] samples/kfifo/dma-example.ko ld.lld: error: undefined symbol: nec7210_board_reset ld.lld: error: undefined symbol: nec7210_read ld.lld: error: undefined symbol: nec7210_writeIt appears that some modules call the function nec7210_board_reset()that is defined in nec7210.c. In an allyesconfig build, these othermodules are built in. But the file that holds nec7210_board_reset()has: obj-m += nec7210.oWhere that "-m" means it only gets built as a module. With the othermodules built in, they have no access to nec7210_board_reset() and the buildfails.This isn't the only function. After fixing that one, I hit another: ld.lld: error: undefined symbol: push_gpib_event ld.lld: error: undefined symbol: gpib_match_device_pathWhere push_gpib_event() was also used outside of the file it was definedin, and that file too only was built as a module.Since the directory that nec7210.c is only traversed whenCONFIG_GPIB_NEC7210 is set, and the directory with gpib_common.c is onlytraversed when CONFIG_GPIB_COMMON is set, use those configs as theoption to build those modules. When it is an allyesconfig, then theywill both be built in and their functions will be available to the othermodules that are also built in.Fixes: 3ba84ac69b53e ("staging: gpib: Add nec7210 GPIB chip driver")Fixes: 9dde4559e9395 ("staging: gpib: Add GPIB common core driver")Signed-off-by: Steven Rostedt (Google) Reviewed-by: Palmer Dabbelt Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/staging/gpib/common/Makefile

79d2e191 - staging: gpib: fix Makefiles

Thu, 12 Dec 2024 15:42:35 +0000

staging: gpib: fix MakefilesHaving gpib drivers built-in rather than as loadable modules causeslink failure because the drivers are never actually built:arm-linux-gnueabi-ld: drivers/staging/gpib/fmh_gpib/fmh_gpib.o: in function `fmh_gpib_t1_delay':fmh_gpib.c:(.text+0x3b0): undefined reference to `nec7210_t1_delay'arm-linux-gnueabi-ld: drivers/staging/gpib/fmh_gpib/fmh_gpib.o: in function `fmh_gpib_serial_poll_status':fmh_gpib.c:(.text+0x418): undefined reference to `nec7210_serial_poll_status'arm-linux-gnueabi-ld: drivers/staging/gpib/fmh_gpib/fmh_gpib.o: in function `fmh_gpib_secondary_address':fmh_gpib.c:(.text+0x57c): undefined reference to `nec7210_secondary_address'arm-linux-gnueabi-ld: drivers/staging/gpib/fmh_gpib/fmh_gpib.o: in function `fmh_gpib_primary_address':fmh_gpib.c:(.text+0x5ac): undefined reference to `nec7210_primary_address'Change this to use the correct Makefile syntax, setting either obj-m or obj-y.Signed-off-by: Arnd Bergmann Link: https://lore.kernel.org/r/20241212154245.1411411-2-arnd@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/staging/gpib/common/Makefile

9dde4559 - staging: gpib: Add GPIB common core driver

Wed, 18 Sep 2024 12:18:52 +0000

staging: gpib: Add GPIB common core driverThis is the common core driver that interfaces with the userland codeand creates the gpib device files.Signed-off-by: Dave Penkler Link: https://lore.kernel.org/r/20240918121908.19366-6-dpenkler@gmail.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/staging/gpib/common/Makefile