Changes in spi-loopback-test.c

a73fa369 - spi: loopback-test: Do not split 1024-byte hexdumps

Fri, 02 May 2025 11:10:35 +0000

spi: loopback-test: Do not split 1024-byte hexdumpsspi_test_print_hex_dump() prints buffers holding less than 1024 bytes infull. Larger buffers are truncated: only the first 512 and the last 512bytes are printed, separated by a truncation message. The latter isconfusing in case the buffer holds exactly 1024 bytes, as all data isprinted anyway.Fix this by printing buffers holding up to and including 1024 bytes infull.Fixes: 84e0c4e5e2c4ef42 ("spi: add loopback test driver to allow for spi_master regression tests")Signed-off-by: Geert Uytterhoeven Link: https://patch.msgid.link/37ee1bc90c6554c9347040adabf04188c8f704aa.1746184171.git.geert+renesas@glider.beSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

f04cff14 - spi: loopback-test: drop driver owner assignment

Wed, 27 Mar 2024 17:47:35 +0000

spi: loopback-test: drop driver owner assignmentCore in spi_register_driver() already sets the .owner, so driverdoes not need to.Signed-off-by: Krzysztof Kozlowski Link: https://msgid.link/r/20240327174737.519637-1-krzysztof.kozlowski@linaro.orgSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

2c2310c1 - spi: loopback-test: Follow renaming of SPI "master" to "controller"

Wed, 07 Feb 2024 18:40:35 +0000

spi: loopback-test: Follow renaming of SPI "master" to "controller"In commit 8caab75fd2c2 ("spi: Generalize SPI "master" to "controller"")some functions and struct members were renamed. To not break all driverscompatibility macros were provided.To be able to remove these compatibility macros push the renaming intothis driver.Acked-by: Jonathan Cameron Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/2f57c89d601d0875cd245a2e95c915b9bfcfc47d.1707324794.git.u.kleine-koenig@pengutronix.deSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

749396cb - spi: Explicitly include correct DT includes

Fri, 14 Jul 2023 17:49:52 +0000

spi: Explicitly include correct DT includesThe DT of_device.h and of_platform.h date back to the separateof_platform_bus_type before it as merged into the regular platform bus.As part of that merge prepping Arm DT support 13 years ago, they"temporarily" include each other. They also include platform_device.hand of.h. As a result, there's a pretty much random mix of those includefiles used throughout the tree. In order to detangle these headers andreplace the implicit includes with struct declarations, users need toexplicitly include the correct includes.Signed-off-by: Rob Herring Link: https://lore.kernel.org/r/20230714174955.4064174-1-robh@kernel.orgSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

6d87552c - spi: spi-loopback-test: Add module param for iteration length

Wed, 12 Apr 2023 20:20:09 +0000

spi: spi-loopback-test: Add module param for iteration lengthSPI test framework is designed to run each test case fora list of lengths.Introduce a module parameter to limit the iterationsto a single value among the list of lengths.Signed-off-by: Rohit Ner Link: https://lore.kernel.org/r/20230412202009.3750955-2-rohitner@google.comSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

392af84b - spi: spi-loopback-test: Allow skipping delays

Tue, 03 Jan 2023 15:22:10 +0000

spi: spi-loopback-test: Allow skipping delaysA 100 ms delay is inserted between tests by default in order to "detectthe individual tests when using a logic analyzer". However, such delaysare unnecessary when using this module for automated regression testing,so allow them to be disabled with a module parameter.Signed-off-by: Vincent Whitchurch Link: https://lore.kernel.org/r/20230103152211.3034779-1-vincent.whitchurch@axis.comSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

b85ad8a5 - spi: spi-loopback-test: Add test to trigger DMA/PIO mixing

Fri, 16 Sep 2022 11:39:48 +0000

spi: spi-loopback-test: Add test to trigger DMA/PIO mixingAdd a test where a small and a large transfer in a message hit the samecache line. This test currently fails on spi-s3c64xx on in DMA modesince it ends up mixing DMA and PIO without proper cache maintenance.Signed-off-by: Vincent Whitchurch Link: https://lore.kernel.org/r/20220916113951.228398-2-vincent.whitchurch@axis.comSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

9e37a3ab - spi: spi-loopback-test: Fix 'tx_buf' might be 'rx_buf'

Mon, 10 May 2021 06:58:23 +0000

spi: spi-loopback-test: Fix 'tx_buf' might be 'rx_buf'In function 'spi_test_run_iter': Value 'tx_buf' might be 'rx_buf'.Signed-off-by: Jay Fang Link: https://lore.kernel.org/r/1620629903-15493-5-git-send-email-f.fangjian@huawei.comSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

4f0f586b - treewide: Change list_sort to use const pointers

Thu, 08 Apr 2021 18:28:34 +0000

treewide: Change list_sort to use const pointerslist_sort() internally casts the comparison function passed to itto a different type with constant struct list_head pointers, anduses this pointer to call the functions, which trips indirect callControl-Flow Integrity (CFI) checking.Instead of removing the consts, this change defines thelist_cmp_func_t type and changes the comparison function types ofall list_sort() callers to use const pointers, thus avoiding typemismatches.Suggested-by: Nick Desaulniers Signed-off-by: Sami Tolvanen Reviewed-by: Nick Desaulniers Reviewed-by: Christoph Hellwig Reviewed-by: Kees Cook Tested-by: Nick Desaulniers Tested-by: Nathan Chancellor Signed-off-by: Kees Cook Link: https://lore.kernel.org/r/20210408182843.1754385-10-samitolvanen@google.com List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

837ba18d - spi: spi-loopback-test: Fix out-of-bounds read

Wed, 02 Sep 2020 13:23:41 +0000

spi: spi-loopback-test: Fix out-of-bounds readThe "tx/rx-transfer - crossing PAGE_SIZE" test always fails whenlen=131071 and rx_offset >= 5: spi-loopback-test spi0.0: Running test tx/rx-transfer - crossing PAGE_SIZE ... with iteration values: len = 131071, tx_off = 0, rx_off = 3 with iteration values: len = 131071, tx_off = 0, rx_off = 4 with iteration values: len = 131071, tx_off = 0, rx_off = 5 loopback strangeness - rx changed outside of allowed range at: ...a4321000 spi_msg@ffffffd5a4157690 frame_length: 131071 actual_length: 131071 spi_transfer@ffffffd5a41576f8 len: 131071 tx_buf: ffffffd5a4340ffcNote that rx_offset > 3 can only occur if the SPI controller driver sets->dma_alignment to a higher value than 4, so most SPI controller driversare not affect.The allocated Rx buffer is of size SPI_TEST_MAX_SIZE_PLUS, which is 132KiB (assuming 4 KiB pages). This test uses an initial offset into therx_buf of PAGE_SIZE - 4, and a len of 131071, so the range expected tobe written in this transfer ends at (4096 - 4) + 5 + 131071 == 132 KiB,which is also the end of the allocated buffer. But the code whichverifies the content of the buffer reads a byte beyond the allocatedbuffer and spuriously fails because this out-of-bounds read doesn'treturn the expected value.Fix this by using ITERATE_LEN instead of ITERATE_MAX_LEN to avoidtesting sizes which cause out-of-bounds reads.Signed-off-by: Vincent Whitchurch Link: https://lore.kernel.org/r/20200902132341.7079-1-vincent.whitchurch@axis.comSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

055fe5f4 - spi: spi-loopback-test: Fix formatting issues in function header blocks

Fri, 17 Jul 2020 13:54:11 +0000

spi: spi-loopback-test: Fix formatting issues in function header blocksKerneldoc function parameter descriptions must be in '@.*: ' format.Fixes the following W=1 kernel build warning(s): drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'spi' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'test' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'tx' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'rx' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'spi' not described in 'spi_test_run_test' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'test' not described in 'spi_test_run_test' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'tx' not described in 'spi_test_run_test' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'rx' not described in 'spi_test_run_test'Signed-off-by: Lee Jones Cc: Mark Brown Cc: Martin Sperl Cc: linux-spi@vger.kernel.orgLink: https://lore.kernel.org/r/20200717135424.2442271-2-lee.jones@linaro.orgSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

867bd886 - spi: spi-loopback-test: use new `delay` field

Thu, 26 Sep 2019 10:51:40 +0000

spi: spi-loopback-test: use new `delay` fieldThis change replaces the use of the `delay_usecs` field with the new`delay` field. The code/test still uses micro-seconds, but they are nowconfigured and used via the `struct spi_delay` format of the `delay` field.Signed-off-by: Alexandru Ardelean Link: https://lore.kernel.org/r/20190926105147.7839-13-alexandru.ardelean@analog.comSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

c942fddf - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157

Mon, 27 May 2019 06:55:06 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157Based on 3 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later version this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more details this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later version [author] [kishon] [vijay] [abraham] [i] [kishon]@[ti] [com] this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more details this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later version [author] [graeme] [gregory] [gg]@[slimlogic] [co] [uk] [author] [kishon] [vijay] [abraham] [i] [kishon]@[ti] [com] [based] [on] [twl6030]_[usb] [c] [author] [hema] [hk] [hemahk]@[ti] [com] this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more detailsextracted by the scancode license scanner the SPDX license identifier GPL-2.0-or-laterhas been chosen to replace the boilerplate/reference in 1105 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Allison Randal Reviewed-by: Richard Fontana Reviewed-by: Kate Stewart Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190527070033.202006027@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

8bc85a87 - spi: loopback-test: implement testing with no CS

Tue, 25 Jul 2017 07:57:08 +0000

spi: loopback-test: implement testing with no CSTo run spi-loopback-tests on HW without modifications, we need todisable Chip Select. This should avoid surprising side effects forSPI devices by testing patterns.Signed-off-by: Oleksij Rempel Signed-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

59a8831d - spi: loopback-test: make several module parameters static

Tue, 18 Jul 2017 12:42:32 +0000

spi: loopback-test: make several module parameters staticSeveral module parameters are local to the source, so make themstatic. Cleans up several sparse warnings such as:"symbol 'loop_req' was not declared. Should it be static?"Signed-off-by: Colin Ian King Signed-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

f12a616e - spi: loopback-test: provide loop_req option.

Fri, 14 Jul 2017 09:42:46 +0000

spi: loopback-test: provide loop_req option.Provide a module parameter to request internal loop by the SPI mastercontroller.This should make loop testing easier without extra HW modification.For test automation a logic analyzer is recommended for hostcontroller-independent verification.An example test rig configuration and procedure: i.MX6S RIoRBoard Logic Analyzer ----------------------------------------- (J13 4) GND ------------- GND (J13 6) CSPI3-CLK ------> PIN 3 (J13 8) CSPI3-MOSI <----- PIN 2 ^ - internal loop configured by SPI_LOOP | or can be user external jamper. (J13 10) CSPI3-MISO -----> PIN 1grab some data and decode it:sigrok-cli -d fx2lafw --time 160000 --config samplerate=10m \ --channels 0-2 -o dump.srsigrok-cli -i dump.sr -P spi:mosi=1:clk=2 > result_for_regression_testsSigned-off-by: Oleksij Rempel Signed-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

704c3098 - spi: loopback-test: Fix kfree() NULL pointer error.

Tue, 20 Jun 2017 09:30:53 +0000

spi: loopback-test: Fix kfree() NULL pointer error.Here, rx/tx allocation can fail. So avoid kvfree callwith NULL pointer.Signed-off-by: Arvind Yadav Signed-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

478de2ba - spi: loopback-test: fix spelling mistake: "reruning" -> "rerunning"

Mon, 26 Jun 2017 13:42:31 +0000

spi: loopback-test: fix spelling mistake: "reruning" -> "rerunning"trivial fix to spelling mistake in dev_info error messageSigned-off-by: Colin Ian King Signed-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

905e0b5e - spi: loopback-test: fix spelling mistake: "minimam" -> "minimum"

Thu, 30 Mar 2017 10:01:25 +0000

spi: loopback-test: fix spelling mistake: "minimam" -> "minimum"trivial fix to spelling mistake in dev_err error messageSigned-off-by: Colin Ian King Signed-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c

d2c14c64 - spi: loopback-test: fix potential integer overflow on multiple

Mon, 20 Mar 2017 13:58:05 +0000

spi: loopback-test: fix potential integer overflow on multipleA multiplication of 8U * xfer-len with the type of a 32 bit unsigned intis evaluated using 32 bit arithmetic and then used in a context thatexpects an expression of type unsigned long long (64 bits). Avoid anypotential overflow by casting BITS_PER_BYTE to unsigned long long.Detected by CoverityScan, CID#1419691 ("Unintentional integer overflow")Fixes: ea9936f324356 ("spi: loopback-test: add elapsed time check")Signed-off-by: Colin Ian King Signed-off-by: Mark Brown List of files: /linux-6.15/drivers/spi/spi-loopback-test.c