Changes in slave.c

aac2f836 - soundwire: slave: fix an OF node reference leak in soundwire slave device

Thu, 05 Dec 2024 03:48:44 +0000

soundwire: slave: fix an OF node reference leak in soundwire slave deviceWhen initializing a soundwire slave device, an OF node is stored to thedevice with refcount incremented. However, the refcount is notdecremented in .release(), thus call of_node_put() insdw_slave_release().Fixes: a2e484585ad3 ("soundwire: core: add device tree support for slave devices")Signed-off-by: Joe Hattori Reviewed-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20241205034844.2784964-1-joe@pf.is.s.u-tokyo.ac.jpSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/soundwire/slave.c

cdd30ebb - module: Convert symbol namespace to string literal

Mon, 02 Dec 2024 14:59:47 +0000

module: Convert symbol namespace to string literalClean up the existing export namespace code along the same lines ofcommit 33def8498fdd ("treewide: Convert macro and uses of __section(foo)to __section("foo")") and for the same reason, it is not desired for thenamespace argument to be a macro expansion itself.Scripted using git grep -l -e MODULE_IMPORT_NS -e EXPORT_SYMBOL_NS | while read file; do awk -i inplace ' /^#define EXPORT_SYMBOL_NS/ { gsub(/__stringify$ns$/, "ns"); print; next; } /^#define MODULE_IMPORT_NS/ { gsub(/__stringify$ns$/, "ns"); print; next; } /MODULE_IMPORT_NS/ { $0 = gensub(/MODULE_IMPORT_NS$([^)]*)$/, "MODULE_IMPORT_NS(\"\\1\")", "g"); } /EXPORT_SYMBOL_NS/ { if ($0 ~ /(EXPORT_SYMBOL_NS[^(]*)$([^,]+),/) { if ($0 !~ /(EXPORT_SYMBOL_NS[^(]*)\(([^,]+), ([^)]+)$/ && $0 !~ /(EXPORT_SYMBOL_NS[^(]*)/ && $0 !~ /^my/) { getline line; gsub(/[[:space:]]*\\$/, ""); gsub(/[[:space:]]/, "", line); $0 = $0 " " line; } $0 = gensub(/(EXPORT_SYMBOL_NS[^(]*)$([^,]+), ([^)]+)$/, "\\1(\\2, \"\\3\")", "g"); } } { print }' $file; doneRequested-by: Masahiro Yamada Signed-off-by: Peter Zijlstra (Intel) Link: https://mail.google.com/mail/u/2/#inbox/FMfcgzQXKWgMmjdFwwdsfgxzKpVHWPlcAcked-by: Greg KH Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/soundwire/slave.c

0c673d28 - soundwire: slave: lookup SDCA version and functions

Wed, 16 Oct 2024 10:23:26 +0000

soundwire: slave: lookup SDCA version and functionsUse SDCA helpers to get the basic information and store it in theslave context. The information will be optionally be used in codecdrivers to register sub-devices for each Function.When platforms are not based on ACPI the helpers do absolutelynothing.Signed-off-by: Pierre-Louis Bossart Reviewed-by: Péter Ujfalusi Signed-off-by: Bard Liao Acked-by: Vinod Koul Link: https://patch.msgid.link/20241016102333.294448-5-yung-chuan.liao@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/soundwire/slave.c

b6212f9b - soundwire: slave: simplify code with acpi_get_local_u64_address()

Tue, 28 May 2024 19:29:34 +0000

soundwire: slave: simplify code with acpi_get_local_u64_address()Now we have a helper so there's no need to open-code.Signed-off-by: Pierre-Louis Bossart Reviewed-by: Péter Ujfalusi Reviewed-by: Bard Liao Acked-by: Vinod Koul Reviewed-by: Takashi Iwai Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20240528192936.16180-3-pierre-louis.bossart@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/soundwire/slave.c

99fea943 - soundwire: constify the struct device_type usage

Mon, 19 Feb 2024 12:14:36 +0000

soundwire: constify the struct device_type usageSince commit aed65af1cc2f ("drivers: make device_type const"), the drivercore can properly handle constant struct device_type. Move thesdw_master_type and sdw_slave_type variables to be constant structures aswell, placing it into read-only memory which can not be modified atruntime.Cc: Greg Kroah-Hartman Signed-off-by: "Ricardo B. Marliere" Link: https://lore.kernel.org/r/20240219-device_cleanup-soundwire-v1-1-9edd51767611@marliere.netSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/soundwire/slave.c

8a8a9ac8 - soundwire: fix initializing sysfs for same devices on different buses

Tue, 17 Oct 2023 16:09:33 +0000

soundwire: fix initializing sysfs for same devices on different busesIf same devices with same device IDs are present on different soundwirebuses, the probe fails due to conflicting device names and sysfsentries: sysfs: cannot create duplicate filename '/bus/soundwire/devices/sdw:0:0217:0204:00:0'The link ID is 0 for both devices, so they should be differentiated bythe controller ID. Add the controller ID so, the device names and sysfs entries looklike: sdw:1:0:0217:0204:00:0 -> ../../../devices/platform/soc@0/6ab0000.soundwire-controller/sdw-master-1-0/sdw:1:0:0217:0204:00:0 sdw:3:0:0217:0204:00:0 -> ../../../devices/platform/soc@0/6b10000.soundwire-controller/sdw-master-3-0/sdw:3:0:0217:0204:00:0[PLB changes: use bus->controller_id instead of bus->id]Fixes: 7c3cd189b86d ("soundwire: Add Master registration")Cc: stable@vger.kernel.orgReviewed-by: Bard Liao Reviewed-by: Vijendar Mukunda Co-developed-by: Pierre-Louis Bossart Signed-off-by: Pierre-Louis Bossart Signed-off-by: Krzysztof Kozlowski Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Acked-by: Mark Brown Tested-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20231017160933.12624-3-pierre-louis.bossart@linux.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/soundwire/slave.c

bd29c00e - soundwire: revisit driver bind/unbind and callbacks

Tue, 21 Jun 2022 22:56:38 +0000

soundwire: revisit driver bind/unbind and callbacksIn the SoundWire probe, we store a pointer from the driver ops intothe 'slave' structure. This can lead to kernel oopses when unbindingcodec drivers, e.g. with the following sequence to remove machinedriver and codec driver./sbin/modprobe -r snd_soc_sof_sdw/sbin/modprobe -r snd_soc_rt711The full details can be found in the BugLink below, for reference thetwo following examples show different cases of driver ops/callbacksbeing invoked after the driver .remove().kernel: BUG: kernel NULL pointer dereference, address: 0000000000000150kernel: Workqueue: events cdns_update_slave_status_work [soundwire_cadence]kernel: RIP: 0010:mutex_lock+0x19/0x30kernel: Call Trace:kernel: ? sdw_handle_slave_status+0x426/0xe00 [soundwire_bus 94ff184bf398570c3f8ff7efe9e32529f532e4ae]kernel: ? newidle_balance+0x26a/0x400kernel: ? cdns_update_slave_status_work+0x1e9/0x200 [soundwire_cadence 1bcf98eebe5ba9833cd433323769ac923c9c6f82]kernel: BUG: unable to handle page fault for address: ffffffffc07654c8kernel: Workqueue: pm pm_runtime_workkernel: RIP: 0010:sdw_bus_prep_clk_stop+0x6f/0x160 [soundwire_bus]kernel: Call Trace:kernel: kernel: sdw_cdns_clock_stop+0xb5/0x1b0 [soundwire_cadence 1bcf98eebe5ba9833cd433323769ac923c9c6f82]kernel: intel_suspend_runtime+0x5f/0x120 [soundwire_intel aca858f7c87048d3152a4a41bb68abb9b663a1dd]kernel: ? dpm_sysfs_remove+0x60/0x60This was not detected earlier in Intel tests since the tests firstremove the parent PCI device and shut down the bus. The sequenceabove is a corner case which keeps the bus operational but without adriver bound.While trying to solve this kernel oopses, it became clear that theexisting SoundWire bus does not deal well with the unbind case.Commit 528be501b7d4a ("soundwire: sdw_slave: add probe_complete structure and new fields")added a 'probed' status variable and a 'probe_complete'struct completion. This status is however not reset on remove andlikewise the 'probe complete' is not re-initialized, so thebind/unbind/bind test cases would fail. The timeout used before the'update_status' callback was also a bad idea in hindsight, thereshould really be no timing assumption as to if and when a driver isbound to a device.An initial draft was based on device_lock() and device_unlock() wastested. This proved too complicated, with deadlocks created during thesuspend-resume sequences, which also use the same device_lock/unlock()as the bind/unbind sequences. On a CometLake device, a bad DSDT/BIOScaused spurious resumes and the use of device_lock() caused hangsduring suspend. After multiple weeks or testing and painfulreverse-engineering of deadlocks on different devices, we looked foralternatives that did not interfere with the device core.A bus notifier was used successfully to keep track of DRIVER_BOUND andDRIVER_UNBIND events. This solved the bind-unbind-bind case in tests,but it can still be defeated with a theoretical corner case where thememory is freed by a .remove while the callback is in use. Thenotifier only helps make sure the driver callbacks are valid, but notthat the memory allocated in probe remains valid while the callbacksare invoked.This patch suggests the introduction of a new 'sdw_dev_lock' mutexprotecting probe/remove and all driver callbacks. Since this mutex is'local' to SoundWire only, it does not interfere with existing locksand does not create deadlocks. In addition, this patch removes the'probe_complete' completion, instead we directly invoke the'update_status' from the probe routine. That removes any sort oftiming dependency and a much better support for the device/drivermodel, the driver could be bound before the bus started, or eons afterthe bus started and the hardware would be properly initialized in allcases.BugLink: https://github.com/thesofproject/linux/issues/3531Fixes: 56d4fe31af77 ("soundwire: Add MIPI DisCo property helpers")Fixes: 528be501b7d4a ("soundwire: sdw_slave: add probe_complete structure and new fields")Signed-off-by: Pierre-Louis Bossart Reviewed-by: Rander Wang Reviewed-by: Ranjani Sridharan Reviewed-by: Bard Liao Reviewed-by: Péter Ujfalusi Link: https://lore.kernel.org/r/20220621225641.221170-2-pierre-louis.bossart@linux.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/soundwire/slave.c

9089d1a4 - soundwire: Use acpi_dev_for_each_child()

Mon, 13 Jun 2022 18:35:26 +0000

soundwire: Use acpi_dev_for_each_child()Instead of walking the list of children of an ACPI device directly,use acpi_dev_for_each_child() to carry out an action for all ofthe given ACPI device's children.This will help to eliminate the children list head from structacpi_device as it is redundant and it is used in questionable waysin some places (in particular, locking is needed for walking thelist pointed to it safely, but it is often missing).Signed-off-by: Rafael J. Wysocki Reviewed-by: Pierre-Louis Bossart Tested-by: Pierre-Louis Bossart Acked-By: Vinod Koul List of files: /linux-6.15/drivers/soundwire/slave.c

9c294739 - soundwire/ASoC: add leading zeroes in peripheral device name

Tue, 11 May 2021 06:01:37 +0000

soundwire/ASoC: add leading zeroes in peripheral device nameWe recently added leading zeroes in dev_dbg() messages but forgot todo the same for the peripheral device name. Adding leading zeroesmakes it easier to read manufacturer ID and part ID, e.g.:sdw:0:025d:0700:00sdw:0:025d:0711:00sdw:1:025d:0700:00sdw:1:025d:1308:00sdw:2:025d:0700:00sdw:2:025d:0701:00sdw:3:025d:0700:00sdw:3:025d:0715:00The use of '01x' for link_id and unique_id is intentional to show thevalue range in the code, it's understood it does not actually changethe format.To avoid problems with git bisect, the same change needs to be appliedto the Intel SoundWire machine driver, otherwise the components can'tbe found and the card registration fails.Tested-by: Srinivas Kandagatla Signed-off-by: Pierre-Louis Bossart Reviewed-by: Rander Wang Signed-off-by: Bard Liao Acked-by: Mark Brown Link: https://lore.kernel.org/r/20210511060137.29856-1-yung-chuan.liao@linux.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/soundwire/slave.c

01ad444e - soundwire: export sdw_compare_devid, sdw_extract_slave_id and sdw_slave_add

Tue, 30 Mar 2021 14:47:17 +0000

soundwire: export sdw_compare_devid, sdw_extract_slave_id and sdw_slave_addExporting these three functions makes sense as it can be used byother controllers like Qualcomm during auto-enumeration!Reported-by: kernel test robot Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20210330144719.13284-8-srinivas.kandagatla@linaro.orgSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/soundwire/slave.c

6558b667 - soundwire: add override addr ops

Tue, 02 Mar 2021 07:51:03 +0000

soundwire: add override addr opsPlatform firmware may have incorrect _ADR values causing the driverprobes to fail. Add the override_ops, which when configured will allowfor quirks based on DMI etc to override the addr values.Co-developed-by: Bard Liao Signed-off-by: Bard Liao Signed-off-by: Vinod Koul Reviewed-by: Rander Wang Reviewed-by: Guennadi Liakhovetski Link: https://lore.kernel.org/r/20210302075105.11515-2-yung-chuan.liao@linux.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/soundwire/slave.c

c397efb7 - soundwire: use consistent format for Slave devID logs

Fri, 15 Jan 2021 05:37:34 +0000

soundwire: use consistent format for Slave devID logsWe mix decimal and hexadecimal values, this leads to confusions indmesg logs and bug reports. Let's add a 0x prefix for all hexadecimalvalues and a format when more than 4 bits are used.Signed-off-by: Pierre-Louis Bossart Reviewed-by: Rander Wang Signed-off-by: Bard Liao Link: https://lore.kernel.org/r/20210115053738.22630-2-yung-chuan.liao@linux.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/soundwire/slave.c

0173f525 - soundwire: sysfs: add slave status and device number before probe

Thu, 24 Sep 2020 19:44:30 +0000

soundwire: sysfs: add slave status and device number before probeThe MIPI DisCo device properties that are read by the driver fromplatform firmware, or hard-coded in the driver, should only beprovided as sysfs entries when a driver probes successfully.However the device status and device number is updated even when thereis no driver present, and hence can be updated when a Slave device isdetected on the bus without being described in platform firmware andwithout any driver registered/probed.As suggested by GregKH, the attribute group for Slave status anddevice number is is added by default upon device registration.Credits to Vinod Koul for the status_show() function, shared in aseparate patch and used as is here. The status table was modified toremove an unnecessary enum and status_show() is handled in a differentgroup attribute than what was suggested by Vinod.Tested-by: Srinivas Kandgatla Signed-off-by: Pierre-Louis Bossart Co-developed-by: Vinod Koul Reviewed-by: Greg Kroah-Hartman Link: https://lore.kernel.org/r/20200924194430.121058-3-pierre-louis.bossart@linux.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/soundwire/slave.c

fcb9d730 - soundwire: bus: add enumerated Slave device to device list

Thu, 24 Sep 2020 19:44:29 +0000

soundwire: bus: add enumerated Slave device to device listCurrently Slave devices are only added on startup, either from DeviceTree or ACPI entries. However Slave devices that are physicallypresent on the bus, but not described in platform firmware, will neverbe added to the device list. The user/integrator can only know thelist of devices by looking a dynamic debug logs.This patch suggests adding a Slave device even if there is no matchingDT or ACPI entry, so that we can see this in sysfs entry.Initial code from Srinivas. Comments, fixes for ACPI probe and editsof commit message by Pierre.Signed-off-by: Srinivas Kandagatla Co-developed-by: Pierre-Louis Bossart Signed-off-by: Pierre-Louis Bossart Link: https://lore.kernel.org/r/20200924194430.121058-2-pierre-louis.bossart@linux.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/soundwire/slave.c

c2819e19 - soundwire: slave: add first_interrupt_done status

Tue, 08 Sep 2020 13:45:17 +0000

soundwire: slave: add first_interrupt_done statusSome Slaves report incorrect information in their interrupt statusregisters after a master/bus reset, track the initial interrupthandling so that quirks can be introduced to filter out incorrectinformation while keeping interrupts enabled in steady state.Signed-off-by: Pierre-Louis Bossart Signed-off-by: Bard Liao Reviewed-by: Kai Vehmanen Reviewed-by: Guennadi Liakhovetski Link: https://lore.kernel.org/r/20200908134521.6781-4-yung-chuan.liao@linux.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/soundwire/slave.c

bd6a024f - soundwire: slave: use SDW_DISCO_LINK_ID()

Thu, 03 Sep 2020 11:44:58 +0000

soundwire: slave: use SDW_DISCO_LINK_ID()use SDW_DISCO_LINK_ID() in slave code to extract field values instead ofopen coding masks and shift operations to extract link_idSigned-off-by: Vinod Koul Tested-by: Bard Liao Link: https://lore.kernel.org/r/20200903114504.1202143-4-vkoul@kernel.orgSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/soundwire/slave.c

60737558 - soundwire: fix port_ready[] dynamic allocation in mipi_disco

Mon, 31 Aug 2020 13:43:18 +0000

soundwire: fix port_ready[] dynamic allocation in mipi_discoThe existing code allocates memory for the total number of ports.This only works if the ports are contiguous, but will break if e.g. aDevices uses port0, 1, and 14. The port_ready[] array would contain 3elements, which would lead to an out-of-bounds access. Conversely inother cases, the wrong port index would be used leading to timeouts onprepare.This can be fixed by allocating for the worst-case of 15ports (DP0..DP14). In addition since the number is now fixed, we canuse an array instead of a dynamic allocation.Signed-off-by: Pierre-Louis Bossart Signed-off-by: Bard Liao Reviewed-by: Rander Wang Reviewed-by: Guennadi Liakhovetski Link: https://lore.kernel.org/r/20200831134318.11443-4-yung-chuan.liao@linux.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/soundwire/slave.c

90acca1d - soundwire: bus_type: introduce sdw_slave_type and sdw_master_type

Mon, 18 May 2020 17:43:19 +0000

soundwire: bus_type: introduce sdw_slave_type and sdw_master_typethis is a preparatory patch before the introduction of thesdw_master_type. The SoundWire slave support is slightly modified withthe use of a sdw_slave_type, and the uevent handling move toslave.c (since it's not necessary for the master).No functionality change other than moving code around.Signed-off-by: Pierre-Louis Bossart Signed-off-by: Bard Liao Acked-by: Jaroslav Kysela Link: https://lore.kernel.org/r/20200518174322.31561-3-yung-chuan.liao@linux.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/soundwire/slave.c

8893ab5e - soundwire: slave: don't init debugfs on device registration error

Sun, 19 Apr 2020 18:51:15 +0000

soundwire: slave: don't init debugfs on device registration errorThe error handling flow seems incorrect, there is no reason to try andadd debugfs support if the device registration did notsucceed. Return on error.Signed-off-by: Pierre-Louis Bossart Signed-off-by: Bard Liao Reviewed-by: Ranjani Sridharan Reviewed-by: Guennadi Liakhovetski Link: https://lore.kernel.org/r/20200419185117.4233-2-yung-chuan.liao@linux.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/soundwire/slave.c

a90def06 - soundwire: bus: fix race condition with initialization_complete signaling

Wed, 15 Jan 2020 00:08:37 +0000

soundwire: bus: fix race condition with initialization_complete signalingWaiting for the enumeration to be complete may not be enough for aSlave driver, there is a possible race condition between resumeoperations and initializations handled in an interrupt thread, whichcan results in settings not being fully restored after system orpm_runtime resume.This patch builds on the changes added for enumeration_complete,init_completion() is called when the Slave device becomes UNATTACHED,as done with enumeration_complete.The difference with the enumeration_complete case is that complete()is signaled after the Slave device is fully initialized after the.update_status() callback is called.A Slave device driver can decide to wait on either of the twocomplete() cases, depending on its initialization code andrequirements.Signed-off-by: Rander Wang Signed-off-by: Pierre-Louis Bossart Link: https://lore.kernel.org/r/20200115000844.14695-4-pierre-louis.bossart@linux.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/soundwire/slave.c