Changes in wcnss_ctrl.c

b066a2c4 - soc: qcom: wcnss: simplify with cleanup.h

Wed, 03 Jul 2024 09:42:40 +0000

soc: qcom: wcnss: simplify with cleanup.hAllocate the memory with scoped/cleanup.h to reduce error handling (lesserror paths) and make the code a bit simpler.Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20240703-thermal-const-v1-5-6e59e139c65d@linaro.orgSigned-off-by: Bjorn Andersson List of files: /linux-6.15/drivers/soc/qcom/wcnss_ctrl.c

9b09c0f2 - soc: qcom: Switch to EXPORT_SYMBOL_GPL()

Fri, 22 Sep 2023 18:48:17 +0000

soc: qcom: Switch to EXPORT_SYMBOL_GPL()Switch to GPL version of EXPORT_SYMBOL for Qualcomm SoC drivers.Signed-off-by: Unnathi Chalicheemala Reviewed-by: Trilok Soni Link: https://lore.kernel.org/r/20230922184817.5183-1-quic_uchalich@quicinc.comSigned-off-by: Bjorn Andersson List of files: /linux-6.15/drivers/soc/qcom/wcnss_ctrl.c

c2bfe2b7 - soc: qcom: wcnss_ctrl: Remove redundant initialization owner in wcnss_ctrl_driver

Tue, 08 Aug 2023 02:14:46 +0000

soc: qcom: wcnss_ctrl: Remove redundant initialization owner in wcnss_ctrl_driverThe module_rpmsg_driver() will set "THIS_MODULE" to driver.owner whenregister a rpmsg_driver driver, so it is redundant initialization to setdriver.owner in the statement. Remove it for clean code.Signed-off-by: Li Zetao Link: https://lore.kernel.org/r/20230808021446.2975843-1-lizetao1@huawei.comSigned-off-by: Bjorn Andersson List of files: /linux-6.15/drivers/soc/qcom/wcnss_ctrl.c

6484be9d - soc: qcom: Explicitly include correct DT includes

Fri, 14 Jul 2023 17:51:41 +0000

soc: qcom: Explicitly include correct DT includesThe DT of_device.h and of_platform.h date back to the separateof_platform_bus_type before it as merged into the regular platform bus.As part of that merge prepping Arm DT support 13 years ago, they"temporarily" include each other. They also include platform_device.hand of.h. As a result, there's a pretty much random mix of those includefiles used throughout the tree. In order to detangle these headers andreplace the implicit includes with struct declarations, users need toexplicitly include the correct includes.Signed-off-by: Rob Herring Link: https://lore.kernel.org/r/20230714175142.4067795-1-robh@kernel.orgSigned-off-by: Bjorn Andersson List of files: /linux-6.15/drivers/soc/qcom/wcnss_ctrl.c

82ec0c29 - soc: qcom: wcnss_ctrl: Allow reading firmware-name from DT

Fri, 12 Mar 2021 00:33:17 +0000

soc: qcom: wcnss_ctrl: Allow reading firmware-name from DTThe WLAN NV firmware blob differs between platforms, and possiblydevices, so add support in the wcnss_ctrl driver for reading the path ofthis file from DT in order to allow these files to live in a genericfile system (or linux-firmware).The new property is optional and the code falls back to the old filenameif the property isn't specified.Tested-by: Bryan O'Donoghue Tested-by: Aníbal Limón Link: https://lore.kernel.org/r/20210312003318.3273536-5-bjorn.andersson@linaro.orgSigned-off-by: Bjorn Andersson List of files: /linux-6.15/drivers/soc/qcom/wcnss_ctrl.c

ac3f2784 - soc: qcom: wcnss_ctrl: Introduce local variable "dev"

Fri, 12 Mar 2021 00:33:16 +0000

soc: qcom: wcnss_ctrl: Introduce local variable "dev"Introduce a local variable to carry the struct device *, to reduce theline lengths in the next patch.Tested-by: Aníbal Limón Link: https://lore.kernel.org/r/20210312003318.3273536-4-bjorn.andersson@linaro.orgSigned-off-by: Bjorn Andersson List of files: /linux-6.15/drivers/soc/qcom/wcnss_ctrl.c

f5c805b1 - soc: qcom: wcnss_ctrl: Demote non-conformant struct header and fix function headers

Tue, 03 Nov 2020 15:28:31 +0000

soc: qcom: wcnss_ctrl: Demote non-conformant struct header and fix function headersFixes the following W=1 kernel build warning(s): drivers/soc/qcom/wcnss_ctrl.c:81: warning: Function parameter or member 'major' not described in 'wcnss_version_resp' drivers/soc/qcom/wcnss_ctrl.c:81: warning: Function parameter or member 'minor' not described in 'wcnss_version_resp' drivers/soc/qcom/wcnss_ctrl.c:81: warning: Function parameter or member 'version' not described in 'wcnss_version_resp' drivers/soc/qcom/wcnss_ctrl.c:81: warning: Function parameter or member 'revision' not described in 'wcnss_version_resp' drivers/soc/qcom/wcnss_ctrl.c:122: warning: Function parameter or member 'rpdev' not described in 'wcnss_ctrl_smd_callback' drivers/soc/qcom/wcnss_ctrl.c:122: warning: Function parameter or member 'priv' not described in 'wcnss_ctrl_smd_callback' drivers/soc/qcom/wcnss_ctrl.c:122: warning: Function parameter or member 'addr' not described in 'wcnss_ctrl_smd_callback' drivers/soc/qcom/wcnss_ctrl.c:122: warning: Excess function parameter 'channel' description in 'wcnss_ctrl_smd_callback' drivers/soc/qcom/wcnss_ctrl.c:272: warning: Function parameter or member 'priv' not described in 'qcom_wcnss_open_channel'Cc: Andy Gross Cc: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.orgReviewed-by: Bjorn Andersson Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20201103152838.1290217-19-lee.jones@linaro.orgSigned-off-by: Bjorn Andersson List of files: /linux-6.15/drivers/soc/qcom/wcnss_ctrl.c

97fb5e8d - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 284

Wed, 29 May 2019 14:17:58 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 284Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 and only version 2 as published by the free software foundation this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more detailsextracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 294 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Allison Randal Reviewed-by: Alexios Zavras Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190529141900.825281744@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/soc/qcom/wcnss_ctrl.c

4c96ed17 - soc: qcom: wcnss_ctrl: Avoid string overflow

Wed, 29 Aug 2018 07:57:21 +0000

soc: qcom: wcnss_ctrl: Avoid string overflow'chinfo.name' is used as a NUL-terminated string, but using strncpy() withthe length equal to the buffer size may result in lack of the termination:drivers//soc/qcom/wcnss_ctrl.c: In function 'qcom_wcnss_open_channel':drivers//soc/qcom/wcnss_ctrl.c:284:2: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation] strncpy(chinfo.name, name, sizeof(chinfo.name)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~This changes it to use the safer strscpy() instead.Signed-off-by: Niklas Cassel Reviewed-by: Bjorn Andersson Signed-off-by: Andy Gross List of files: /linux-6.15/drivers/soc/qcom/wcnss_ctrl.c

90c29ed7 - soc: qcom: wcnss_ctrl: Fix increment in NV upload

Wed, 28 Feb 2018 00:45:25 +0000

soc: qcom: wcnss_ctrl: Fix increment in NV uploadhdr.len includes both the size of the header and the fragment, so usingthis when stepping through the firmware causes us to skip 16 bytes everychunk of 3072 bytes; causing only the first fragment to actually bevalid data.Instead use fragment size steps through the firmware blob.Fixes: ea7a1f275cf0 ("soc: qcom: Introduce WCNSS_CTRL SMD client")Reported-by: Will Newton Signed-off-by: Bjorn Andersson Signed-off-by: Andy Gross List of files: /linux-6.15/drivers/soc/qcom/wcnss_ctrl.c

b8339909 - soc: qcom: wcnss_ctrl: add missing MODULE_DEVICE_TABLE()

Sun, 02 Jul 2017 13:23:36 +0000

soc: qcom: wcnss_ctrl: add missing MODULE_DEVICE_TABLE()This fixes a problem of wifi module not loading on db410c.Signed-off-by: Rob Clark Reviewed-by: Bjorn Andersson Signed-off-by: Andy Gross List of files: /linux-6.15/drivers/soc/qcom/wcnss_ctrl.c

5052de8d - soc: qcom: smd: Transition client drivers from smd to rpmsg

Tue, 28 Mar 2017 05:26:33 +0000

soc: qcom: smd: Transition client drivers from smd to rpmsgBy moving these client drivers to use RPMSG instead of the direct SMDAPI we can reuse them ontop of the newly added GLINK wire-protocolsupport found in the 820 and 835 Qualcomm platforms.As the new (RPMSG-based) and old SMD implementations are mutuallyexclusive we have to change all client drivers in one commit, to makesure we have a working system before and after this transition.Acked-by: Andy Gross Acked-by: Kalle Valo Acked-by: Marcel Holtmann Signed-off-by: Bjorn Andersson Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/soc/qcom/wcnss_ctrl.c

6be2b3d0 - soc: qcom: wcnss_ctrl: Make wcnss_ctrl parent the other components

Mon, 06 Jun 2016 23:58:20 +0000

soc: qcom: wcnss_ctrl: Make wcnss_ctrl parent the other componentsWe need the signal from wcnss_ctrl indicating that the firmware is upand running before we can communicate with the other components of thechip. So make these other components children of the wcnss_ctrl device,so they can be probed in order.The process seems to take between 1/2-5 seconds, so this is done in aworker, instead of holding up the probe.Signed-off-by: Bjorn Andersson Signed-off-by: Andy Gross List of files: /linux-6.15/drivers/soc/qcom/wcnss_ctrl.c

b853cb96 - soc: qcom: smd: Make callback pass channel reference

Tue, 29 Mar 2016 04:35:22 +0000

soc: qcom: smd: Make callback pass channel referenceBy passing the smd channel reference to the callback, rather than thesmd device, we can open additional smd channels from sub-devices of smddevices.Also updates the two smd clients today found in mainline.Signed-off-by: Bjorn Andersson Signed-off-by: Andy Gross List of files: /linux-6.15/drivers/soc/qcom/wcnss_ctrl.c

ea7a1f27 - soc: qcom: Introduce WCNSS_CTRL SMD client

Mon, 21 Sep 2015 17:52:55 +0000

soc: qcom: Introduce WCNSS_CTRL SMD clientThe WCNSS_CTRL SMD client is used for among other things upload nvfirmware to a newly booted WCNSS chip.Signed-off-by: Bjorn Andersson Signed-off-by: Andy Gross List of files: /linux-6.15/drivers/soc/qcom/wcnss_ctrl.c