Changes in aspeed-lpc-ctrl.c

511c06e3 - soc: Switch back to struct platform_driver::remove()

Tue, 29 Oct 2024 07:48:58 +0000

soc: Switch back to struct platform_driver::remove()After commit 0edb555a65d1 ("platform: Make platform_driver::remove()return void") .remove() is (again) the right callback to implement forplatform drivers.Convert all platform drivers below drivers/soc to use .remove(), withthe eventual goal to drop struct platform_driver::remove_new(). As.remove() and .remove_new() have the same prototypes, conversion is doneby just changing the structure member name in the driver initializer.On the way do a few whitespace changes to make indention consistent.Signed-off-by: Uwe Kleine-König Acked-by: Heiko Stuebner Acked-by: Herve Codina # for fsl/qe/{qmc,tsa}.cAcked-by: Bjorn Andersson # qcom partsAcked-by: Gabriel Somlo Acked-by: Andrew Jeffery # aspeedLink: https://lore.kernel.org/r/20241029074859.509587-2-u.kleine-koenig@baylibre.comSigned-off-by: Arnd Bergmann List of files: /linux-6.15/drivers/soc/aspeed/aspeed-lpc-ctrl.c

0af9e891 - soc/aspeed: Convert to platform remove callback returning void

Mon, 25 Sep 2023 09:54:52 +0000

soc/aspeed: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is ignored (apartfrom emitting a warning) and this typically results in resource leaks.To improve here there is a quest to make the remove callback returnvoid. In the first step of this quest all drivers are converted to.remove_new() which already returns void. Eventually after all driversare converted, .remove_new() will be renamed to .remove().Trivially convert this driver from always returning zero in the removecallback to the void returning variant.Signed-off-by: Uwe Kleine-König Reviewed-by: Andrew Jeffery Link: https://lore.kernel.org/r/20230925095532.1984344-2-u.kleine-koenig@pengutronix.deLink: https://lore.kernel.org/r/20230925095532.1984344-3-u.kleine-koenig@pengutronix.deLink: https://lore.kernel.org/r/20230925095532.1984344-4-u.kleine-koenig@pengutronix.deLink: https://lore.kernel.org/r/20230925095532.1984344-5-u.kleine-koenig@pengutronix.deSigned-off-by: Joel Stanley List of files: /linux-6.15/drivers/soc/aspeed/aspeed-lpc-ctrl.c

301a5d3a - soc: aspeed: lpc-ctrl: Block error printing on probe defer cases

Tue, 01 Feb 2022 07:01:18 +0000

soc: aspeed: lpc-ctrl: Block error printing on probe defer casesAdd a checking code when it gets -EPROBE_DEFER while getting a clockresource. In this case, it doesn't need to print out an error messagebecause the probing will be re-visited.Signed-off-by: Jae Hyun Yoo Signed-off-by: Joel Stanley Reviewed-by: Andrew Jeffery Reviewed-by: Iwona Winiarska Link: https://lore.kernel.org/r/20211104173709.222912-1-jae.hyun.yoo@intel.comLink: https://lore.kernel.org/r/20220201070118.196372-1-joel@jms.id.au'Signed-off-by: Arnd Bergmann List of files: /linux-6.15/drivers/soc/aspeed/aspeed-lpc-ctrl.c

51e321fe - soc: aspeed-lpc-ctrl: Fix clock cleanup in error path

Wed, 25 Aug 2021 00:12:14 +0000

soc: aspeed-lpc-ctrl: Fix clock cleanup in error pathMove syscon_regmap_lookup_by_compatible() above thedevm_clk_get() to avoid missing clk_disable_unprepare().Fixes: 2f9b25fa6682 ("soc: aspeed: Re-enable FWH2AHB on AST2600")Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Signed-off-by: Joel Stanley Reviewed-by: Joel Stanley Link: https://lore.kernel.org/r/20210824085522.1849410-1-yangyingliang@huawei.comLink: https://lore.kernel.org/r/20210825001214.3056193-1-joel@jms.id.au'Signed-off-by: Arnd Bergmann List of files: /linux-6.15/drivers/soc/aspeed/aspeed-lpc-ctrl.c

2f9b25fa - soc: aspeed: Re-enable FWH2AHB on AST2600

Tue, 29 Jun 2021 07:35:19 +0000

soc: aspeed: Re-enable FWH2AHB on AST2600Recent builds of the vendor u-boot tree disable features of theBMC that may allow unwanted access if not correctly configured. Thisincludes the firmware hub to ahb bridge (FWH2AHB), which is used by thisdriver.The bit to "un-disable" it is in the SCU. Set it only when the ioctl iscalled and we are running on the ast2600, as to not open up the'backdoor' unless there's userspace trying to use it.Fixes: deb50313ba83 ("soc: aspeed-lpc-ctrl: LPC to AHB mapping on ast2600")Link: https://lore.kernel.org/r/20210629073520.318514-2-joel@jms.id.auSigned-off-by: Joel Stanley List of files: /linux-6.15/drivers/soc/aspeed/aspeed-lpc-ctrl.c

b49a0e69 - soc: aspeed: lpc-ctrl: Fix boundary check for mmap

Tue, 03 Aug 2021 23:48:18 +0000

soc: aspeed: lpc-ctrl: Fix boundary check for mmapThe check mixes pages (vm_pgoff) with bytes (vm_start, vm_end) on oneside of the comparison, and uses resource address (rather than just theresource size) on the other side of the comparison.This can allow malicious userspace to easily bypass the boundary check andmap pages that are located outside memory-region reserved by the driver.Fixes: 6c4e97678501 ("drivers/misc: Add Aspeed LPC control driver")Cc: stable@vger.kernel.orgSigned-off-by: Iwona Winiarska Reviewed-by: Andrew Jeffery Tested-by: Andrew Jeffery Reviewed-by: Joel Stanley Signed-off-by: Joel Stanley List of files: /linux-6.15/drivers/soc/aspeed/aspeed-lpc-ctrl.c

489774ff - soc: aspeed: Adapt to new LPC device tree layout

Fri, 19 Mar 2021 06:27:36 +0000

soc: aspeed: Adapt to new LPC device tree layoutAdd check against LPC device v2 compatible string toensure that the fixed device tree layout is adopted.The LPC register offsets are also fixed accordingly.Signed-off-by: Chia-Wei Wang Reviewed-by: Andrew Jeffery Reviewed-by: Joel Stanley Link: https://lore.kernel.org/r/20210319062752.145730-5-andrew@aj.id.auSigned-off-by: Joel Stanley List of files: /linux-6.15/drivers/soc/aspeed/aspeed-lpc-ctrl.c

cd460be0 - soc: aspeed-lpc-ctrl: Fix driver name

Fri, 25 Sep 2020 05:23:25 +0000

soc: aspeed-lpc-ctrl: Fix driver nameClarify the string now that it supports the AST2600 too.Signed-off-by: Joel Stanley List of files: /linux-6.15/drivers/soc/aspeed/aspeed-lpc-ctrl.c

4d1d81db - soc: aspeed-lpc-ctrl: Fix whitespace

Fri, 25 Sep 2020 05:22:44 +0000

soc: aspeed-lpc-ctrl: Fix whitespaceSome misaligned indentation I noticed when applying another patch.Signed-off-by: Joel Stanley List of files: /linux-6.15/drivers/soc/aspeed/aspeed-lpc-ctrl.c

5042d3f2 - soc: aspeed-lpc-ctrl: LPC to AHB mapping on ast2600

Thu, 12 Mar 2020 12:14:13 +0000

soc: aspeed-lpc-ctrl: LPC to AHB mapping on ast2600The ast2600 disables the mapping of AHB memory regions by default,only allowing the LPC window to point to SPI NOR. In order to point thewindow to any AHB address, an ast2600 specific bit must be toggled.Reviewed-by: Andrew Jeffery Link: https://lore.kernel.org/r/20200312121413.294384-1-joel@jms.id.auSigned-off-by: Joel Stanley List of files: /linux-6.15/drivers/soc/aspeed/aspeed-lpc-ctrl.c

6bf4ddbe - soc: aspeed-lpc-ctrl: Fail probe of lpc-ctrl if reserved memory is not aligned

Wed, 16 Oct 2019 23:39:50 +0000

soc: aspeed-lpc-ctrl: Fail probe of lpc-ctrl if reserved memory is not alignedAlignment is a hardware constraint of the LPC2AHB bridge, and misalignedreserved memory will present as corrupted data.Signed-off-by: Andrew Jeffery Reviewed-by: Joel Stanley Link: https://lore.kernel.org/r/20191016233950.10100-1-andrew@aj.id.auSigned-off-by: Joel Stanley List of files: /linux-6.15/drivers/soc/aspeed/aspeed-lpc-ctrl.c

44ddc4de - soc: aspeed: lpc: Add AST2600 compatible strings

Wed, 25 Sep 2019 12:56:03 +0000

soc: aspeed: lpc: Add AST2600 compatible stringsThe AST2600 has the same lpc-ctrl and lpc-snoop devices as theAST2500.Signed-off-by: Brad Bishop Acked-by: Andrew Jeffery Link: https://lore.kernel.org/r/20190925125610.12096-4-bradleyb@fuzziesquirrel.comSigned-off-by: Joel Stanley List of files: /linux-6.15/drivers/soc/aspeed/aspeed-lpc-ctrl.c

c8a3b9b5 - soc: aspeed: lpc-ctrl: Fix probe error handling

Thu, 20 Jun 2019 09:17:38 +0000

soc: aspeed: lpc-ctrl: Fix probe error handlinggcc warns that a mising "flash" phandle node leads to undefinedbehavior later:drivers/soc/aspeed/aspeed-lpc-ctrl.c: In function 'aspeed_lpc_ctrl_probe':drivers/soc/aspeed/aspeed-lpc-ctrl.c:201:18: error: '*((void *)&resm+8)' may be used uninitialized in this function [-Werror=maybe-uninitialized]Only set the flash base and size if we find a phandle in the devicetree.Reported-by: Arnd Bergmann Reviewed-by: Andrew Jeffery Reviewed-by: Vijay Khemka Signed-off-by: Joel Stanley List of files: /linux-6.15/drivers/soc/aspeed/aspeed-lpc-ctrl.c

e4272af4 - soc: aspeed: lpc-ctrl: make parameter optional

Thu, 30 May 2019 20:36:51 +0000

soc: aspeed: lpc-ctrl: make parameter optionalMaking memory-region and flash as optional parameter in devicetree if user needs to use these parameter through ioctl thenneed to define in devicetree.Signed-off-by: Vijay Khemka Reviewed-by: Andrew Jeffery Signed-off-by: Joel Stanley List of files: /linux-6.15/drivers/soc/aspeed/aspeed-lpc-ctrl.c

2874c5fd - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152

Mon, 27 May 2019 06:55:01 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later versionextracted by the scancode license scanner the SPDX license identifier GPL-2.0-or-laterhas been chosen to replace the boilerplate/reference in 3029 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190527070032.746973796@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/soc/aspeed/aspeed-lpc-ctrl.c

524feb79 - soc: add aspeed folder and misc drivers

Mon, 22 Apr 2019 17:54:19 +0000

soc: add aspeed folder and misc driversCreate a SoC folder for the ASPEED parts and place the misc driverscurrently present into this folder. These drivers are not generic partdrivers, but rather only apply to the ASPEED SoCs.Signed-off-by: Patrick Venture Acked-by: Arnd Bergmann Signed-off-by: Olof Johansson List of files: /linux-6.15/drivers/soc/aspeed/aspeed-lpc-ctrl.c