Changes in scsi_debugfs.c

ba0f09b0 - scsi: core: Improve the code for showing commands in debugfs

Mon, 25 Mar 2024 22:47:54 +0000

scsi: core: Improve the code for showing commands in debugfsSome but not all command information is cleared by scsi_end_request().As an example, if scsi_show_rq() is called after a SCSI command has beenallocated and before SCMD_INITIALIZED is set, .cmnd holds the CDBof a previous command. Showing that information in debugfs is confusing.Hence this patch that restricts the information shown in debugfs tovalid information.Signed-off-by: Bart Van Assche Link: https://lore.kernel.org/r/20240325224755.1477910-3-bvanassche@acm.orgSigned-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/scsi_debugfs.c

9972c02a - scsi: core: Introduce scsi_cmd_list_info()

Mon, 25 Mar 2024 22:47:53 +0000

scsi: core: Introduce scsi_cmd_list_info()Slightly improve code readability by introducing a helper function forderiving the list information and by using guard() + return instead ofgoto + explicit unlock + return.Signed-off-by: Bart Van Assche Link: https://lore.kernel.org/r/20240325224755.1477910-2-bvanassche@acm.orgSigned-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/scsi_debugfs.c

90f359c1 - scsi: core: Report error list information in debugfs

Tue, 22 Aug 2023 16:38:10 +0000

scsi: core: Report error list information in debugfsProvide information in debugfs about SCSI error handling to make it easierto debug the SCSI error handler. Additionally, report the maximum number ofretries in debugfs (.allowed).Reviewed-by: John Garry Cc: Hannes Reinecke Cc: Damien Le Moal Cc: Mike Christie Cc: Ming Lei Signed-off-by: Bart Van Assche Link: https://lore.kernel.org/r/20230822163811.219569-1-bvanassche@acm.orgSigned-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/scsi_debugfs.c

6aded12b - scsi: core: Remove struct scsi_request

Thu, 24 Feb 2022 17:55:51 +0000

scsi: core: Remove struct scsi_requestLet submitters initialize the scmd->allowed field directly instead ofindirecting through struct scsi_request and remove the now superfluousstructure.Link: https://lore.kernel.org/r/20220224175552.988286-8-hch@lst.deReviewed-by: Bart Van Assche Reviewed-by: John Garry Signed-off-by: Christoph Hellwig Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/scsi_debugfs.c

ce70fd9a - scsi: core: Remove the cmd field from struct scsi_request

Thu, 24 Feb 2022 17:55:47 +0000

scsi: core: Remove the cmd field from struct scsi_requestNow that each scsi_request is backed by a scsi_cmnd, there is no need toindirect the CDB storage. Change all submitters of SCSI passthroughrequests to store the CDB information directly in the scsi_cmnd, and whiledoing so allocate the full 32 bytes that cover all Linux supported SCSIhosts instead of requiring dynamic allocation for > 16 byte CDBs. On64-bit systems this does not change the size of the scsi_cmnd at all, whileon 32-bit systems it slightly increases it for now, but that increase willbe made up by the removal of the remaining scsi_request fields.Link: https://lore.kernel.org/r/20220224175552.988286-4-hch@lst.deReviewed-by: Bart Van Assche Reviewed-by: John Garry Signed-off-by: Christoph Hellwig Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/scsi_debugfs.c

3369046e - scsi: core: Show SCMD_LAST in text form

Mon, 29 Nov 2021 19:46:00 +0000

scsi: core: Show SCMD_LAST in text formThe SCSI debugfs code supports showing information about pending commands,including translating SCSI command flags from numeric into text format.Also convert the SCMD_LAST flag from numeric into text form.Link: https://lore.kernel.org/r/20211129194609.3466071-4-bvanassche@acm.orgFixes: 8930a6c20791 ("scsi: core: add support for request batching")Signed-off-by: Bart Van Assche Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/scsi_debugfs.c

aaff5eba - scsi: remove the unchecked_isa_dma flag

Wed, 31 Mar 2021 07:29:58 +0000

scsi: remove the unchecked_isa_dma flagRemove the unchecked_isa_dma now that all users are gone.Signed-off-by: Christoph Hellwig Acked-by: Martin K. Petersen Reviewed-by: Hannes Reinecke Link: https://lore.kernel.org/r/20210331073001.46776-6-hch@lst.deSigned-off-by: Jens Axboe List of files: /linux-6.15/drivers/scsi/scsi_debugfs.c

16238355 - scsi: scsi_debugfs: Use for_each_set_bit to simplify code

Thu, 25 Jul 2019 20:07:51 +0000

scsi: scsi_debugfs: Use for_each_set_bit to simplify codeWe can use for_each_set_bit() to slightly simplify the code.Signed-off-by: Andy Shevchenko Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/scsi_debugfs.c

659c1c1b - scsi: devinfo: use const_ilog2 for array indices

Tue, 17 Apr 2018 23:35:07 +0000

scsi: devinfo: use const_ilog2 for array indicesUse the just introduced const_ilog2() macro to avoid sparse errors.Signed-off-by: Martin Wilck Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/scsi_debugfs.c

39051dd8 - scsi: sd: Remove zone write locking

Thu, 21 Dec 2017 06:43:44 +0000

scsi: sd: Remove zone write lockingThe block layer now handles zone write locking.[mkp: removed SCMD_ZONE_WRITE_LOCK reference in scsi_debugfs]Signed-off-by: Damien Le Moal Reviewed-by: Christoph Hellwig Reviewed-by: Martin K. Petersen Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/scsi_debugfs.c

2ee4e9ce - scsi: scsi-mq-debugfs: Show more information

Wed, 06 Dec 2017 00:57:53 +0000

scsi: scsi-mq-debugfs: Show more informationShow the request result, request timeout and SCSI command flags. Thisinformation is very helpful when trying to figure out why a queue gotstuck. An example of the information that is exported through debugfs:$ (cd /sys/kernel/debug/block && find -type f -print0 | xargs -0 grep ago)./sda/hctx0/busy:ffff8804a4523300 {.op=READ, .cmd_flags=FAILFAST_DEV|FAILFAST_TRANSPORT|FAILFAST_DRIVER|RAHEAD, .rq_flags=MQ_INFLIGHT|DONTPREP|IO_STAT|STATS, .atomic_flags=STARTED, .tag=24, .internal_tag=-1, .cmd=Read(10) 28 00 06 80 1c c8 00 00 08 00, .retries=0, .result = 0x0, .flags=TAGGED|INITIALIZED, .timeout=90.000, allocated 0.010 s ago}Signed-off-by: Bart Van Assche Cc: James E.J. Bottomley Cc: Martin K. Petersen Cc: Ming Lei Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Johannes Thumshirn Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/scsi_debugfs.c

14e3062f - scsi: core: Fix a scsi_show_rq() NULL pointer dereference

Wed, 06 Dec 2017 00:57:51 +0000

scsi: core: Fix a scsi_show_rq() NULL pointer dereferenceAvoid that scsi_show_rq() triggers a NULL pointer dereference if calledafter sd_uninit_command(). Swap the NULL pointer assignment and themempool_free() call in sd_uninit_command() to make it less likely thatscsi_show_rq() triggers a use-after-free. Note: even with these changesscsi_show_rq() can trigger a use-after-free but that's a lesser evilthan e.g. suppressing debug information for T10 PI Type 2 commandscompletely. This patch fixes the following oops:BUG: unable to handle kernel NULL pointer dereference at (null)IP: scsi_format_opcode_name+0x1a/0x1c0CPU: 1 PID: 1881 Comm: cat Not tainted 4.14.0-rc2.blk_mq_io_hang+ #516Call Trace: __scsi_format_command+0x27/0xc0 scsi_show_rq+0x5c/0xc0 __blk_mq_debugfs_rq_show+0x116/0x130 blk_mq_debugfs_rq_show+0xe/0x10 seq_read+0xfe/0x3b0 full_proxy_read+0x54/0x90 __vfs_read+0x37/0x160 vfs_read+0x96/0x130 SyS_read+0x55/0xc0 entry_SYSCALL_64_fastpath+0x1a/0xa5[mkp: added Type 2]Fixes: 0eebd005dd07 ("scsi: Implement blk_mq_ops.show_rq()")Reported-by: Ming Lei Signed-off-by: Bart Van Assche Cc: James E.J. Bottomley Cc: Martin K. Petersen Cc: Ming Lei Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Johannes Thumshirn Cc: stable@vger.kernel.orgSigned-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/scsi_debugfs.c

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/scsi/scsi_debugfs.c

cad8cf20 - scsi: Show .retries and .jiffies_at_alloc in debugfs

Wed, 30 Aug 2017 23:58:41 +0000

scsi: Show .retries and .jiffies_at_alloc in debugfsMake these two member variables available in debugfs such that theirvalue can be verified by kernel developers. An example of the newoutput:ffff8804a513d480 {.op=READ, .cmd_flags=META|PRIO, .rq_flags=MQ_INFLIGHT|DONTPREP|IO_STAT|STATS, .atomic_flags=STARTED, .tag=17, .internal_tag=-1, .cmd=Read(10) 28 00 08 81 32 38 00 00 08 00, .retries=0, allocated 0.010 s ago}Signed-off-by: Bart Van Assche Cc: Hannes Reinecke Cc: Christoph Hellwig Cc: Johannes Thumshirn Reviewed-by: Johannes Thumshirn Reviewed-by: Christoph Hellwig Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/scsi_debugfs.c

0eebd005 - scsi: Implement blk_mq_ops.show_rq()

Wed, 26 Apr 2017 20:47:57 +0000

scsi: Implement blk_mq_ops.show_rq()Show the SCSI CDB for pending SCSI commands in/sys/kernel/debug/block/*/mq/*/dispatch and */rq_list. An exampleof how SCSI commands are displayed by this code:ffff8801703245c0 {.op=READ, .cmd_flags=META PRIO, .rq_flags=DONTPREP IO_STAT STATS, .tag=14, .internal_tag=-1, .cmd=Read(10) 28 00 2a 81 1b 30 00 00 08 00}Signed-off-by: Bart Van Assche Reviewed-by: Omar Sandoval Cc: Martin K. Petersen Cc: James Bottomley Cc: Hannes Reinecke Cc: Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/scsi/scsi_debugfs.c