Changes in initio.c

c9a71ca1 - scsi: Constify struct pci_device_id

Sat, 07 Dec 2024 16:48:28 +0000

scsi: Constify struct pci_device_id'struct pci_device_id' is not modified in these drivers.Constifying this structure moves some data to a read-only section, soincrease overall security.On a x86_64, with allmodconfig, as an example:Before:====== text data bss dec hex filename 70237 9137 320 79694 1374e drivers/scsi/3w-9xxx.oAfter:===== text data bss dec hex filename 70461 8913 320 79694 1374e drivers/scsi/3w-9xxx.oSigned-off-by: Christophe JAILLET Link: https://lore.kernel.org/r/fc61b1946488c1ea8f7a17a06cf40fbd05dcc6de.1733590049.git.christophe.jaillet@wanadoo.frSigned-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/initio.c

e6f3799d - scsi: initio: Remove redundant variable 'rb'

Tue, 16 Jan 2024 11:26:06 +0000

scsi: initio: Remove redundant variable 'rb'The variable 'rb' is being assigned a value but it isn't being readafterwards. The assignment is redundant and so 'rb' can be removed.Cleans up clang scan build warning:warning: Although the value stored to 'rb' is used in the enclosingexpression, the value is never actually read from 'rb'[deadcode.DeadStores]Signed-off-by: Colin Ian King Link: https://lore.kernel.org/r/20240116112606.2263738-1-colin.i.king@gmail.comSigned-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/initio.c

4ba116af - scsi: initio: Declare SCSI host template const

Wed, 22 Mar 2023 19:54:41 +0000

scsi: initio: Declare SCSI host template constMake it explicit that the SCSI host template is not modified.Signed-off-by: Bart Van Assche Link: https://lore.kernel.org/r/20230322195515.1267197-47-bvanassche@acm.orgSigned-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/initio.c

3fa5975b - scsi: initio: Remove redundant assignment to pointer scb

Fri, 05 Aug 2022 11:41:00 +0000

scsi: initio: Remove redundant assignment to pointer scbThe variable scb is assigned a value but it is never read. The assignmentis redundant and can be removed. Also replace the != NULL check with themore usual non-null check idiom.Cleans up clang scan build warning:drivers/scsi/initio.c:1169:9: warning: Although the value stored to 'scb'is used in the enclosing expression, the value is never actually readfrom 'scb' [deadcode.DeadStores]Link: https://lore.kernel.org/r/20220805114100.2339637-1-colin.i.king@gmail.comSigned-off-by: Colin Ian King Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/initio.c

09cc102b - scsi: initio: Stop using the SCSI pointer

Fri, 18 Feb 2022 19:50:54 +0000

scsi: initio: Stop using the SCSI pointerSet .cmd_size in the SCSI host template instead of using the SCSI pointerfrom struct scsi_cmnd. This patch prepares for removal of the SCSI pointerfrom struct scsi_cmnd.Link: https://lore.kernel.org/r/20220218195117.25689-27-bvanassche@acm.orgReviewed-by: Johannes Thumshirn Reviewed-by: Hannes Reinecke Reviewed-by: Himanshu Madhani Signed-off-by: Bart Van Assche Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/initio.c

c981e9e0 - scsi: initio: Don't use GFP_DMA in initio_probe_one()

Wed, 22 Dec 2021 09:16:30 +0000

scsi: initio: Don't use GFP_DMA in initio_probe_one()The driver doesn't express DMA addressing limitation under 32-bits anywhereelse, so remove the spurious GFP_DMA allocation.Link: https://lore.kernel.org/r/20211222091630.922788-1-hch@lst.deSigned-off-by: Christoph Hellwig Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/initio.c

0addfa58 - scsi: initio: Fix a kernel-doc warning

Mon, 29 Nov 2021 19:46:05 +0000

scsi: initio: Fix a kernel-doc warningFix the following kernel-doc warning:drivers/scsi/initio.c:2613: warning: Excess function parameter 'done' description in 'i91u_queuecommand_lck'Link: https://lore.kernel.org/r/20211129194609.3466071-9-bvanassche@acm.orgFixes: af049dfd0b10 ("scsi: core: Remove the 'done' argument from SCSI queuecommand_lck functions")Signed-off-by: Bart Van Assche Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/initio.c

af049dfd - scsi: core: Remove the 'done' argument from SCSI queuecommand_lck functions

Thu, 07 Oct 2021 20:46:14 +0000

scsi: core: Remove the 'done' argument from SCSI queuecommand_lck functionsThe DEF_SCSI_QCMD() macro passes the addresses of the SCSI host lock andalso that of the scsi_done function to the queuecommand_lck() functionimplementations. Remove the 'scsi_done' argument since its address isnow a constant and instead call 'scsi_done' directly from inside thequeuecommand_lck() functions.Link: https://lore.kernel.org/r/20211007204618.2196847-14-bvanassche@acm.orgSigned-off-by: Bart Van Assche Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/initio.c

25e1d896 - scsi: initio: Call scsi_done() directly

Thu, 07 Oct 2021 20:28:35 +0000

scsi: initio: Call scsi_done() directlyConditional statements are faster than indirect calls. Hence callscsi_done() directly.Link: https://lore.kernel.org/r/20211007202923.2174984-41-bvanassche@acm.orgSigned-off-by: Bart Van Assche Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/initio.c

100ec495 - scsi: initio: Fix a few kernel-doc misdemeanours

Wed, 17 Mar 2021 09:12:04 +0000

scsi: initio: Fix a few kernel-doc misdemeanoursFixes the following W=1 kernel build warning(s): drivers/scsi/initio.c:560: warning: Excess function parameter 'num_scbs' description in 'initio_init' drivers/scsi/initio.c:1899: warning: expecting prototype for int_initio_scsi_resel(). Prototype was for int_initio_resel() instead drivers/scsi/initio.c:2615: warning: expecting prototype for i91u_queuecommand(). Prototype was for i91u_queuecommand_lck() instead drivers/scsi/initio.c:2667: warning: Function parameter or member 'dev' not described in 'i91u_biosparam' drivers/scsi/initio.c:2667: warning: expecting prototype for i91u_biospararm(). Prototype was for i91u_biosparam() instead drivers/scsi/initio.c:2740: warning: Function parameter or member 'host_mem' not described in 'i91uSCBPost' drivers/scsi/initio.c:2740: warning: Function parameter or member 'cblk_mem' not described in 'i91uSCBPost' drivers/scsi/initio.c:2740: warning: Excess function parameter 'host' description in 'i91uSCBPost' drivers/scsi/initio.c:2740: warning: Excess function parameter 'cmnd' description in 'i91uSCBPost'Link: https://lore.kernel.org/r/20210317091230.2912389-11-lee.jones@linaro.orgCc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Bas Vermeulen Cc: Christoph Hellwig Cc: Brian Macy Cc: linux-scsi@vger.kernel.orgSigned-off-by: Lee Jones Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/initio.c

78e40ac8 - scsi: initio: Remove unused variable 'prev'

Fri, 12 Mar 2021 09:47:31 +0000

scsi: initio: Remove unused variable 'prev'Fixes the following W=1 kernel build warning(s): drivers/scsi/initio.c: In function ‘initio_find_busy_scb’: drivers/scsi/initio.c:869:30: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable]Link: https://lore.kernel.org/r/20210312094738.2207817-24-lee.jones@linaro.orgCc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Bas Vermeulen Cc: Christoph Hellwig Cc: Brian Macy Cc: linux-scsi@vger.kernel.orgReviewed-by: Christoph Hellwig Signed-off-by: Lee Jones Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/initio.c

9df17f46 - scsi: initio: Drop internal SCSI message definition

Wed, 13 Jan 2021 09:04:46 +0000

scsi: initio: Drop internal SCSI message definitionUse the standard SCSI message definitions instead of the driver-internalones.Link: https://lore.kernel.org/r/20210113090500.129644-22-hare@suse.deReviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/initio.c

ca57b069 - scsi: initio: Use module_pci_driver() to simplify the code

Thu, 17 Sep 2020 07:10:45 +0000

scsi: initio: Use module_pci_driver() to simplify the codeUse the module_pci_driver() macro to make the code simpler by eliminatingmodule_init() and module_exit() calls.Link: https://lore.kernel.org/r/20200917071045.1909320-1-liushixin2@huawei.comSigned-off-by: Liu Shixin Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/initio.c

0c3dbdeb - scsi: initio: make initio_state_7() static

Tue, 17 Dec 2019 13:43:09 +0000

scsi: initio: make initio_state_7() staticFix sparse warning:drivers/scsi/initio.c:1643:5: warning: symbol 'initio_state_7' was not declared. Should it be static?Link: https://lore.kernel.org/r/20191217134309.41649-1-chenzhou10@huawei.comReported-by: Hulk Robot Signed-off-by: Chen Zhou Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/initio.c

c82ee6d3 - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18

Sun, 19 May 2019 13:51:48 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 or at your option any later version this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more details you should have received a copy of the gnu general public license along with this program see the file copying if not write to the free software foundation 675 mass ave cambridge ma 02139 usaextracted by the scancode license scanner the SPDX license identifier GPL-2.0-or-laterhas been chosen to replace the boilerplate/reference in 52 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Jilayne Lovejoy Reviewed-by: Steve Winslow Reviewed-by: Kate Stewart Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190519154042.342335923@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/scsi/initio.c

2a3d4eb8 - scsi: flip the default on use_clustering

Thu, 13 Dec 2018 15:17:02 +0000

scsi: flip the default on use_clusteringMost SCSI drivers want to enable "clustering", that is merging ofsegments so that they might span more than a single page. Remove theENABLE_CLUSTERING define, and require drivers to explicitly setDISABLE_CLUSTERING to disable this feature.Signed-off-by: Christoph Hellwig Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/initio.c

663b4117 - scsi: initio: use dma_set_mask

Thu, 18 Oct 2018 13:10:19 +0000

scsi: initio: use dma_set_maskThe driver currently uses pci_set_dma_mask despite otherwise using thegeneric DMA API.Signed-off-by: Christoph Hellwig Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/initio.c

d282e2b3 - SCSI: initio: remove duplicate module device table

Thu, 19 Nov 2015 14:33:41 +0000

SCSI: initio: remove duplicate module device tableThe initio driver has for many years had two copies of thesame module device table. One of them is also used for registeringthe other driver, the other one is entirely useless after thelarge scale cleanup that Alan Cox did back in 2007.The compiler warns about this whenever the driver is built-in:drivers/scsi/initio.c:131:29: warning: 'i91u_pci_devices' defined but not used [-Wunused-variable]This removes the extraneous table and the warning.Signed-off-by: Arnd Bergmann Fixes: 72d39fea901 ("[SCSI] initio: Convert into a real Linux driver and update to modern style")Reviewed-by: Christoph Hellwig Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/scsi/initio.c

b84b1d52 - scsi: Do not set cmd_per_lun to 1 in the host template

Wed, 29 Apr 2015 06:57:34 +0000

scsi: Do not set cmd_per_lun to 1 in the host template'0' is now used as the default cmd_per_lun value,so there's no need to explicitly set it to '1' in thehost template.Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig Signed-off-by: James Bottomley List of files: /linux-6.15/drivers/scsi/initio.c

4909cc2b - [SCSI] remove deprecated IRQF_DISABLED from SCSI

Wed, 05 Mar 2014 05:09:41 +0000

[SCSI] remove deprecated IRQF_DISABLED from SCSIIt's a NOOP since 2.6.35 and it will be removed one day.[jejb: remove from missed arm scsi drivers]Signed-off-by: Michael Opdenacker Signed-off-by: James Bottomley List of files: /linux-6.15/drivers/scsi/initio.c