Changes in rtc-sunxi.c

48144c28 - rtc: Explicitly include correct DT includes

Mon, 24 Jul 2023 20:54:54 +0000

rtc: Explicitly include correct DT includesThe DT of_device.h and of_platform.h date back to the separateof_platform_bus_type before it as merged into the regular platform bus.As part of that merge prepping Arm DT support 13 years ago, they"temporarily" include each other. They also include platform_device.hand of.h. As a result, there's a pretty much random mix of those includefiles used throughout the tree. In order to detangle these headers andreplace the implicit includes with struct declarations, users need toexplicitly include the correct includes.Signed-off-by: Rob Herring Link: https://lore.kernel.org/r/20230724205456.767430-1-robh@kernel.orgSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-sunxi.c

fdcfd854 - rtc: rework rtc_register_device() resource management

Mon, 09 Nov 2020 16:34:08 +0000

rtc: rework rtc_register_device() resource managementrtc_register_device() is a managed interface but it doesn't use devresby itself - instead it marks an rtc_device as "registered" and the devrescallback for devm_rtc_allocate_device() takes care of resource release.This doesn't correspond with the design behind devres where managedstructures should not be aware of being managed. The correct solutionhere is to register a separate devres callback for unregistering thedevice.While at it: rename rtc_register_device() to devm_rtc_register_device()and add it to the list of managed interfaces in devres.rst. This way wecan avoid any potential confusion of driver developers who may expectthere to exist a corresponding unregister function.Signed-off-by: Bartosz Golaszewski Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl List of files: /linux-6.15/drivers/rtc/rtc-sunxi.c

09ef18bc - rtc: use devm_platform_ioremap_resource() to simplify code

Sun, 06 Oct 2019 10:29:20 +0000

rtc: use devm_platform_ioremap_resource() to simplify codeUse devm_platform_ioremap_resource() to simplify the code a bit.This is detected by coccinelle.Signed-off-by: YueHaibing Link: https://lore.kernel.org/r/20191006102953.57536-2-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-3-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-4-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-5-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-6-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-7-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-8-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-9-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-10-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-11-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-12-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-13-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-14-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-15-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-16-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-17-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-18-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-19-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-20-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-21-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-22-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-23-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-24-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-25-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-26-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-27-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-28-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-29-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-30-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-31-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-32-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-33-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-34-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-35-yuehaibing@huawei.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-sunxi.c

44c638ce - rtc: remove superfluous error message

Sun, 18 Aug 2019 22:00:41 +0000

rtc: remove superfluous error messageThe RTC core now has error messages in case of registration failure, thereis no need to have other messages in the drivers.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20190818220041.17833-2-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-sunxi.c

faac9102 - rtc: Remove dev_err() usage after platform_get_irq()

Tue, 30 Jul 2019 18:15:39 +0000

rtc: Remove dev_err() usage after platform_get_irq()We don't need dev_err() messages when platform_get_irq() fails now thatplatform_get_irq() prints an error message itself when something goeswrong. Let's remove these prints with a simple semantic patch.// @@expression ret;struct platform_device *E;@@ret =(platform_get_irq(E, ...)|platform_get_irq_byname(E, ...));if ( \( ret < 0 \| ret <= 0 \) ){(-if (ret != -EPROBE_DEFER)-{ ...-dev_err(...);-... }|...-dev_err(...);)...}// While we're here, remove braces on if statements that only have onestatement (manually).Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: linux-rtc@vger.kernel.orgCc: Greg Kroah-Hartman Signed-off-by: Stephen Boyd Link: https://lore.kernel.org/r/20190730181557.90391-40-swboyd@chromium.orgSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-sunxi.c

16216333 - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 1

Sun, 19 May 2019 13:51:31 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 1Based on 2 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later version this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more details you should have received a copy of the gnu general public license along with this program if not write to the free software foundation inc 51 franklin street fifth floor boston ma 02110 1301 usa this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option [no]_[pad]_[ctrl] any later version this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more details you should have received a copy of the gnu general public license along with this program if not write to the free software foundation inc 51 franklin street fifth floor boston ma 02110 1301 usaextracted by the scancode license scanner the SPDX license identifier GPL-2.0-or-laterhas been chosen to replace the boilerplate/reference in 176 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Jilayne Lovejoy Reviewed-by: Steve Winslow Reviewed-by: Allison Randal Reviewed-by: Kate Stewart Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190519154040.652910950@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/rtc/rtc-sunxi.c

29615d03 - rtc: sunxi: fix possible race condition

Mon, 04 Jun 2018 12:05:40 +0000

rtc: sunxi: fix possible race conditionThe IRQ is requested before the struct rtc is allocated and registered, butthis struct is used in the IRQ handler. This may lead to a NULL pointerdereference.Switch to devm_rtc_allocate_device/rtc_register_device to allocate the rtcbefore requesting the IRQ.Signed-off-by: Alexandre Belloni Acked-by: Maxime Ripard Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-sunxi.c

22652ba7 - rtc: stop validating rtc_time in .read_time

Mon, 19 Feb 2018 15:23:56 +0000

rtc: stop validating rtc_time in .read_timeThe RTC core is always calling rtc_valid_tm after the read_time callback.It is not necessary to call it just before returning from the callback.Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-sunxi.c

4d833d60 - rtc: sunxi: use of_device_get_match_data

Thu, 19 Nov 2015 10:50:10 +0000

rtc: sunxi: use of_device_get_match_dataThe usage of of_device_get_match_data reduce the code size a bit.Signed-off-by: LABBE Corentin Acked-by: Chen-Yu Tsai Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-sunxi.c

6ddab92f - rtc: sunxi: constify the data_year_param structure

Thu, 19 Nov 2015 10:50:09 +0000

rtc: sunxi: constify the data_year_param structureThe data_year_param struct is never modified, so lets constify it.This permit to remove cast since of_device_id is const also.Signed-off-by: LABBE Corentin Acked-by: Chen-Yu Tsai Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-sunxi.c

f8947feb - rtc: sunxi: fix signedness issues

Thu, 19 Nov 2015 10:50:08 +0000

rtc: sunxi: fix signedness issuesThe variable year must be set as unsigned since it is used withsunxi_rtc_data_year{.min|.max} and as parameter of is_leap_year() whichwait for unsigned int.Only tm_year is not unsigned, but it is long.This patch fix also the format of printing of min/max. (must use %u sincethey are unsigned)The parameter to of sunxi_rtc_setaie() must be set to uint since callersgive always uint data.Signed-off-by: LABBE Corentin Acked-by: Chen-Yu Tsai Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-sunxi.c

9033fd8b - rtc: sunxi: Replace deprecated rtc_tm_to_time()

Fri, 12 Jun 2015 02:04:12 +0000

rtc: sunxi: Replace deprecated rtc_tm_to_time()sunxi_rtc_setalarm() uses deprecated rtc_tm_to_time(),which will overflow in year 2106 on 32-bit machines.This patch solves this by:- Replacing rtc_tm_to_time() with rtc_tm_sub()Also remove the unnecessary initial zeroing of somelocal variables in sunxi_rtc_setalarm().Cc: Carlo Caione Signed-off-by: Xunlei Pang Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-sunxi.c

0929ae37 - rtc: drop owner assignment from platform_drivers

Mon, 20 Oct 2014 14:21:31 +0000

rtc: drop owner assignment from platform_driversA platform_driver does not need to set an owner, it will be populated by thedriver core.Signed-off-by: Wolfram Sang List of files: /linux-6.15/drivers/rtc/rtc-sunxi.c

f49bd06e - rtc: sunxi: change compatibles

Thu, 03 Apr 2014 21:50:02 +0000

rtc: sunxi: change compatiblesThe Allwinner A10 compatibles were following a slightly differentcompatible patterns than the rest of the SoCs for historical reasons.Change the compatibles to match the other pattern in the RTC driver forconsistency.Signed-off-by: Maxime Ripard Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-sunxi.c

594c6fb9 - ARM: sun4i/sun7i: RTC driver

Sat, 16 Nov 2013 17:33:54 +0000

ARM: sun4i/sun7i: RTC driverThis patch introduces the driver for the RTC in the Allwinner A10 andA20 SoCs.Signed-off-by: Carlo Caione Acked-by: Alessandro Zummo Signed-off-by: Maxime Ripard List of files: /linux-6.15/drivers/rtc/rtc-sunxi.c